diff options
| author | skyostil <skyostil@chromium.org> | 2014-10-02 03:08:56 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-02 10:09:12 +0000 |
| commit | 4db84b031042bf4f99720372f657ff53e4503a16 (patch) | |
| tree | 5404610852e9b896fd411729e49d4b9adf4e31d8 /build/get_landmines.py | |
| parent | 949b6e5050c7a2ee2a894799db19ec325ba911ef (diff) | |
| download | chromium_src-4db84b031042bf4f99720372f657ff53e4503a16.zip chromium_src-4db84b031042bf4f99720372f657ff53e4503a16.tar.gz chromium_src-4db84b031042bf4f99720372f657ff53e4503a16.tar.bz2 | |
Revert of Revert of Use the new java_cpp_enum rule in content. (patchset #1 id:1 of https://codereview.chromium.org/625543002/)
Reason for revert:
Oops, wasn't supposed to revert this after all.
Original issue's description:
> Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
>
> Reason for revert:
> Fails to compile on several bots:
>
> https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
>
> First error:
> FAILED: cd ../../clank/native/framework; python <snip ...>
> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
> import org.chromium.content.common.TopControlsState;
> ^
> symbol: class TopControlsState
> location: package org.chromium.content.common
>
> Original issue's description:
> > Use the new java_cpp_enum rule in content.
> >
> > This moves most of the generated Java enums under content/ to use the
> > java_cpp_enum rule removing the need for keeping the enums in
> > separate list files and the need for the .template files.
> >
> > BUG=405532, 351558
> >
> > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> > Cr-Commit-Position: refs/heads/master@{#297789}
>
> TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=405532, 351558
>
> Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef
> Cr-Commit-Position: refs/heads/master@{#297793}
TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org,perezju@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558
Review URL: https://codereview.chromium.org/617103007
Cr-Commit-Position: refs/heads/master@{#297794}
Diffstat (limited to 'build/get_landmines.py')
| -rwxr-xr-x | build/get_landmines.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/build/get_landmines.py b/build/get_landmines.py index 8fa5a3b..f15d8db 100755 --- a/build/get_landmines.py +++ b/build/get_landmines.py @@ -58,6 +58,7 @@ def print_landmines(): print 'ninja dependency cycle: crbug.com/408192' if platform() == 'android': print 'Clobber: To delete stale generated .java files.' + print 'Delete stale generated .java files again. crbug.com/349592' def main(): |