diff options
| author | scottmg <scottmg@chromium.org> | 2014-12-10 15:34:07 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-10 23:34:32 +0000 |
| commit | fa5da3e4e515967d593c3822b1d82f5e844080c5 (patch) | |
| tree | a61d425b3882425bdd4bb3db0affb88bb2604fcf /build/vs_toolchain.py | |
| parent | 3dada715544fd57776cee55e93e2da49801f1c3f (diff) | |
| download | chromium_src-fa5da3e4e515967d593c3822b1d82f5e844080c5.zip chromium_src-fa5da3e4e515967d593c3822b1d82f5e844080c5.tar.gz chromium_src-fa5da3e4e515967d593c3822b1d82f5e844080c5.tar.bz2 | |
win gn: Semi-support for non-depot_tools toolchain
I had to set:
DEPOT_TOOLS_WIN_TOOLCHAIN=0
GYP_MSVS_OVERRIDE_PATH=C:/Program Files (x86)/Microsoft Visual Studio 12.0
GYP_MSVS_VERSION=2013
WindowsSdkDir=C:/Program Files (x86)/Windows Kits/8.1
then
gn gen out\gn --args="is_debug=true cpu_arch=\"x86\""
ninja -C out/gn base
worked OK.
Further patches welcome to make this less ugly.
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/789303002
Cr-Commit-Position: refs/heads/master@{#307791}
Diffstat (limited to 'build/vs_toolchain.py')
| -rw-r--r-- | build/vs_toolchain.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py index fb7e142..5373f03 100644 --- a/build/vs_toolchain.py +++ b/build/vs_toolchain.py @@ -202,7 +202,7 @@ runtime_dirs = "%s" os.environ['WINDOWSSDKDIR'], os.environ['GYP_MSVS_VERSION'], os.environ.get('WDK_DIR', ''), - ';'.join(runtime_dll_dirs)) + ';'.join(runtime_dll_dirs or ['None'])) def main(): |