diff options
author | ernstm@chromium.org <ernstm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-11 21:12:33 +0000 |
---|---|---|
committer | ernstm@chromium.org <ernstm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-11 21:12:33 +0000 |
commit | adbe30f035bfc0c63f763a2d4af165ea2d1cf9c0 (patch) | |
tree | d30cfc87d61a7db96b0793be39364a38040266e9 /cc/debug/rendering_stats_instrumentation.h | |
parent | 8d9a3359b14a5bfbbde3fe766231a73935ad065e (diff) | |
download | chromium_src-adbe30f035bfc0c63f763a2d4af165ea2d1cf9c0.zip chromium_src-adbe30f035bfc0c63f763a2d4af165ea2d1cf9c0.tar.gz chromium_src-adbe30f035bfc0c63f763a2d4af165ea2d1cf9c0.tar.bz2 |
telemetry: Refactored rasterize_and_record measurement.
- switched rasterize_and_record benchmark to new benchmark architecture.
- detailled traces are not required anymore, fixing the issue with trace
event buffer overflows.
- changed output to show pixels rasterized and recorded for one iteration of the raster/record loop.
- Further reduced variance by excluding lowres tiles and adding another sleep to the measurement. Stdev of pixel counts is now zero (except for amazon.com). Stdev of time metrics with 100 repetitions is well below 1% of the mean for most pages in the top_25.
R=nduca@chromium.org
BUG=280638
Review URL: https://codereview.chromium.org/25353009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228253 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/debug/rendering_stats_instrumentation.h')
-rw-r--r-- | cc/debug/rendering_stats_instrumentation.h | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/cc/debug/rendering_stats_instrumentation.h b/cc/debug/rendering_stats_instrumentation.h index fcecb37..4508600 100644 --- a/cc/debug/rendering_stats_instrumentation.h +++ b/cc/debug/rendering_stats_instrumentation.h @@ -19,11 +19,11 @@ class CC_EXPORT RenderingStatsInstrumentation { virtual ~RenderingStatsInstrumentation(); // Return current main thread rendering stats. - MainThreadRenderingStats GetMainThreadRenderingStats() { + const MainThreadRenderingStats& main_thread_rendering_stats() { return main_stats_; } // Return current impl thread rendering stats. - ImplThreadRenderingStats GetImplThreadRenderingStats() { + const ImplThreadRenderingStats& impl_thread_rendering_stats() { return impl_stats_; } // Return the accumulated, combined rendering stats. @@ -36,15 +36,6 @@ class CC_EXPORT RenderingStatsInstrumentation { // clear current stats. void AccumulateAndClearImplThreadStats(); - // Issue trace event for current main thread rendering stats. - void IssueTraceEventForMainThreadStats() { - main_stats_.IssueTraceEvent(); - } - // Issue trace event for current impl thread rendering stats. - void IssueTraceEventForImplThreadStats() { - impl_stats_.IssueTraceEvent(); - } - // Read and write access to the record_rendering_stats_ flag is not locked to // improve performance. The flag is commonly turned off and hardly changes // it's value during runtime. @@ -66,6 +57,7 @@ class CC_EXPORT RenderingStatsInstrumentation { RenderingStatsInstrumentation(); private: + // TODO(ernstm): rename to *_thread_rendering_stats_* MainThreadRenderingStats main_stats_; MainThreadRenderingStats main_stats_accu_; ImplThreadRenderingStats impl_stats_; |