diff options
author | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
---|---|---|
committer | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
commit | 0023fc78d056556b353ee17f03760bec8c1fee49 (patch) | |
tree | 009367358a1c44b08f3142f63b087d936206ba44 /cc/output/delegating_renderer.h | |
parent | 37df32bd517577ac6ad20c6d76b236265caeacaf (diff) | |
download | chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2 |
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass by value creates unneccessary overhead which should be avoided.
BUG=159273
Review URL: https://codereview.chromium.org/93663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/output/delegating_renderer.h')
-rw-r--r-- | cc/output/delegating_renderer.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/cc/output/delegating_renderer.h b/cc/output/delegating_renderer.h index c18bfa7..3de65f7 100644 --- a/cc/output/delegating_renderer.h +++ b/cc/output/delegating_renderer.h @@ -31,8 +31,8 @@ class CC_EXPORT DelegatingRenderer : public Renderer { virtual void DrawFrame(RenderPassList* render_passes_in_draw_order, ContextProvider* offscreen_context_provider, float device_scale_factor, - gfx::Rect device_viewport_rect, - gfx::Rect device_clip_rect, + const gfx::Rect& device_viewport_rect, + const gfx::Rect& device_clip_rect, bool allow_partial_swap, bool disable_picture_quad_image_filtering) OVERRIDE; @@ -41,7 +41,8 @@ class CC_EXPORT DelegatingRenderer : public Renderer { virtual void SwapBuffers(const CompositorFrameMetadata& metadata) OVERRIDE; virtual void ReceiveSwapBuffersAck(const CompositorFrameAck&) OVERRIDE; - virtual void GetFramebufferPixels(void* pixels, gfx::Rect rect) OVERRIDE; + virtual void GetFramebufferPixels(void* pixels, + const gfx::Rect& rect) OVERRIDE; virtual bool IsContextLost() OVERRIDE; |