summaryrefslogtreecommitdiffstats
path: root/cc/output
diff options
context:
space:
mode:
authorhendrikw <hendrikw@chromium.org>2014-09-26 17:29:20 -0700
committerCommit bot <commit-bot@chromium.org>2014-09-27 00:29:31 +0000
commit06aebb2f4b89f7bb0a511fa12881e919a860287a (patch)
tree82f47e61195d60ee77ed93a75a4bf11c1d0ffc29 /cc/output
parent360b06ad8dcf4f8d6e3758fb50aa77e66b94798a (diff)
downloadchromium_src-06aebb2f4b89f7bb0a511fa12881e919a860287a.zip
chromium_src-06aebb2f4b89f7bb0a511fa12881e919a860287a.tar.gz
chromium_src-06aebb2f4b89f7bb0a511fa12881e919a860287a.tar.bz2
cc: Removed DCHECK that asserted MapPoint returns clipped as true
When we apply a perspective to a div, we could end up with a situation where the mapped points end up behind the view. When this happened we would DCHECK, but since this a valid scenario and the rendered results look correct (as far as I can tell), I'm removing the DCHECK. Please see http://jsfiddle.net/kkryf2v4/ for an example where we animate from non-clipped to clipped div. BUG=416367 Review URL: https://codereview.chromium.org/610603003 Cr-Commit-Position: refs/heads/master@{#297082}
Diffstat (limited to 'cc/output')
-rw-r--r--cc/output/gl_renderer.cc8
1 files changed, 3 insertions, 5 deletions
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index a6de852..bc64c67 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -1422,15 +1422,13 @@ bool GLRenderer::SetupQuadForAntialiasing(
gfx::PointF top_left = tile_rect.origin();
gfx::PointF top_right = tile_rect.top_right();
- // Map points to device space.
+ // Map points to device space. We ignore |clipped|, since the result of
+ // |MapPoint()| still produces a valid point to draw the quad with. When
+ // clipped, the point will be outside of the viewport. See crbug.com/416367.
bottom_right = MathUtil::MapPoint(device_transform, bottom_right, &clipped);
- DCHECK(!clipped);
bottom_left = MathUtil::MapPoint(device_transform, bottom_left, &clipped);
- DCHECK(!clipped);
top_left = MathUtil::MapPoint(device_transform, top_left, &clipped);
- DCHECK(!clipped);
top_right = MathUtil::MapPoint(device_transform, top_right, &clipped);
- DCHECK(!clipped);
LayerQuad::Edge bottom_edge(bottom_right, bottom_left);
LayerQuad::Edge left_edge(bottom_left, top_left);