diff options
| author | brianderson@chromium.org <brianderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-23 10:45:03 +0000 |
|---|---|---|
| committer | brianderson@chromium.org <brianderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-23 10:45:03 +0000 |
| commit | c8cbae7f41a1212bce61523021a60ee78783993b (patch) | |
| tree | 8a57d88602df03a587c2dcd2a95039b20ec4ef83 /cc/output | |
| parent | 280755cad298b37cd6ead4d16337c4e1ed79f1a0 (diff) | |
| download | chromium_src-c8cbae7f41a1212bce61523021a60ee78783993b.zip chromium_src-c8cbae7f41a1212bce61523021a60ee78783993b.tar.gz chromium_src-c8cbae7f41a1212bce61523021a60ee78783993b.tar.bz2 | |
cc: Rename VSync to BeginFrame
We are replacing hard vsync scheduling with BeginFrame+deadline
intervals.
This patch removes references to vsync in CC where it will no
longer make sense. (One exception is cc::VSyncTimeSource, which
will be removed in future patches to be incorporated into the
scheduler itself.)
Additionally, BeginFrames are clarified with suffixes whenever
context is not enough and existing identifiers associated with
BeginFrame when it no longer makes sense are renamed.
A summary of the important renames are as follows:
Browser Side Renames:
COutputSurface::EnableVSyncNotification -> SetNeedsBeginFrame
COutputSurface::OnDidVSync -> OnBeginFrame
ViewHostMsg_SetVSyncNotificationEnabled -> ViewHostMsg_SetNeedsBeginFrame
ViewMsg_DidVSync -> ViewMsg_BeginFrame
Impl Side Renames:
LTHI::EnableVSyncNotification -> SetNeedsBeginFrame
LTHI::DidVSync -> BeginFrame
LTHI::DidRecieveLastInputEventForVSync -> DidReceiveLastInputEventForBeginFrame
Main+Impl Side Renames:
LTHIClient::DidVSync -> BeginFrameOnImplThread
LTHIClient::DidRecieveLastInputEventForVSync -> DidReceiveLastInputEventForBeginFrameOnImplThread
TProxy::BeginFrame -> BeginFrameOnMainThread
TProxy::ForceBeginFrameOnImplThread -> ForceCommitOnImplThread
TProxy::BeginFrameCompleteOnImplThread -> StartCommitOnImplThread
Scheduler::BeginFrameComplete -> FinishCommit
Scheduler::BeginFrameAborted -> BeginFrameAbortedByMainThread
Scheduler::LastVsyncTime -> LastBeginFrameOnImplThreadTime
Scheduler::VSyncTick -> BeginFrame
SchedulerSM::VSyncCallbackNeeded -> BeginFrameNeededByImplThread
SchedulerSM::ACTION_BEGIN_FRAME -> ACTION_SEND_BEGIN_FRAME_TO_MAIN_THREAD
FRC::DidBeginFrame -> DidSwapBuffers
FRC::DidFinishFrame -> DidSwapBuffersComplete
Random Renames:
LTSettings::render_vsync_enabled -> throttle_frame_production
LTSettings::render_vsync_notification_enabled -> render_parent_drives_begin_frame
LTSettings::synchronously_disable_vsync -> using_synchronous_renderer_compositor
RenderWidget::SynchronouslyDisableVSync -> UsingSynchronousRendererCompositor
BUG=240945
Review URL: https://chromiumcodereview.appspot.com/15058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201739 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/output')
| -rw-r--r-- | cc/output/output_surface.h | 8 | ||||
| -rw-r--r-- | cc/output/output_surface_client.h | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h index 0be2e3b..22ce6af 100644 --- a/cc/output/output_surface.h +++ b/cc/output/output_surface.h @@ -98,10 +98,10 @@ class CC_EXPORT OutputSurface { // processing should be stopped, or lowered in priority. virtual void UpdateSmoothnessTakesPriority(bool prefer_smoothness) {} - // Requests a vsync notification from the output surface. The notification - // will be delivered by calling OutputSurfaceClient::DidVSync for all future - // vsync events until the callback is disabled. - virtual void EnableVSyncNotification(bool enable_vsync) {} + // Requests a BeginFrame notification from the output surface. The + // notification will be delivered by calling + // OutputSurfaceClient::BeginFrame until the callback is disabled. + virtual void SetNeedsBeginFrame(bool enable) {} protected: OutputSurfaceClient* client_; diff --git a/cc/output/output_surface_client.h b/cc/output/output_surface_client.h index 32dec38..1f188af 100644 --- a/cc/output/output_surface_client.h +++ b/cc/output/output_surface_client.h @@ -18,7 +18,7 @@ class CC_EXPORT OutputSurfaceClient { virtual void SetNeedsRedrawRect(gfx::Rect damage_rect) = 0; virtual void OnVSyncParametersChanged(base::TimeTicks timebase, base::TimeDelta interval) = 0; - virtual void DidVSync(base::TimeTicks frame_time) = 0; + virtual void BeginFrame(base::TimeTicks frame_time) = 0; virtual void OnSendFrameToParentCompositorAck(const CompositorFrameAck&) = 0; virtual void OnSwapBuffersComplete() = 0; virtual void DidLoseOutputSurface() = 0; |