diff options
author | rouslan <rouslan@chromium.org> | 2014-10-03 13:48:53 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-03 20:49:08 +0000 |
commit | f4518c10c2862ffaa359a6b47726f4d28d4ee14f (patch) | |
tree | e130793775cbf3358aec6a43bf69963b1688c9a3 /cc/output | |
parent | 6d0b6b1671b6c201f221c4520c0ccfa91bbbd573 (diff) | |
download | chromium_src-f4518c10c2862ffaa359a6b47726f4d28d4ee14f.zip chromium_src-f4518c10c2862ffaa359a6b47726f4d28d4ee14f.tar.gz chromium_src-f4518c10c2862ffaa359a6b47726f4d28d4ee14f.tar.bz2 |
Revert of Separate networkingPrivate api tests (patchset #4 id:60001 of https://codereview.chromium.org/602713004/)
Reason for revert:
Appears to have broken browser_tests on "Win7 Tests (dbg)(1)" builder.
Example failing test output:
NetworkingPrivateApiTest.DisableNetworkType (run #1):
[ RUN ] NetworkingPrivateApiTest.DisableNetworkType
[1556:948:1003/111910:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup
[1604:4732:1003/111913:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[1556:948:1003/111913:WARNING:extension_apitest.cc(215)] Workaround for 177163, prematurely returning
c:\b\build\slave\win_builder__dbg_\build\src\chrome\browser\extensions\api\networking_private\networking_private_apitest.cc(339): error: Value of: GetDisabled(::onc::network_config::kEthernet)
Actual: false
Expected: true
[1556:948:1003/111913:WARNING:channel.cc(177)] WriteMessage() while shutting down
[1556:2396:1003/111913:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue
[ FAILED ] NetworkingPrivateApiTest.DisableNetworkType, where TypeParam = and GetParam() = (3507 ms)
NetworkingPrivateApiTest.DisableNetworkType (run #2):
[ RUN ] NetworkingPrivateApiTest.DisableNetworkType
[4204:420:1003/111941:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup
[3932:3104:1003/111943:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[4204:420:1003/111943:WARNING:extension_apitest.cc(215)] Workaround for 177163, prematurely returning
c:\b\build\slave\win_builder__dbg_\build\src\chrome\browser\extensions\api\networking_private\networking_private_apitest.cc(339): error: Value of: GetDisabled(::onc::network_config::kEthernet)
Actual: false
Expected: true
[4204:420:1003/111943:WARNING:channel.cc(177)] WriteMessage() while shutting down
[4204:2016:1003/111943:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue
[ FAILED ] NetworkingPrivateApiTest.DisableNetworkType, where TypeParam = and GetParam() = (2398 ms)
NetworkingPrivateApiTest.DisableNetworkType (run #3):
[ RUN ] NetworkingPrivateApiTest.DisableNetworkType
[3008:1460:1003/111945:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup
[4364:4564:1003/111947:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[3008:1460:1003/111947:WARNING:extension_apitest.cc(215)] Workaround for 177163, prematurely returning
c:\b\build\slave\win_builder__dbg_\build\src\chrome\browser\extensions\api\networking_private\networking_private_apitest.cc(339): error: Value of: GetDisabled(::onc::network_config::kEthernet)
Actual: false
Expected: true
[3008:1460:1003/111947:WARNING:channel.cc(177)] WriteMessage() while shutting down
[3008:4248:1003/111947:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue
[ FAILED ] NetworkingPrivateApiTest.DisableNetworkType, where TypeParam = and GetParam() = (2971 ms)
NetworkingPrivateApiTest.DisableNetworkType (run #4):
[ RUN ] NetworkingPrivateApiTest.DisableNetworkType
[4748:3336:1003/111949:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy OFF at startup
[3920:3340:1003/111950:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[4748:3336:1003/111950:WARNING:extension_apitest.cc(215)] Workaround for 177163, prematurely returning
c:\b\build\slave\win_builder__dbg_\build\src\chrome\browser\extensions\api\networking_private\networking_private_apitest.cc(339): error: Value of: GetDisabled(::onc::network_config::kEthernet)
Actual: false
Expected: true
[4748:3336:1003/111950:WARNING:channel.cc(177)] WriteMessage() while shutting down
[4748:2624:1003/111950:WARNING:message_in_transit_queue.cc(18)] Destroying nonempty message queue
[ FAILED ] NetworkingPrivateApiTest.DisableNetworkType, where TypeParam = and GetParam() = (2398 ms)
See more details on the builder page: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31443
Original issue's description:
> Separate networkingPrivate api tests
>
> This still does not address the fact that the Chrome OS and Wim/Mac
> tests share the same result expectations, but it at least accomplishes
> the following:
> * Adds a set of pure API tests that just test the API, not the fake
> implementations
> * Separates the Chrome OS and Win/Mac fake implementation tests into
> their own files to improve readability
>
> BUG=371442
>
> Committed: https://crrev.com/5decf417198f072f2669db817fcd9c5556d19fff
> Cr-Commit-Position: refs/heads/master@{#298048}
TBR=mef@chromium.org,pneubeck@chromium.org,armansito@chromium.org,tbarzic@chromium.org,stevenjb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=371442
Review URL: https://codereview.chromium.org/628743002
Cr-Commit-Position: refs/heads/master@{#298092}
Diffstat (limited to 'cc/output')
0 files changed, 0 insertions, 0 deletions