summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
diff options
context:
space:
mode:
authorhans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-25 09:08:19 +0000
committerhans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-25 09:08:19 +0000
commit3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19 (patch)
treeb26f7f81e48a95473eb4af5304301e9d8cd22fb8 /chrome/browser/autocomplete
parenteef99b6591d82399096abdcee07dd67359eec036 (diff)
downloadchromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.zip
chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.gz
chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.bz2
Virtual destructors should have virtual keyword.
Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete')
-rw-r--r--chrome/browser/autocomplete/autocomplete_edit.h2
-rw-r--r--chrome/browser/autocomplete/autocomplete_popup_view_gtk.h2
-rw-r--r--chrome/browser/autocomplete/history_contents_provider.h2
-rw-r--r--chrome/browser/autocomplete/history_quick_provider.h2
-rw-r--r--chrome/browser/autocomplete/search_provider.h2
5 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit.h b/chrome/browser/autocomplete/autocomplete_edit.h
index 9d3f8b8..1da8241 100644
--- a/chrome/browser/autocomplete/autocomplete_edit.h
+++ b/chrome/browser/autocomplete/autocomplete_edit.h
@@ -103,7 +103,7 @@ class AutocompleteEditModel : public AutocompleteControllerDelegate {
AutocompleteEditModel(OmniboxView* view,
AutocompleteEditController* controller,
Profile* profile);
- ~AutocompleteEditModel();
+ virtual ~AutocompleteEditModel();
AutocompleteController* autocomplete_controller() const {
return autocomplete_controller_.get();
diff --git a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
index 7152fa2..2f3eda3 100644
--- a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
+++ b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h
@@ -36,7 +36,7 @@ class AutocompletePopupViewGtk : public AutocompletePopupView,
AutocompleteEditModel* edit_model,
Profile* profile,
GtkWidget* location_bar);
- ~AutocompletePopupViewGtk();
+ virtual ~AutocompletePopupViewGtk();
// Overridden from AutocompletePopupView:
virtual bool IsOpen() const;
diff --git a/chrome/browser/autocomplete/history_contents_provider.h b/chrome/browser/autocomplete/history_contents_provider.h
index e4279a1..7ceb0b9 100644
--- a/chrome/browser/autocomplete/history_contents_provider.h
+++ b/chrome/browser/autocomplete/history_contents_provider.h
@@ -35,7 +35,7 @@ class HistoryContentsProvider : public HistoryProvider {
virtual void Stop() OVERRIDE;
private:
- ~HistoryContentsProvider();
+ virtual ~HistoryContentsProvider();
void QueryComplete(HistoryService::Handle handle,
history::QueryResults* results);
diff --git a/chrome/browser/autocomplete/history_quick_provider.h b/chrome/browser/autocomplete/history_quick_provider.h
index 69c7dc8..20cd5df 100644
--- a/chrome/browser/autocomplete/history_quick_provider.h
+++ b/chrome/browser/autocomplete/history_quick_provider.h
@@ -28,7 +28,7 @@ class HistoryQuickProvider : public HistoryProvider {
public:
HistoryQuickProvider(ACProviderListener* listener, Profile* profile);
- ~HistoryQuickProvider();
+ virtual ~HistoryQuickProvider();
// AutocompleteProvider. |minimal_changes| is ignored since there
// is no asynch completion performed.
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index e627cb4..2a62236 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -82,7 +82,7 @@ class SearchProvider : public AutocompleteProvider,
static const int kKeywordProviderURLFetcherID;
private:
- ~SearchProvider();
+ virtual ~SearchProvider();
// Manages the providers (TemplateURLs) used by SearchProvider. Two providers
// may be used: