diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-15 16:07:14 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-15 16:07:14 +0000 |
commit | 6314e6f6d7ac203479afe79a46a3e592a2a8da69 (patch) | |
tree | 46f6de1466dfa7f7172045333d26063c3405c1dd /chrome/browser/net/url_fixer_upper.cc | |
parent | 8b98be9556c88fb7cc231305fa707a6a18595738 (diff) | |
download | chromium_src-6314e6f6d7ac203479afe79a46a3e592a2a8da69.zip chromium_src-6314e6f6d7ac203479afe79a46a3e592a2a8da69.tar.gz chromium_src-6314e6f6d7ac203479afe79a46a3e592a2a8da69.tar.bz2 |
Fix a bunch of minor Coverity issues.
- pass more things by const reference
- check return codes (minor severity)
Review URL: http://codereview.chromium.org/149643
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20731 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/net/url_fixer_upper.cc')
-rw-r--r-- | chrome/browser/net/url_fixer_upper.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/net/url_fixer_upper.cc b/chrome/browser/net/url_fixer_upper.cc index 4097b88..fa572c3 100644 --- a/chrome/browser/net/url_fixer_upper.cc +++ b/chrome/browser/net/url_fixer_upper.cc @@ -29,7 +29,7 @@ namespace { // UTF8 to UTF16. Instead of this after-the-fact adjustment, we should parse it // in the correct string format to begin with. url_parse::Component UTF8ComponentToWideComponent( - string text_utf8, + const string& text_utf8, const url_parse::Component& component_utf8) { if (component_utf8.len == -1) return url_parse::Component(); @@ -44,7 +44,8 @@ url_parse::Component UTF8ComponentToWideComponent( return component_w; } -void UTF8PartsToWideParts(string text_utf8, const url_parse::Parsed& parts_utf8, +void UTF8PartsToWideParts(const string& text_utf8, + const url_parse::Parsed& parts_utf8, url_parse::Parsed* parts) { if (IsStringASCII(text_utf8)) { *parts = parts_utf8; |