diff options
| author | johnnyg@chromium.org <johnnyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-11 17:40:31 +0000 |
|---|---|---|
| committer | johnnyg@chromium.org <johnnyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-11 17:40:31 +0000 |
| commit | 8b7135d6aa44d68307bfb7ff5e6441fcf1c5231b (patch) | |
| tree | 39f24246b28900218dded1cfe462ebe400ee3a6d /chrome/browser/notifications/balloon_collection_mac.mm | |
| parent | 4a3dab23cadf0cbe68bd82c06fd970ae8b1d7e10 (diff) | |
| download | chromium_src-8b7135d6aa44d68307bfb7ff5e6441fcf1c5231b.zip chromium_src-8b7135d6aa44d68307bfb7ff5e6441fcf1c5231b.tar.gz chromium_src-8b7135d6aa44d68307bfb7ff5e6441fcf1c5231b.tar.bz2 | |
Unit tests for desktop notifications.
* Allow non-windows BalloonCollections to create non-viewable balloons (so that non-viewing aspects are cross-platform testable)
* Makes NotificationObjectProxy overridable by a mock object which logs instead of calls to JS
* Move Layout code from private to protected in BalloonCollection to enable verification of position code.
BUG=none
TEST=these
Review URL: http://codereview.chromium.org/371041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31670 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/notifications/balloon_collection_mac.mm')
| -rw-r--r-- | chrome/browser/notifications/balloon_collection_mac.mm | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/notifications/balloon_collection_mac.mm b/chrome/browser/notifications/balloon_collection_mac.mm index 6197b49..2bff15e 100644 --- a/chrome/browser/notifications/balloon_collection_mac.mm +++ b/chrome/browser/notifications/balloon_collection_mac.mm @@ -4,14 +4,12 @@ #include "chrome/browser/notifications/balloon_collection.h" -#include "base/gfx/size.h" #include "base/logging.h" Balloon* BalloonCollectionImpl::MakeBalloon(const Notification& notification, Profile* profile) { - // TODO(johnnyg): http://crbug.com/23066. Part of future Mac support. - NOTIMPLEMENTED(); - return NULL; + // TODO(johnnyg): http://crbug.com/23066. Hook up to views. + return new Balloon(notification, profile, this); } bool BalloonCollectionImpl::Layout::RefreshSystemMetrics() { |