diff options
| author | vabr <vabr@chromium.org> | 2015-11-24 02:21:16 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-24 10:22:12 +0000 |
| commit | 1bff66d12e811993940e7dd01074768c30e0cd5b (patch) | |
| tree | ecd7f565eccd09960dbd981761837c467c490322 /chrome/browser/ui/passwords/passwords_model_delegate.h | |
| parent | 8e7faebfbdee8e62471a7ee839279f184b68980a (diff) | |
| download | chromium_src-1bff66d12e811993940e7dd01074768c30e0cd5b.zip chromium_src-1bff66d12e811993940e7dd01074768c30e0cd5b.tar.gz chromium_src-1bff66d12e811993940e7dd01074768c30e0cd5b.tar.bz2 | |
Remove ManagePasswordsUIController::NavigateToSmartLockPage
Replace it with the equivalent ManagePasswordsUIController::NavigateToExternalPasswordManager.
Note: This CL does not remove IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE yet, because it is also used in other pieces of the password manager UI. We need to double-check if it is OK to merge that with chrome::kPasswordManagerAccountDashboardURL, or whether it just should be made a separate constant. Using localisation to get the hl= URL parameter is very likely an overkill, see #0 in http://crbug.com/548259.
R=vasilii@chromium.org
BUG=548259
Review URL: https://codereview.chromium.org/1467993002
Cr-Commit-Position: refs/heads/master@{#361304}
Diffstat (limited to 'chrome/browser/ui/passwords/passwords_model_delegate.h')
| -rw-r--r-- | chrome/browser/ui/passwords/passwords_model_delegate.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/chrome/browser/ui/passwords/passwords_model_delegate.h b/chrome/browser/ui/passwords/passwords_model_delegate.h index c104c19..5226225 100644 --- a/chrome/browser/ui/passwords/passwords_model_delegate.h +++ b/chrome/browser/ui/passwords/passwords_model_delegate.h @@ -80,10 +80,8 @@ class PasswordsModelDelegate { const autofill::PasswordForm& form, password_manager::CredentialType credential_type) = 0; - // Two different ways to open a new tab pointing to passwords.google.com. - // TODO(crbug.com/548259) eliminate one of them. + // Open a new tab pointing to passwords.google.com. virtual void NavigateToExternalPasswordManager() = 0; - virtual void NavigateToSmartLockPage() = 0; // Open a new tab, pointing to the Smart Lock help article. virtual void NavigateToSmartLockHelpPage() = 0; // Open a new tab, pointing to the password manager settings page. |