diff options
| author | anujk.sharma <anujk.sharma@samsung.com> | 2014-09-16 09:52:38 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-16 16:53:36 +0000 |
| commit | 59b968271f2a2fb948ad110f0ed1b3da870b0eb5 (patch) | |
| tree | 887ef57436ddb9381623bca7aa9ad775e98dd46c /components/web_cache | |
| parent | 96256bfea5c496aa70b1913555b1e1c7f166c426 (diff) | |
| download | chromium_src-59b968271f2a2fb948ad110f0ed1b3da870b0eb5.zip chromium_src-59b968271f2a2fb948ad110f0ed1b3da870b0eb5.tar.gz chromium_src-59b968271f2a2fb948ad110f0ed1b3da870b0eb5.tar.bz2 | |
Code refactor related to WeakPtrFactory in src/components module
Changing in the intialization order of WeakPtrFactory in src/components module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.
BUG=303818
Review URL: https://codereview.chromium.org/573623002
Cr-Commit-Position: refs/heads/master@{#295084}
Diffstat (limited to 'components/web_cache')
| -rw-r--r-- | components/web_cache/browser/web_cache_manager.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/web_cache/browser/web_cache_manager.h b/components/web_cache/browser/web_cache_manager.h index 0945ec5..5d64992 100644 --- a/components/web_cache/browser/web_cache_manager.h +++ b/components/web_cache/browser/web_cache_manager.h @@ -229,10 +229,10 @@ class WebCacheManager : public content::NotificationObserver { // recently than they have been active. std::set<int> inactive_renderers_; - base::WeakPtrFactory<WebCacheManager> weak_factory_; - content::NotificationRegistrar registrar_; + base::WeakPtrFactory<WebCacheManager> weak_factory_; + DISALLOW_COPY_AND_ASSIGN(WebCacheManager); }; |