diff options
author | vmpstr <vmpstr@chromium.org> | 2016-02-26 17:21:52 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-27 01:23:32 +0000 |
commit | 3edc914481ff715869bd27903f2f9884e6d017da (patch) | |
tree | 2a63bf039e1c2d2768a9bb1955c77843d880b1e8 /extensions/browser/guest_view | |
parent | fa093a8177047c4275f104122b823950d1699d45 (diff) | |
download | chromium_src-3edc914481ff715869bd27903f2f9884e6d017da.zip chromium_src-3edc914481ff715869bd27903f2f9884e6d017da.tar.gz chromium_src-3edc914481ff715869bd27903f2f9884e6d017da.tar.bz2 |
extensions: Add out-of-line copy ctors for complex classes.
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=reillyg@chromium.org, dcheng@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1724293002
Cr-Commit-Position: refs/heads/master@{#378054}
Diffstat (limited to 'extensions/browser/guest_view')
4 files changed, 8 insertions, 0 deletions
diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc index b0b140e..822f131 100644 --- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc +++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc @@ -403,6 +403,9 @@ WebViewPermissionHelper::PermissionResponseInfo::PermissionResponseInfo( allowed_by_default(allowed_by_default) { } +WebViewPermissionHelper::PermissionResponseInfo::PermissionResponseInfo( + const PermissionResponseInfo& other) = default; + WebViewPermissionHelper::PermissionResponseInfo::~PermissionResponseInfo() { } diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.h b/extensions/browser/guest_view/web_view/web_view_permission_helper.h index 8383665..f5d037d 100644 --- a/extensions/browser/guest_view/web_view/web_view_permission_helper.h +++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.h @@ -43,6 +43,7 @@ class WebViewPermissionHelper PermissionResponseInfo(const PermissionResponseCallback& callback, WebViewPermissionType permission_type, bool allowed_by_default); + PermissionResponseInfo(const PermissionResponseInfo& other); ~PermissionResponseInfo(); }; diff --git a/extensions/browser/guest_view/web_view/web_view_renderer_state.cc b/extensions/browser/guest_view/web_view/web_view_renderer_state.cc index 8e9e26d..c95fac9 100644 --- a/extensions/browser/guest_view/web_view/web_view_renderer_state.cc +++ b/extensions/browser/guest_view/web_view/web_view_renderer_state.cc @@ -12,6 +12,9 @@ namespace extensions { WebViewRendererState::WebViewInfo::WebViewInfo() { } +WebViewRendererState::WebViewInfo::WebViewInfo(const WebViewInfo& other) = + default; + WebViewRendererState::WebViewInfo::~WebViewInfo() { } diff --git a/extensions/browser/guest_view/web_view/web_view_renderer_state.h b/extensions/browser/guest_view/web_view/web_view_renderer_state.h index f5b18f5..c1c9242 100644 --- a/extensions/browser/guest_view/web_view/web_view_renderer_state.h +++ b/extensions/browser/guest_view/web_view/web_view_renderer_state.h @@ -36,6 +36,7 @@ class WebViewRendererState { std::set<int> content_script_ids; WebViewInfo(); + WebViewInfo(const WebViewInfo& other); ~WebViewInfo(); }; |