diff options
| author | vmpstr <vmpstr@chromium.org> | 2016-02-26 17:21:52 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-27 01:23:32 +0000 |
| commit | 3edc914481ff715869bd27903f2f9884e6d017da (patch) | |
| tree | 2a63bf039e1c2d2768a9bb1955c77843d880b1e8 /extensions/browser/value_store | |
| parent | fa093a8177047c4275f104122b823950d1699d45 (diff) | |
| download | chromium_src-3edc914481ff715869bd27903f2f9884e6d017da.zip chromium_src-3edc914481ff715869bd27903f2f9884e6d017da.tar.gz chromium_src-3edc914481ff715869bd27903f2f9884e6d017da.tar.bz2 | |
extensions: Add out-of-line copy ctors for complex classes.
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=reillyg@chromium.org, dcheng@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1724293002
Cr-Commit-Position: refs/heads/master@{#378054}
Diffstat (limited to 'extensions/browser/value_store')
| -rw-r--r-- | extensions/browser/value_store/value_store_change.cc | 2 | ||||
| -rw-r--r-- | extensions/browser/value_store/value_store_change.h | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/extensions/browser/value_store/value_store_change.cc b/extensions/browser/value_store/value_store_change.cc index 904ec82..3bbad59 100644 --- a/extensions/browser/value_store/value_store_change.cc +++ b/extensions/browser/value_store/value_store_change.cc @@ -31,6 +31,8 @@ ValueStoreChange::ValueStoreChange( const std::string& key, base::Value* old_value, base::Value* new_value) : inner_(new Inner(key, old_value, new_value)) {} +ValueStoreChange::ValueStoreChange(const ValueStoreChange& other) = default; + ValueStoreChange::~ValueStoreChange() {} const std::string& ValueStoreChange::key() const { diff --git a/extensions/browser/value_store/value_store_change.h b/extensions/browser/value_store/value_store_change.h index 4c03cc3..a5e6bf5 100644 --- a/extensions/browser/value_store/value_store_change.h +++ b/extensions/browser/value_store/value_store_change.h @@ -26,6 +26,8 @@ class ValueStoreChange { ValueStoreChange( const std::string& key, base::Value* old_value, base::Value* new_value); + ValueStoreChange(const ValueStoreChange& other); + ~ValueStoreChange(); // Gets the key of the setting which changed. |