diff options
| author | jam <jam@chromium.org> | 2016-02-10 15:45:40 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-10 23:47:16 +0000 |
| commit | ffaec53850a27fc0888998c98c7bb092ccbd8552 (patch) | |
| tree | 665d5d9564497e52b6343f33eb9e6ef2636203d0 /extensions/common | |
| parent | ac440714860679857517ac7dd4c6282acbfa4033 (diff) | |
| download | chromium_src-ffaec53850a27fc0888998c98c7bb092ccbd8552.zip chromium_src-ffaec53850a27fc0888998c98c7bb092ccbd8552.tar.gz chromium_src-ffaec53850a27fc0888998c98c7bb092ccbd8552.tar.bz2 | |
Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety.
Also add a few checked_cast for places where we converted from size_t and we're sure that it's safe.
BUG=581409
Review URL: https://codereview.chromium.org/1684793003
Cr-Commit-Position: refs/heads/master@{#374788}
Diffstat (limited to 'extensions/common')
| -rw-r--r-- | extensions/common/stack_frame.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/extensions/common/stack_frame.h b/extensions/common/stack_frame.h index b174ffc..a55b8d8 100644 --- a/extensions/common/stack_frame.h +++ b/extensions/common/stack_frame.h @@ -29,6 +29,9 @@ struct StackFrame { bool operator==(const StackFrame& rhs) const; + // Note: we use uint32_t instead of size_t because this struct is sent over + // IPC which could span 32 & 64 bit processes. This is fine since line numbers + // and column numbers shouldn't exceed UINT32_MAX even on 64 bit builds. uint32_t line_number; uint32_t column_number; base::string16 source; |