diff options
| author | brettw <brettw@chromium.org> | 2014-09-19 18:44:11 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-20 01:44:30 +0000 |
| commit | 7dab582eb44ec4f5eeb46ea99fee0fd15a80bfdc (patch) | |
| tree | 28edc2692f422f2c9cad9aa441be906a1b217662 /gpu | |
| parent | 1409716c29452510a262878e7f6f825d71c045c5 (diff) | |
| download | chromium_src-7dab582eb44ec4f5eeb46ea99fee0fd15a80bfdc.zip chromium_src-7dab582eb44ec4f5eeb46ea99fee0fd15a80bfdc.tar.gz chromium_src-7dab582eb44ec4f5eeb46ea99fee0fd15a80bfdc.tar.bz2 | |
Make mojo/services pass in "gn check"
This mostly just adds the missing dependency identified by the checker.
In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target.
This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets.
In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases.
Reland of https://codereview.chromium.org/581273003/
TBR=darin
Review URL: https://codereview.chromium.org/591763002
Cr-Commit-Position: refs/heads/master@{#295841}
Diffstat (limited to 'gpu')
| -rw-r--r-- | gpu/BUILD.gn | 9 | ||||
| -rw-r--r-- | gpu/command_buffer/service/BUILD.gn | 4 |
2 files changed, 7 insertions, 6 deletions
diff --git a/gpu/BUILD.gn b/gpu/BUILD.gn index c6c8e27..8239940 100644 --- a/gpu/BUILD.gn +++ b/gpu/BUILD.gn @@ -37,7 +37,7 @@ # gpu/skia_bindings/skia_bindings.gyp:gpu_skia_bindings => //gpu/skia_bindings component("gpu") { - deps = [ + public_deps = [ "//gpu/command_buffer/client", "//gpu/command_buffer/client:gles2_cmd_helper_sources", "//gpu/command_buffer/common", @@ -56,16 +56,15 @@ source_set("test_support") { "command_buffer/client/gles2_interface_stub.h", ] - deps = [ + public_deps = [ ":gpu", "//gpu/command_buffer/client:gles2_interface", + ] + deps = [ "//testing/gmock", "//testing/gtest", "//ui/gl:gl_unittest_utils", ] - forward_dependent_configs_from = [ - "//gpu/command_buffer/client:gles2_interface", - ] } test("gl_tests") { diff --git a/gpu/command_buffer/service/BUILD.gn b/gpu/command_buffer/service/BUILD.gn index 19f2809..780431d 100644 --- a/gpu/command_buffer/service/BUILD.gn +++ b/gpu/command_buffer/service/BUILD.gn @@ -116,12 +116,14 @@ source_set("service") { "//third_party/khronos:khronos_headers", ] + public_deps = [ + "//gpu/command_buffer/common", + ] deps = [ ":disk_cache_proto", "//base", "//base/third_party/dynamic_annotations", "//crypto", - "//gpu/command_buffer/common", "//third_party/angle:translator", "//third_party/protobuf:protobuf_lite", "//third_party/re2", |