diff options
| author | danakj <danakj@chromium.org> | 2016-03-22 17:09:49 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-23 00:11:09 +0000 |
| commit | 899c6f30cf5c2c1d3472efc2f4e4b4aab02adc9d (patch) | |
| tree | 22d858840b473075d3b63e0de332afce8a15e00d /gpu | |
| parent | ee5b9e5aa4f385eeb16518ae08bb4d73758006d2 (diff) | |
| download | chromium_src-899c6f30cf5c2c1d3472efc2f4e4b4aab02adc9d.zip chromium_src-899c6f30cf5c2c1d3472efc2f4e4b4aab02adc9d.tar.gz chromium_src-899c6f30cf5c2c1d3472efc2f4e4b4aab02adc9d.tar.bz2 | |
Remove simple methods from WebGraphicsContext3D that do strings.
Remove simple methods that return or take strings from
WebGraphicsContext3D and just call the methods on GLES2Interface
directly, converting to/from WTF::String and char*.
R=chrishtr@chromium.org, kbr@chromium.org, pfeldman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1821903002
Cr-Commit-Position: refs/heads/master@{#382741}
Diffstat (limited to 'gpu')
| -rw-r--r-- | gpu/blink/webgraphicscontext3d_impl.cc | 23 | ||||
| -rw-r--r-- | gpu/blink/webgraphicscontext3d_impl.h | 8 |
2 files changed, 0 insertions, 31 deletions
diff --git a/gpu/blink/webgraphicscontext3d_impl.cc b/gpu/blink/webgraphicscontext3d_impl.cc index 98fbb71..7a9a620 100644 --- a/gpu/blink/webgraphicscontext3d_impl.cc +++ b/gpu/blink/webgraphicscontext3d_impl.cc @@ -73,12 +73,6 @@ WebGraphicsContext3DImpl::~WebGraphicsContext3DImpl() { } -blink::WebString WebGraphicsContext3DImpl:: - getRequestableExtensionsCHROMIUM() { - return blink::WebString::fromUTF8( - gl_->GetRequestableExtensionsCHROMIUM()); -} - bool WebGraphicsContext3DImpl::getActiveAttrib( WebGLId program, WGC3Duint index, ActiveInfo& info) { GLint max_name_length = -1; @@ -200,18 +194,6 @@ blink::WebString WebGraphicsContext3DImpl:: return res; } -blink::WebString WebGraphicsContext3DImpl::getString( - WGC3Denum name) { - return blink::WebString::fromUTF8( - reinterpret_cast<const char*>(gl_->GetString(name))); -} - -void WebGraphicsContext3DImpl::shaderSource( - WebGLId shader, const WGC3Dchar* string) { - GLint length = strlen(string); - gl_->ShaderSource(shader, 1, &string, &length); -} - void WebGraphicsContext3DImpl::setErrorMessageCallback( WebGraphicsContext3D::WebGraphicsErrorMessageCallback* cb) { error_message_callback_ = cb; @@ -222,11 +204,6 @@ void WebGraphicsContext3DImpl::setContextLostCallback( context_lost_callback_ = cb; } -void WebGraphicsContext3DImpl::pushGroupMarkerEXT( - const WGC3Dchar* marker) { - gl_->PushGroupMarkerEXT(0, marker); -} - ::gpu::gles2::GLES2Interface* WebGraphicsContext3DImpl::getGLES2Interface() { return gl_; } diff --git a/gpu/blink/webgraphicscontext3d_impl.h b/gpu/blink/webgraphicscontext3d_impl.h index 3f05ff1..db08260 100644 --- a/gpu/blink/webgraphicscontext3d_impl.h +++ b/gpu/blink/webgraphicscontext3d_impl.h @@ -47,12 +47,6 @@ class GPU_BLINK_EXPORT WebGraphicsContext3DImpl blink::WebString getProgramInfoLog(blink::WebGLId program) override; blink::WebString getShaderInfoLog(blink::WebGLId shader) override; blink::WebString getShaderSource(blink::WebGLId shader) override; - blink::WebString getString(blink::WGC3Denum name) override; - - void shaderSource(blink::WebGLId shader, - const blink::WGC3Dchar* string) override; - - blink::WebString getRequestableExtensionsCHROMIUM() override; blink::WebString getTranslatedShaderSourceANGLE( blink::WebGLId shader) override; @@ -63,8 +57,6 @@ class GPU_BLINK_EXPORT WebGraphicsContext3DImpl void setErrorMessageCallback( WebGraphicsContext3D::WebGraphicsErrorMessageCallback* callback) override; - void pushGroupMarkerEXT(const blink::WGC3Dchar* marker) override; - // WebGraphicsContext3D implementation. ::gpu::gles2::GLES2Interface* getGLES2Interface() override; |