diff options
| author | brettw <brettw@chromium.org> | 2016-03-25 10:55:15 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-25 17:56:51 +0000 |
| commit | affa906687c76c929545f8073fffaa53ff3a1a4a (patch) | |
| tree | 3755b1452b8fc4e4c722dd200a59d0998c0e162d /gpu | |
| parent | 36bf097458296e86dd3054632826dc78f658856f (diff) | |
| download | chromium_src-affa906687c76c929545f8073fffaa53ff3a1a4a.zip chromium_src-affa906687c76c929545f8073fffaa53ff3a1a4a.tar.gz chromium_src-affa906687c76c929545f8073fffaa53ff3a1a4a.tar.bz2 | |
Revert of Introduce GpuVideoDecodeAcceleratorFactory. (patchset #22 id:600001 of https://codereview.chromium.org/1745903002/ )lkcr
Reason for revert:
Too many problems: Android, Win64 linking, component linking (duplicate code die to incorrect visibility)
Original issue's description:
> Introduce GpuVideoDecodeAcceleratorFactory.
>
> - Move platform-specific code from GpuVideoDecodeAccelerator to
> GpuVideoDecodeAcceleratorFactory.
>
> - Make GVDAFactory a content/public interface, to provide the ability to
> instantiate VDAs from outside content/.
>
> - Unify how we obtain access to various GL functionality/classes from VDAs
> by introducing a set of callbacks provided by the client.
>
> - Replace VDA::CanDecodeOnIOThread() with
> VDA::TryInitializeDecodeOnSeparateThread(). This allows us to remove
> additional client/taskrunner arguments from VDA constructors, and give client
> the option to use a separate thread to decode, instead of having to make this
> decision in the factory, and enforcing these arguments in the constructors.
>
> - Deduplicate VDA creation code across users (currently GVDA and vdaunittest).
>
> BUG=b/27687678
> TEST=compile/run various VDA impls
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/6977e5243786901a766a38c2c291464875dffbd6
> Cr-Commit-Position: refs/heads/master@{#383256}
TBR=jochen@chromium.org,ananta@chromium.org,fsamuel@chromium.org,kcwu@chromium.org,liberato@chromium.org,owenlin@chromium.org,sandersd@chromium.org,jam@chromium.org,boliu@chromium.org,posciak@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/27687678
Review URL: https://codereview.chromium.org/1832123002
Cr-Commit-Position: refs/heads/master@{#383300}
Diffstat (limited to 'gpu')
| -rw-r--r-- | gpu/command_buffer/service/BUILD.gn | 1 | ||||
| -rw-r--r-- | gpu/config/BUILD.gn | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/gpu/command_buffer/service/BUILD.gn b/gpu/command_buffer/service/BUILD.gn index fc8ad968..7ad6816 100644 --- a/gpu/command_buffer/service/BUILD.gn +++ b/gpu/command_buffer/service/BUILD.gn @@ -19,7 +19,6 @@ group("service") { source_set("service_sources") { visibility = [ - "//content/public/gpu/*", "//gpu/*", "//mojo/gles2:gles2", ] diff --git a/gpu/config/BUILD.gn b/gpu/config/BUILD.gn index fa9a972..3ca9edf 100644 --- a/gpu/config/BUILD.gn +++ b/gpu/config/BUILD.gn @@ -25,7 +25,6 @@ group("config") { source_set("config_sources") { visibility = [ "//components/mus/gles2:*", - "//content/public/gpu/*", "//gpu/*", ] |