diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-31 15:19:05 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-31 15:19:05 +0000 |
| commit | 252014f95ffbc88c6b627bb1a1fa4ff019096707 (patch) | |
| tree | 3346e34b3867261b2bea75c0523e2aeb19d4cb95 /ppapi | |
| parent | bcb999db980e678755e59b8c85cb973df95614ab (diff) | |
| download | chromium_src-252014f95ffbc88c6b627bb1a1fa4ff019096707.zip chromium_src-252014f95ffbc88c6b627bb1a1fa4ff019096707.tar.gz chromium_src-252014f95ffbc88c6b627bb1a1fa4ff019096707.tar.bz2 | |
Give FunctionGroupBase a virtual destructor.
HostDispatcher has a scoped_ptr<FunctionGroupBase>, so without this, it
won't invoke destructors of objects implenting FunctionGroupBase (i.e.
this is a real bug.)
Found by clang's -Wdelete-non-virtual-dtor
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7084034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87306 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
| -rw-r--r-- | ppapi/shared_impl/function_group_base.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ppapi/shared_impl/function_group_base.h b/ppapi/shared_impl/function_group_base.h index 9cdfcc6..4f98396 100644 --- a/ppapi/shared_impl/function_group_base.h +++ b/ppapi/shared_impl/function_group_base.h @@ -16,6 +16,8 @@ class ResourceCreationAPI; class FunctionGroupBase { public: + virtual ~FunctionGroupBase() {} + // Dynamic casting for this object. Returns the pointer to the given type if // it's supported. virtual thunk::PPB_CharSet_FunctionAPI* AsCharSet_FunctionAPI() { |