summaryrefslogtreecommitdiffstats
path: root/printing
diff options
context:
space:
mode:
authorthestig <thestig@chromium.org>2016-02-12 20:42:45 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-13 04:43:32 +0000
commit5ff7db243989f9ede75ab88daa2e0dee3d35fff5 (patch)
treea8b940518ff43766a07bd4e0a761b7e3df5ee5f0 /printing
parent4db8034d6f49d12f09f0210084b48671315a3675 (diff)
downloadchromium_src-5ff7db243989f9ede75ab88daa2e0dee3d35fff5.zip
chromium_src-5ff7db243989f9ede75ab88daa2e0dee3d35fff5.tar.gz
chromium_src-5ff7db243989f9ede75ab88daa2e0dee3d35fff5.tar.bz2
Cleanup misc nits in printing metafile code.
Review URL: https://codereview.chromium.org/1693883004 Cr-Commit-Position: refs/heads/master@{#375346}
Diffstat (limited to 'printing')
-rw-r--r--printing/metafile_skia_wrapper.cc2
-rw-r--r--printing/pdf_metafile_skia.cc34
-rw-r--r--printing/pdf_metafile_skia.h1
3 files changed, 18 insertions, 19 deletions
diff --git a/printing/metafile_skia_wrapper.cc b/printing/metafile_skia_wrapper.cc
index 9f728b5..016b68d 100644
--- a/printing/metafile_skia_wrapper.cc
+++ b/printing/metafile_skia_wrapper.cc
@@ -11,7 +11,7 @@ namespace printing {
namespace {
-const char* kMetafileKey = "CrMetafile";
+const char kMetafileKey[] = "CrMetafile";
} // namespace
diff --git a/printing/pdf_metafile_skia.cc b/printing/pdf_metafile_skia.cc
index e7ebc5c..0fade56 100644
--- a/printing/pdf_metafile_skia.cc
+++ b/printing/pdf_metafile_skia.cc
@@ -65,6 +65,21 @@ bool WriteAssetToBuffer(const SkStreamAsset* asset,
return (length == assetCopy->read(buffer, length));
}
+SkTime::DateTime TimeToSkTime(base::Time time) {
+ base::Time::Exploded exploded;
+ time.UTCExplode(&exploded);
+ SkTime::DateTime skdate;
+ skdate.fTimeZoneMinutes = 0;
+ skdate.fYear = exploded.year;
+ skdate.fMonth = exploded.month;
+ skdate.fDayOfWeek = exploded.day_of_week;
+ skdate.fDay = exploded.day_of_month;
+ skdate.fHour = exploded.hour;
+ skdate.fMinute = exploded.minute;
+ skdate.fSecond = exploded.second;
+ return skdate;
+}
+
} // namespace
namespace printing {
@@ -99,7 +114,7 @@ bool PdfMetafileSkia::StartPage(const gfx::Size& page_size,
const gfx::Rect& content_area,
const float& scale_factor) {
if (data_->recorder_.getRecordingCanvas())
- this->FinishPage();
+ FinishPage();
DCHECK(!data_->recorder_.getRecordingCanvas());
SkSize sk_page_size = gfx::SizeFToSkSize(gfx::SizeF(page_size));
data_->pages_.push_back(
@@ -133,28 +148,13 @@ bool PdfMetafileSkia::FinishPage() {
return true;
}
-static SkTime::DateTime TimeToSkTime(base::Time time) {
- base::Time::Exploded exploded;
- time.UTCExplode(&exploded);
- SkTime::DateTime skdate;
- skdate.fTimeZoneMinutes = 0;
- skdate.fYear = exploded.year;
- skdate.fMonth = exploded.month;
- skdate.fDayOfWeek = exploded.day_of_week;
- skdate.fDay = exploded.day_of_month;
- skdate.fHour = exploded.hour;
- skdate.fMinute = exploded.minute;
- skdate.fSecond = exploded.second;
- return skdate;
-}
-
bool PdfMetafileSkia::FinishDocument() {
// If we've already set the data in InitFromData, leave it be.
if (data_->pdf_data_)
return false;
if (data_->recorder_.getRecordingCanvas())
- this->FinishPage();
+ FinishPage();
SkDynamicMemoryWStream pdf_stream;
skia::RefPtr<SkDocument> pdf_doc =
diff --git a/printing/pdf_metafile_skia.h b/printing/pdf_metafile_skia.h
index aa5acd7..dffcc3e 100644
--- a/printing/pdf_metafile_skia.h
+++ b/printing/pdf_metafile_skia.h
@@ -7,7 +7,6 @@
#include <stdint.h>
-#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "build/build_config.h"