diff options
| author | krasin <krasin@chromium.org> | 2016-03-08 21:07:10 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-09 05:08:19 +0000 |
| commit | 729a518e05c01b45067d28c9eebfb05ef76043ff (patch) | |
| tree | 69a8a66e36573eb195dd964fe1223e821e708bc6 /tools/clang | |
| parent | fddcba7d1bc975cd1647382a2e73af7fe26d9f4f (diff) | |
| download | chromium_src-729a518e05c01b45067d28c9eebfb05ef76043ff.zip chromium_src-729a518e05c01b45067d28c9eebfb05ef76043ff.tar.gz chromium_src-729a518e05c01b45067d28c9eebfb05ef76043ff.tar.bz2 | |
Revert of clang upload.sh: don't download Clang binaries from clang_upload bots. (patchset #3 id:40001 of https://codereview.chromium.org/1757733004/ )
Reason for revert:
Not needed anymore. https://codereview.chromium.org/1776893002/ was a better approach.
Original issue's description:
> clang upload.sh: don't download Clang binaries from clang_upload bots.
>
> Clang Upload trybots are used to build the new Clang
> binaries. Right now, they fail, because they try to download
> the not-yet-built clang revision during runhooks.
>
> In this CL a check into update.py is added to skip the
> download if it's running from Clang Upload trybot. LLVM_FORCE_LOCAL_BUILD env var is used for that.
>
> BUG=578306
>
> Committed: https://crrev.com/9321234d5ec76fadeacefd38591b93420dc62b67
> Cr-Commit-Position: refs/heads/master@{#379989}
TBR=thakis@chromium.org,hans@chromium.org,krasin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=578306
Review URL: https://codereview.chromium.org/1777793003
Cr-Commit-Position: refs/heads/master@{#380072}
Diffstat (limited to 'tools/clang')
| -rwxr-xr-x | tools/clang/scripts/update.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py index 8b922b8..b1a59b7 100755 --- a/tools/clang/scripts/update.py +++ b/tools/clang/scripts/update.py @@ -722,11 +722,6 @@ def main(): if args.if_needed: is_clang_required = False - # We don't need to download the toolchain on upload bots during runhooks. - if 'LLVM_FORCE_LOCAL_BUILD' in os.environ: - print ('Skipping downloading Clang toolchain binaries as ' - 'LLVM_FORCE_LOCAL_BUILD is found in the environment') - return 0 # clang is always used on Mac and Linux. if sys.platform == 'darwin' or sys.platform.startswith('linux'): is_clang_required = True |