diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-20 19:31:10 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-20 19:32:33 +0000 |
| commit | d4d772ea090aa8c073e93243ddee9c1258661cda (patch) | |
| tree | 23f1c6fe8346074a9504f3ca7c9234fd37afab90 /tools/win | |
| parent | 069c7b15ef037351d9f5771424bb6db80e5c92e0 (diff) | |
| download | chromium_src-d4d772ea090aa8c073e93243ddee9c1258661cda.zip chromium_src-d4d772ea090aa8c073e93243ddee9c1258661cda.tar.gz chromium_src-d4d772ea090aa8c073e93243ddee9c1258661cda.tar.bz2 | |
Don't pass const strings to CreateProcess.
The documentation says that CreateProcess() can modify its second parameter
in UNICODE builds.
BUG=396705
R=scottmg@chromium.org, vitalybuka@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/487303004
Cr-Commit-Position: refs/heads/master@{#290890}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290890 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/win')
| -rw-r--r-- | tools/win/link_limiter/limiter.cc | 2 | ||||
| -rw-r--r-- | tools/win/split_link/split_link.cc | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/tools/win/link_limiter/limiter.cc b/tools/win/link_limiter/limiter.cc index b8a5d1c..cbb1f2a 100644 --- a/tools/win/link_limiter/limiter.cc +++ b/tools/win/link_limiter/limiter.cc @@ -74,7 +74,7 @@ static DWORD RunExe(const tstring& exe_name) { } if (!CreateProcess(NULL, // lpApplicationName - const_cast<TCHAR*>(cmdline.c_str()), + &cmdline[0], NULL, // lpProcessAttributes NULL, // lpThreadAttributes TRUE, // bInheritHandles diff --git a/tools/win/split_link/split_link.cc b/tools/win/split_link/split_link.cc index dab0618..3dd9118 100644 --- a/tools/win/split_link/split_link.cc +++ b/tools/win/split_link/split_link.cc @@ -135,8 +135,7 @@ static void RunLinker(const vector<wstring>& prefix, const wchar_t* msg) { fflush(stdout); } if (!CreateProcess(NULL, - reinterpret_cast<LPWSTR>(const_cast<wchar_t *>( - cmd.c_str())), + &cmd[0], NULL, NULL, TRUE, |