diff options
Diffstat (limited to 'build')
| -rw-r--r-- | build/config/BUILDCONFIG.gn | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn index a868fbd..2e7f878 100644 --- a/build/config/BUILDCONFIG.gn +++ b/build/config/BUILDCONFIG.gn @@ -600,7 +600,15 @@ template("component") { _component_mode = "source_set" } target(_component_mode, target_name) { - forward_variables_from(invoker, "*") + # Explicitly forward visibility, implicitly forward everything else. + # Forwarding "*" doesn't recurse into nested scopes (to avoid copying all + # globals into each template invocation), so won't pick up file-scoped + # variables. Normally this isn't too bad, but visibility is commonly + # defined at the file scope. Explicitly forwarding visibility and then + # excluding it from the "*" set works around this problem. + # See http://crbug.com/594610 + forward_variables_from(invoker, [ "visibility" ]) + forward_variables_from(invoker, "*", [ "visibility" ]) # All shared libraries must have the sanitizer deps to properly link in # asan mode (this target will be empty in other cases). |