| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
|
|
|
|
|
|
|
|
| |
BUG=354046
Review URL: https://codereview.chromium.org/441553002
Cr-Commit-Position: refs/heads/master@{#295186}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move AppWindow, AppWindowRegistry and AppsClient from apps/ to extensions/browser/app_window
Change the namespace from apps to extensions.
Fix GYP and DEPS.
BUG=403726
TBR=sky@chromium.org for include and namespace changes
Review URL: https://codereview.chromium.org/494033002
Cr-Commit-Position: refs/heads/master@{#292599}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the following clients of BCKS to using the KeyedService
component:
- //apps
- //chrome/browser/apps
- //chrome/browser/chromeos
- //chrome/browser/managed_mode
BUG=351704
TBR=yoz,jochen
Review URL: https://codereview.chromium.org/197733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename ShellWindowRegistry
* Rename ShellWindowGeometryCache
* Rename members like shell_window_ to app_window_
* Rename locals like shell_window to app_window
BUG=343591
TEST=compiles
COLLABORATOR=scheib@chromium.org
TBR=skuhne@chromium.org for chrome/browser/ui/ash/launcher
TBR=thakis@chromium.org for chrome/browser/ui/cocoa
TBR=erg@chromium.org for chrome/browser/ui/gtk
TBR=sky@chromium.org for chrome/test
Review URL: https://codereview.chromium.org/166573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change introduces separate ExtensionSystemFactories for app shell and for chrome; in particular, a new ShellExtensionSystemFactory. ExtensionsBrowserClient now selects between the two at the factory level. Callers can simply use ExtensionSystem::Get.
BUG=337707
Review URL: https://codereview.chromium.org/137753016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ExtensionPrefs and related classes from
chrome/browser/extensions/ to the top-level extensions/
directory. The following classes are moved:
ExtensionPrefStore
ExtensionPrefValueMap
ExtensionPrefValueMapFactory
ExtensionPrefs
ExtensionPrefsFactory
ExtensionScopedPref
The TestExtensionPrefs helper class and the
ExtensionPrefsTest unit tests remain in
chrome/browser/extensions, since TestExtensionPrefs has a
dependency on Chrome's PrefServiceSyncable that seems like it
will be difficult to break (more explanation at
https://codereview.chromium.org/108643002/).
BUG=313284
TBR=sky@chromium.org,pam@chromium.org
Review URL: https://codereview.chromium.org/46853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This lets it run a little further when attempting to run an app.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/106033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=159366
Review URL: https://chromiumcodereview.appspot.com/22642008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This apps specific code now lives in AppLoadService in the apps/
component.
BUG=159366, 159265, 175381
Review URL: https://chromiumcodereview.appspot.com/15947007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203382 0039d316-1c4b-4281-b951-d872f2087c98
|