| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the following clients of BCKS to using the KeyedService
component:
- //apps
- //chrome/browser/apps
- //chrome/browser/chromeos
- //chrome/browser/managed_mode
BUG=351704
TBR=yoz,jochen
Review URL: https://codereview.chromium.org/197733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppLifetimeMonitor listens to extension host notifications and observes
ShellWindowRegistry. It sends out notifications when:
- an app starts
- the first shell window opens
- the last shell window closes
- the app stops
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204487
Review URL: https://chromiumcodereview.appspot.com/16412002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was causing BrowserCommandControllerTest.IncognitoModeOnSigninAllowedPrefChange to crash.
> Factor out AppLifetimeMonitor.
>
> AppLifetimeMonitor listens to extension host notifications and observes
> ShellWindowRegistry. It sends out notifications when:
> - an app starts
> - the first shell window opens
> - the last shell window closes
> - the app stops
>
> BUG=
>
> Review URL: https://chromiumcodereview.appspot.com/16412002
TBR=jackhou@chromium.org
Review URL: https://codereview.chromium.org/16554002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppLifetimeMonitor listens to extension host notifications and observes
ShellWindowRegistry. It sends out notifications when:
- an app starts
- the first shell window opens
- the last shell window closes
- the app stops
BUG=
Review URL: https://chromiumcodereview.appspot.com/16412002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/15695004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=227219
R=joi@chromium.org
Review URL: https://codereview.chromium.org/15517005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Renames of the classes and methods will follow in separate patch(es).
BUG=227219
R=erg@chromium.org, joi@chromium.org
Review URL: https://codereview.chromium.org/14743010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only do this if the app had windows opened the last time it was running,
otherwise apps that were running but had no windows may restart by opening
windows, which manifests as apps coming back on a restart after the user
already closed them.
BUG=230667,167740,162057
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199406
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=199409
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199970
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=200016
Review URL: https://chromiumcodereview.appspot.com/14878008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks unit_tests:BrowserCommandControllerTest.IncognitoModeOnSigninAllowedPrefChange
in debug builds.
The waterfall seems to not be running with DCHECKs on so this passed by unnoticed, but
it causes failures in the CQ which is using DCHECKs. See also crbug.com/240718
Here's a failure build: http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/127560
Local bisect found this test breaks after this CL but not before.
> Restart apps that don't listen to onRestarted() by sending them onLaunched().
>
> We only do this if the app had windows opened the last time it was running,
> otherwise apps that were running but had no windows may restart by opening
> windows, which manifests as apps coming back on a restart after the user
> already closed them.
>
> BUG=230667,167740,162057
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199406
> Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=199409
>
> Review URL: https://chromiumcodereview.appspot.com/14878008
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/15031005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only do this if the app had windows opened the last time it was running,
otherwise apps that were running but had no windows may restart by opening
windows, which manifests as apps coming back on a restart after the user
already closed them.
BUG=230667,167740,162057
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199406
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=199409
Review URL: https://chromiumcodereview.appspot.com/14878008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Restart apps that don't listen to onRestarted() by sending them onLaunched().
>
> We only do this if the app had windows opened the last time it was running,
> otherwise apps that were running but had no windows may restart by opening
> windows, which manifests as apps coming back on a restart after the user
> already closed them.
>
> BUG=230667,167740,162057
>
> Review URL: https://chromiumcodereview.appspot.com/14878008
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/14711009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only do this if the app had windows opened the last time it was running,
otherwise apps that were running but had no windows may restart by opening
windows, which manifests as apps coming back on a restart after the user
already closed them.
BUG=230667,167740,162057
Review URL: https://chromiumcodereview.appspot.com/14878008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of Profile. This will help move it out of chrome.
BUG=227219
Review URL: https://codereview.chromium.org/14141006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This is a small patch to begin the process of pulling apps code out of chrome and the extensions system.
BUG=159366
Review URL: https://chromiumcodereview.appspot.com/11829055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177968 0039d316-1c4b-4281-b951-d872f2087c98
|