| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support building/running ash_unittests and ash_shell_with_content.
Change some build |use_ash| checks to |use_aura| (or remove them).
Avoid the unspecified ash dependency on chrome resources!
Explicitly load new ash_test_*.pak image/string resources instead.
(avoids including ash_resources in chrome paks w/use_aura builds)
Reserve more resource IDs for ash_strings to avoid overlap.
(uses 244 IDs now; reserve 300 instead of 200 to fit existing)
Reserve fewer content shell resource IDs, to avoid exceeding 3100.
(uses 4 IDs now; reserve 150 instead of 250 to keep current total)
https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/gen/content/shell/grit/shell_resources.h
Use base::i18n::GetConfiguredLocale(), in several ash_unittests.
(l10n_util::GetApplicationLocale fails IsLocaleAvailable('en-US'))
(because it's not loading the chrome locale data anymore)
(seems okay to pair with base::i18n::SetICUDefaultLocale)
TODO: Fix ash_unittests failures/crahes (repros on ToT w/use_ash).
TODO: Fix ash_shell_with_content crash (repros on ToT w/use_ash).
TODO: Load ash resources; not 'common' in ash_shell_with_content.
TODO: Exclude ash files from message_center crbug.com/585175.
TODO: Support ash_test_resources_300_percent.pak, etc.?
BUG=584038,585175
TEST=Building ash_unittests and ash_shell_with_content works with use_ash=0 and use_aura=1.
R=oshima@chromium.org,dewittj@chromium.org,sky@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1664013002
Cr-Commit-Position: refs/heads/master@{#374547}
|
| |
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/795373005/ with fix.
TBR=dpranke
Review URL: https://codereview.chromium.org/797613004
Cr-Commit-Position: refs/heads/master@{#310072}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/795373005/)
Reason for revert:
This broke Linux ChromiumOS GN build:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/5292
See also:
https://codereview.chromium.org/816393003
Original issue's description:
> Add GN interactive UI tests
>
> TBR=dpranke
>
> Committed: https://crrev.com/0287a1a1750bbe22d3b4efb29b08b9aed13e723e
> Cr-Commit-Position: refs/heads/master@{#310040}
TBR=dpranke@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/823283005
Cr-Commit-Position: refs/heads/master@{#310054}
|
| |
|
|
|
|
|
|
| |
TBR=dpranke
Review URL: https://codereview.chromium.org/795373005
Cr-Commit-Position: refs/heads/master@{#310040}
|
|
|
It seems to be much more common to have this kind of resources file as a
normal GYP file rather than an *include* GYP file.
$ git ls-files | grep resources.gyp$ | grep -v ash_resources | wc -l
9
vs
$ git ls-files | grep resources.gypi$ | grep -v ash_resources | wc -l
3
BUG=None
TEST=None
R=jamescook@chromium.org
NOTRY=true
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/307993007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274130 0039d316-1c4b-4281-b951-d872f2087c98
|
