summaryrefslogtreecommitdiffstats
path: root/ash/focus_cycler.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix the browser crash that caused by referring to deleted shelf widget.xdai2015-09-291-0/+6
| | | | | | | | | | | When shelf widget & status area widget are removed, they should also be removed from focus cycler. BUG=533987 TEST=Manually checked Review URL: https://codereview.chromium.org/1372743002 Cr-Commit-Position: refs/heads/master@{#351211}
* System modal dialog unhide shelf launcher, and prevents going into maximized ↵afakhry2015-01-121-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | mode. When shelf is auto hidden, displaying a system modal dialog used to unhide it. That was because the ShelfLayoutManager when updating the shelf visibility, it used to ask the MruWindowTracker to build a list of the windows. This list used to exclude the unfocusable windows (due to the system modal dialog), So the returned list used to be empty which means the shelf should be unhidden. We actually need the list of all visible windows regardless of their focusability. Two unit tests has been written to validate the correct behavior in both single and dual display modes. BUG=277893, 447720 TEST=ash_unittests --gtest_filter=ShelfLayoutManagerTest.ShelfWithSystemModalWindowSingleDisplay, ShelfLayoutManagerTest.ShelfWithSystemModalWindowDualDisplay, MaximizeModeWindowManagerTest.GoingToMaximizedWithModalDialogPresent Review URL: https://codereview.chromium.org/780113002 Cr-Commit-Position: refs/heads/master@{#311063}
* Cleaning up MruWindowTracker::BuildWindowList()afakhry2014-12-101-1/+1
| | | | | | | | | | | | | | | | | | | Removing the top_most_at_end parameter which was always set to false and was never used. The previous CL (https://codereview.chromium.org/752253002) was reverted as it caused ash_unittests to fail on Windows: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1) http://build.chromium.org/p/chromium.win/builders/Win8%20Aura This is a retry, but we keep reversing the windows list after we build it. R=oshima@chromium.org BUG=None Review URL: https://codereview.chromium.org/785273002 Cr-Commit-Position: refs/heads/master@{#307593}
* Revert of Cleaning up MruWindowTracker::BuildWindowList() (patchset #1 id:1 ↵gab2014-12-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/786513003/) Reason for revert: I don't see why this would cause any problems, it looks like a purely aesthetic, yet this is the only Ash related CL in the regression range [1] for ever-failing Win8 Aura [2] and Win7(dbg) ash_unittests since these commits. (the test failures seem to be timing out with no output, weird... I'll check this back in if the revert doesn't help...) [1] https://chromium.googlesource.com/chromium/src/+log/8e72e1d6c13fa6a4cf2859ac6e209be4546bb50d..00df169a990ea09d488f1c13ec0293fc11d7992e?pretty=fuller [2]http://build.chromium.org/p/chromium.win/builders/Win8%20Aura Failing tests: ToggleMinimized WindowDockLeftMinimizeWindowWithRestore WindowPanelDockLeftDockRightRestore WindowSnapLeftDockLeftRestore WindowSnapLeftDockLeftSnapRight WindowSnapRightDockRightRestore EventsDoNotLeakToWindowUnderneath Basic MinimizedWindowsAreLru GestureSwipe SwipeUpDownWithoutReleasing VerticalSwipes PanelsHideAndRestoreWithShelf AcceleratorsWithFullscreen WorkAreaChangeWorkspace AlwaysOnTopMultiWindow AlwaysOnTopWindow CycleMruPanelDestroyed CyclePanels CyclePanelsDestroyed HandleCycleWindow MaximizedWindow MostRecentlyUsed SelectingHidesAppList SecondMaximizedWindowHasProperRestoreSize ActivationCancelsOveriew Basic BasicGesture BasicTabKeyNavigation BasicTextFiltering CloseButton CloseButtonOnPanels CreateLabelUnderPanel FullscreenWindow FullscreenWindowMaximizeMode LastWindowDestroyed NewWindowCancelsOveriew NoCrashWithDesktopTap NonActivatableWindowsHidden SelectWindowWithReturnKey SelectingHidesAppList Shutdown TextFilteringSelection WindowOverviewHidesCalloutWidgets AnimatedNormToMaxToNormRepositionsRemaining AutoPlacingMovesTransientChild BasicAutoPlacingOnShowHide NormToMaxToMinRepositionsRemaining NormToMaxToNormRepositionsRemaining ShelfStateUpdated TestSingleWindowsRestoredBounds TestUserHandledWindowRestore TestUserMovedWindowRepositioning ToMinimizeRepositionsRemaining Original issue's description: > Cleaning up MruWindowTracker::BuildWindowList() > > Removing the top_most_at_end parameter which was always set to false and > was never used. > > R=oshima@chromium.org > BUG=None > > Committed: https://crrev.com/f3848eee6c17acc74543c803bcea7ea542e13cbc > Cr-Commit-Position: refs/heads/master@{#307135} TBR=oshima@chromium.org,afakhry@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/790503003 Cr-Commit-Position: refs/heads/master@{#307248}
* Cleaning up MruWindowTracker::BuildWindowList()afakhry2014-12-061-1/+1
| | | | | | | | | | | | Removing the top_most_at_end parameter which was always set to false and was never used. R=oshima@chromium.org BUG=None Review URL: https://codereview.chromium.org/786513003 Cr-Commit-Position: refs/heads/master@{#307135}
* Eliminate ash::internal namespaceoshima@chromium.org2014-04-031-4/+0
| | | | | | | | | | | Plus obvious style nit fixes. BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/224113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
* Move some code from aura/client to wm/publicben@chromium.org2014-03-211-1/+1
| | | | | | | | | | | Still building as part of the aura target, will fix that in a future step. TBR=sky@chromium.org http://crbug.com/308710 Review URL: https://codereview.chromium.org/206453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258651 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --ash-disable-overview-modeflackr@chromium.org2014-03-121-7/+6
| | | | | | | | BUG=340466 Review URL: https://codereview.chromium.org/181563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256645 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor most recently used window tracking into a separate class.flackr@chromium.org2013-07-311-1/+2
| | | | | | | | | BUG=263477 TEST=None Review URL: https://chromiumcodereview.appspot.com/20708005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214609 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cycling of focusable panes in Chrome OS.dmazzoni@chromium.org2013-04-301-5/+30
| | | | | | | | | | | | | | Update the ash window cycle controller so it can tell aura::Window to rotate pane focus and pass it the cycle direction, rather than just activating each window. The end result is that when you press Ctrl+Back and Ctrl+Forward you get a consistent cycle now, going through all panes within the most recently active browser window and then the launcher and status area. BUG=154598 Review URL: https://chromiumcodereview.appspot.com/13861032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197199 0039d316-1c4b-4281-b951-d872f2087c98
* Switch Next Window Key functionalityharrym@chromium.org2013-03-261-1/+1
| | | | | | | | | | | | | Switches the next window button on chromeos (f5) to act the same as alt-tab/shift-alt-tab BUG=174035 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/12618014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190579 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing activation state problem with the launcher acessiblity paneskuhne@chromium.org2013-02-221-10/+6
| | | | | | | | | | | | BUG=165089 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183728 Review URL: https://chromiumcodereview.appspot.com/12315021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184045 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 183728dtu@chromium.org2013-02-211-6/+10
| | | | | | | | | | | | | | | | > Fixing activation state problem with the launcher acessiblity pane > > > BUG=165089 > TEST=unittest > > > Review URL: https://chromiumcodereview.appspot.com/12315021 TBR=skuhne@chromium.org Review URL: https://codereview.chromium.org/12310038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183741 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing activation state problem with the launcher acessiblity paneskuhne@chromium.org2013-02-211-10/+6
| | | | | | | | | | BUG=165089 TEST=unittest Review URL: https://chromiumcodereview.appspot.com/12315021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183728 0039d316-1c4b-4281-b951-d872f2087c98
* Add always on top windows to the alt+tab listzork@chromium.org2012-08-061-1/+1
| | | | | | | | | | BUG=114631 TEST=Open Google Talk. Try to alt+tab away from it, and then back. Review URL: https://chromiumcodereview.appspot.com/10700057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150094 0039d316-1c4b-4281-b951-d872f2087c98
* Fix status area widget resizing and other Ash tray cleanup.stevenjb@google.com2012-06-141-1/+0
| | | | | | | | | | | | | | | Moves common EventFilter code to TrayBubbleView::Host. Fixes web balloon toggle and layout behavior. BUG=none TEST=tests pass and system / notification trays are resized / laid out correctly when web notifications occur (requires --ash-notify) For trivial change to focus_cycler.cc: TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10537162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142273 0039d316-1c4b-4281-b951-d872f2087c98
* Handle Ctrl+F1 and Ctrl+F2 correctly even when no browser window is available.yusukes@chromium.org2012-06-141-32/+15
| | | | | | | | | | | | | - Remove accelerators from ash/focus_cycler.cc and chrome/browser/ui/views/accelerator_table.cc. Instead, handle it in ash/accelerator/accelerator_controller.cc. - Do not try to focus a browser window in ash/focus_cycler.cc when it's not available. Unit tests added. BUG=129307 TEST=ran aura_shell_unittests + manually checked Review URL: https://chromiumcodereview.appspot.com/10545132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142107 0039d316-1c4b-4281-b951-d872f2087c98
* Pass event bitmask (shift, control, alt) to ui::Accelerator instead of booleans.tfarina@chromium.org2012-05-181-2/+2
| | | | | | | | | | BUG=128242 R=ben@chromium.org TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10399044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137792 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ShellDelegate::GetCycleWindowList. Because alt-tab operates onsky@chromium.org2012-04-031-11/+8
| | | | | | | | | | | | | | | | all windows now there is no need to push the implementation to the delegate and it can instead be consolidated. Also added a couple more test cases, and fixed a bug that occurred if there is a single window but it wasn't active. BUG=120987 TEST=see bug, also covered by test. R=jamescook@chromium.org Review URL: http://codereview.chromium.org/9969075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130315 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Focus tray with shift-alt-ssadrul@chromium.org2012-03-261-11/+17
| | | | | | | | | BUG=120177 TEST=none Review URL: https://chromiumcodereview.appspot.com/9855029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129008 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Shell::GetRootWindow with Window::GetRootWindowoshima@chromium.org2012-03-141-1/+1
| | | | | | | | | | | | | | where this makes sense. I didn't change the class that is potentially global and not root specific. This also removes ToplevelLayoutManager that is not longer in use. BUG=115510 TEST=none Review URL: https://chromiumcodereview.appspot.com/9665016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126590 0039d316-1c4b-4281-b951-d872f2087c98
* Ash: Remove compact window mode.jamescook@chromium.org2012-03-081-1/+1
| | | | | | | | | | | | | | | | | | | Remove MultipleWindowIndicatorButton Clean up OpaqueBrowserFrameView Remove CompactBrowserFrameView Remove ash/wm/compact_layout_manager and compact_status_area_layout_manager Remove window mode switches Remove window mode from ash::Shell Remove ShellDelegate::CycleOrder Remove ShellDelegate::GetOverrideWindowMode Remove all outside calls to Shell::IsWindowModeCompact BUG=117284 TEST=existing tests Review URL: https://chromiumcodereview.appspot.com/9630002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125625 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate client API setters/getters to take a RootWindow.ben@chromium.org2012-02-261-1/+2
| | | | | | | | | http://crbug.com/112131 TEST=none TBR=sky Review URL: https://chromiumcodereview.appspot.com/9455081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123690 0039d316-1c4b-4281-b951-d872f2087c98
* Experimental Extension Keybinding (first cut).finnur@chromium.org2012-02-231-2/+6
| | | | | | | | | | | | | | | | | | | | | | Implemented in this cut: - End-to-end extension keybinding -- in one dimension, that is -- no UI, just basic functionality, such as: - Manifest changes to specify keybinding. - A simple parser to parse the keybinding from the manifest. - An Extension Keybinding Registry object. - The ability to open browser action popups, page action popups and send named events to the Extension. Not implemented: - All non-Windows specific code. - Install-success-bubble UI changes (that notify the user of new keybinding -- or of keybinding conflict) - A UI to show all keybindings and keybinding conflicts, allowing user to reconfigure keybindings. BUG=27702 TEST=This is tested by an automated test and requires an extension to test manually (one that registers keybinding shortcuts). Review URL: https://chromiumcodereview.appspot.com/9402018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123228 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so the launcher only gets focus when using the keyboard.sky@chromium.org2012-02-171-1/+3
| | | | | | | | | | BUG=114502 TEST=see bug R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/9406031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122459 0039d316-1c4b-4281-b951-d872f2087c98
* Allow focus to be sent between browser window and launcher/status windowzork@chromium.org2012-02-071-0/+101
R=sky@chromium.org BUG=104192 TEST=Use ctrl+forward/back to move between browser window and status area/launcher Review URL: http://codereview.chromium.org/9295049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120738 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-22 15:36:44 +0000