| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
the header instead of NonClientFrameView. This functionality is necessary so that CustomFrameViewAsh can be put into immersive fullscreen.
BUG=307622
TEST=ResizeShadowAndCursorTest.*
R=jamescook
TBR=sky (For trivial refactor as a result of merging CustomFrameViewAsh::Init() and the CustomFrameViewAsh constructor)
Review URL: https://codereview.chromium.org/27267003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromiumcodereview.appspot.com/14439006
BUG=304196
TEST=ToplevelWindowEventHandlerResizeTest.MouseResizeShadows
Review URL: https://codereview.chromium.org/25807005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RootWindowController::CloseChildWindows() was explicitly deleting
windows. It should only do that for windows that are owned by the
parent, otherwise the window should be removed.
BUG=297028
TEST=covered by test now.
R=oshima@chromium.org
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/25736004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Fixes use after free caused by delete in RootWindowController
>
> RootWindowController::CloseChildWindows() was explicitly deleting
> windows. It should only do that for windows that are owned by the
> parent, otherwise the window should be removed.
>
> BUG=297028
> TEST=covered by test now.
> R=oshima@chromium.org
>
> Review URL: https://codereview.chromium.org/25374002
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/25659002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RootWindowController::CloseChildWindows() was explicitly deleting
windows. It should only do that for windows that are owned by the
parent, otherwise the window should be removed.
BUG=297028
TEST=covered by test now.
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/25374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* define separate file for WindowStateObserver.
Next step.
* Change auto placing code to update the state.
* Notify observers when ash specific state has changed.
Fix code and tests.
BUG=272460
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/23736012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.
The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().
The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.
BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224473
Review URL: https://codereview.chromium.org/24175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove dependency on ui::ScaleFactor from ui/gfx
>
> As part of the work to removed dependencies on ui/base from ui/gfx I have
> changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
> to take float scale values instead of ui::ScaleFactor.
>
> The notion of supported scale factors has been broken into 2 parts.
> ui::SetSupportedScaleFactors remains and calls the
> new ImageSkia::SetSupportedScales().
>
> The initialization of the supported scale factors has been moved from layout.h
> into ResourceBundle, and is done explicitly in tests that don't use
> ResourceBundle.
>
> BUG=103304
> R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/24175004
TBR=davemoore@chromium.org
Review URL: https://codereview.chromium.org/24262008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.
The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().
The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.
BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/24175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move window control methods from window_util.h to WindowState
Removed property_util which is no longer necessary.
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/24108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/23498031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also made GFX_EXPORT real, which is ok since it's the same as
UI_EXPORT. It'll only matter when we separate out at gyp level.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/23531053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=290240
Review URL: https://chromiumcodereview.appspot.com/23619045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Introduced Observer to observe changes to the settings.
* renamed UserHasChangedWindowPositinoOrSize to bounds_channed_by_user
BUG=272460
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222512
R=flackr@chromium.org, skuhne@chromium.org, sky@chromium.org, varkha@chromium.org
Review URL: https://codereview.chromium.org/23518006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Group WM related properties to ash::wm::WindowSettings
> * Introduced Observer to observe changes to the settings.
> * renamed UserHasChangedWindowPositinoOrSize to bounds_channed_by_user
>
> BUG=272460
>
> Review URL: https://chromiumcodereview.appspot.com/23518006
REASON FOR REVERT:
- Causing compiler errors on the tree: Win Aura Builder
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Builder&number=11959
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/23478025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Introduced Observer to observe changes to the settings.
* renamed UserHasChangedWindowPositinoOrSize to bounds_channed_by_user
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/23518006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=282594
TEST=Run ChromeOS with flags:
--force-fieldtrials="ShowProfileSwitcher/AlwaysShow/"
--multi-profiles
Review URL: https://chromiumcodereview.appspot.com/23583037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like this doesn't have to be a window property.
Changed to use a plain global flag.
BUG=272460
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/23625007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/23496024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FrameCaptionButtonContainerView.
TEST=FrameCaptionButtonContainerViewTest.*
BUG=274171
Review URL: https://chromiumcodereview.appspot.com/23202005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=jamescook
Review URL: https://chromiumcodereview.appspot.com/23258003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now aura::Window emits OnVisibilityChanged() when its child window's
visibility has changed (see: http://src.chromium.org/viewvc/chrome/trunk/src/ui/aura/window.cc#l1025)
And when the user switches the tab, or load a tab, the child window of
BrowserFrameAura's visibility is also changed, which causes FramePainter's
OnVisibilityChanged(). Because FramePainter assumes window == window_
in that method and set window_ as |ignore_window|, it can't find any
windows in the root, which makes UseSoloWindowHeaderInRoot() return false
unexpectedly.
Anyways, OnVisibilityChanged() doesn't need to update the solo header
when the visibility change has happened on its child, not itself, so
this CL just adds the simple check.
BUG=268541
R=jamescook@chromium.org
TEST=new ash_unittests passes
Review URL: https://chromiumcodereview.appspot.com/22339003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now DefaultContainer holds the normal windows.
BUG=264396
R=sky@chromium.org
TEST=ash_unittests still passes
Review URL: https://chromiumcodereview.appspot.com/21806009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=263514
TEST=Manual, see bug
Review URL: https://chromiumcodereview.appspot.com/20339002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
workspace, it is pretty clear that it will never be enabled.
No intended functionality change.
BUG=None
TEST=None
R=jamescook
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/20303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The drag and drop tracker creates a non-drawing window for mouse capture
during the drag. Don't count non-drawing windows towards the "solo window"
header opacity computation.
BUG=248727
TEST=added to ash_unittests FramePainterTest
Review URL: https://chromiumcodereview.appspot.com/18654003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also change how we compute the title bounds, which provides better vertical
centering for popup window titles.
This broke due to panels changes crrev.com/183369 and crrev.com/157042
BUG=257068
TEST=added ash_unittests FramePainterTest.TitleIconAlignment
Review URL: https://chromiumcodereview.appspot.com/18652005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When popup window is maximized, we can't read its title because its color
is very similar to its background color. To make title more readable,
title color is changed to white when popup window is maximized.
R=jamescook@chromium.org
BUG=163156
TEST=Compiles, Visual test
Review URL: https://chromiumcodereview.appspot.com/18586003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on CrOS in the ash/ directory.
BUG=173286
Review URL: https://chromiumcodereview.appspot.com/16968003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
theme change. Doing a crossfade animation is bad because we do not cache the image we are crossfading from.
BUG=247251
TEST=Manual, see bug
TBR=jamescook (Because this CL is a subset of https://codereview.chromium.org/16525002/)
Review URL: https://chromiumcodereview.appspot.com/16431006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
specified.
BUG=240568
Test=Manual, see bug
Review URL: https://chromiumcodereview.appspot.com/15096007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fullscreen
Bug=236598
Test=Manual, see bug
Review URL: https://chromiumcodereview.appspot.com/15086004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=235440
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/15030010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the edge gesture functionality from the BorderGestureHandler
to the ShelfLayoutManager, so that touches on the edge of the screen
when there is a touch enabled web page will be handled correctly.
Specifically when autohidden the shelf will steal a small portion of
the touch screen so that users may perform a drag operation to make it
visible.
This CL also changes the method SetHitTestBoundsOverrideOuter to take an
inset for both mouse and touch instead of having a mouse inset and touch
scale. This change is propagated to all the instances that this method is
used and updates the unit tests.
BUG=chromium:223666
TEST=Built and confirmed that dragging in/out works with shelf on
left/bottom/right of screen with page open that handles touch events.
Built and ran modified unit tests.
Review URL: https://chromiumcodereview.appspot.com/14439006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome OS Ash window transparency computation was wrong.
BUG=229709
TEST=Added to ash_unittests FramePainterTest
Review URL: https://chromiumcodereview.appspot.com/14179002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=169880
TEST=Manual, see steps below:
1) Run chrome with --ash-immersive-fullscreen
2) Open an incognito window
3) Use F11 to go into immersive mode
4) Hover mouse at the top of the screen, make sure that the incognito icon shows up
Review URL: https://chromiumcodereview.appspot.com/13353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The computation for when to use transparent "solo window" headers was not
correctly accounting for panels and constrained dialogs.
BUG=224154,225015
TEST=added to ash_unittests FramePainterTest
Review URL: https://chromiumcodereview.appspot.com/13313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue where V2 app windows cause the transparency of window headers
to be computed incorrectly.
BUG=176583
TEST=ash_unittests FramePainterTest.*
R=mukai@chromium.org
Review URL: https://codereview.chromium.org/12807003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
through workspaces
Bug=176025
Test=Manual, see bug
Review URL: https://chromiumcodereview.appspot.com/12319039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change loading indicator color to blue
2. Slow down the initial slide-out
3. Always paint the caption area black, like maximized
4. Clicks in the top pixel of the screen switch tabs
5. Fix a crash due to tooltip position lookup during view reparenting
BUG=180022
TEST=manual, existing unit_tests and browser_tests
Review URL: https://codereview.chromium.org/12393062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=172275
TEST=Open a panel window, minimize button next to close button has the minimize button asset.
Review URL: https://codereview.chromium.org/12313153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove immersive mode button from maximized window frame
* Tie immersive mode to browser-fullscreen only, keep tab-fullscreen
with existing UI
* Size button exits immersive mode
* Add ImageButton::GetImage for testing
* Most browser commands are enabled in immersive fullscreen
BUG=177549
TEST=added to browser_tests views_unittests ash_unittests
Original review: https://codereview.chromium.org/12316086/
Review URL: https://chromiumcodereview.appspot.com/12328119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks omnibox text input after leaving immersive mode, will fix and reland
> ash: Use immersive mode for fullscreen
>
> * Remove immersive mode button from maximized window frame
> * Tie immersive mode to browser-fullscreen only, keep tab-fullscreen
> with existing UI
> * Size button exits immersive mode
> * Add ImageButton::GetImage for testing
>
> BUG=177549
> TEST=added to browser_tests views_unittests ash_unittests
>
>
> Review URL: https://chromiumcodereview.appspot.com/12316086
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/12335098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove immersive mode button from maximized window frame
* Tie immersive mode to browser-fullscreen only, keep tab-fullscreen
with existing UI
* Size button exits immersive mode
* Add ImageButton::GetImage for testing
BUG=177549
TEST=added to browser_tests views_unittests ash_unittests
Review URL: https://chromiumcodereview.appspot.com/12316086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also don't minimize when clicking on titlebar
BUG=160645
Review URL: https://chromiumcodereview.appspot.com/12212207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set them invisible when immersive mode is enabled, but show them when we reveal the toolbar.
Also ensure the caption buttons don't reserve too much horizontal space when the immersive mode button is invisible. Otherwise the tab strip doesn't have enough space.
BUG=168855
TEST=added browser_tests BrowserNonClientFrameViewAshTest.ImmersiveMode
Review URL: https://codereview.chromium.org/11826068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131242
TEST=Tested on Linux ChromeOS build
Review URL: https://chromiumcodereview.appspot.com/11673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=160897
TEST=visual
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/11308239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Prevents windows from resizing bigger than their max size
- Prevents windows from snapping when they have max size defined
- Prevents windows from maximizing when they have max size defined
BUG=152065
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168447
Review URL: https://chromiumcodereview.appspot.com/11366215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual, button changes toggle state when clicked
Review URL: https://chromiumcodereview.appspot.com/11421017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169163 0039d316-1c4b-4281-b951-d872f2087c98
|