summaryrefslogtreecommitdiffstats
path: root/chrome/installer/util
Commit message (Collapse)AuthorAgeFilesLines
* Move variations prefs into the variations componentblundell2015-08-172-3/+5
| | | | | | | | | | | These prefs are used by variations code that is targeted for componentization. BUG=382865 TBR=thakis Review URL: https://codereview.chromium.org/1265423003 Cr-Commit-Position: refs/heads/master@{#343661}
* chrome/installer: Remove unused GetNetworkStatsServer() method.tfarina2015-08-147-24/+0
| | | | | | | | | | | Nobody seems to be calling it, so lets remove it. BUG=None R=robertshield@chromium.org Review URL: https://codereview.chromium.org/1290283002 Cr-Commit-Position: refs/heads/master@{#343390}
* Componentize kExperimentLabelSeparator & BuildExperimentDateString.sdefresne2015-08-137-106/+7
| | | | | | | | | | | | Move kExperimentLabelSeparator & BuildExperimentDateString into the variations components so that chrome/common/variations can be componentized in a followup CL (in order to be shared with iOS). BUG=520070 Review URL: https://codereview.chromium.org/1291763002 Cr-Commit-Position: refs/heads/master@{#343246}
* Replace ToLower calls to the new formatbrettw2015-08-101-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces base::StringToLowerASCII(string) with base::ToLowerASCII(string) This form is 1:1 search and replace. A bunch of places did something like this: std::string foo(something_else); base::StringToLowerASCII(&foo); which became: foo = base::ToLowerASCII(something_else); A couple places really wanted in-place changing and they became: foo = base::ToLowerASCII(foo); There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting). There was more cleanup in: chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case. NOPRESUBMIT=true (due to touching code with wstrings) Review URL: https://codereview.chromium.org/1279123004 Cr-Commit-Position: refs/heads/master@{#342659}
* Replace StringToLowerASCII with base::ToLowerASCIIbrettw2015-08-061-2/+2
| | | | | | | | | | | | | | Standardize on using string pieces and returning strings. Remove in-place version (this was only used in a couple places and they were not performance-critical). De-templatize the character versions of ToUpperASCII/ToLowerASCII. This would lead to bizarre errors if you pass other things (like a string). This is so little code, it's now just duplicated. I renamed StringToLowerASCII to just be ToLowerASCII so you can pass whatever you want to ToLowerASCII and it does the right thing. This seems simpler to me. This replaces all calls of StringToUpperASCII to the new form. The lowercase version is more common and will be done in a separate pass. Review URL: https://codereview.chromium.org/1280473002 Cr-Commit-Position: refs/heads/master@{#342219}
* Check for dual mode migration on taskbar pins as well as start menu shortcuts.gab2015-08-051-0/+2
| | | | | | | | | | | | | Dual mode is only ever explicitly set on start menu shortcuts, but the taskbar shortcut is a pin of the start menu shortcut and thus inherits its properties when created. BUG=501166 TBR=sky@chromium.org (OS_WIN only comment update in shell_integration.h from OWNER of shell_integration_win.cc) Review URL: https://codereview.chromium.org/1265153004 Cr-Commit-Position: refs/heads/master@{#341911}
* Add some extra logging for short-path generation failures.jam2015-07-311-1/+1
| | | | | | | | BUG=515717 Review URL: https://codereview.chromium.org/1265013002 Cr-Commit-Position: refs/heads/master@{#341387}
* Make use of a modern style in InstallUtilTests WRT registry overriding, etc.gab2015-07-311-120/+116
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1234843004 Cr-Commit-Position: refs/heads/master@{#341357}
* clang/win: Fix most -Wunused-function warnings in Chromium code.thakis2015-07-283-23/+2
| | | | | | | | | | | No intended behavior change. BUG=505316 TBR=armansito Review URL: https://codereview.chromium.org/1255073002 Cr-Commit-Position: refs/heads/master@{#340761}
* Annotate large GN targets for precompiled headersbrettw2015-07-281-2/+6
| | | | | | | | | | | | | | | | | | Adds the precompiled header config to most large-ish targets in the build, but keeps the config a no-op (so no precompiled headers will be used but this can bw switched with a one-line change). Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them. I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower). For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static. This is a reland of https://codereview.chromium.org/1250273002/ with the config disabled for easier re-landing and iterating CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=dpranke Review URL: https://codereview.chromium.org/1258273004 Cr-Commit-Position: refs/heads/master@{#340728}
* Revert "Add precompiled headers to GN build for large targets."dpranke2015-07-281-6/+2
| | | | | | | | | | | | | | | | | This reverts commit 8f3218985dde74063ccc362da47803be163f3165. It looks like this may have broken incremental builds on Win. TBR=brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1256223003 Cr-Commit-Position: refs/heads/master@{#340620}
* Add precompiled headers to GN build for large targets.brettw2015-07-271-2/+6
| | | | | | | | | | | | | | | | Turns on precompiled header support in the GN build on Windows, and adds the precompiled header config to most large-ish targets in the build. Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them. I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower). For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1250273002 Cr-Commit-Position: refs/heads/master@{#340535}
* Pin Chrome's shortcut to the Win10 Start menu on install and OS upgrade.gab2015-07-275-59/+98
| | | | | | | | | BUG=503682 TBR=thakis@chromium.org (for method rename having side-effects in chrome/browser/ui and base/). Review URL: https://codereview.chromium.org/1242763002 Cr-Commit-Position: refs/heads/master@{#340493}
* No dual_mode on Win10+ shortcuts.gab2015-07-272-0/+11
| | | | | | | | BUG=501166 Review URL: https://codereview.chromium.org/1252513002 Cr-Commit-Position: refs/heads/master@{#340479}
* Update SplitString calls in chrome.brettw2015-07-212-10/+8
| | | | | | | | In many places that iterated over the results, the code was changed to use a range-based for loop over the result of the SplitStirng call. Review URL: https://codereview.chromium.org/1240183002 Cr-Commit-Position: refs/heads/master@{#339753}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+2
| | | | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071}
* Revert of Remove some legacy versions of StartsWith and EndsWith. (patchset ↵yosin2015-07-161-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:100001 of https://codereview.chromium.org/1239493005/) Reason for revert: Compilation error on Windows: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c ..\..\chrome\installer\gcapi\gcapi.cc /Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C3083: 'StartsWith': the symbol to the left of a '::' must be a type c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base' c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2065: 'INSENSITIVE_ASCII' : undeclared identifier ninja: build stopped: subcommand failed. Original issue's description: > Remove some legacy versions of StartsWith and EndsWith. > > This just replaces > true -> base::CompareCase::SENSITIVE > false -> base::CompareCase::INSENSITIVE_ASCII > > I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. > > extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. > > BUG=506255 > TBR=jam > > Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56 > Cr-Commit-Position: refs/heads/master@{#338996} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506255 Review URL: https://codereview.chromium.org/1233453011 Cr-Commit-Position: refs/heads/master@{#338998}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+2
| | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996}
* Move ReplaceStringPlaceholders to base namespace.brettw2015-07-153-5/+6
| | | | | | | | | | | | Removes most unnecessary base:: qualifications from string_util. Updates ReplaceStringPlaceholders implementation to use C++11 features for the loop iterators. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1227413007 Cr-Commit-Position: refs/heads/master@{#338826}
* Welcome page changes for Windows 10.grt2015-07-144-1/+11
| | | | | | | | | | | | | | | | | | | | | | * Show the welcome page on the first launch following OS upgrades to or past Windows 10 when Chrome is not the default browser unless the WelcomePageOnOSUpgradeEnabled policy setting is set to false or the welcome_page_on_os_upgrade_enabled distribution master_preferences value is set to false. * Suppress showing the signin promo during first-run on Windows 10 and instead show the welcome page before the NTP. BUG=505029 TEST=On Windows 8.1 and older, nothing changes. On Windows 10, the signin promo is no longer shown on first run; rather, the welcome page and the NTP are shown. On Windows 10, the welcome page is shown on the first ordinary launch (for all "On startup" settings except when an URL is provided on the command line) following an upgrade from an earlier version of Windows when Chrome is not the default browser. Review URL: https://codereview.chromium.org/1226643002 Cr-Commit-Position: refs/heads/master@{#338688}
* win: Do not explicitly call MasterPreferences() constructor from member ↵thakis2015-07-142-12/+18
| | | | | | | | | | | | | | | | | function. Fixes ..\..\chrome\installer\util\master_preferences.cc(122,30) : warning(clang): explicit constructor calls are a Microsoft extension [-Wmicrosoft] this->MasterPreferences::MasterPreferences(prefs_path); ^ No intended behavior change. BUG=505296 Review URL: https://codereview.chromium.org/1235033004 Cr-Commit-Position: refs/heads/master@{#338638}
* Remove CaseInsensitiveCompare from string_util.hbrettw2015-07-141-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There were a number of callers in net using this for HTTP headers. I think these callers actually just need ASCII case-insensitive comparisons so these were changed. The omnibox code used this functor. I added a new omnibox-specific one which does not have the locale issues of the old string_util one, but which still has the UTF-16 and combining accent issues (described in great detail in the comment for this). The Windows installer code can't depend on ICU so it calls the Win32 function to do case-insensitive comparisons. This should match the system comparison for registry keys better anyway. I also changed a caller of StartsWith to use this version. I wrote this StartsWith call using ToLower in a previous patch, but it turns out that the lengths of case-mapped strings do change in practice, making the offset computations of the suyrrounding code incorrect. This new version will be like the old version (will miss some cases of case-insensitive equality) but will handle 0x80-0xFF properly. BUG=24917 Review URL: https://codereview.chromium.org/1230583014 Cr-Commit-Position: refs/heads/master@{#338624}
* Introduce UpdateActiveSetupVersionWorkItemgab2015-07-131-25/+23
| | | | | | | | | | | | | | A cleaner solution coming out of an attempt to support two similar use cases differently in https://codereview.chromium.org/1213913002/ and https://codereview.chromium.org/1214163008/. Actual use cases implemented in a follow-up CL (https://codereview.chromium.org/1223933005/). BUG=488247, 502363 TEST=setup_unittests.exe --gtest_filter=UpdateActiveSetupVersionWorkItemTest* Review URL: https://codereview.chromium.org/1223953003 Cr-Commit-Position: refs/heads/master@{#338528}
* clang/win: Fix a -Wreorder warning that crept in after the cleanup.Nico Weber2015-07-101-2/+2
| | | | | | | | | | | | | | | | | | | ..\..\chrome\installer\util\set_reg_value_work_item.cc(123,7) : warning(clang): field 'status_' will be initialized after field 'type_' [-Wreorder] status_(SET_VALUE), ^ This was added very recently in https://codereview.chromium.org/1220473002, after https://codereview.chromium.org/1210013007 had already cleaned up this file. No behavior change. BUG=505304 TBR=gab@chromium.org, grt@chromium.org Review URL: https://codereview.chromium.org/1228283002. Cr-Commit-Position: refs/heads/master@{#338243}
* Use --previous-version command-line parameter.bcwhite2015-07-092-0/+4
| | | | | | | | | | | If that parameter is provided, match only that specific version of an install. BUG=385419 Review URL: https://codereview.chromium.org/1220193008 Cr-Commit-Position: refs/heads/master@{#338011}
* Fixed all unused-variable Clang warnings on Windows.mgiuca2015-07-082-3/+3
| | | | | | | | | | | | | | Usually, fixed by removing the unused variables. Some variables had to be guarded by #ifs. Some variables could be used instead. Also removed unused test file sweep02_16b_mono_16KHz.raw. BUG=505319 TBR=rpaquay@chromium.org Review URL: https://codereview.chromium.org/1220133003 Cr-Commit-Position: refs/heads/master@{#337767}
* clang/win: Re-enable -Wlogical-op-parentheses.sammc2015-07-081-1/+1
| | | | | | | | BUG=504699 Review URL: https://codereview.chromium.org/1214303004 Cr-Commit-Position: refs/heads/master@{#337709}
* Move WriteInto to base namespace.Brett Wilson2015-07-072-2/+2
| | | | | | | | | | | | | | | | | | Update all callers. De-inlines the template. For some reason touching the namespaces started givin errors about DCHECK not being defined. Indeed, this header does not include logging.h. Rather than include logging in this very common header, it seems preferable to move the implementation to the .cc file. This removes support for the wstring variant and updates the callers that used it. R=ben@chromium.org, ben TBR=jschuh (sandbox_win.cc) NOPRESUBMIT=true (this patch touches code using legacy wstrings) Review URL: https://codereview.chromium.org/1223983002. Cr-Commit-Position: refs/heads/master@{#337703}
* Only attmept to modify experiments key if it is present and valid.wfh2015-07-021-0/+4
| | | | | | | | BUG=474417 Review URL: https://codereview.chromium.org/1213453002 Cr-Commit-Position: refs/heads/master@{#337211}
* clang/win: Build without -Wno-int-to-void-pointer-cast.sammc2015-07-021-2/+4
| | | | | | | | | BUG=504697 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/1222563004 Cr-Commit-Position: refs/heads/master@{#337179}
* Introduce a SetRegValueWorkItem overload that accepts a callback insteadgab2015-07-027-152/+362
| | | | | | | | | | | | | | | | | | | | of a fixed value. The callback is used to determine the desired value after inspecting the existing value. Also modified the existing test's paradigm to bring it up to modern days (from initial.commit!) and added some more tests to cover this new use case. Bypassing the wstring usage presubmit warnings because we will likely want to merge this, will consider fixing the API on trunk after. BUG=488247, 502363 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1220473002 Cr-Commit-Position: refs/heads/master@{#337164}
* clang/win: Fix warnings to prepare for building without -Wno-reorder.sammc2015-07-024-11/+12
| | | | | | | | | | | | | This changes constructor initializer list ordering to match field declaration ordering, except for gtest and breakpad, where the warning is disabled. BUG=505304 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1210013007 Cr-Commit-Position: refs/heads/master@{#337152}
* Fix some case-insensitive cases for StartsWith.brettw2015-07-013-11/+29
| | | | | | | | | | | | | | | | | | This is not all callers so the old function is not deleted. Most calls are replaced with either StartsWith with the enum, or StartsWith(base::i18n::ToLower(...) for cases that need truely-internationalized case comparison (or when I wasn't sure). The most interesting case is chrome/installer/util which can't depend on base/i18n and it wants Unicode case-insensitive compares. I replaced these with a call to the Win32 function CompareString Add a missing protobuf dependency in components/storage_monitor that a try run turned up. In a few cases there is some related cleanup when I touched code: SplitString calls in experiment_labels.cc (which I've been doing patches to update), for loop in gcapi_omaha_experiment.cc, In some cases, a ToLower call was pulled out of a loop as in autofill_agent.cc. From this file I also removed a redundant comparison since the code checked it if was equal or a prefix, and a prefix returns true if it's equal. BUG=506255 Review URL: https://codereview.chromium.org/1220653002 Cr-Commit-Position: refs/heads/master@{#337093}
* Fix some clang warnings with -Wmissing-braces in chrome.dcheng2015-07-013-4/+5
| | | | | | | | | | | | | | | | Clang warns if there are missing braces around a subobject initializer. The most common idiom that triggers this is: STRUCT s = {0}; if the first field of STRUCT is itself a struct. This can be more simply written as: STRUCT s = {}; which also prevents the warning from firing. BUG=505297 Review URL: https://codereview.chromium.org/1217383003 Cr-Commit-Position: refs/heads/master@{#337088}
* With this CL we store path to actual Program Files folder in an environment ↵shrikant2015-06-231-9/+23
| | | | | | | | | | variable in order to avoid repetitive use of SHGetFolderPath API. Especially on Windows 10 along with AppContainer token, SHGetFolderPath seem to take different route, which causes renderer process to crash. With this patch if environment variable is already set then we won't call SHGetFolderPath. Current assumption is that browser's environment is passed to renderer as it is, so any variables set by browser process are passed to renderer in environment. BUG=502416 Review URL: https://codereview.chromium.org/1193023002 Cr-Commit-Position: refs/heads/master@{#335735}
* Pin shortcuts via shell verbs rather than ShellExecuteEx.grt2015-06-231-5/+3
| | | | | | | | | | BUG=498383 TEST=Chrome's icon is pinned to the taskbar upon install on Win7, 8, 8.1, and 10. TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1193363003 Cr-Commit-Position: refs/heads/master@{#335630}
* Fix missing dependency on Win GN component buildsrockot2015-06-171-0/+4
| | | | | | | | | BUG=500805,501385 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1183793007 Cr-Commit-Position: refs/heads/master@{#334852}
* Move EndsWith to base namespace.brettw2015-06-121-1/+1
| | | | | | | | TBR=jschuh@chromium.org Review URL: https://codereview.chromium.org/1182183003 Cr-Commit-Position: refs/heads/master@{#334284}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-123-5/+6
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* Move StringToUpperASCII to base namespacebrettw2015-06-091-1/+1
| | | | | | | | | | Removes some unnecessary base:: qualifications in the base files I touched. clang-formatted file_util_unittest because lots of wrapping changed with this removal (seems to be a big improvement). BUG= Review URL: https://codereview.chromium.org/1171973003 Cr-Commit-Position: refs/heads/master@{#333560}
* Beacons for tracking default browser status.grt2015-06-028-6/+615
| | | | | | | | | BUG=488247 R=gab@chromium.org,wfh@chromium.org Review URL: https://codereview.chromium.org/1146843003 Cr-Commit-Position: refs/heads/master@{#332423}
* Fix uninstall survey link.dbeam2015-05-261-1/+1
| | | | | | | | | R=gab@chromium.org BUG=490852 Review URL: https://codereview.chromium.org/1150363002 Cr-Commit-Position: refs/heads/master@{#331388}
* Fix a lot of support links.dbeam2015-05-221-1/+1
| | | | | | | | | | | | | | | Things I did: 1) Changed all domains I could find to https://support.google.com 2) Changed all the bin/answer.py?answer=# to answer/# 3) Left any code-populated ?hl= for now (worried about CHECK() failures) TBR=cpu@chromium.org BUG=490858,490875,490887 Review URL: https://codereview.chromium.org/1144193005 Cr-Commit-Position: refs/heads/master@{#331064}
* Remove dependency on resources from installer_utilbrettw2015-05-215-6/+9
| | | | | | | | | | | | chrome/installer/util used to depend on chrome:resources but was apparently never used. This causes a problem because chrome_watcher.dll depends on installer_util, and chrome:resources depends on the omnibox mojo target. To get this dependency "right" we would have to link all of mojo system into chrome_watcher.dll. It is properly dead-code stripped (I checked) but this still seems undesirable. I removed the dependency and also made //chrome/installer/* "gn check" clean. There were some other unnecessary deps and header file uses. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1148173002 Cr-Commit-Position: refs/heads/master@{#330895}
* Improve the default browser settings dialog for Win10cpu2015-05-192-8/+41
| | | | | | | | | | | On Win10 the current approach of SHOpenWithDialog is suboptimal. See the bug for more details. BUG=488774,489803 Review URL: https://codereview.chromium.org/1140293002 Cr-Commit-Position: refs/heads/master@{#330596}
* Check last modification time on overinstall for all dev builds.grt2015-05-191-2/+2
| | | | | | | | | | | This makes the build/test cycle easier for Release builds. BUG=none R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1144543008 Cr-Commit-Position: refs/heads/master@{#330558}
* Delete unused code in chrome/common or mark them as platform specific.thestig2015-05-112-0/+15
| | | | | | | | Found by Scythe. Review URL: https://codereview.chromium.org/1127163004 Cr-Commit-Position: refs/heads/master@{#329230}
* GN Windows component build fixesbrettw2015-05-053-92/+0
| | | | | | | | | | | | | The main thing this fixes is the midi component. Previously midi_unittests was never compiled on any Windows component bot and the component build was all messed up. This patch makes the component build work correctly for this component. Remove installer_util_unittests.rc and its header. These seem to be autogenerated Visual Studio files. They just include the strings resource file, but GN includes the strings resource file itself by nature of the dependencies (GYP doesn't do this). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg BUG=470212 Review URL: https://codereview.chromium.org/1121363002 Cr-Commit-Position: refs/heads/master@{#328383}
* Add a GN flag for the Windows multi-dll build.brettw2015-05-011-1/+2
| | | | | | | | | | | | | The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. Originally landed as https://codereview.chromium.org/1120803003/ TBR=scottmg@chromium.org TBR=ddorwin@chromium.org (widevine) CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1123433002 Cr-Commit-Position: refs/heads/master@{#327998}
* Add installer_util_unittests to the GN windows buildbrettw2015-05-0113-33/+108
| | | | | | | | | | | | | | This fixes some C++ Warnings on Windows to avoid having to add suppressions to the GN build. Moves the generated strings header to the same place in the gen tree as it is in the source tree. Update includes. Previously landed https://codereview.chromium.org/1062743006/ TBR=scottmg@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1116293002 Cr-Commit-Position: refs/heads/master@{#327929}
generated by cgit v1.1 at 2024-10-31 04:50:19 +0000