summaryrefslogtreecommitdiffstats
path: root/chrome_elf
Commit message (Collapse)AuthorAgeFilesLines
...
* Update Chomium's build files to work w/ latest GN binaries.dpranke2015-02-201-2/+2
| | | | | | | | | | | | | | The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate. R=brettw@chromium.org TBR=ddorwin@chromium.org EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg BUG=344767 Review URL: https://codereview.chromium.org/913373002 Cr-Commit-Position: refs/heads/master@{#317223}
* sandbox: Fix some nt_internals.h function prototypes for Win64rnk2015-02-201-3/+3
| | | | | | | | | | | | | | | NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes. NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes. DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change. R=robertshield@chromium.org,rvargas@chromium.org BUG=458690 Review URL: https://codereview.chromium.org/921353002 Cr-Commit-Position: refs/heads/master@{#317177}
* Add support for correct Windows 10 version enumeration.wfh2015-02-021-0/+3
| | | | | | | | BUG=454018 Review URL: https://codereview.chromium.org/891813003 Cr-Commit-Position: refs/heads/master@{#314213}
* Use NoImportLib: true for blacklist_test_dll_3 to avoid unnecessary rebuildingscottmg2015-01-301-0/+6
| | | | | | | | | | | | | | Avoids ninja expecting an import .lib to be generated so that it doesn't continually rebuild because the import lib is "missing". To be landed after gyp roll at https://codereview.chromium.org/890043003/ lands. R=robertshield@chromium.org BUG=342974,451499 Review URL: https://codereview.chromium.org/886123002 Cr-Commit-Position: refs/heads/master@{#314008}
* Add GN files for chrome_elfvchigrin2015-01-231-0/+205
| | | | | | Review URL: https://codereview.chromium.org/832583007 Cr-Commit-Position: refs/heads/master@{#312814}
* Add crdli.dll and crdli64.dll to Chrome'e Blacklistcsharp2015-01-211-0/+2
| | | | | | | | | | These dlls have been causing stability issues. BUG= Review URL: https://codereview.chromium.org/852843002 Cr-Commit-Position: refs/heads/master@{#312392}
* Add vntsrv.dll to Chrome's Blacklistcsharp2015-01-121-0/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/837033002 Cr-Commit-Position: refs/heads/master@{#311053}
* Reblacklist virtualCamera.ax, it's causing renderer hangs.dalecurtis2015-01-081-0/+2
| | | | | | | | | | | | | | | | | This driver has persistent issues, we previously blacklisted it for http://crbug.com/378465 but came up with a workaround and thus it was allowed again. Now we're getting renderer hangs because it blocks a sync ipc from completing on the audio thread. Given the multiple issues and high install base, I think we should permanently blacklist this dll from loading. BUG=422522 TEST=none Review URL: https://codereview.chromium.org/838683002 Cr-Commit-Position: refs/heads/master@{#310556}
* Add YCWebCameraSource.ax to Chrome blacklistservolk2015-01-071-0/+1
| | | | | | | | | | | | | One of the top crashes for Chrome 38 and 39 is a crash due to some issue in YCWebCameraSource.ax, which is a component of CyberLink Youcam software. Let's blacklist it for now, to stop Chrome from crashing repeatedly. BUG=424159 Review URL: https://codereview.chromium.org/831223003 Cr-Commit-Position: refs/heads/master@{#310284}
* Add wajam_goblin.dll and wajam_goblin_64.dll to Chrome's blacklist.csharp2014-10-311-0/+2
| | | | | | | | BUG=429173 Review URL: https://codereview.chromium.org/698533002 Cr-Commit-Position: refs/heads/master@{#302274}
* Fix two minor bugs found by /analyzebrucedawson2014-10-281-2/+2
| | | | | | | | | | | | | | | | | BUG=427616 /analyze pointed out that the loop range-check used the comma operator when && was probably intended. The bug was harmless, but confusing, so I fixed it. /analyze also pointed out that the code was checking data read by a function and then checking whether the read succeeded. Reversing the order of the checks has no effect except to get rid of the undefined behavior. Review URL: https://codereview.chromium.org/678193003 Cr-Commit-Position: refs/heads/master@{#301691}
* Add safetynut.dll to the browser blacklist.csharp2014-10-231-0/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/654753008 Cr-Commit-Position: refs/heads/master@{#300823}
* Replace OVERRIDE with its C++11 counterparts in src/chrome_elfr.nagaraj2014-10-113-3/+3
| | | | | | | | | | | This step is a complete search for OVERRIDE to replace it with its lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/644783004 Cr-Commit-Position: refs/heads/master@{#299241}
* Remove ScDetours.dll from the Browser Blacklistcsharp2014-09-291-2/+0
| | | | | | | | | | | Quick Report reports they have fixed the issue and the dll now works correctly with chromium. BUG=382561 Review URL: https://codereview.chromium.org/617453002 Cr-Commit-Position: refs/heads/master@{#297178}
* Remove implicit HANDLE conversions from elf.rvargas2014-09-251-4/+5
| | | | | | | | | BUG=416722 R=gab@chromium.org, robertshield@chromium.org Review URL: https://codereview.chromium.org/603803002 Cr-Commit-Position: refs/heads/master@{#296819}
* Clean up unused param in RegistryOverrideManagergab2014-09-182-5/+3
| | | | | | | | | | This param has been unused since http://crrev.com/234367 and makes the method confusing. BUG=314800 Review URL: https://codereview.chromium.org/575253002 Cr-Commit-Position: refs/heads/master@{#295400}
* Change base/file_utils.h includes to base/files/file_utils.h in chrome_elf/ ↵thestig2014-09-102-3/+3
| | | | | | | | | | and components/ Also fix the formatting of chrome_elf/OWNERS Review URL: https://codereview.chromium.org/546733002 Cr-Commit-Position: refs/heads/master@{#294245}
* Remove cespy.dll from the browser blacklistcsharp2014-09-081-1/+0
| | | | | | | | | | | cespy.dll is a LSP and preventing it from loading in Chrome prevents users from accessing the internet. BUG=399968 Review URL: https://codereview.chromium.org/545003006 Cr-Commit-Position: refs/heads/master@{#293812}
* Reorder GenerateStateFromBeaconAndAttemptCount.csharp2014-08-251-11/+9
| | | | | | | | | | | I think the older order could result in incorrect behavior if Chrome crashed during startup. This might help with the bug as well. BUG=406475 Review URL: https://codereview.chromium.org/500563002 Cr-Commit-Position: refs/heads/master@{#291679}
* Add export to query for blacklisted-ness.robertshield@chromium.org2014-08-063-0/+14
| | | | | | | | | BUG=394532 TEST=unit_tests Review URL: https://codereview.chromium.org/444543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287899 0039d316-1c4b-4281-b951-d872f2087c98
* Add V-bates to Chrome's Browser's blacklistcsharp@chromium.org2014-08-051-0/+5
| | | | | | | | BUG=399744 Review URL: https://codereview.chromium.org/440663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287546 0039d316-1c4b-4281-b951-d872f2087c98
* Add more detail to Chrome ELF crash reportscaitkp@chromium.org2014-08-011-1/+16
| | | | | | | | BUG=370153 Review URL: https://codereview.chromium.org/434143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287116 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome_elf_unittests on 64 bit builds.robertshield@chromium.org2014-07-241-1/+11
| | | | | | | | | | BUG=397137,396244 TEST=chrome_elf_unittests NOTRY=true Review URL: https://codereview.chromium.org/418033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285377 0039d316-1c4b-4281-b951-d872f2087c98
* Adding 3 unstable Dlls to the blacklist.krstnmnlsn@chromium.org2014-06-271-0/+3
| | | | | | | | | | | | minisp.dll (seems to be malware) cespy.dll (CovenantEyes) cplushook.dll (seems to be malware) BUG= Review URL: https://codereview.chromium.org/354063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280443 0039d316-1c4b-4281-b951-d872f2087c98
* Adding blacklisted dlls to safe browsing incident reports.krstnmnlsn@chromium.org2014-06-273-14/+13
| | | | | | | | | | | | | | Also added a unit test to environment_data_collection_win_unittest.cc Edited chrome_elf_init_win.cc and blacklist.cc so that the registry is only cleared immediately before being repopulated (and safe browsing is not left with an empty registry to read from). BUG= Review URL: https://codereview.chromium.org/346763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280380 0039d316-1c4b-4281-b951-d872f2087c98
* Update DllHash to include recently blacklisted dllscsharp@chromium.org2014-06-251-0/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/353873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279814 0039d316-1c4b-4281-b951-d872f2087c98
* Add scdetour.dll to the browser blacklistcsharp@chromium.org2014-06-251-0/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/357733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279741 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist registry keys now stored under chromium name for chromium builds.krstnmnlsn@chromium.org2014-06-241-2/+11
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/349693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279267 0039d316-1c4b-4281-b951-d872f2087c98
* Report when blacklist.cc fails to setup the blacklisting thunk.csharp@chromium.org2014-06-191-3/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/343613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278393 0039d316-1c4b-4281-b951-d872f2087c98
* Adding 3 DLLs to the blacklist.krstnmnlsn@chromium.org2014-06-171-3/+7
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/332193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277791 0039d316-1c4b-4281-b951-d872f2087c98
* Can now adjust the number of retries before the blacklist is disabled.krstnmnlsn@chromium.org2014-06-175-97/+200
| | | | | | | | | | | | | | | Also added UMA recording of the blacklist disabled and retry succeeded events. Deprecating the blacklist start up events 'BLACKLIST_THUNK_SETUP_FAILED' and 'BLACKLIST_INTERCEPTION_FAILED' as we are switching over to a more coarse grained recording of the set up status (this information can be gathered from crash reporting now anyways). BUG= Review URL: https://codereview.chromium.org/311893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277614 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Blacklists virtualCamera.ax ↵henrika@chromium.org2014-06-151-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/325323003/) Reason for revert: No crashes have been found after 37.0.2046.2 and Canary on Windows is now on 37.0.2051.2, hence it looks good. Not sure if was the blacklisting or the "calling CoInitializeEx twice" patch which did the trick here. I would like to revert the blacklisting patch to see if we can cope with the CoInitializeEx patch only. It would be great if we could avoid adding another DLL to the blacklist. Original issue's description: > Blacklists virtualCamera.ax. > > Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator. > > BUG=383715, 378465 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276946 TBR=tommi@chromium.org,robertshield@chromium.org NOTREECHECKS=true NOTRY=true BUG=383715, 378465 Review URL: https://codereview.chromium.org/335073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277320 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment to the Browser Blacklist Listcsharp@chromium.org2014-06-131-0/+6
| | | | | | | | | | | | This comment roughly explains when the blacklist should be used, as well as linking to the blacklist policy. R=robertshield@chromium.org BUG= Review URL: https://codereview.chromium.org/334913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277108 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklists virtualCamera.ax.henrika@chromium.org2014-06-131-0/+2
| | | | | | | | | | Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator. BUG=383715, 378465 Review URL: https://codereview.chromium.org/325323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276946 0039d316-1c4b-4281-b951-d872f2087c98
* Add "One Key Theater" DLLs to the browser DLL blacklist.wfh@chromium.org2014-06-091-0/+5
| | | | | | | | | | | These DLLs were causing major instabilities on Stable Channel. BUG=379218 NOTRY=true Review URL: https://codereview.chromium.org/320653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275859 0039d316-1c4b-4281-b951-d872f2087c98
* Finch Blacklist is now added to the Hardcoded blacklist.krstnmnlsn@chromium.org2014-06-056-25/+117
| | | | | | | | | | | | | The finch blacklist is collected from finch in chrome_elf_init_win.cc, stored in a registry, and added to the blacklist in blacklist.cc. BUG= Review URL: https://codereview.chromium.org/300933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275086 0039d316-1c4b-4281-b951-d872f2087c98
* Increase accuracy when determining if the browser blacklist was setup.csharp@chromium.org2014-05-281-3/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/298893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273377 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS file for browser blacklist.robertshield@chromium.org2014-05-221-0/+3
| | | | | | | | | BUG=NONE TEST=NONE Review URL: https://codereview.chromium.org/292123011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272337 0039d316-1c4b-4281-b951-d872f2087c98
* For Chrome builds, only upload crashes when the build is official.thestig@chromium.org2014-05-211-9/+7
| | | | | | | | BUG=362783 Review URL: https://codereview.chromium.org/292933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271840 0039d316-1c4b-4281-b951-d872f2087c98
* Fix prefered base addresses on win64jschuh@chromium.org2014-04-121-2/+12
| | | | | | | | | | | | We need a +4GB base so the loader will randomize above 4GB. BUG=361670 R=robertshield@chromium.org,jam@chromium.org NOTRY=TRUE Review URL: https://codereview.chromium.org/233413008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263540 0039d316-1c4b-4281-b951-d872f2087c98
* Use SYZYASAN instead of ADDRESS_SANITIZER.chrisha@google.com2014-03-271-5/+6
| | | | | | | | | | | We've seen different failure related to the fact that we use the same flag without providing the same API and functionality. BUG= TBR=jamesr Review URL: https://codereview.chromium.org/212643015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259855 0039d316-1c4b-4281-b951-d872f2087c98
* Stop chrome_elf from patching already patched functionscsharp@chromium.org2014-03-251-2/+3
| | | | | | | | BUG=353978 Review URL: https://codereview.chromium.org/208273006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259157 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure chrome_elf's breakpad client is actually uploading dumps.caitkp@chromium.org2014-03-241-1/+1
| | | | | | Review URL: https://codereview.chromium.org/206223006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259014 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome_elf use thunks instead of function pointers.caitkp@chromium.org2014-03-188-139/+264
| | | | | | | | | | | | | | 1. Add functionality to ServiceResolverThunk to copy a thunk without patching. 2. Move chrome_elf thunk-handling code to a common location. 3. Use a thunk instead of a f'n ptr for redirects. BUG=334379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255151 Review URL: https://codereview.chromium.org/183833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257749 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure CreateFile call is not inlined, so EMET doesn't get upset.caitkp@chromium.org2014-03-131-8/+29
| | | | | | | | BUG=348383 Review URL: https://codereview.chromium.org/197863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256751 0039d316-1c4b-4281-b951-d872f2087c98
* Use PEImage in ntdll_cache.cccsharp@chromium.org2014-03-122-36/+24
| | | | | | | | | | | Use the exported functions iterator in PEImage instead of writing our own. BUG= Review URL: https://codereview.chromium.org/192933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256424 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255151 "Make chrome_elf use thunks instead of function po..."caitkp@chromium.org2014-03-077-229/+133
| | | | | | | | | | | | | | | | | | | (Crashy on today's canary) > Make chrome_elf use thunks instead of function pointers. > > 1. Add functionality to ServiceResolverThunk to copy a thunk without patching. > 2. Move chrome_elf thunk-handling code to a common location. > 3. Use a thunk instead of a f'n ptr for redirects. > > BUG=334379 > > Review URL: https://codereview.chromium.org/183833004 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/189803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255703 0039d316-1c4b-4281-b951-d872f2087c98
* Add version resource to chrome_elf.dllrobertshield@chromium.org2014-03-072-0/+29
| | | | | | | | | BUG=349926 TEST=NONE Review URL: https://codereview.chromium.org/183973039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255570 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome_elf use thunks instead of function pointers.caitkp@chromium.org2014-03-057-133/+229
| | | | | | | | | | | | 1. Add functionality to ServiceResolverThunk to copy a thunk without patching. 2. Move chrome_elf thunk-handling code to a common location. 3. Use a thunk instead of a f'n ptr for redirects. BUG=334379 Review URL: https://codereview.chromium.org/183833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255151 0039d316-1c4b-4281-b951-d872f2087c98
* Catch EXCEPTION_GUARD_PAGE in SafeGetImageInfocsharp@chromium.org2014-03-041-0/+1
| | | | | | | | | | SafeGetImageInfo shouldn't raise exceptions. BUG=348693 Review URL: https://codereview.chromium.org/185533008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254870 0039d316-1c4b-4281-b951-d872f2087c98