summaryrefslogtreecommitdiffstats
path: root/chromeos/network/network_state.cc
Commit message (Collapse)AuthorAgeFilesLines
* Extend vpnProvider to allow reconnectionscernekee2016-03-161-1/+13
| | | | | | | | | | | | | | | | | | Upcoming changes in the Chrome OS networking daemon (shill) will allow third party VPNs to transition "backwards" from Online->Configuring if the default physical connection changes. Add a "reconnect" flag so that VPN apps can signal their compatibility with this new scheme, and add the necessary UI changes so that Chrome can identify reconnections and present them to the user in a sensible way. Also, change the UI so that users can cancel VPN reconnections (and connections) using the "Disconnect" button. BUG=514343 Review URL: https://codereview.chromium.org/1722453002 Cr-Commit-Position: refs/heads/master@{#381566}
* Add BSSID + Frequency to NetworkState/getNetworksstevenjb2016-01-201-13/+11
| | | | | | | | BUG=575412 Review URL: https://codereview.chromium.org/1583423002 Cr-Commit-Position: refs/heads/master@{#370513}
* Switch to standard integer types in chromeos/.avi2015-12-211-0/+2
| | | | | | | | | BUG=138542 TBR=zelidrag@chromium.org Review URL: https://codereview.chromium.org/1540803002 Cr-Commit-Position: refs/heads/master@{#366324}
* Convert vector_as_array to vector::data in //chrome{,cast,os}.davidben2015-11-301-2/+1
| | | | | | | | | BUG=556678 TBR=zelidrag@chromium.org Review URL: https://codereview.chromium.org/1452853002 Cr-Commit-Position: refs/heads/master@{#362264}
* Add Dynamic WEP support to wifi config UIstevenjb2015-11-061-0/+7
| | | | | | | | BUG=551666 Review URL: https://codereview.chromium.org/1406933005 Cr-Commit-Position: refs/heads/master@{#358233}
* Provide ONC Source in MNCH::GetNetworks, Priority in GetStatestevenjb2015-08-211-2/+6
| | | | | | | | | | | | | | Ths CL: * Correctly sets the Source ONC property in GetNetworks * Provides Priorty for networkingPrivate.getState and getNetworks BUG=521037 For missing owner in wifi_config_delegate_chromeos_unittest.cc TBR=stevenjb Review URL: https://codereview.chromium.org/1304683004 Cr-Commit-Position: refs/heads/master@{#344630}
* Use networkingPrivate.startConnect (Take 2)stevenjb2015-04-161-2/+6
| | | | | | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. Original CL (reverted for unrelated failure): https://codereview.chromium.org/1043343002/ BUG=430115 TBR=michaelpg, pneubeck, mpearson@chromium.org Review URL: https://codereview.chromium.org/1091043002 Cr-Commit-Position: refs/heads/master@{#325484}
* Revert of Use networkingPrivate.startConnect (patchset #12 id:240001 of ↵mpearson2015-04-141-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1043343002/) Reason for revert: Causes browser_test failure on Win7 bot. https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1) [ RUN ] WebNavigationApiTest.Failures [4444:4508:0414/144708:WARNING:data_reduction_proxy_config.cc(319)] SPDY proxy OFF at startup [4444:2028:0414/144708:ERROR:bluetooth_adapter_win.cc(102)] NOT IMPLEMENTED [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x5) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 2147483650, remote ID 3) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x3B01) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [4444:2028:0414/144709:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframe", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframeNavigation", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[FAIL] cancel: Received unexpected event 'onCompleted':{"frameId":0,"processId":0,"tabId":0,"timeStamp":0,"url":"chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/e.html"} Error at captureEvent (chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:194:17) at chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:219:5 at EventImpl.dispatchToListener (extensions::event_bindings:395:22) at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26) at EventImpl.dispatch_ (extensions::event_bindings:379:35) at dispatchArgs (extensions::event_bindings:247:26) at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistent", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) c:\b\build\slave\win_x64_builder\build\src\chrome\browser\extensions\api\web_navigation\web_navigation_apitest.cc(468): error: Value of: RunExtensionTest("webnavigation/failures") Actual: false Expected: true Failed 1 of 4 tests [4444:2028:0414/144710:ERROR:browser_thread.h(263)] DeleteSoon failed on thread 0 [ FAILED ] WebNavigationApiTest.Failures, where TypeParam = and GetParam() = (2465 ms) Original issue's description: > Use networkingPrivate.startConnect > > This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. > It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. > > BUG=430115 > > Committed: https://crrev.com/e22e5bcbad2cea941993b32e6cc3b082822a42fc > Cr-Commit-Position: refs/heads/master@{#325108} TBR=armansito@chromium.org,michaelpg@chromium.org,pneubeck@chromium.org,stevenjb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=430115 Review URL: https://codereview.chromium.org/1085993002 Cr-Commit-Position: refs/heads/master@{#325145}
* Use networkingPrivate.startConnectstevenjb2015-04-141-2/+6
| | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. BUG=430115 Review URL: https://codereview.chromium.org/1043343002 Cr-Commit-Position: refs/heads/master@{#325108}
* Add an ONC property for the third-party VPN provider extension IDbartfab2015-03-181-11/+32
| | | | | | | | | | | | This CL maps the third-party VPN provider extension ID (which is stored in shill's |Provider.Host| field) to an ONC property. BUG=460428 TEST=Extended unit tests and API test Review URL: https://codereview.chromium.org/1019033002 Cr-Commit-Position: refs/heads/master@{#321238}
* Add ash::VPNDelegate and Chrome OS implementationbartfab2015-03-171-0/+20
| | | | | | | | | | | | | | | | | This CL is the first step toward support for third-party VPNs in ash UI. t adds a delegate interface that ash UI will use to retrieve the list of available VPN providers and request that a VPN provider show its "add network" dialog. The CL was tested together with follow-up CLs which wire up the actual UI. BUG=460428 TEST=Manual, together with follow-ups that wire up the UI Review URL: https://codereview.chromium.org/984863005 Cr-Commit-Position: refs/heads/master@{#320939}
* Move chromeos::device_event_log into components.reillyg2015-02-201-1/+1
| | | | | | | | | | | | | There is device code in Chrome on non-Chrome OS platforms that would benefit from a user-visible log dashboard like chrome://device-log. This change moves the code for managing the device log into a component and enables chrome://device-log on all versions of Chrome. BUG=452609 Review URL: https://codereview.chromium.org/919183002 Cr-Commit-Position: refs/heads/master@{#317406}
* Add Source property to networkingPrivate.getStatestevenjb2015-02-191-0/+2
| | | | | | | | BUG=454031 Review URL: https://codereview.chromium.org/917053002 Cr-Commit-Position: refs/heads/master@{#317174}
* Networking.config: UI modifications in the ashtraycschuet2015-02-161-0/+5
| | | | | | | | BUG=432280 Review URL: https://codereview.chromium.org/895733002 Cr-Commit-Position: refs/heads/master@{#316444}
* Introduce NetworkState::is_captive_portal()stevenjb2015-01-271-9/+60
| | | | | | | | | | For c/b/ui/webui/chromeos/login/network_state_informer.cc TBR=nkostylov@chromium.org BUG=450364 Review URL: https://codereview.chromium.org/873713004 Cr-Commit-Position: refs/heads/master@{#313311}
* chromeos networking: move from security to securityclass propertyquiche2015-01-091-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Adopt shill's kSecurityClassProperty, in place of shill's kSecurityProperty. This eliminates the need for Chrome to understand the equivalence of WPA and RSN networks. This CL introduces only one functional change. Namely, NetworkState::GetSpecifier will now collapse WPA and RSN networks into one class (by virtue of using kSecurityClassProperty). The previous behavior is considered a bug. After this CL, only WifiAccessPointInfoProviderChromeOs still uses kSecurityProperty. In that one case, we want to break out WPA and RSN networks, to understand what fraction of systems are connecting through older APs. While there: remove a couple of unused files in chromeos/test/data/network/policy/. BUG=chromium:440032 TEST=ManagedNetworkConfigurationHandlerTest.* TEST=ONC* Review URL: https://codereview.chromium.org/788633003 Cr-Commit-Position: refs/heads/master@{#310840}
* Remove CACert NSS nickname to PEM migration.pneubeck2015-01-091-38/+3
| | | | | | | | | | | This migration was added in Aug 2013, M30: https://chromiumcodereview.appspot.com/20087002 . According to UMA stats, it is triggered now for very few users/devices and can be removed. BUG=447211 Review URL: https://codereview.chromium.org/845533002 Cr-Commit-Position: refs/heads/master@{#310726}
* DeviceEventLog cleanupstevenjb2014-12-101-9/+11
| | | | | | | | | | | | | | | This CL does the following: * Fixes the formatting for the network log in chrome://network * Adds a LOGIN type for login events * Uses a string for 'type' in GetString to allow multiple types (or non- types) to be passed) Add login type, use type strings in GetAsType BUG=293739 Review URL: https://codereview.chromium.org/784223003 Cr-Commit-Position: refs/heads/master@{#307753}
* NetworkState: cache raw SSIDs for WiFi networksquiche2014-11-131-0/+8
| | | | | | | | | | | | | | | | | | | | | When updating a network password from sync, we need the ability to find an existing network based on its SSID. To avoid many RPCs when searching for networks, cache the SSID in NetworkState. Note that shill's kSSIDProperty doesn't cleanly pass-through non-UTF-8 strings. So we use kWifiHexSsid instead. We decode the hex, and store the decoded string as a vector<uint8_t>. The use of vector<uint8_t> is intended to express the fact that the encoding of the string is unknown. BUG=chromium:432585 TEST=NetworkStateTest.* TEST=NetworkConfigurationHandlerStubTest.StubSetAndClearProperties Review URL: https://codereview.chromium.org/721863002 Cr-Commit-Position: refs/heads/master@{#304038}
* Add Wimax to ONC.pneubeck2014-09-181-3/+4
| | | | | | | | | | | | | | This adds the object "WiMAX" to ONC, which contains the basic properties AutoConnect (read/write) EAP (write-only) SignalStrength (read-only). Also all general network properties like Name or ConnectionState are supported. BUG=414417 Review URL: https://codereview.chromium.org/578823003 Cr-Commit-Position: refs/heads/master@{#295467}
* Use ONC for Cellular APN and SimLock in Settingsstevenjb2014-08-271-0/+6
| | | | | | | | | | BUG=279351 For chrome/browser/ui/webui/chromeos/network_config_message_handler.cc: TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/492383002 Cr-Commit-Position: refs/heads/master@{#292245}
* Enable Verizon OTA activation.thieule@chromium.org2014-08-121-3/+2
| | | | | | | | | | | | Enables OTA activation using the old Wifi flow except it connects to the cellular network instead of requiring a Wifi connection. BUG=chromium:384185 TEST=Unit tests, manually activate SIM on CDMA and LTE Review URL: https://codereview.chromium.org/406473002 Cr-Commit-Position: refs/heads/master@{#288854} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288854 0039d316-1c4b-4281-b951-d872f2087c98
* Remove additional dependencies from InternetOptionsHandlerstevenjb@chromium.org2014-07-121-9/+0
| | | | | | | | | | Removes UIData from NetworkState. BUG=279351 Review URL: https://codereview.chromium.org/383013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282821 0039d316-1c4b-4281-b951-d872f2087c98
* Rely on Service.Visible instead of Manager.Servicesstevenjb@chromium.org2014-06-201-0/+2
| | | | | | | | | | | | With this change we rely on Service.Visible and only use Manager.Services to determine which services to observe. BUG=384380 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/330833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278594 0039d316-1c4b-4281-b951-d872f2087c98
* Merge FavoriteState into NetworkStatestevenjb@chromium.org2014-06-121-13/+67
| | | | | | | | | | | | BUG=375955 For trivial renaming: R=armansito@chromium.org, pneubeck@chromium.org TBR=derat@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/289383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276822 0039d316-1c4b-4281-b951-d872f2087c98
* Move NetworkTypePattern to its own filestevenjb@chromium.org2014-05-281-0/+1
| | | | | | | | | | | | BUG=none For trivial apps/shell/browser/ change: R=pneubeck@chromium.org TBR=derat@chromium.org Review URL: https://codereview.chromium.org/300623008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273352 0039d316-1c4b-4281-b951-d872f2087c98
* Implement networkingPrivate.getNetworksstevenjb@chromium.org2014-05-191-2/+12
| | | | | | | | | | | | | Design Doc and Proposal here: https://docs.google.com/a/google.com/document/d/1QWIzDvf_-iZJW8CINvhxzIERwwKeg72302hNUw0ZrSM/edit This CL depends on https://codereview.chromium.org/275543005/ BUG=371966 Review URL: https://codereview.chromium.org/280023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271490 0039d316-1c4b-4281-b951-d872f2087c98
* Use GUID instead of ServicePath in networkingPrivate APIstevenjb@chromium.org2014-05-161-0/+4
| | | | | | | | | | | | | | | | | | | | Currently we pass the service path of networks as the "GUID" in the networkingPrivate implementation on Chrome OS. We should be using the actual GUID (if one exists) or create a GUID if one does not. Note: This change should not break any existing usage since the GUID value should be transparant to the implementation. (This will have the positive side effect of making the GUID consistent across sessions). BUG=284827 For fake_wifi_service.cc: R=asargent@chromium.org, pneubeck@chromium.org TBR=mef@chromium.org Review URL: https://codereview.chromium.org/275543005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271106 0039d316-1c4b-4281-b951-d872f2087c98
* Provide IPConfigs in networkingPrivate.GetPropertiesstevenjb@chromium.org2014-05-091-38/+42
| | | | | | | | | | | | BUG=365848 For components/wifi fixes for tests: R=pneubeck@chromium.org TBR=mef@chromium.org Review URL: https://codereview.chromium.org/267433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269334 0039d316-1c4b-4281-b951-d872f2087c98
* Add ManagedState::GetStatePropertiesstevenjb@chromium.org2014-05-021-51/+36
| | | | | | | | | | | | | | | | | | | | | | | | This CL makes the following changes: * Provides a consistent GetStateProperties method across all ManagedState subclasses * Reduces the number of properties provided by NetworkState::Get[State]Properties (including the IPConfigs sub-dictionary) * Documents the properties provided by networkingPrivate.GetState This is in preparation for converting the chrome://network debug tool to use an API mirroring networkingPrivate, in preparation for switching Settings to do the same (using the same bridge). BUG=365848 For network.js/html R=pneubeck@chromium.org TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/256893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267682 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly check for unset Shill errors in error notification codestevenjb@chromium.org2014-03-251-4/+9
| | | | | | | | | | Shill uses "Unknown" for unset errors instead of empty values; we need to correctly check that in the notification UI. BUG=355811 Review URL: https://codereview.chromium.org/206873009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259352 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup network event logging, add to ManagedNetworkConfigurationHandlerstevenjb@chromium.org2014-03-251-1/+7
| | | | | | | | | | | | | | | | I noticed we were getting some ERROR spam when we request properites for networks that are no longer visible, which required some additiona logging to track down (and hopefully make it easier to track down other issues in the future). BUG=none TBR=pneubeck@chromium.org Original CL: https://codereview.chromium.org/207183003/ Review URL: https://codereview.chromium.org/210073007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259145 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258956 "Cleanup network event logging, add to ManagedNetw..."stevenjb@chromium.org2014-03-241-7/+1
| | | | | | | | | | | | | | | | | | | | > Cleanup network event logging, add to ManagedNetworkConfigurationHandler > > I noticed we were getting some ERROR spam when we request properites for > networks that are no longer visible, which required some additiona > logging to track down (and hopefully make it easier to track down other > issues in the future). > > BUG=none > R=pneubeck@chromium.org > > Review URL: https://codereview.chromium.org/207183003 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/207163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258987 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup network event logging, add to ManagedNetworkConfigurationHandlerstevenjb@chromium.org2014-03-241-1/+7
| | | | | | | | | | | | | | I noticed we were getting some ERROR spam when we request properites for networks that are no longer visible, which required some additiona logging to track down (and hopefully make it easier to track down other issues in the future). BUG=none R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/207183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258956 0039d316-1c4b-4281-b951-d872f2087c98
* Include FavoriteState in chrome://networkstevenjb@chromium.org2014-03-181-5/+3
| | | | | | | | | BUG=353376 R=pneubeck@chromium.org, tbarzic@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/202493006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257814 0039d316-1c4b-4281-b951-d872f2087c98
* Improve network error notifications and cleanup codestevenjb@chromium.org2014-03-171-0/+2
| | | | | | | | | | | | | | | | This CL does the following: * Stores last_error in NetworkState * Uses Service.PreviousError when Serice.Error is empty * Relies on Service + NetworkState properties instead of awkwardly passing shill errors around (inconsistently) Note: This CL was developed in parallel to PreviousError in Shill. Rather than revert the last_error changes, I decided to track both and LOG if we use one or the other under the assumption that more information is better. BUG=333955,344398,337608,332620 R=armansito@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/165263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257456 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup shill_stub_helper, GetSharedProfilePath -> ShillProfileClientstevenjb@chromium.org2014-03-031-1/+1
| | | | | | | | | | | Also replaces IsStubPortalledWifiEnabled() with more robust logic. BUG=345033 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/183033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254492 0039d316-1c4b-4281-b951-d872f2087c98
* Use EapMethod to provide correct network error messagestevenjb@chromium.org2013-10-011-0/+4
| | | | | | | | | BUG=297374 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/24644005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226246 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor access to the ONC policy for a network.pneubeck@chromium.org2013-10-011-29/+1
| | | | | | | | | | | | | | | | | Instead of relying on a value stored in Shill (namely, onc_source in UIData) and caching that in NetworkState, directly access the new ONC preference in Chrome to check whether a network is managed or not. Proxy settings worked already in that way. With this change internet_options_handler uses the same code path. The only functional change is that a policy indicator will also be visible in the NetworkList of chrome://settings if Ethernet is managed. BUG=126870 (for API changes; network_state_informer.cc, preferences_browsertest.cc) R=bartfab@chromium.org, stevenjb@chromium.org TBR=nkostylev@chromium.org, ygorshenin@chromium.org Review URL: https://codereview.chromium.org/23609047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226237 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate DBus service constants from flimflam namespace to shill namespace.benchan@chromium.org2013-09-241-47/+46
| | | | | | | | | | | | | | | | | | | | | | | | All shill DBus service constants have been moved from the flimflam namespace to the shill namespace. This CL makes the corresponding changes on the Chrome side. Related CLs: https://chromium-review.googlesource.com/#/c/170123/ https://chromium-review.googlesource.com/#/c/170205/ https://chromium-review.googlesource.com/#/c/170206/ https://chromium-review.googlesource.com/#/c/170207/ https://chromium-review.googlesource.com/#/c/170208/ https://chromium-review.googlesource.com/#/c/170209/ https://chromium-review.googlesource.com/#/c/170223/ https://chromium-review.googlesource.com/#/c/170230/ https://chromium-review.googlesource.com/#/c/170231/ BUG=295425 R=gspencer@chromium.org,gauravsh@chromium.org,stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/24348002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224942 0039d316-1c4b-4281-b951-d872f2087c98
* Add NetworkState::RequiresActivation.armansito@chromium.org2013-09-161-0/+6
| | | | | | | | | | | | | | Added a utility function to NetworkState to query if a network requires activation. All UI code should use this instead of comparing the Cellular.ActivationState property themselves, as this utility function handles the "unknown" case as well. BUG=289470 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/23532065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223472 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up NetworkState membersstevenjb@chromium.org2013-09-061-45/+1
| | | | | | | | | | | | This includes updating the (already asynchronous) calls in MobileActivator and MobileSetupUI to retrieve the complete set of service properties so that we do not need to cache some infrequently used properties. BUG=252553 For test files: TBR=armansito@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/23441025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221785 0039d316-1c4b-4281-b951-d872f2087c98
* Move Shill property utility functions to a separate file.pneubeck@chromium.org2013-09-041-120/+7
| | | | | | | | | | | | | | | | This CL moves some functions to handle Shill properties to shill_property_util.* This cleans up some dependencies (e.g. network_connection_handler.cc doesn't include managed_network_configuration_handler.h anymore) and allows to share some more code. GetUIData was adapted slightly to make use of GetUIDataFromValue. CopyIdentifyingProperties deviates from the original implementation in network_connection_handler (e.g. it didn't copy the SSID). This function will be used in ManagedNetConfHandler for the new "AllowAutoconnect" policy. BUG=280146 Review URL: https://chromiumcodereview.appspot.com/23551004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221260 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate c/b/chromeos/options/network_connect.ccstevenjb@chromium.org2013-08-211-7/+3
| | | | | | | | | | | | | | | | | | | | | This is just some code cleanup designed to faciliate moving the Network Notifications to the message center. It also improves the logic for showing a notification after a connect error by eliminating the NetworkState dependency (by explicitly fetching the properties before showing the notification). Having two 'network_connect.cc' files was confusing, also the functions remaining don't directly have anything to do with connect, they are support functions with Chrome dependencies and belong in AshSystemTrayDelegate. Now all of the connect flow is in one place (ash::network_connect). BUG=271546 R=gauravsh@chromium.org, jennyz@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/22796014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218752 0039d316-1c4b-4281-b951-d872f2087c98
* Implement DhcpProxyScriptFetcherChromeos using net::ProxyScriptFetcherstevenjb@chromium.org2013-08-131-1/+21
| | | | | | | | | | | | | | This caches Service.WebProxyAutoDiscoveryUrl in NetworkState and passes the value for the Default network (if set) to the ProxyScriptFetcherImpl instance created in ProxyServiceFactory. BUG=253915 For proxy_service_factory.cc owner: TBR=joi@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/22589004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217294 0039d316-1c4b-4281-b951-d872f2087c98
* Improve debug logging for GetNameFromPropertiesstevenjb@chromium.org2013-08-131-6/+11
| | | | | | | | | | | Better logging to help debug a problem with non-asci ssids. BUG=chrome-os-partner:18659 R=gauravsh@chromium.org Review URL: https://codereview.chromium.org/22908005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217132 0039d316-1c4b-4281-b951-d872f2087c98
* Show notifications for Network Config errorsstevenjb@chromium.org2013-08-101-1/+8
| | | | | | | | | | | | | Follow up to https://codereview.chromium.org/21046008/ to: * Treat invalid 'share' parameter as a configuration failure * Show error notifications for configuration failures * Eliminate NetworkStateNotifier::NetworkConnectionStateChanged which watched for connect failures triggered by NetworkLibrary connection attempts. This is now redundant and could result in duplicate notifications (one would replace the other). BUG=270936 Review URL: https://chromiumcodereview.appspot.com/22340006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216824 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all connect code to use NetworkHandler instead of NetworkLibrarystevenjb@chromium.org2013-08-091-27/+16
| | | | | | | | | | | | | | * Eliminates kUseNewNetworkConnectionHandler * Converts *_config_view to NetworkStateHandler + network_connect * Migrates non Chrome/Browser dependent network_connect code to ash::network_connect. BUG=263978 R=gauravsh@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/21046008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216568 0039d316-1c4b-4281-b951-d872f2087c98
* Add migration from CaCert NSS nicknames to PEM.pneubeck@chromium.org2013-08-061-1/+32
| | | | | | | | BUG=263044 Review URL: https://chromiumcodereview.appspot.com/20087002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215914 0039d316-1c4b-4281-b951-d872f2087c98
* Call NetworkState::GetNameFromProperties from ↵stevenjb@chromium.org2013-08-021-32/+38
| | | | | | | | | | | | | NetworkConfigurationHandler::GetProperties This addresses a bug where NetworkingPrivateAPI would receive the incorrect name when using getProperties (vs. getState) and ensures that the Name property is valid regardless of how it is retrieved from Shill. See issue for details. BUG=264077 R=gauravsh@chromium.org, tbarzic@chromium.org Review URL: https://codereview.chromium.org/20922003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215153 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-06-11 08:23:55 +0000