| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This metrics provider is used on iOS, so to enable clean integration on iOS
this CL componentizes it and injects its //chrome-level dependencies from the
embedder.
BUG=512426
Review URL: https://codereview.chromium.org/1254983003
Cr-Commit-Position: refs/heads/master@{#341183}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to send "perf stat" data over UMA.
BUG=chromium:478289
TEST=build chrome successfully
Signed-off-by: Simon Que <sque@chromium.org>
Review URL: https://codereview.chromium.org/1134013005
Cr-Commit-Position: refs/heads/master@{#334920}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProvideStabilityMetrics has been separated in
ProvideInitialStabilityMetrics and ProvideStabilityMetrics.
The first one is only called for an initial stability logs.
The second one is called for all ongoing logs.
BUG=482716
R=asvitkine
Review URL: https://codereview.chromium.org/1117933002
Cr-Commit-Position: refs/heads/master@{#327742}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
concludes the client-side “phased profiling” work.
I’m removing TODO items, and the DIFFS introduced by this should remind the reviewers that there are open questions that they wanted to re-raise, assuming the the CL doesn’t make it clear that the way it’s implemented is OK.
If there are still concerns, we should agree on one important thing before we resume the discussions: phase change delivery chain doesn’t go through metrics provider. It starts at the event source (FirstWebContentsProfiler), then goes to TrackingSynchronizer, then goes to base/. Once we agree on the design of this chain, it will make sense to go to more detailed discussions and open questions.
BUG=456354
Review URL: https://codereview.chromium.org/1021053003
Cr-Commit-Position: refs/heads/master@{#327143}
|
|
|
|
|
|
|
|
|
| |
BUG=441441
TEST=build/android/test_runner.py gtest -s components_unittests --gtest_filter=HistogramManager*
Review URL: https://codereview.chromium.org/1075503002
Cr-Commit-Position: refs/heads/master@{#324352}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provides a metrics provider that uploads statistical stack profiling
state via UMA.
This CL builds on top of the statistical profiler implementation in
https://crrev.com/1016563004, which is under review.
BUG=464929
Review URL: https://codereview.chromium.org/981143006
Cr-Commit-Position: refs/heads/master@{#321928}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed in https://codereview.chromium.org/866163002/, this change will
allow consumer of the metrics component to configure the metrics uploader endpoint
without modifying the component.
BUG=453987
Review URL: https://codereview.chromium.org/886173002
Cr-Commit-Position: refs/heads/master@{#316915}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/929883002
Cr-Commit-Position: refs/heads/master@{#316519}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part of change to collect, upload and expose histogram data
for Cronet.
BUG=441466
Committed: https://crrev.com/4eb0fd47de0736f3f4c970e8d7f8813ef2177886
Cr-Commit-Position: refs/heads/master@{#308239}
Review URL: https://codereview.chromium.org/794493002
Cr-Commit-Position: refs/heads/master@{#308427}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4eb0fd47de0736f3f4c970e8d7f8813ef2177886.
HistogramManagerBucketFields times out on Win7 Tests.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/33548
TBR=rtenneti@chromium.org,asvitkine@chromium.org,mef@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=441466
Review URL: https://codereview.chromium.org/800363002
Cr-Commit-Position: refs/heads/master@{#308315}
|
|
|
|
|
|
|
|
|
|
|
| |
Part of change to collect, upload and expose histogram data
for Cronet.
BUG=441466
Review URL: https://codereview.chromium.org/794493002
Cr-Commit-Position: refs/heads/master@{#308239}
|
|
|
|
|
|
|
|
|
|
| |
specific log data.
BUG=440626
Review URL: https://codereview.chromium.org/791563002
Cr-Commit-Position: refs/heads/master@{#307751}
|
|
|
|
|
|
|
|
| |
Add lots of missing dependencies identified by "gn check" in both the GN and GYP builds.
Review URL: https://codereview.chromium.org/756233002
Cr-Commit-Position: refs/heads/master@{#305841}
|
|
|
|
|
|
|
|
| |
BUG=374199
Review URL: https://codereview.chromium.org/728963002
Cr-Commit-Position: refs/heads/master@{#304282}
|
|
|
|
|
|
|
|
|
|
| |
Add export_dependent_settings to GYP of component_metrics_proto users.
BUG=None
Review URL: https://codereview.chromium.org/684703005
Cr-Commit-Position: refs/heads/master@{#301620}
|
|
|
|
|
|
|
|
| |
BUG=400927
Review URL: https://codereview.chromium.org/511623002
Cr-Commit-Position: refs/heads/master@{#296025}
|
|
|
|
|
|
|
|
|
| |
R=asvitkine@chromium.org,isherman@chromium.org,
BUG=404791
Review URL: https://codereview.chromium.org/577823002
Cr-Commit-Position: refs/heads/master@{#295527}
|
|
|
|
|
|
|
|
|
| |
R=asvitkine@chromium.org,isherman@chromium.org
BUG=404791
Review URL: https://codereview.chromium.org/523273003
Cr-Commit-Position: refs/heads/master@{#294935}
|
|
|
|
|
|
|
|
|
|
| |
extracted implementation supports the use of a backup storage location and reports consistency between the two locations.
BUG=412398
Review URL: https://codereview.chromium.org/558683002
Cr-Commit-Position: refs/heads/master@{#294498}
|
|
|
|
|
|
|
|
|
| |
R=stevenjb@chromium.org,asvitkine@chromium.org,benchan@chromium.org
BUG=404791
Review URL: https://codereview.chromium.org/558873002
Cr-Commit-Position: refs/heads/master@{#294466}
|
|
|
|
|
|
|
|
| |
BUG=412384
Review URL: https://codereview.chromium.org/558653002
Cr-Commit-Position: refs/heads/master@{#294182}
|
|
|
|
|
|
|
|
|
|
|
| |
The only user of this interface has been folded into
NetworkMetricsProvider.
BUG=409872
Review URL: https://codereview.chromium.org/532623003
Cr-Commit-Position: refs/heads/master@{#293149}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Precursor refactoring CL @ https://codereview.chromium.org/365133005/
Precursor kInstallDate move to metrics_pref_names @ https://codereview.chromium.org/370813003/
This is the Windows implementation, POSIX implementation to follow in https://codereview.chromium.org/377713002/ (easier to develop and test on Linux in a follow-up CL)
BUG=391338
Review URL: https://codereview.chromium.org/372473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows other clients to use the external serialization utils.
R=bsimonnet@chromium.org,isherman@chromium.org,asvitkine@chromium.org
BUG=343624
Review URL: https://codereview.chromium.org/394093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/autofill
components/metrics
components/policy
components/variations
third_party/libphonenumber
third_party/mt19937ar
ui/gfx/ipc
These are all requried to compile chrome/browser in some form or another.
Fills out all grit_defines (also required for chrome/browser) and adds associated flags for them.
Add the ability for generated_extensions_api to not generate a bundle.
Remove mt19937ar from .gitignore (it's just checked into the tree)
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/365793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds extensions common API target and extensions templates.
Adds a number of new targets: widevine, flash, sync proto, metrics proto, device serial.
Minor enhancements to protobuf and mojo templates.
TBR=jamesr
Review URL: https://codereview.chromium.org/343233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, it would persist logs in uncompressed form.
This CL changes the code to compress logs before they're
saved. A new pair of prefs is introduced for storing
these logs, while reading from the old pref is still
maintained to not lose old logs.
Additionally, this makes the metrics log discard limit
(currently 50k) be checked against the compressed size
rather than the uncompressed size.
Simplifies the format used to store logs, now simply
storing the compressed log bytes and corresponding hash
for each log. The size and checksum fields are removed.
(Size was redundant while the checksum is not no longer
necessary now that we store the log hash.)
Deletes some tests that inspected the actual pref
values are removed, in favor of tests that check that
serializing and de-serializing works as expected.
Finally, also introduces GzipUncompress() that is
needed for tests that inspect log manager logs.
BUG=382076
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/318203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MetricsService, along with prefs that it uses, is moved into the Metrics
component.
A later CL will move MetricsService (and all other code in the metrics
component) into the metrics namespace.
BUG=374198
TBR=jochen
Review URL: https://codereview.chromium.org/320553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two input type enums:
* one in the autocomplete code
* one in the metrics code that's used for UMA logging;
this one is meant to remain stable
As part of fixing the linked bug, I created
https://codereview.chromium.org/314773002/
whch needed an input type enum, one which would remain stable.
It didn't necessarily have to be the metrics enum.
After discussion with the UMA folks (who deal with how to handle
stable enum problems all the time), we reached the conclusion
that we should have one stable enum and use it everywhere. That's
the cleanest answer.
This single enum has to live in the metrics directory because metrics
is a component.
This change combines the two existing enums into one, putting the
new enum in a new file in the metrics directory. The reason for
a new file is so we can include it without include the whole
OmniboxEventProto or any other metrics code.
The main files to review are autocomplete_input.h and *.proto.
All other changes are a mechanical result of the changes in
those three files.
The internal proto change has been submitted.
TBR=stevenjb
for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
that removes an unnecessary include
BUG=284781
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696
Review URL: https://codereview.chromium.org/319523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/319523005/)
Reason for revert:
Broke the build on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac
Original issue's description:
> Omnibox: Combine Two Input Type Enums into One
>
> There are two input type enums:
> * one in the autocomplete code
> * one in the metrics code that's used for UMA logging;
> this one is meant to remain stable
>
> As part of fixing the linked bug, I created
> https://codereview.chromium.org/314773002/
> whch needed an input type enum, one which would remain stable.
> It didn't necessarily have to be the metrics enum.
>
> After discussion with the UMA folks (who deal with how to handle
> stable enum problems all the time), we reached the conclusion
> that we should have one stable enum and use it everywhere. That's
> the cleanest answer.
>
> This single enum has to live in the metrics directory because metrics
> is a component.
>
> This change combines the two existing enums into one, putting the
> new enum in a new file in the metrics directory. The reason for
> a new file is so we can include it without include the whole
> OmniboxEventProto or any other metrics code.
>
> The main files to review are autocomplete_input.h and *.proto.
> All other changes are a mechanical result of the changes in
> those three files.
>
> The internal proto change has been submitted.
>
> TBR=stevenjb
> for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
> that removes an unnecessary include
>
> BUG=284781
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696
TBR=pkasting@chromium.org,isherman@chromium.org,mpearson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=284781
Review URL: https://codereview.chromium.org/320713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two input type enums:
* one in the autocomplete code
* one in the metrics code that's used for UMA logging;
this one is meant to remain stable
As part of fixing the linked bug, I created
https://codereview.chromium.org/314773002/
whch needed an input type enum, one which would remain stable.
It didn't necessarily have to be the metrics enum.
After discussion with the UMA folks (who deal with how to handle
stable enum problems all the time), we reached the conclusion
that we should have one stable enum and use it everywhere. That's
the cleanest answer.
This single enum has to live in the metrics directory because metrics
is a component.
This change combines the two existing enums into one, putting the
new enum in a new file in the metrics directory. The reason for
a new file is so we can include it without include the whole
OmniboxEventProto or any other metrics code.
The main files to review are autocomplete_input.h and *.proto.
All other changes are a mechanical result of the changes in
those three files.
The internal proto change has been submitted.
TBR=stevenjb
for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
that removes an unnecessary include
BUG=284781
Review URL: https://codereview.chromium.org/319523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=374209
Review URL: https://codereview.chromium.org/318993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the prefs that MetricsLog uses. Leaves the unittest in //chrome for
the time being as it has //chrome dependencies that will need to be worked
through.
BUG=374208
Review URL: https://codereview.chromium.org/310513008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Moves the Metrics-related prefs and switches that MetricsStateManager uses into
the Metrics component as well.
BUG=374210
Review URL: https://codereview.chromium.org/312583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows targets that do not wish to depend on net
to use the MetricsService code.
Also, moves compression code to be in the net/ directory
of the metrics component.
BUG=375771,374295
R=isherman@chromium.org,blundell@chromium.org,davidben@chromium.org
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/291153013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cloned_install_detector_unittest is left in //chrome at the current time as it
still has //chrome-level dependencies.
BUG=374212
R=isherman@chromium.org
TBR=thakis
Review URL: https://codereview.chromium.org/290033003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestMetricsServiceClient class.
BUG=374237,374235
TEST=compiles
R=asvitkine@chromium.org, blundell@chromium.org
Review URL: https://codereview.chromium.org/290343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Automove with some manual fixes.
BUG=374214
Review URL: https://codereview.chromium.org/294693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, introduces a way to register MetricsProviders
on MetricsService.
BUG=374229
R=isherman@chromium.org
Review URL: https://codereview.chromium.org/296483004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=374204
TEST=compiles
R=asvitkine@chromium.org, blundell@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/293663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In a later CL, MetricsService ctor will take an instance of
MetricsServiceClient.
BUG=374238
Review URL: https://codereview.chromium.org/292693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are removing the dependency of ChromeOS on Chrome to send metrics.
If Chrome is not install on a system, we will provide a simple service that will
upload the metrics. This module will need to read the same logs and use the same
parsing mechanism as Chrome does now. The common serialization code will be kept
in base to make it accessible to both Chrome and ChromeOS.
The code in chrome/browser/chromeos/ will be migrated to use this in an other
CL.
BUG=chromium:358371
TEST=unittest included
Review URL: https://codereview.chromium.org/227873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will replace the repeated PerfDataProto field in the UMA protobuf. It
provides for more metadata surrounding the collection of each profile. It
also allows for more types of profiles to be collected, other than perf.
BUG=chromium:358778
TEST=build successfully
Signed-off-by: Simon Que <sque@chromium.org>
Review URL: https://codereview.chromium.org/226273004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This extracts the code for storing persisting a list of unsent logs in
preference, and refactors the code that depends on it.
The SerializedLog class is changed to a private type LogHashPair in PersistedLogs.
The PersistedLogs class replaces the MetricsLogSerializer class, and additionally
takes ownership of the list of logs being managed.
With the current implementation, when a log is staged, it is not removed from
the PersistedLogs object, and is instead removed when the staged log is
discarded. This removes the need for provisionally storing the staged log if
it is currently being uploaded when shutting down.
BUG=372911
Review URL: https://codereview.chromium.org/178833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome OS needs to have access to the metrics aggretion and serialization logic
to build a metric sender service replacing chrome. Protobuf definitions are
moved to components too.
The code remaining will be extrated in components/metrics and
components/variation during a refactoring later this year.
BUG=chromium:360183
TEST=run unittests
TBR=sky@chromium.org, benwells@chromium.org
Review URL: https://codereview.chromium.org/239093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Responses (RAPPORs).
See the design doc at http://www.chromium.org/developers/design-documents/rappor
BUG=328168
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/49753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252492 0039d316-1c4b-4281-b951-d872f2087c98
|