| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
it will always notify worker service observers even if there is no corresponding WorkerInstance in WorkerProcessHost::instances_ list(the instance can be removed when WorkerMessageFilter is closed).
WorkerDevToolsManager::InspectedWorkersList has been merged into WorkerDevToolsManager.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8364008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeRenderViewHostObserver needs the value of render_view_host when cleaning
up, but the user-after-free fix made render_view_host() always NULL in the dtor.
The previous fix was http://codereview.chromium.org/8354034/
TBR=jam@chromium.org
TEST=asan bots are happy
Review URL: http://codereview.chromium.org/8352049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser.
BUG=98716
Review URL: http://codereview.chromium.org/8342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window_container_type.h as well since it is included by
content_browser_client.h
BUG=98716
TEST=it builds + existing tests
Review URL: http://codereview.chromium.org/8346017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
TEST=it builds
Review URL: http://codereview.chromium.org/8336007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes.
BUG=98716
Review URL: http://codereview.chromium.org/8331001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8256006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To be able to debug shared workers initialization, devtools front-end needs to attach very early, before first statement of the worker script is executed. To achieve this on the IO thread we keep a list of shared workers for which devtools front-end was opened and not closed yet. If such worker is destroyed we store its URL and name in the pending workers list and once a new worker is created again we tell it to pause its worker context on start and wait for explicit notification from the devtools client or resume message(in case we learn that the client has already closed on the UI thread). After pause message was sent to the worker being created we put corresponding data to the paused_workers_ list and post reattach task to the UI thread which should result in reattach message to the new worker if the front-end still exists, otherwise when the worker data is removed from the paused_workers_ list we will send resume message and worker will continue to operate as usual.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8216008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now DevToolsManager only allows attaching/detaching RenderViewHosts. This
API should be extended to allow same functionality for arbitrary DevToolsAgentHost.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8222003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8199005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8199001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/8135002/ which was reverted due to compilation errors.
We want agent to save its state into a string instead of using a map of
runtime properties. Also the serialized state should be taken into account
only when existing client is reattached from one agent to another, this
is why we introduce Reattach message.
Also see https://bugs.webkit.org/show_bug.cgi?id=69335
BUG=None
TEST=None
TBR=pfeldman,jam
Review URL: http://codereview.chromium.org/8136029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DevToolsRuntimeProperties map"
This reverts commit 103920. WebKit dependency is not updated yet.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8137004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want agent to save its state into a string instead of using a map of
runtime properties. Also the serialized state should be taken into account
only when existing client is reattached from one agent to another, this
is why we introduce Reattach message.
Also see https://bugs.webkit.org/show_bug.cgi?id=69335
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8135002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In case of worker devtools agent host we will need to know
whether a client is attached to it to update corresponding map on the IO thread.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8117004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DevTools need to attach very early on navigation before the loading actually started to listen for resource loading and script execution.Page prerendering breaks this.
BUG=98541
TEST=PrerenderBrowserTest.NavigateToPrerenderedPageWhenDevToolsAttached
Review URL: http://codereview.chromium.org/8083029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build.
R=jam@chromium.org, darin@chromium.org
BUG=90442
TEST=
Review URL: http://codereview.chromium.org/8054037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
inspected RVH doesn't change
BUG=98210
TEST=DevToolsSanityTest.TestConsoleOnNavigateBack
Review URL: http://codereview.chromium.org/8050011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
BUG=90442
TEST=
Review URL: http://codereview.chromium.org/7885041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for creating a content shared library.
R=darin@chromium.org, jam@chromium.org, willchan@chromium.org
BUG=90442
TEST=everything still compiles
Review URL: http://codereview.chromium.org/7800015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already have RenderViewDevToolsAgent host for inspected pages. This
patch introduces WorkderDevToolsAgentHost which implements DevToolsAgentHost
interface for inspected shared workers. Also this patch moves part
of devtools message routing for workers to DevToolsManager.
BUG=None
TEST=Existing DevTools tests
Review URL: http://codereview.chromium.org/7737026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
created for all new render_view_hosts. This patch moves handling of IPC messages from agent to RenderViewDevToolsAgentHost and handling of client IPC messages to DevToolsWindow.
BUG=None
TEST=Existing DevTools tests
Review URL: http://codereview.chromium.org/7778010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Reduce dependencies on chrome/
BUG=90443
Review URL: http://codereview.chromium.org/7800004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need an abstract interface that would encapsulate communication
with inspected instance's DevTools agent. It is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.
BUG=None
TEST=DevTools tests
TBR=pfeldman
Review URL: http://codereview.chromium.org/7778001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
several bots, like the trybots hinted it will)
- DevTools: introduce DevToolsAgentHost
We need an abstract interface that would encapsulate communication
with inspected instance's DevTools agent. It is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.
BUG=None
TEST=DevTools tests
Review URL: http://codereview.chromium.org/7719026
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/7774004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need an abstract interface that would encapsulate communication
with inspected instance's DevTools agent. It is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.
BUG=None
TEST=DevTools tests
Review URL: http://codereview.chromium.org/7719026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the test suite implicitly provides global resources for each test,
but they're re-initialized between each test.
The performance overhead is negligible.
We need that to continue moving tests from unit_tests
to content_unittests. Because of shared test fixtures
the test suites need to be compatible.
BUG=90443
Review URL: http://codereview.chromium.org/7744039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7670016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r96927 due to sporadic RenderProcessHostTest.DevToolsOnSelfInOwnProcess*
tests failures on win and mac.
TBR=pfeldman
BUG=
TEST=
Review URL: http://codereview.chromium.org/7658013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need an abstract interface that would encapsulate communication
with inspected instance DeviTools agent. It'is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.
BUG=None
TEST=DevTools tests
Review URL: http://codereview.chromium.org/7660010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 96906 due to RenderProcessHostTest.DevToolsOnSelfInOwnProcess*
test failures.
TBR=pfeldman
BUG=
TEST=
Review URL: http://codereview.chromium.org/7657007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need an abstract interface that would encapsulate communication
with inspected instance DeviTools agent. It'is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.
BUG=None
TEST=DevTools tests
Review URL: http://codereview.chromium.org/7648032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
them.
R=jam@chromium.org
Review URL: http://codereview.chromium.org/7635006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66458
TEST=DevToolsManagerTest.NoUnresponsiveDialogInInspectedTab
Review URL: http://codereview.chromium.org/7565008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90839
TEST=None
Review URL: http://codereview.chromium.org/7576002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Now that ForceReopenWindow method is gone(in r91695), the browser process should own the DevToolsManager.
BUG=None
TEST=existing DevTools tests
Review URL: http://codereview.chromium.org/7461125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/browser/debugger
BUG=84078
TEST=None
Review URL: http://codereview.chromium.org/7544015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
server.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7492065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=76788
TEST=no change visible
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94332
Review URL: http://codereview.chromium.org/7480028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=76788
TEST=no change visible
Review URL: http://codereview.chromium.org/7480028
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/7492051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76788
TEST=no change visible
Review URL: http://codereview.chromium.org/7480028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
devtools files.
BUG=84078
TEST=
Review URL: http://codereview.chromium.org/7453021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r94208 (re-land r94196), add missing NET_API decl.
TBR=willchan@chromium.org
BUG=84078
TEST=everything compiles
Review URL: http://codereview.chromium.org/7477035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/browser/debugger.
Add Observer concept to net::NetLog.
Use net::NetLog::Observer in ChromeNetLog.
Remove ChromeNetLog dependency in content/browser/debugger.
Forked from http://codereview.chromium.org/7310029/ to finish Jói's
patch.
BUG=84078
TEST=existing
Review URL: http://codereview.chromium.org/7468019
TBR=dpranke@chromium.org
Review URL: http://codereview.chromium.org/7517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add Observer concept to net::NetLog.
Use net::NetLog::Observer in ChromeNetLog.
Remove ChromeNetLog dependency in content/browser/debugger.
Forked from http://codereview.chromium.org/7310029/ to finish Jói's
patch.
BUG=84078
TEST=existing
Review URL: http://codereview.chromium.org/7468019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it private and establish a friend whitelist for existing users.
BUG=64339
TEST=none
Review URL: http://codereview.chromium.org/7438002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7458016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7458015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7453019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93176 0039d316-1c4b-4281-b951-d872f2087c98
|