summaryrefslogtreecommitdiffstats
path: root/content/browser/debugger
Commit message (Collapse)AuthorAgeFilesLines
* DevTools: rename debugger/ to devtools/, move DevTools files into ↵pfeldman@chromium.org2012-12-1956-4717/+0
| | | | | | | | | content/renderer/devtools. Review URL: https://codereview.chromium.org/11630004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173903 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r173891 - "DevTools: rename debugger/ to devtools/, move DevTools ↵mnissler@chromium.org2012-12-1956-0/+4717
| | | | | | | | | | | | | | | | | | | | files into content/renderer/devtools." DevToolsManagerTest.ForwardMessageToClient: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20x64&number=29428 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Aura&number=304 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Clang%20%28dbg%29&number=37637 http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%281%29&number=17804 http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29&number=1107 BUG=None TEST=Tree becomes greener. TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/11645015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173893 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: rename debugger/ to devtools/, move DevTools files into ↵pfeldman@chromium.org2012-12-1956-4717/+0
| | | | | | | | content/renderer/devtools. Review URL: https://codereview.chromium.org/11630004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173891 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly set actions in devtools_resources as requiring cygwin (gyp only)iannucci@google.com2012-12-181-0/+1
| | | | | | | | TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/11573025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173632 0039d316-1c4b-4281-b951-d872f2087c98
* Telemetry / Devtools TraceHandler: exposes tracing via dev tools.bulach@chromium.org2012-12-186-4/+375
| | | | | | | | | | | | | | - exposes start / stop / get request methods via devtools. This allows Telemetry to integrate trace collection across all platforms in a consistent way. BUG= TEST=./tools/telemetry/run_tests --browser=android-content-shell testGotTrace Review URL: https://chromiumcodereview.appspot.com/11548032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173595 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: allow query parameters and fragments in remote debugging command urls.pfeldman@chromium.org2012-12-171-0/+9
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11591016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173503 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add /json/activate/ command to the discovery protocol.pfeldman@chromium.org2012-12-112-107/+159
| | | | | | | | | | | | | This change adds suppot for /activate command and refactors the json commands handling so that all commands supported jsonp properly. For the jsonp support, we always respond with 200 OK and specify the actual code in the jsonp call parameter. For the above purposes, migrates net/server/http_server from Send404() scheme to Send(net::HTTP_NOT_FOUND). BUG=157495 Review URL: https://chromiumcodereview.appspot.com/11499004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172285 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that DevToolsHttpHandlerImpl is always destroyed on the UI thread.bauerb@chromium.org2012-11-293-17/+13
| | | | | | | | | | | | | If we post back to the UI thread from StopHandlerThread, it can happen that the task is executed before we're finished on the FILE thread, which means we drop the last reference on the FILE thread. Using PostTaskAndReply avoids that, because it makes sure that the task is always destroyed on the originating thread. BUG=161027 Review URL: https://chromiumcodereview.appspot.com/11434003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170291 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DevToolsHttpHandlerTest.TestStartStop on Windowstbreisacher@chromium.org2012-11-281-1/+1
| | | | | | | | | BUG=161027 TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/11299232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169999 0039d316-1c4b-4281-b951-d872f2087c98
* Add Linux to list of platforms DevToolsHttpHandlerTest.TestStartStopjoi@chromium.org2012-11-261-2/+3
| | | | | | | | | | | is flaky on. TBR=mnaganov@chromium.org BUG=161027 Review URL: https://chromiumcodereview.appspot.com/11348223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169430 0039d316-1c4b-4281-b951-d872f2087c98
* Serialize DevToolsHttpHandler's start / stop sequence.mnaganov@chromium.org2012-11-262-13/+19
| | | | | | | | | | | | | | | | | | Our mistake was to allow too much asynchronousity that allowed attempting to stop the handler thread while it wasn't yet started. Also, I removed "hiding" thread pointer from ::Stop to avoid races with actions happening on the FILE thread. Instead, to protect against accidental double ::Stop calls, we check handler thread's message loop existence. R=pfeldman@chromium.org BUG=162210 Review URL: https://chromiumcodereview.appspot.com/11415123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169415 0039d316-1c4b-4281-b951-d872f2087c98
* Triggering InspectElement from context menu over a guest will open guest's ↵lazyboy@chromium.org2012-11-141-1/+1
| | | | | | | | | | | | | | devtools with correct element highlighted. BUG=140329 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167486 Relanding after linux_clang dbg bot fix. Review URL: https://chromiumcodereview.appspot.com/11362016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167744 0039d316-1c4b-4281-b951-d872f2087c98
* Mark DevToolsHttpHandlerTest.TestStartStop as flaky on Androidmnaganov@chromium.org2012-11-141-1/+8
| | | | | | | | | TBR=pfeldman@chromium.org BUG=161027 Review URL: https://codereview.chromium.org/11293281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167712 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land "Move DevTools server thread starting / stopping to FILE thread"mnaganov@chromium.org2012-11-143-8/+146
| | | | | | | | | | | | | | Fixed the test to pass on Android. Fixed memory leak in the test. R=pfeldman@chromium.org TBR=jam@chromium.org BUG=159646,160877 Original CL: https://chromiumcodereview.appspot.com/11410035 Review URL: https://codereview.chromium.org/11377152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167685 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 167498 - Move DevTools server thread starting / stopping to FILE threadilevy@chromium.org2012-11-143-145/+8
| | | | | | | | | | | | | | | | | | | | | | | | This CL made DevToolsHttpHandlerTest flaky. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/3904/steps/content_unittests/logs/stdio CRITICAL:root:Crashed: CRITICAL:root:DevToolsHttpHandlerTest.TestStartStop CRITICAL:root:[FATAL:notification_registrar.cc(79)] Check failed: CalledOnValidThread(). [FATAL:notification_registrar.cc(79)] Check failed: CalledOnValidThread(). CRITICAL:root:DevToolsHttpHandlerTest.TestStartStop CRITICAL:root:[FATAL:notification_registrar.cc(79)] Check failed: CalledOnValidThread(). [FATAL:notification_registrar.cc(79)] Check failed: CalledOnValidThread(). R=pfeldman@chromium.org BUG=159646 Review URL: https://chromiumcodereview.appspot.com/11410035 TBR=mnaganov@chromium.org Review URL: https://codereview.chromium.org/11360244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167568 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this to fix the compile failures on linux clang. please reland ↵ananta@chromium.org2012-11-131-1/+1
| | | | | | | | | | | | | | | after fixing. Revert 167486 - Triggering InspectElement from context menu over a guest will open guest's devtools with correct element highlighted. BUG=140329 Review URL: https://chromiumcodereview.appspot.com/11362016 TBR=lazyboy@chromium.org Review URL: https://chromiumcodereview.appspot.com/11275300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167506 0039d316-1c4b-4281-b951-d872f2087c98
* Move DevTools server thread starting / stopping to FILE threadmnaganov@chromium.org2012-11-133-8/+145
| | | | | | | | | | R=pfeldman@chromium.org BUG=159646 Review URL: https://chromiumcodereview.appspot.com/11410035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167498 0039d316-1c4b-4281-b951-d872f2087c98
* Triggering InspectElement from context menu over a guest will open guest's ↵lazyboy@chromium.org2012-11-131-1/+1
| | | | | | | | | | devtools with correct element highlighted. BUG=140329 Review URL: https://chromiumcodereview.appspot.com/11362016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167486 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: [remote debugging] emit Inspector.detached protocol message upon ↵pfeldman@chromium.org2012-11-025-2/+27
| | | | | | | | | connectin termination. BUG=129539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165656 0039d316-1c4b-4281-b951-d872f2087c98
* Move debugger and appcache to the content namespace.jam@chromium.org2012-10-2410-56/+48
| | | | | | Review URL: https://codereview.chromium.org/11267015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163896 0039d316-1c4b-4281-b951-d872f2087c98
* Moved GetDiscoveryPageHTML call on UI thread.vsevik@chromium.org2012-10-242-2/+14
| | | | | | | | | BUG=157323 Review URL: https://chromiumcodereview.appspot.com/11276002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163881 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch more code into the content namespace.jam@chromium.org2012-10-231-2/+1
| | | | | | Review URL: https://codereview.chromium.org/11231077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163632 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: merge is_docked and dock_side into single dock_side state.pfeldman@chromium.org2012-10-192-13/+0
| | | | | | | | | As of today, we manage devtools window state in a weird way: it can be either docked or undocked, and while docked it can attach to bottom or to the right. These two levels of setting makes it hard to manage code, we'd like devtools window to have enum of equal states: bottom, right, undocked (so far). This change makes it happen. Review URL: https://chromiumcodereview.appspot.com/11189060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162982 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: [remote debugging] terminate web socket connection upon renderer ↵pfeldman@chromium.org2012-10-172-1/+39
| | | | | | | | | | | | | disconnect. BUG=154253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162123 Review URL: https://chromiumcodereview.appspot.com/11141024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162355 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "DevTools: [remote debugging] terminate web socket connection upon ↵loislo@chromium.org2012-10-171-26/+4
| | | | | | | | | | | | | | | renderer disconnect." It broke python automation on DevTools perf bot. This reverts commit 8a429d0f0a8300776fc65eeec0831c3b3840a5a3. BUG=none TBR=yurys@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/11190017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162322 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: provide a way to get DevTools Protocol Versionpfeldman@chromium.org2012-10-162-0/+31
| | | | | | | | | BUG=154064 Review URL: https://chromiumcodereview.appspot.com/11151019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162137 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: [remote debugging] terminate web socket connection upon renderer ↵pfeldman@chromium.org2012-10-161-4/+26
| | | | | | | | | | | disconnect. BUG=154253 Review URL: https://chromiumcodereview.appspot.com/11141024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162123 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: [remote debugging] introduce json/new and json/close for creating ↵pfeldman@chromium.org2012-10-102-56/+140
| | | | | | | | and closing the tabs. Review URL: https://chromiumcodereview.appspot.com/11033046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161126 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: run the devtools remote debugging server on a separate thread.pfeldman@chromium.org2012-09-282-19/+47
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10991056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159257 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools [remote debugging]: serve devtools front-end files from the bundle, ↵pfeldman@chromium.org2012-09-272-157/+24
| | | | | | | | never redirect to chrome-devtools://. Review URL: https://chromiumcodereview.appspot.com/10986050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159042 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: request page thumbnails from the devtools handler delegate, do not ↵pfeldman@chromium.org2012-09-272-3/+30
| | | | | | | | redirect to chrome://thumb. Review URL: https://chromiumcodereview.appspot.com/10985041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158982 0039d316-1c4b-4281-b951-d872f2087c98
* Destroy WorkerDevToolsAgentHost when corresponding worker terminatesyurys@chromium.org2012-09-261-0/+1
| | | | | | | | | | The call was missing and now that jam is moving NOTIFICATION_APP_TERMINATING from content/ to chrome/ (http://codereview.chromium.org/10968064/) it became obvious. BUG=None Review URL: https://codereview.chromium.org/10989012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158790 0039d316-1c4b-4281-b951-d872f2087c98
* Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, ↵jam@chromium.org2012-09-251-26/+1
| | | | | | | | | since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98
* Remove storage context accessors from ResourceContext.ajwong@chromium.org2012-09-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | ResourceContext is the IO thread projection of the Profile. Since one profile may now have multiple StoragePartitions (and thus multiple storage contexts), we need to remove these accessors. All code in the IO thread has enough information to find their appropriate storage context objects without needing to grab it through the ResourceContext. The only users of the ResourceContext storage context APIs are in worker_host classes. As a result of this change, a number of APIs that previously just took 1 ResourceContext now need to take 4 additional objects. We could create a StoragePartitionForIO class that parallels StoragePartition, but since the API ugliness is purely limited to workers, the abstraction isn't worth its weight. BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10885044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156126 0039d316-1c4b-4281-b951-d872f2087c98
* Add SPDY request headers to DevTools.mmenke@chromium.org2012-09-071-0/+21
| | | | | | | | R=eroman@chromium.org, yurys@chromium.org BUG=73945 Review URL: https://chromiumcodereview.appspot.com/10870080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155413 0039d316-1c4b-4281-b951-d872f2087c98
* Removed calls to URLRequest::URLRequest in favor of ↵erikwright@chromium.org2012-09-011-6/+3
| | | | | | | | | | | | | | | URLRequestContext::CreateRequest This patch is by departed intern shalev@chromium.org, but it failed to pass the CQ for reasons unrelated to the patch. Original review at http://codereview.chromium.org/10870060/ . TBR=mmenke@chromium.org,michaeln@chromium.org,brettw@chromium.org,ben@chromium.org,zelidrag@chromium.org,phajdan.jr@chromium.org,pfeldman@chromium.org BUG=142945 Review URL: https://chromiumcodereview.appspot.com/10910044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154550 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Fix a leak.jhawkins@chromium.org2012-08-311-3/+3
| | | | | | | | | | | | | The allocated IPC message needs to stay alive for the life of the callback, so pass ownership to bind using base::Owned. BUG=145700 R=khorimoto@chromium.org TBR=pfeldman Review URL: https://chromiumcodereview.appspot.com/10908025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154351 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where the inspector would not keep event pages alive.mpcomplete@chromium.org2012-08-226-17/+20
| | | | | | | | | | | | The notification that an inspector window was opened was not always being sent. BUG=143284 TBR=creis@chromium.org,pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10837296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152733 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: support JSONP mode in /json remote debugging discovery.pfeldman@chromium.org2012-08-101-1/+10
| | | | | | | | | BUG=141867 Review URL: https://chromiumcodereview.appspot.com/10830259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151071 0039d316-1c4b-4281-b951-d872f2087c98
* Add a menu item to content_shell to open devtools to make it more discoverable.jam@chromium.org2012-08-092-15/+37
| | | | | | | | | | | Since the devtools server is running for each content shell browser process, the user doesn't specify a server port anymore. Instead I let the system pick. This made it necessary to plumb the data back from net::HttpServer. For now I only added Windows and Linux UI. Mac UI will be done later. BUG=90445 Review URL: https://chromiumcodereview.appspot.com/10837177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150808 0039d316-1c4b-4281-b951-d872f2087c98
* Remove #pragma once from contentajwong@chromium.org2012-07-118-9/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructorsrsleevi@chromium.org2012-06-251-1/+1
| | | | | | | | | | | | | Change content::ResourceResponse to be base::RefCountedData<> rather than directly inheriting from both ResourceResponseHead and base::RefCounted. BUG=123295 TEST=existing Review URL: https://chromiumcodereview.appspot.com/10416003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143880 0039d316-1c4b-4281-b951-d872f2087c98
* Added URLRequestContext to constructor for URLRequest.erikwright@chromium.org2012-06-221-3/+6
| | | | | | | | | | | | | Previously, the context was set using the member function set_context. Note that the context for a URLRequest is not allowed to be null. BUG=81979 TEST=None TBR=ajwong,brettw,vitalybuka,sky Review URL: https://chromiumcodereview.appspot.com/10559036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143595 0039d316-1c4b-4281-b951-d872f2087c98
* Rename IPC Sender and Listener in ppapi, content/public, and content/rendererbrettw@chromium.org2012-06-202-0/+2
| | | | | | | | | | | This is the new name in preparation for deleting the backwards-compatible typedef. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10532162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143282 0039d316-1c4b-4281-b951-d872f2087c98
* Make NetLog take in callbacks that return Values rathermmenke@chromium.org2012-06-102-89/+82
| | | | | | | | | | | | than refcounted objects. Avoids the need to create classes and copy data. Also no longer get time whenever an event is logged. BUG=126243 Review URL: https://chromiumcodereview.appspot.com/10399083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141377 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 139933 - Clean up RenderViewHostManager swapping logic.creis@chromium.org2012-06-061-2/+1
| | | | | | | | | | | | | | | | | | Reverting due to http://crbug.com/131376. Makes the difference between swapping SiteInstances and swapping BrowsingInstances explicit, and adds CHECKs to enforce invariants more effectively. BUG=123007 TEST=No functionality change. Review URL: https://chromiumcodereview.appspot.com/9965091 TBR=creis@chromium.org Review URL: https://chromiumcodereview.appspot.com/10546029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140795 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify how Content*Client interfaces are created. Instead of depending on ↵jam@chromium.org2012-06-051-4/+5
| | | | | | | | | | | the embedder to know when to create and set them and to handle special cases like zygote/single-process, directly ask the embedder to create an instance of a specific type. Also, if the embedder doesn't return an instance create the empty version. Remove MockContentRendererClient since it existed before ContentRendererClient had an implementation and has no need anymore. Rename MockContentBrowserClient to TestContentBrowserClient to better reflect how it's used. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10479023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140524 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock notification observer header from content\test to ↵jam@chromium.org2012-06-031-4/+0
| | | | | | | | | | content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10494012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140245 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up RenderViewHostManager swapping logic.creis@chromium.org2012-06-011-1/+2
| | | | | | | | | | | | | Makes the difference between swapping SiteInstances and swapping BrowsingInstances explicit, and adds CHECKs to enforce invariants more effectively. BUG=123007 TEST=No functionality change. Review URL: https://chromiumcodereview.appspot.com/9965091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139933 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 137734 - Select theme resources from ResourceBundle at ↵flackr@chromium.org2012-05-241-1/+3
| | | | | | | | | | | | | | | requested scale factor." Relanding original CL 137734, http://codereview.chromium.org/10387010/. TBR=aa,abodenha,ben,sail,tony BUG=123611 TEST=All try bots pass and aura runs without errors. Review URL: https://chromiumcodereview.appspot.com/10412004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138769 0039d316-1c4b-4281-b951-d872f2087c98