| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPC Messages
============
This CL replaces the following view-oriented IPC messages:
IPC_MESSAGE_ROUTED2(ViewMsg_SavePageAsMHTML,
int /* job_id */,
IPC::PlatformFileForTransit /* file handle */)
IPC_MESSAGE_CONTROL2(ViewHostMsg_SavedPageAsMHTML,
int /* job_id */,
int64 /* size of the MHTML file, -1 if error */)
with the following frame-oriented IPC messages:
IPC_MESSAGE_ROUTED5(FrameMsg_SerializeAsMHTML,
int /* job_id (used to match responses to requests) */,
IPC::PlatformFileForTransit /* destination file */,
std::string /* mhtml boundary marker */,
FrameRoutingIdToContentIdMap,
bool /* is last frame */)
IPC_MESSAGE_ROUTED3(FrameHostMsg_SerializeAsMHTMLResponse,
int /* job_id (used to match responses to requests) */,
bool /* true if success, false if error */,
std::string /* mhtml boundary marker that was used */)
This allows MHTML generation to work, even when some frames are in separate
processes.
Supporting changes
==================
This CL builds on top of recent CLs below:
crrev.com/1436683002 - Making PageSerializer operate on single frames only.
crrev.com/1441553002 - Generating CIDs in Blink during MHTML serialization.
crrev.com/1415463007 - Exposing more granular methods from MHTMLArchive.
crrev.com/1380963006 - MHTMLGenerator preparation for per-frame serialization.
Handling of renderer IPC messages was moved from MHTMLGenerator into
RenderFrameImpl. Handling of browser IPC responses was moved from
RenderProcessHostImpl into RenderFrameHostImpl.
MHTMLGenerationManager now handles walking over all the frames and
asking the renderer process to serialize them into MHTML (sequentially -
one frame at a time). MHTMLGenerationManager also handles generating
ContentIDs for all frames.
BUG=538766
Review URL: https://codereview.chromium.org/1386873003
Cr-Commit-Position: refs/heads/master@{#365082}
|
