| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1544273002
Cr-Commit-Position: refs/heads/master@{#366875}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. When permission is granted, with the default values, we should gather non-loopback candidates.
2. When permission is denied, iceServers passed in as [], we should not see any candidates.
3. When permission is denied, iceServers not specified, we should see loopback candidates only.
4. When permission is granted, but multiple-routes is not requested, we should see loopback candidates only.
BUG=520101
Review URL: https://codereview.chromium.org/1387673002
Cr-Commit-Position: refs/heads/master@{#353562}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to stop shipping the snapshot file, and instead we want
to generate it on the client. This will reduce the download size.
But since snapshot generation will be asynchronous in a utility
process, it might not be present on the first few runs of the
browser. This means we have to be able to start up without the
snapshot file (just with the natives source file). This CL
fixes Blink to cope with a missing snapshot file (V8 could
already cope).
R=rmcilroy@chromium.org, sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1164483003
Cr-Commit-Position: refs/heads/master@{#333258}
|
|
|
|
|
|
|
|
|
|
| |
isolate_holder.h is public and used by blink and therefore cannot refer to types from base. As part of porting this to other platforms we needed to load snapshots from BaseFile descriptors.
BUG=421063
Review URL: https://codereview.chromium.org/1011133006
Cr-Commit-Position: refs/heads/master@{#323886}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Covers content/.
BUG=422426
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/803813003
Cr-Commit-Position: refs/heads/master@{#309496}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/689563002
Cr-Commit-Position: refs/heads/master@{#303095}
|
|
|
|
|
|
|
|
|
|
|
|
| |
files as opposed to being statically linked to the binary.
This is not currently supported on any architecture.
BUG=421063
Review URL: https://codereview.chromium.org/594603003
Cr-Commit-Position: refs/heads/master@{#301595}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/671663002
Cr-Commit-Position: refs/heads/master@{#300461}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/630813002
Cr-Commit-Position: refs/heads/master@{#298228}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, Mojo applications that link against mojo_environment_chromium
do not need to instantiate mojo::Environment. We rely on AtExitManager for all
finalization of singleton objects. This frees us up to use the familiar
base::Singleton and base::LazyInstance for any such state. Tests can use
ShadowingAtExitManager to clean the environment between test runs.
It becomes a link error to use mojo::Environment if you are not linking against
mojo_environment_standalone. I plan to follow this up with a change that buries
mojo::Environment for the case where you are linking against
mojo_environment_standalone. Ideally, this means no one will ever need to think
about mojo::Environment again.
Review URL: https://codereview.chromium.org/281353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/319183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused layout tests (when run with check-sys-deps) to hang on Windows
with a stuck content_shell process. See Issue 376929.
BUG=376929
> Mojo: nuke EnvironmentData
>
> With this change, Mojo applications that link against mojo_environment_chromium
> do not need to instantiate mojo::Environment. We rely on AtExitManager for all
> finalization of singleton objects. This frees us up to use the familiar
> base::Singleton and base::LazyInstance for any such state. Tests can use
> ShadowingAtExitManager to clean the environment between test runs.
>
> It becomes a link error to use mojo::Environment if you are not linking against
> mojo_environment_standalone. I plan to follow this up with a change that buries
> mojo::Environment for the case where you are linking against
> mojo_environment_standalone. Ideally, this means no one will ever need to think
> about mojo::Environment again.
>
> Review URL: https://codereview.chromium.org/281353005
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/299263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, Mojo applications that link against mojo_environment_chromium
do not need to instantiate mojo::Environment. We rely on AtExitManager for all
finalization of singleton objects. This frees us up to use the familiar
base::Singleton and base::LazyInstance for any such state. Tests can use
ShadowingAtExitManager to clean the environment between test runs.
It becomes a link error to use mojo::Environment if you are not linking against
mojo_environment_standalone. I plan to follow this up with a change that buries
mojo::Environment for the case where you are linking against
mojo_environment_standalone. Ideally, this means no one will ever need to think
about mojo::Environment again.
Review URL: https://codereview.chromium.org/281353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of the mentioned CL, that hit an internal bot due
to a test needing the flag |kUseFakeDeviceForMediaStream|.
Original CL message -----------------------------------------------
Mac Video Capture Device: split VCD into VCD and Factory.
VideoCaptureDeviceMac includes factory and non-factory parts.
This CL splits them into VideoCaptureDeviceMac and
VideoCaptureDeviceFactoryMac. The latter inherits the previous
class' static methods: Create(), GetDeviceNames() and
GetDeviceSupportedFormats().
All video factory code previously in MediaStreamManager is
moved into VideoCaptureFactory. This includes the use
of the flag |kUseFakeDeviceForMediaStream|.
This flag is moved correspondingly into media_switches.cc --
(but note that this flag is still used in MediaStreamManager for
the Fake Audio parts). File media_switches.cc is
included in several test files where the flag is used.
VideoCaptureDeviceTest is splitted as well into:
a) Tests that were exercising only the FakeVCD
(FakeVideoCaptureDeviceTest).
b) All other tests, that use the underlying OS webcam.
This VideoCaptureDeviceTest gets a Factory and uses it
instead of static methods.
A unit test is added to VCDFMac, doing little for the moment
but I'm planning to add support for testing at least the
blacklisting -- req from rsesek@ in another CL.
-------------------------------------------------------------------
TBR= perkj@chromium.org, dalecurtis@chromium.org, jochen@chromium.org
BUG=288562, 323913, 255552
Review URL: https://codereview.chromium.org/278333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/265263004/)
Reason for revert:
Some backoffice bots broke due to |kUseFakeDeviceForMediaStream| not being correctly defined - reverting until M36 storm passes and then I'll figure those out.
Original issue's description:
> Mac Video Capture Device: split VCD into VCD and Factory.
>
> VideoCaptureDeviceMac includes factory and non-factory parts.
> This CL splits them into VideoCaptureDeviceMac and
> VideoCaptureDeviceFactoryMac. The latter inherits the previous
> class' static methods: Create(), GetDeviceNames() and
> GetDeviceSupportedFormats().
>
> All video factory code previously in MediaStreamManager is
> moved into VideoCaptureFactory. This includes the use
> of the flag |kUseFakeDeviceForMediaStream|.
> This flag is moved correspondingly into media_switches.cc --
> (but note that this flag is still used in MediaStreamManager for
> the Fake Audio parts). File media_switches.cc is
> included in several test files where the flag is used.
>
>
> VideoCaptureDeviceTest is splitted as well into:
> a) Tests that were exercising only the FakeVCD
> (FakeVideoCaptureDeviceTest).
> b) All other tests, that use the underlying OS webcam.
> This VideoCaptureDeviceTest gets a Factory and uses it
> instead of static methods.
>
> A unit test is added to VCDFMac, doing little for the moment
> but I'm planning to add support for testing at least the
> blacklisting -- req from rsesek@ in another CL.
>
> BUG=288562, 323913, 255552
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269271
TBR=perkj@chromium.org,jochen@chromium.org,dalecurtis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=288562, 323913, 255552
Review URL: https://codereview.chromium.org/273063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VideoCaptureDeviceMac includes factory and non-factory parts.
This CL splits them into VideoCaptureDeviceMac and
VideoCaptureDeviceFactoryMac. The latter inherits the previous
class' static methods: Create(), GetDeviceNames() and
GetDeviceSupportedFormats().
All video factory code previously in MediaStreamManager is
moved into VideoCaptureFactory. This includes the use
of the flag |kUseFakeDeviceForMediaStream|.
This flag is moved correspondingly into media_switches.cc --
(but note that this flag is still used in MediaStreamManager for
the Fake Audio parts). File media_switches.cc is
included in several test files where the flag is used.
VideoCaptureDeviceTest is splitted as well into:
a) Tests that were exercising only the FakeVCD
(FakeVideoCaptureDeviceTest).
b) All other tests, that use the underlying OS webcam.
This VideoCaptureDeviceTest gets a Factory and uses it
instead of static methods.
A unit test is added to VCDFMac, doing little for the moment
but I'm planning to add support for testing at least the
blacklisting -- req from rsesek@ in another CL.
BUG=288562, 323913, 255552
Review URL: https://codereview.chromium.org/265263004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we've sorted out the build issues on all platforms it can be
removed.
BUG=353602
TEST=none
R=jam@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/226213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=darin@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/220073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
duplication of code in the browser test harness for setting up the browser process, and also ensures that initialization code in ContentMainRunner runs.
Most of the changes are to unit tests which run in browser test executables. These were getting all the setup that these binaries did for browser tests even though they were unit tests. Now they have to explicitly setup objects that they need. This would be done automatically if they were in a unit test binary and therefore using the unit test harness. The goal should be to move these tests to unit test binaries, and make them support launching some tests in separate processes building on the work that Pawel did.
BUG=350550
R=sky@chromium.org
Review URL: https://codereview.chromium.org/190663012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was this TODO(sky): convert this and InitMessagePumpForUIFactory() to return a
scoped_ptr.
This patch is for doing the same.
R=darin@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/185413019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let me know if you prefer to keep some of these as INFO or just delete
them.
R=jam@chromium.org
BUG=322805
Review URL: https://codereview.chromium.org/84293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The content_browsertests on Android exit before IO thread is joined.
Some tasks on IO thread needs to access GetContentClient() which has
been reset by ContentShellTestSuiteInitializer::OnTestEnd when test
is terminated.
To keep closer to production code, this patch tries to not reset
ContentClient on Android when test is ended.
BUG=181069
R=jam@chromium.org
Review URL: https://codereview.chromium.org/27518013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 94094b6f47c929e5ebaa54eb2627c93e7367399f.
Looks like interactive_ui_tests passed on the next build that didn't have the revert yet.
TBR=maruel
BUG=236893
Review URL: https://codereview.chromium.org/49843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke Mac interactive_ui_tests
> GTTF: make sharding_supervisor.py use --brave-new-test-launcher
>
> - browser tests use parallel jobs by default (except interactive_ui_tests)
> - sharding + PRE_ tests are handled correctly
> - .isolate files updated
>
> BUG=236893
> R=maruel@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/46023003
TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/48113008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- browser tests use parallel jobs by default (except interactive_ui_tests)
- sharding + PRE_ tests are handled correctly
- .isolate files updated
BUG=236893
R=maruel@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/46023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4cfd0a0dd30f07a2d9ca4b9943b0164f4c14c4a0.
TBR=maruel
BUG=236893
Review URL: https://codereview.chromium.org/45043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236893
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/39213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=180021
R=marja@chromium.org
TBR=joi@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23316003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19620002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There will now be one for using fake devices and one for bypassing the UI. The reason is that we want to be able to write browser tests which can run on VMs and yet test the infobar.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/17338005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236893
R=jam@chromium.org
Review URL: https://codereview.chromium.org/16820008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Android
Android needs to use a nested message loop in order to execute the
layout tests. We have an implementation of this for content_browsertests
as BrowserTestSystemMessageHandler, but this lives in /content/test/
which content_shell cannot depend on.
Move it to /content/public/test/ as NestedSystemMessageHandler and
update content_browsertests to depend on that instead. For content_shell,
implement support of starting the nested loop, and use it when running
layout tests.
BUG=232044
Review URL: https://chromiumcodereview.appspot.com/17076008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 1de6b10d7585d15940ef8624d6ae48e49746ae88.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be useful for extracting content-specific
parts of test_launcher.cc .
These parts will need to be shared between content
and chrome, and are expected to be in the files
being extracted in this CL.
BUG=236893
R=sky@chromium.org
Review URL: https://codereview.chromium.org/15067015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=180021
TBR=marja@chromium.org
Review URL: https://codereview.chromium.org/15060007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=180021
TBR=marja@chromium.org
Review URL: https://codereview.chromium.org/14767019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14335017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content's embedder API. The main reasons are that it makes content's embedder interfaces harder to change if they're reused by the embedder, and that its makes it confusing for embedder code when there are multiple ways to do the same thing.
BUG=227047
Review URL: https://codereview.chromium.org/13409003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This changes the "easy" content subdirectories (everything but browser, renderer, and common) and the ppapi top level directory.
Review URL: https://codereview.chromium.org/12208057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, in nested mode only native side messages are processed (which
is sufficient for some tests running with in-process renderer (--single-process)
BUG=138275
Review URL: https://chromiumcodereview.appspot.com/12095078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Revert 179189"
This reverts commit 5844ab0c6a41cc9d306f8c355cc7ceb5e290cbb1.
Original CL:https://codereview.chromium.org/12047068/
was reverted as we failed to update the bot scripts with the new package
name for content_shell_apk
TBR=mark@chromium.org,jam@chromium.org
BUG=138275
Review URL: https://chromiumcodereview.appspot.com/12091033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failed to rename package name in buildbot scripts. Broke buildbots.
> Add apk for running content_browsertests
>
> Split off org.chromium.content_shell into:
> org.chromium.content_shell - content shell java code, builds a jar, directory structure similar to other jar targets
> org.chromium.content_shell_apk - application code to build content_shell_apk, directory structure similar to that of android application
> org.chromium.content_browsertests_apk - application code to build content_browsertests_apk
>
> Also splitting content/shell/android/res into:
> - content/shell/android/java/res
> - content/shell/android/shell_apk/res
>
> Both content_shell_apk and content_browsertests_apk will depend on content_shell_java target to include java/res needed to show a shell based browser.
>
> I will do another CL to move The java files for content_shell_tests_apk to content_shell_apk package.
>
> BUG=138275
>
>
> Review URL: https://chromiumcodereview.appspot.com/12047068
TBR=nileshagrawal@chromium.org
Review URL: https://codereview.chromium.org/12088031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split off org.chromium.content_shell into:
org.chromium.content_shell - content shell java code, builds a jar, directory structure similar to other jar targets
org.chromium.content_shell_apk - application code to build content_shell_apk, directory structure similar to that of android application
org.chromium.content_browsertests_apk - application code to build content_browsertests_apk
Also splitting content/shell/android/res into:
- content/shell/android/java/res
- content/shell/android/shell_apk/res
Both content_shell_apk and content_browsertests_apk will depend on content_shell_java target to include java/res needed to show a shell based browser.
I will do another CL to move The java files for content_shell_tests_apk to content_shell_apk package.
BUG=138275
Review URL: https://chromiumcodereview.appspot.com/12047068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11346016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a flag --use-fake-device-for-media-stream for replacing actual
camera with a fake one.
The fake camera also generates a visual beep every 1 second.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11270026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11228040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is take 2; the original patch ( http://crrev.com/159815 ), which only dealt with OLE, broke a few tests. The OneClickSignIn tests were skipping the RenderViewHostTestHarness SetUp() method, while the Accessibility tests directly muck with Widgets and thus have to manually init OLE.
BUG=none
TEST=Fewer "Multiple OleInitialize..." messages in tests
Review URL: https://codereview.chromium.org/11031059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
having OLE initialized after r159815.
This change reverts r159881, r159982, and r160020, and fixes the core bug.
BUG=153741
TEST=none
Review URL: https://codereview.chromium.org/11036030
TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/11066008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
initialized after r159815.
This change reverts r159881, r159982, and r160020, and fixes the core bug.
BUG=153741
TEST=none
Review URL: https://codereview.chromium.org/11036030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the number of duplicate initializations, which are noticeable now that I've added logging for them.
I'm trying to track down a mysterious XP-only failure in OneClickSigninHelperTest.
If reverting this change doesn't fix the problem, I'll un-revert.
BUG=none
TEST=Fewer "Multiple OleInitialize..." messages in tests
TBR=phajdan.jr
Review URL: https://codereview.chromium.org/11036010
TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/11030020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160020 0039d316-1c4b-4281-b951-d872f2087c98
|