summaryrefslogtreecommitdiffstats
path: root/extensions/browser/extension_error.cc
Commit message (Collapse)AuthorAgeFilesLines
* Use the appropriate variant of IntToString in //extensionsricea2015-09-251-6/+8
| | | | | | | | | | | | | | | Using the wrong variant of IntToString() can lead to unexpected behaviour and bugs. Use the appropriate variant for the type being converted. No behaviour change intended. BUG=505479 TEST=compiled Review URL: https://codereview.chromium.org/1352893003 Cr-Commit-Position: refs/heads/master@{#350874}
* [Extensions OOPI] Update ErrorConsole and related to use RenderFrameHostsrdevlin.cronin2015-06-241-76/+2
| | | | | | | | | | | | | | | Update ErrorConsole-related things, including adding runtime errors and the developerPrivate API to use RenderFrameHosts. Remove the message listener for console messages from TabHelper, since it should be fully handled in ChromeExtensionWebContentsObserver. Remove unneeded ExtensionError::ToValue code. BUG=455776 BUG=503676 Review URL: https://codereview.chromium.org/1202753002 Cr-Commit-Position: refs/heads/master@{#335961}
* Add declarativeContent support for bookmarked statewittman2015-06-241-5/+32
| | | | | | | | | | | Allow extensions to test the bookmarked state of URLs using the declarativeContent API. BUG=485169 Review URL: https://codereview.chromium.org/1183983003 Cr-Commit-Position: refs/heads/master@{#335945}
* [Extensions] Add a developerPrivate.deleteExtensionErrors functionrdevlin.cronin2015-03-211-0/+1
| | | | | | | | | | Add a developerPrivate API function for removing extension errors. BUG=TBD Review URL: https://codereview.chromium.org/1014323003 Cr-Commit-Position: refs/heads/master@{#321673}
* Revert of Revert "Typecheck JS files for chrome://extensions" (patchset #1 ↵dbeam2014-08-271-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/508283002/) Reason for revert: fixed check_licenses issues Original issue's description: > Revert "Typecheck JS files for chrome://extensions" > > This reverts commit 405253b7ee22ecb318d3c1ca9187e1e7259e704f. > > Caused a liscene failure on android bot: > http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/87b3206 TBR=vitalyp@chromium.org,eroman@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/512003002 Cr-Commit-Position: refs/heads/master@{#292229}
* Revert "Typecheck JS files for chrome://extensions"Eric Roman2014-08-271-4/+0
| | | | | | | | | | | This reverts commit 405253b7ee22ecb318d3c1ca9187e1e7259e704f. Caused a liscene failure on android bot: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio Review URL: https://codereview.chromium.org/508283002 Cr-Commit-Position: refs/heads/master@{#292208}
* Typecheck JS files for chrome://extensionsvitalyp2014-08-271-0/+4
| | | | | | | | | | BUG=393873 R=dbeam@chromium.org TEST=gyp --depth . chrome/browser/resources/extensions/compiled_resources.gyp && ninja -C out/Default Review URL: https://codereview.chromium.org/475633006 Cr-Commit-Position: refs/heads/master@{#292195}
* Add base:: to string16 in extensions/.dbeam@chromium.org2013-12-201-8/+7
| | | | | | | | | R=yoz@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/107803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242211 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'Inspect' Links for views in the Extension Error Consolerdevlin.cronin@chromium.org2013-11-011-3/+11
| | | | | | | | | | | | | | | Add the option to inspect a resource or render view in the error console, opening the developer tools for that resource/view. Goes with: https://codereview.chromium.org/23816005 BUG=21734 TBR=yoshiki@chromium.org (task_manager) TBR=ben@chromium.org (ui [refactor only]) Review URL: https://codereview.chromium.org/23459008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232246 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comparison in an equal comparator.etienneb@chromium.org2013-09-101-2/+2
| | | | | | | | | | | | This issue was found by a linter. R=rdevlin.cronin@chromium.org, yoz@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23503045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222213 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadcode in an invalid string construction.etienneb@chromium.org2013-09-101-1/+1
| | | | | | | | | | | This issue was found by a linter. R=yoz@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23717041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222182 0039d316-1c4b-4281-b951-d872f2087c98
* Follows https://codereview.chromium.org/22938005/rdevlin.cronin@chromium.org2013-09-071-0/+31
| | | | | | | | | | | Add UI elements for extension runtime (javascript) errors on the chrome:extensions page. Include a stack trace and, if possible, links to the source code. TBR=finnur@chromium.org BUG=21734 Review URL: https://chromiumcodereview.appspot.com/23624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221824 0039d316-1c4b-4281-b951-d872f2087c98
* Expand RuntimeErrors for ErrorConsolerdevlin.cronin@chromium.org2013-09-061-2/+3
| | | | | | | | | | | Include two of our internal scripts (event_bindings and schemaUtil) as sources for runtime errors. Add tests for same. BUG=21734 Review URL: https://chromiumcodereview.appspot.com/23923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221652 0039d316-1c4b-4281-b951-d872f2087c98
* Add Error Console UI for install warnings to the chrome:extensions page ↵rdevlin.cronin@chromium.org2013-09-051-20/+40
| | | | | | | | | | | | (hidden behind the error console switch). Snazzy Images: http://imgur.com/a/7QnMo#0 (updated 9/3) BUG=21734 Review URL: https://chromiumcodereview.appspot.com/22938005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221527 0039d316-1c4b-4281-b951-d872f2087c98
* Catch ManifestErrors with ErrorConsole; Add Browsertestsrdevlin.cronin@chromium.org2013-09-031-2/+6
| | | | | | | | | | Add backend support for catching manifest install warnings with the ErrorConsole. Forked from https://codereview.chromium.org/22938005 in order to reduce size and separate backend and frontend CLs. BUG=21734 Review URL: https://chromiumcodereview.appspot.com/23684015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221020 0039d316-1c4b-4281-b951-d872f2087c98
* Report Javascript Runtime Errors to the Error Consolerdevlin.cronin@chromium.org2013-09-011-69/+28
| | | | | | | | | | | TBR=brettw@chromium.org (moving DEPS file from extensions/common/matcher to extensions/common). BUG=21734 Review URL: https://chromiumcodereview.appspot.com/23007021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220753 0039d316-1c4b-4281-b951-d872f2087c98
* ErrorConsole Switch, Duplicate Error Detection, Dev Mode Checkrdevlin.cronin@chromium.org2013-08-281-27/+66
| | | | | | | | | | | | | Add in a command-line switch for ErrorConsole ('enable-error-console'). Add in duplicate-error detection, so that multiple copies of the same error aren't both stored. Add in a check so that the ErrorConsole only stores errors if the user is in Developer Mode. Rename ManifestParsingError to ManifestError, JavascriptRuntimeError to RuntimeError BUG=21734 Review URL: https://chromiumcodereview.appspot.com/23311011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220108 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit 21609003: Move ExtensionError to extensions/, add error limitsrdevlin.cronin@chromium.org2013-08-101-0/+172
| | | | | | | | | | | | | | Added in a fix for the memory leak. Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/. Limit the number of errors stored per extension to 100. Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them. BUG=21734 Review URL: https://chromiumcodereview.appspot.com/22647007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216871 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 216345 "Move ExtensionError to extensions/, add error limits"jyasskin@chromium.org2013-08-081-172/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It leaks memory: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/24926/steps/memory%20test%3A%20unit/logs/stdio Leak_DefinitelyLost 663 (264 direct, 399 indirect) bytes in 3 blocks are definitely lost in loss record 33,024 of 38,445 operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140) extensions::(anonymous namespace)::CreateNewRuntimeError(bool, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&) (chrome/browser/extensions/error_console/error_console_unittest.cc:51) extensions::ErrorConsoleUnitTest_AddAndRemoveErrors_Test::TestBody() (chrome/browser/extensions/error_console/error_console_unittest.cc:80) > Move ExtensionError to extensions/, add error limits > > Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/. > Limit the number of errors stored per extension to 100. > Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them. > > BUG=21734 > > Review URL: https://chromiumcodereview.appspot.com/21609003 TBR=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/22585003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216355 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionError to extensions/, add error limitsrdevlin.cronin@chromium.org2013-08-081-0/+172
Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/. Limit the number of errors stored per extension to 100. Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them. BUG=21734 Review URL: https://chromiumcodereview.appspot.com/21609003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216345 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-28 05:59:56 +0000