| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deletes the forwarding headers in base/prefs.
Updates the remaining users of base/prefs includes to use components/prefs.
Sort headers in updated files.
Move PrefServiceFactory out of the base namespace. Update users.
Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
COMPONENTS_PREFS_.
Add components/prefs to DEPS file of directories where checkdeps fails after
the update.
BUG=583034
Reland of http://crrev.com/1662523004#ps40001 with fix.
TBR=estade@chromium.org
Review URL: https://codereview.chromium.org/1668463002
Cr-Commit-Position: refs/heads/master@{#373197}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#3 id:40001 of https://codereview.chromium.org/1662523004/ )
Reason for revert:
Broke Win Builder compile:
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463/steps/compile/logs/stdio
Original issue's description:
> Delete base/prefs and update callers to use components.
>
> Deletes the forwarding headers in base/prefs.
>
> Updates the remaining users of base/prefs includes to use components/prefs.
> Sort headers in updated files.
>
> Move PrefServiceFactory out of the base namespace. Update users.
>
> Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
> COMPONENTS_PREFS_.
>
> Add components/prefs to DEPS file of directories where checkdeps fails after
> the update.
>
> BUG=583034
>
> Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef
> Cr-Commit-Position: refs/heads/master@{#373105}
TBR=estade@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583034
Review URL: https://codereview.chromium.org/1662843002
Cr-Commit-Position: refs/heads/master@{#373115}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deletes the forwarding headers in base/prefs.
Updates the remaining users of base/prefs includes to use components/prefs.
Sort headers in updated files.
Move PrefServiceFactory out of the base namespace. Update users.
Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
COMPONENTS_PREFS_.
Add components/prefs to DEPS file of directories where checkdeps fails after
the update.
BUG=583034
Review URL: https://codereview.chromium.org/1662523004
Cr-Commit-Position: refs/heads/master@{#373105}
|
|
|
|
|
|
|
|
|
|
| |
This added kPrefInstallTime for extensions that were installed before the install time pref was introduced, 5 years ago: https://codereview.chromium.org/5213002
BUG=none
Review URL: https://codereview.chromium.org/1603463006
Cr-Commit-Position: refs/heads/master@{#370224}
|
|
|
|
|
|
|
|
|
|
| |
The pref change happened > 4 years ago (https://codereview.chromium.org/7003098), let's assume everything's migrated.
BUG=none
Review URL: https://codereview.chromium.org/1589403002
Cr-Commit-Position: refs/heads/master@{#370169}
|
|
|
|
|
|
|
|
|
|
|
| |
This was deprecated > 3 years ago in https://chromiumcodereview.appspot.com/10828316.
Let's assume everything's migrated by now.
BUG=none
Review URL: https://codereview.chromium.org/1594553004
Cr-Commit-Position: refs/heads/master@{#369822}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/1549643002
Cr-Commit-Position: refs/heads/master@{#366702}
|
|
|
|
|
|
|
|
| |
BUG=557422
Review URL: https://codereview.chromium.org/1537893002
Cr-Commit-Position: refs/heads/master@{#366120}
|
|
|
|
|
|
|
|
| |
BUG=517735
Review URL: https://codereview.chromium.org/1497193002
Cr-Commit-Position: refs/heads/master@{#363918}
|
|
|
|
|
|
|
|
| |
BUG=542691,548333
Review URL: https://codereview.chromium.org/1431623003
Cr-Commit-Position: refs/heads/master@{#359069}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace a bunch of pointers with const&.
TBR=pkotwicz@chromium.org (themes)
TBR=atwilson@chromium.org (background)
TBR=rogerta@chromium.org (ui/sync)
BUG=455414
Review URL: https://codereview.chromium.org/1365443003
Cr-Commit-Position: refs/heads/master@{#351631}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PermissionSet represents a set of permissions, and for some reason,
it's been refcounted. There's really no reason to have it, and it
makes everything more costly and difficult to reason about. Remove the
refcounting.
Note: This is part 1 of a 2-part series. This removes the ref-counting.
In a followup, I'll go through and update many of the places that
use const PermissionSet* and convert to const &.
BUG=455414
TBR=thestig@chromium.org (misc chrome files with ptr conversion)
TBR=nasko@chromium.org (extension messages - not actually changing any IPC messages)
Review URL: https://codereview.chromium.org/1349613003
Cr-Commit-Position: refs/heads/master@{#350684}
|
|
|
|
|
|
|
|
|
|
| |
PermissionSet is refcounted (why is another issue), but multiple functions are
returning raw pointers to constructed PermissionSets, which makes for ugly casts
and potential leaks. Make all functions return refptrs.
Review URL: https://codereview.chromium.org/1353543002
Cr-Commit-Position: refs/heads/master@{#349497}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly called by clients.
Also, various cleanup related to DisableReasons, which were sometimes set inconsistently vs. the extension's enabled state.
ExtensionPrefs::SetExtensionState now also sets the disable reasons, to make sure they're updated at the same time as the enabled/disabled state.
BUG=None
Review URL: https://codereview.chromium.org/1296703003
Cr-Commit-Position: refs/heads/master@{#345577}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/1254363004
Cr-Commit-Position: refs/heads/master@{#342093}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that indicates the extension has local changes that still need to be synced.
It's set when something changes before sync is ready, and cleared once the extension state has been synced.
This should handle all conflicts between sync and local state reasonably well, and as a bonus allows us to get rid of the (weird and not-really-working) PendingEnables class.
BUG=509990
Review URL: https://codereview.chromium.org/1240573012
Cr-Commit-Position: refs/heads/master@{#339651}
|
|
|
|
|
|
|
|
|
|
| |
The "DidExtensionEscalatePermissions" flag is basically equivalent to HasDisableReason(DISABLE_PERMISSIONS_INCREASE | DISABLE_REMOTE_INSTALL), so check that instead of storing a separate pref.
BUG=493610
Review URL: https://codereview.chromium.org/1164603003
Cr-Commit-Position: refs/heads/master@{#333706}
|
|
|
|
|
|
|
|
|
|
| |
This will allow us (in a follow-up CL) to *not* grant permissions to extensions that come in via Sync disabled due to a permission increase.
BUG=484214
Review URL: https://codereview.chromium.org/1136543003
Cr-Commit-Position: refs/heads/master@{#330727}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have added PrefRegistry registration functions that do not need to
accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is
redundant and we can remove it altogether.
BUG=476800
Review URL: https://codereview.chromium.org/1092683004
Cr-Commit-Position: refs/heads/master@{#327439}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have added PrefRegistry registration functions that do not need to
accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is
redundant and we can remove it altogether.
Ran the following command:
for x in $(git ls-files | grep -E "\.(cc|h|mm)$") ; do perl -0777 -i -pe 's/,[ \n]*(user_prefs::)+PrefRegistrySyncable::UNSYNCABLE_PREF//igs' $x ; done && git cl format
There are still some occurences that need to be manually fixed.
BUG=476800
Review URL: https://codereview.chromium.org/1102733002
Cr-Commit-Position: refs/heads/master@{#326993}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are designed to give us more information about production-only
crashes occurring in ChromeAppSorting. These checks should help narrow
down the times at which extension_scoped_prefs_ is null.
Added TODOs to remove most of the checks later (although I plan to leave
one in as a safeguard).
BUG=476648
Review URL: https://codereview.chromium.org/1055453007
Cr-Commit-Position: refs/heads/master@{#326746}
|
|
|
|
|
|
|
|
|
|
| |
same behavior can be achieved by AddDisableReason().
BUG=475911
Review URL: https://codereview.chromium.org/1073153002
Cr-Commit-Position: refs/heads/master@{#325387}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue is due to usage of UserScript::ValidUserScriptSchemes()
instead of UserScript::kValidUserScriptSchemes,
we will add CHROMEUI scheme in valid schemes mask if extension is component extension.
BUG=467230
Review URL: https://codereview.chromium.org/1025613003
Cr-Commit-Position: refs/heads/master@{#325197}
|
|
|
|
|
|
|
|
|
|
| |
view in what causes the latency there.
BUG=454789
Review URL: https://codereview.chromium.org/1080063002
Cr-Commit-Position: refs/heads/master@{#325094}
|
|
|
|
|
|
|
|
|
|
|
| |
This should be cleared together for privacy reasons. To keep things
simple, whenever any history is cleared all launch times are forgotten.
BUG=405822
Review URL: https://codereview.chromium.org/977833002
Cr-Commit-Position: refs/heads/master@{#320047}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds checking for MustRemainDisabled() from management policy after an extension is installed or updated, so that extensions supposed to be disabled will be disabled initially with proper disabled reason set.
This CL also assumes that all disabled extension comes with proper disabled reason, so there are additional changes to ensure this.
1) Another extension disabled reason DISABLE_EXTERNAL_EXTENSION is added for external extensions. These extensions will be disabled initially on windows for user prompting.
2) Two tests from extension_disabled_ui_browsertest.cc is removed since these two tests are meant for legacy disables with not disabled reason set in user pref, which should be rarely seen now. And these rare cases are handled by presuming it's disabled by user action as well.
BUG=None
Review URL: https://codereview.chromium.org/714133002
Cr-Commit-Position: refs/heads/master@{#304587}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/664933004
Cr-Commit-Position: refs/heads/master@{#300475}
|
|
|
|
|
|
|
|
|
|
| |
Moving pref corresponding to bubble actions outside extension_prefs.
BUG=175701
Review URL: https://codereview.chromium.org/577043002
Cr-Commit-Position: refs/heads/master@{#298480}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/622343002
Cr-Commit-Position: refs/heads/master@{#298042}
|
|
|
|
|
|
|
|
|
|
| |
Use ExtensionManagement instead.
BUG=177351
Review URL: https://codereview.chromium.org/555323002
Cr-Commit-Position: refs/heads/master@{#294688}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionManagement Service.
Make ExtensionManagement listening to preference changes.
Move all functionality of admin_policy into StandardManagementPolicyProvider, the latter was essentially a wrapper over admin_policy before.
Merge admin_policy_unittest into extension_management_unittests with minor changes.
BUG=177351
TEST=ExtensionServiceTest,ExtensionManagementTest,ExtensionAdminPolicyTest
Review URL: https://codereview.chromium.org/500043003
Cr-Commit-Position: refs/heads/master@{#293514}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The pref's exclusive user AppWindow will move to extensions/browser
Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h}
Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc
BUG=403726
Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7
Review URL: https://codereview.chromium.org/493003002
Cr-Commit-Position: refs/heads/master@{#291655}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/493003002/)
Reason for revert:
Breaks GN:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/10608
Original issue's description:
> Merge apps/pref* to extensions/browser/pref*
>
> The pref's exclusive user AppWindow will move to extensions/browser
>
> Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h}
> Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc
>
> BUG=403726
> TBR=bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7
TBR=benwells@chromium.org,bauerb@chromium.org,bartfab@chromium.org,hashimoto@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403726
Review URL: https://codereview.chromium.org/499253002
Cr-Commit-Position: refs/heads/master@{#291652}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The pref's exclusive user AppWindow will move to extensions/browser
Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h}
Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc
BUG=403726
TBR=bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc.
Review URL: https://codereview.chromium.org/493003002
Cr-Commit-Position: refs/heads/master@{#291650}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidates id_util functions of extension/app/component ids in the crx_file component.
It belongs there because these types of ids are not exclusive to extensions, but rather, for anything that comes in a crx file.
BUG=371463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/481433005
Cr-Commit-Position: refs/heads/master@{#290971}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates the ENABLED_COMPONENT state, and fixes the path CHECK failure.
BUG=402377
Review URL: https://codereview.chromium.org/462533002
Cr-Commit-Position: refs/heads/master@{#289616}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We migrated to the new kToolbarSize pref over four years ago. I think this is
safe to remove. :)
Review URL: https://codereview.chromium.org/451193003
Cr-Commit-Position: refs/heads/master@{#289184}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preferences and their matching MAC.
The time has come where some tracked preferences are starting to be deprecated and keeping them declared
solely for the sake of having them migrated back to the unprotected store by TrackedPreferencesMigrator
only to be cleared from that store shortly after is adding overhead (and furthermore with that technique
only the value would be cleaned up, not its matching MAC).
Implemented in CleanupDeprecatedTrackedPreferences() in pref_hash_filter.cc and added a comment pointing
to it from kTrackedPrefs.
Review URL: https://codereview.chromium.org/432533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=396319
Review URL: https://codereview.chromium.org/412003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ephemeral apps are not shown in the app launcher or NTP, but they are
assigned ordinals, which results in unfilled NTP pages. This patch
does not give ephemeral apps launch ordinals until they are promoted
to fully installed apps.
AppSorting::MarkExtensionAsHidden() was refactored to
AppSorting::SetExtensionVisible() to allow the visibility of the
extension in the NTP to change.
BUG=394192
TEST=browser_tests
Review URL: https://codereview.chromium.org/397903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Taking the address of a temporary
* Octal escape sequence terminated by decimal number
* Signedness mismatch
* Possibly-uninitialized local variable
This also contains a small number of cleanups to nearby code (e.g. no else after return).
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/382673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=160586
Review URL: https://codereview.chromium.org/399433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pref is currently registered in different places for Mac and
toolkit-views, resulting in problems for toolkit-views on Mac (i.e. it
gets registered twice).
The views pref moved into extension_prefs.cc in r183799. This moves the
mac pref to the same place for increased code cohesion, simplifying a
lot of things.
BUG=155525, 390755
Review URL: https://codereview.chromium.org/378153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefs
The "ephemeral_app" flag is only written to extension prefs for
ephemeral apps and removed when the app is fully installed.
BUG=None
TEST=browser_tests (EphemeralAppBrowserTest.*)
Review URL: https://codereview.chromium.org/342593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
protection.
BUG=312883
Review URL: https://codereview.chromium.org/340093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is effectively a revert of http://crrev.com/202763005
BUG=339004
Review URL: https://codereview.chromium.org/337323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split from https://codereview.chromium.org/308003005/ for extensions
system changes that allows to install a none syncable Extension.
- Add a do_not_sync pref to ExtensionPrefs;
- Add a kInstallFlagDoNotSync that CrxInstaller uses to initialize the pref;
- Update util::ShouldSyncApp and add ShouldSyncExtension to use the pref to skip sync in ExtensionSyncService;
BUG=358791
Review URL: https://codereview.chromium.org/323843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
take a bitmask instead of 4 boolean values (soon to be 5).
As part of that, change the default-true flag "wait for idle" to a
default-false flag "install immediately".
R=asargent@chromium.org
TBR=estade@chromium.org, atwilson@chromium.org, dimich@chromium.org
Review URL: https://codereview.chromium.org/322893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attempt, this time with two one-liner test fixes)
Also use the browser action highlighting for extensions that have a browser action icon.
NOTE: This CL was already green-lighted here:
https://codereview.chromium.org/288923004/
BUG=381291
TBR=sky, devlin, dbeam
Review URL: https://codereview.chromium.org/320633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add an extension override bubble and warning box for proxy extensions.
>
> Also use the browser action highlighting for extensions that have a browser action icon.
>
> BUG=381291
> R=dbeam@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/288923004
TBR=finnur@chromium.org
Review URL: https://codereview.chromium.org/312403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275255 0039d316-1c4b-4281-b951-d872f2087c98
|