summaryrefslogtreecommitdiffstats
path: root/extensions/browser/extension_prefs.cc
Commit message (Collapse)AuthorAgeFilesLines
* Delete base/prefs and update callers to use components.brettw2016-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Deletes the forwarding headers in base/prefs. Updates the remaining users of base/prefs includes to use components/prefs. Sort headers in updated files. Move PrefServiceFactory out of the base namespace. Update users. Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to COMPONENTS_PREFS_. Add components/prefs to DEPS file of directories where checkdeps fails after the update. BUG=583034 Reland of http://crrev.com/1662523004#ps40001 with fix. TBR=estade@chromium.org Review URL: https://codereview.chromium.org/1668463002 Cr-Commit-Position: refs/heads/master@{#373197}
* Revert of Delete base/prefs and update callers to use components. (patchset ↵msw2016-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #3 id:40001 of https://codereview.chromium.org/1662523004/ ) Reason for revert: Broke Win Builder compile: https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463/steps/compile/logs/stdio Original issue's description: > Delete base/prefs and update callers to use components. > > Deletes the forwarding headers in base/prefs. > > Updates the remaining users of base/prefs includes to use components/prefs. > Sort headers in updated files. > > Move PrefServiceFactory out of the base namespace. Update users. > > Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to > COMPONENTS_PREFS_. > > Add components/prefs to DEPS file of directories where checkdeps fails after > the update. > > BUG=583034 > > Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef > Cr-Commit-Position: refs/heads/master@{#373105} TBR=estade@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583034 Review URL: https://codereview.chromium.org/1662843002 Cr-Commit-Position: refs/heads/master@{#373115}
* Delete base/prefs and update callers to use components.brettw2016-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | Deletes the forwarding headers in base/prefs. Updates the remaining users of base/prefs includes to use components/prefs. Sort headers in updated files. Move PrefServiceFactory out of the base namespace. Update users. Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to COMPONENTS_PREFS_. Add components/prefs to DEPS file of directories where checkdeps fails after the update. BUG=583034 Review URL: https://codereview.chromium.org/1662523004 Cr-Commit-Position: refs/heads/master@{#373105}
* ExtensionPrefs: remove FixMissingPrefstreib2016-01-191-21/+0
| | | | | | | | | | This added kPrefInstallTime for extensions that were installed before the install time pref was introduced, 5 years ago: https://codereview.chromium.org/5213002 BUG=none Review URL: https://codereview.chromium.org/1603463006 Cr-Commit-Position: refs/heads/master@{#370224}
* ExtensionPrefs: remove MigratePermissionstreib2016-01-191-57/+0
| | | | | | | | | | The pref change happened > 4 years ago (https://codereview.chromium.org/7003098), let's assume everything's migrated. BUG=none Review URL: https://codereview.chromium.org/1589403002 Cr-Commit-Position: refs/heads/master@{#370169}
* Extensions: remove DeprecatedDisableReasontreib2016-01-151-32/+0
| | | | | | | | | | | This was deprecated > 3 years ago in https://chromiumcodereview.appspot.com/10828316. Let's assume everything's migrated by now. BUG=none Review URL: https://codereview.chromium.org/1594553004 Cr-Commit-Position: refs/heads/master@{#369822}
* Switch to standard integer types in extensions/browser/.avi2015-12-231-5/+10
| | | | | | | | | BUG=138542 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1549643002 Cr-Commit-Position: refs/heads/master@{#366702}
* Convert Pass()→std::move() in //extensionsdcheng2015-12-181-5/+6
| | | | | | | | BUG=557422 Review URL: https://codereview.chromium.org/1537893002 Cr-Commit-Position: refs/heads/master@{#366120}
* Remove all the ephemeral apps code.benwells2015-12-091-48/+3
| | | | | | | | BUG=517735 Review URL: https://codereview.chromium.org/1497193002 Cr-Commit-Position: refs/heads/master@{#363918}
* Extensions sync: Create a whitelist of syncable disable reasonstreib2015-11-111-0/+8
| | | | | | | | BUG=542691,548333 Review URL: https://codereview.chromium.org/1431623003 Cr-Commit-Position: refs/heads/master@{#359069}
* [Extensions] Make const PermissionSet* const PermissionSet& where possiblerdevlin.cronin2015-09-301-22/+17
| | | | | | | | | | | | | | Replace a bunch of pointers with const&. TBR=pkotwicz@chromium.org (themes) TBR=atwilson@chromium.org (background) TBR=rogerta@chromium.org (ui/sync) BUG=455414 Review URL: https://codereview.chromium.org/1365443003 Cr-Commit-Position: refs/heads/master@{#351631}
* [Extensions] Un-refcount PermissionSetrdevlin.cronin2015-09-241-10/+10
| | | | | | | | | | | | | | | | | | | PermissionSet represents a set of permissions, and for some reason, it's been refcounted. There's really no reason to have it, and it makes everything more costly and difficult to reason about. Remove the refcounting. Note: This is part 1 of a 2-part series. This removes the ref-counting. In a followup, I'll go through and update many of the places that use const PermissionSet* and convert to const &. BUG=455414 TBR=thestig@chromium.org (misc chrome files with ptr conversion) TBR=nasko@chromium.org (extension messages - not actually changing any IPC messages) Review URL: https://codereview.chromium.org/1349613003 Cr-Commit-Position: refs/heads/master@{#350684}
* [Extensions] Make methods return refptrs for PermissionSetrdevlin.cronin2015-09-171-23/+17
| | | | | | | | | | PermissionSet is refcounted (why is another issue), but multiple functions are returning raw pointers to constructed PermissionSets, which makes for ugly casts and potential leaks. Make all functions return refptrs. Review URL: https://codereview.chromium.org/1353543002 Cr-Commit-Position: refs/heads/master@{#349497}
* ExtensionSyncService: listen for relevant changes instead of being ↵treib2015-08-261-19/+22
| | | | | | | | | | | | | explicitly called by clients. Also, various cleanup related to DisableReasons, which were sometimes set inconsistently vs. the extension's enabled state. ExtensionPrefs::SetExtensionState now also sets the disable reasons, to make sure they're updated at the same time as the enabled/disabled state. BUG=None Review URL: https://codereview.chromium.org/1296703003 Cr-Commit-Position: refs/heads/master@{#345577}
* Move ownership of AppSorting from ExtensionPrefs to ExtensionSystemtreib2015-08-061-26/+18
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1254363004 Cr-Commit-Position: refs/heads/master@{#342093}
* Extension syncing: Introduce a NeedsSync preftreib2015-07-211-0/+14
| | | | | | | | | | | | | that indicates the extension has local changes that still need to be synced. It's set when something changes before sync is ready, and cleared once the extension state has been synced. This should handle all conflicts between sync and local state reasonably well, and as a bonus allows us to get rid of the (weird and not-really-working) PendingEnables class. BUG=509990 Review URL: https://codereview.chromium.org/1240573012 Cr-Commit-Position: refs/heads/master@{#339651}
* Remove ExtensionPrefs::SetDidExtensionEscalatePermissions.treib2015-06-101-11/+3
| | | | | | | | | | The "DidExtensionEscalatePermissions" flag is basically equivalent to HasDisableReason(DISABLE_PERMISSIONS_INCREASE | DISABLE_REMOTE_INSTALL), so check that instead of storing a separate pref. BUG=493610 Review URL: https://codereview.chromium.org/1164603003 Cr-Commit-Position: refs/heads/master@{#333706}
* Extensions: Store disable reasons in Synctreib2015-05-201-24/+32
| | | | | | | | | | This will allow us (in a follow-up CL) to *not* grant permissions to extensions that come in via Sync disabled due to a permission increase. BUG=484214 Review URL: https://codereview.chromium.org/1136543003 Cr-Commit-Position: refs/heads/master@{#330727}
* Manually remove all existing occurences of PrefRegistrySyncable::UNSYNCABLE_PREFraymes2015-04-291-28/+8
| | | | | | | | | | | | Now that we have added PrefRegistry registration functions that do not need to accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is redundant and we can remove it altogether. BUG=476800 Review URL: https://codereview.chromium.org/1092683004 Cr-Commit-Position: refs/heads/master@{#327439}
* Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREFraymes2015-04-271-27/+11
| | | | | | | | | | | | | | | | | Now that we have added PrefRegistry registration functions that do not need to accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is redundant and we can remove it altogether. Ran the following command: for x in $(git ls-files | grep -E "\.(cc|h|mm)$") ; do perl -0777 -i -pe 's/,[ \n]*(user_prefs::)+PrefRegistrySyncable::UNSYNCABLE_PREF//igs' $x ; done && git cl format There are still some occurences that need to be manually fixed. BUG=476800 Review URL: https://codereview.chromium.org/1102733002 Cr-Commit-Position: refs/heads/master@{#326993}
* Added CHECKs for null pointers in ChromeAppSorting.mgiuca2015-04-241-0/+4
| | | | | | | | | | | | | | | These are designed to give us more information about production-only crashes occurring in ChromeAppSorting. These checks should help narrow down the times at which extension_scoped_prefs_ is null. Added TODOs to remove most of the checks later (although I plan to leave one in as a safeguard). BUG=476648 Review URL: https://codereview.chromium.org/1055453007 Cr-Commit-Position: refs/heads/master@{#326746}
* Code Cleanup for extension_prefs, as AddDisableReasons() is not required ↵deepak.m12015-04-161-5/+0
| | | | | | | | | | same behavior can be achieved by AddDisableReason(). BUG=475911 Review URL: https://codereview.chromium.org/1073153002 Cr-Commit-Position: refs/heads/master@{#325387}
* Fix for ERROR:url_pattern_set.cc(240)] Invalid url pattern: chrome://print/*deepak.m12015-04-151-0/+8
| | | | | | | | | | | | | This issue is due to usage of UserScript::ValidUserScriptSchemes() instead of UserScript::kValidUserScriptSchemes, we will add CHROMEUI scheme in valid schemes mask if extension is component extension. BUG=467230 Review URL: https://codereview.chromium.org/1025613003 Cr-Commit-Position: refs/heads/master@{#325197}
* Adding more metrics under ProfileImpl::OnPrefsLoaded. Trying to get a good ↵rkaplow2015-04-141-1/+13
| | | | | | | | | | view in what causes the latency there. BUG=454789 Review URL: https://codereview.chromium.org/1080063002 Cr-Commit-Position: refs/heads/master@{#325094}
* Clear extension last launched times when browser history is cleared.benwells2015-03-111-0/+20
| | | | | | | | | | | This should be cleared together for privacy reasons. To keep things simple, whenever any history is cleared all launch times are forgotten. BUG=405822 Review URL: https://codereview.chromium.org/977833002 Cr-Commit-Position: refs/heads/master@{#320047}
* Add more management policy checking after extension installedbinjin2014-11-181-9/+14
| | | | | | | | | | | | | | | This CL adds checking for MustRemainDisabled() from management policy after an extension is installed or updated, so that extensions supposed to be disabled will be disabled initially with proper disabled reason set. This CL also assumes that all disabled extension comes with proper disabled reason, so there are additional changes to ensure this. 1) Another extension disabled reason DISABLE_EXTERNAL_EXTENSION is added for external extensions. These extensions will be disabled initially on windows for user prompting. 2) Two tests from extension_disabled_ui_browsertest.cc is removed since these two tests are meant for legacy disables with not disabled reason set in user pref, which should be rarely seen now. And these rare cases are handled by presuming it's disabled by user action as well. BUG=None Review URL: https://codereview.chromium.org/714133002 Cr-Commit-Position: refs/heads/master@{#304587}
* Standardize usage of virtual/override/final in extensions/dcheng2014-10-211-3/+2
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/664933004 Cr-Commit-Position: refs/heads/master@{#300475}
* Refactoring of bubble controllers.merkulova2014-10-071-57/+0
| | | | | | | | | | Moving pref corresponding to bubble actions outside extension_prefs. BUG=175701 Review URL: https://codereview.chromium.org/577043002 Cr-Commit-Position: refs/heads/master@{#298480}
* replace OVERRIDE and FINAL with override and final in extensions/mostynb2014-10-031-1/+1
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/622343002 Cr-Commit-Position: refs/heads/master@{#298042}
* Deprecate direct use of legacy extension management preferencebinjin2014-09-121-21/+0
| | | | | | | | | | Use ExtensionManagement instead. BUG=177351 Review URL: https://codereview.chromium.org/555323002 Cr-Commit-Position: refs/heads/master@{#294688}
* Add StandardManagementPolicyProvider implementation based on ↵binjin2014-09-051-6/+0
| | | | | | | | | | | | | | | | | ExtensionManagement Service. Make ExtensionManagement listening to preference changes. Move all functionality of admin_policy into StandardManagementPolicyProvider, the latter was essentially a wrapper over admin_policy before. Merge admin_policy_unittest into extension_management_unittests with minor changes. BUG=177351 TEST=ExtensionServiceTest,ExtensionManagementTest,ExtensionAdminPolicyTest Review URL: https://codereview.chromium.org/500043003 Cr-Commit-Position: refs/heads/master@{#293514}
* Merge apps/pref* to extensions/browser/pref*hashimoto2014-08-251-0/+6
| | | | | | | | | | | | | | | The pref's exclusive user AppWindow will move to extensions/browser Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h} Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc BUG=403726 Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7 Review URL: https://codereview.chromium.org/493003002 Cr-Commit-Position: refs/heads/master@{#291655}
* Revert of Merge apps/pref* to extensions/browser/pref* (patchset #1 of ↵machenbach2014-08-251-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/493003002/) Reason for revert: Breaks GN: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/10608 Original issue's description: > Merge apps/pref* to extensions/browser/pref* > > The pref's exclusive user AppWindow will move to extensions/browser > > Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h} > Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc > > BUG=403726 > TBR=bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc. > > Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7 TBR=benwells@chromium.org,bauerb@chromium.org,bartfab@chromium.org,hashimoto@chromium.org NOTREECHECKS=true NOTRY=true BUG=403726 Review URL: https://codereview.chromium.org/499253002 Cr-Commit-Position: refs/heads/master@{#291652}
* Merge apps/pref* to extensions/browser/pref*hashimoto2014-08-251-0/+6
| | | | | | | | | | | | | | The pref's exclusive user AppWindow will move to extensions/browser Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h} Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc BUG=403726 TBR=bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc. Review URL: https://codereview.chromium.org/493003002 Cr-Commit-Position: refs/heads/master@{#291650}
* Extensions: Move id_util functions to crx_file component.tommycli@chromium.org2014-08-211-18/+19
| | | | | | | | | | | | | | Consolidates id_util functions of extension/app/component ids in the crx_file component. It belongs there because these types of ids are not exclusive to extensions, but rather, for anything that comes in a crx file. BUG=371463 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/481433005 Cr-Commit-Position: refs/heads/master@{#290971} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290971 0039d316-1c4b-4281-b951-d872f2087c98
* Make runtime.reload() work with component extensions.amistry@chromium.org2014-08-141-29/+18
| | | | | | | | | | | This eliminates the ENABLED_COMPONENT state, and fixes the path CHECK failure. BUG=402377 Review URL: https://codereview.chromium.org/462533002 Cr-Commit-Position: refs/heads/master@{#289616} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289616 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated kBrowserActionContainerWidth prefrdevlin.cronin@chromium.org2014-08-131-11/+0
| | | | | | | | | | We migrated to the new kToolbarSize pref over four years ago. I think this is safe to remove. :) Review URL: https://codereview.chromium.org/451193003 Cr-Commit-Position: refs/heads/master@{#289184} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289184 0039d316-1c4b-4281-b951-d872f2087c98
* Augment PrefHashFilter with the ability to cleanup deprecated tracked ↵gab@chromium.org2014-08-011-6/+0
| | | | | | | | | | | | | | | | preferences and their matching MAC. The time has come where some tracked preferences are starting to be deprecated and keeping them declared solely for the sake of having them migrated back to the unprotected store by TrackedPreferencesMigrator only to be cleared from that store shortly after is adding overhead (and furthermore with that technique only the value would be cleaned up, not its matching MAC). Implemented in CleanupDeprecatedTrackedPreferences() in pref_hash_filter.cc and added a comment pointing to it from kTrackedPrefs. Review URL: https://codereview.chromium.org/432533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287050 0039d316-1c4b-4281-b951-d872f2087c98
* Additional metrics for disabled extensions and content verificationasargent@chromium.org2014-07-251-0/+15
| | | | | | | | BUG=396319 Review URL: https://codereview.chromium.org/412003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285688 0039d316-1c4b-4281-b951-d872f2087c98
* Do not assign launch ordinals to ephemeral appstmdiep@chromium.org2014-07-211-4/+10
| | | | | | | | | | | | | | | | | | Ephemeral apps are not shown in the app launcher or NTP, but they are assigned ordinals, which results in unfilled NTP pages. This patch does not give ephemeral apps launch ordinals until they are promoted to fully installed apps. AppSorting::MarkExtensionAsHidden() was refactored to AppSorting::SetExtensionVisible() to allow the visibility of the extension in the NTP to change. BUG=394192 TEST=browser_tests Review URL: https://codereview.chromium.org/397903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284536 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for re-enabling more MSVC level 4 warnings: misc edition #2pkasting@chromium.org2014-07-181-2/+2
| | | | | | | | | | | | | | | | | | This contains fixes for the following sorts of issues: * Assignment inside conditional * Taking the address of a temporary * Octal escape sequence terminated by decimal number * Signedness mismatch * Possibly-uninitialized local variable This also contains a small number of cleanups to nearby code (e.g. no else after return). BUG=81439 TEST=none Review URL: https://codereview.chromium.org/382673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
* Extirpate CreateBooleanValue.estade@chromium.org2014-07-171-5/+6
| | | | | | | | BUG=160586 Review URL: https://codereview.chromium.org/399433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283619 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Consolidate kBrowserActionContainerWidth pref registrationtapted@chromium.org2014-07-091-1/+6
| | | | | | | | | | | | | | | | This pref is currently registered in different places for Mac and toolkit-views, resulting in problems for toolkit-views on Mac (i.e. it gets registered twice). The views pref moved into extension_prefs.cc in r183799. This moves the mac pref to the same place for increased code cohesion, simplifying a lot of things. BUG=155525, 390755 Review URL: https://codereview.chromium.org/378153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282177 0039d316-1c4b-4281-b951-d872f2087c98
* Fully installed apps should not have the ephemeral_app flag set in extension ↵tmdiep@chromium.org2014-06-251-6/+22
| | | | | | | | | | | | | | prefs The "ephemeral_app" flag is only written to extension prefs for ephemeral apps and removed when the app is fully installed. BUG=None TEST=browser_tests (EphemeralAppBrowserTest.*) Review URL: https://codereview.chromium.org/342593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279616 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the known_disabled feature as it is now superseeded by settings ↵gab@chromium.org2014-06-231-9/+4
| | | | | | | | | | protection. BUG=312883 Review URL: https://codereview.chromium.org/340093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279171 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the ability to retain local data of evicted ephemeral appstmdiep@chromium.org2014-06-181-78/+3
| | | | | | | | | | This is effectively a revert of http://crrev.com/202763005 BUG=339004 Review URL: https://codereview.chromium.org/337323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277972 0039d316-1c4b-4281-b951-d872f2087c98
* Add a do_not_sync pref to ExtensionPrefs.xiyuan@chromium.org2014-06-141-0/+18
| | | | | | | | | | | | | | | Split from https://codereview.chromium.org/308003005/ for extensions system changes that allows to install a none syncable Extension. - Add a do_not_sync pref to ExtensionPrefs; - Add a kInstallFlagDoNotSync that CrxInstaller uses to initialize the pref; - Update util::ShouldSyncApp and add ShouldSyncExtension to use the pref to skip sync in ExtensionSyncService; BUG=358791 Review URL: https://codereview.chromium.org/323843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277269 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Make ExtensionService:: and ExtensionPrefs::OnExtensionInstalledkalman@chromium.org2014-06-131-11/+9
| | | | | | | | | | | | | | take a bitmask instead of 4 boolean values (soon to be 5). As part of that, change the default-true flag "wait for idle" to a default-false flag "install immediately". R=asargent@chromium.org TBR=estade@chromium.org, atwilson@chromium.org, dimich@chromium.org Review URL: https://codereview.chromium.org/322893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276999 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extension override bubble and warning box for proxy extensions. (2nd ↵finnur@chromium.org2014-06-071-0/+14
| | | | | | | | | | | | | | | | attempt, this time with two one-liner test fixes) Also use the browser action highlighting for extensions that have a browser action icon. NOTE: This CL was already green-lighted here: https://codereview.chromium.org/288923004/ BUG=381291 TBR=sky, devlin, dbeam Review URL: https://codereview.chromium.org/320633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275577 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 275229 "Add an extension override bubble and warning box ..."finnur@chromium.org2014-06-051-14/+0
| | | | | | | | | | | | | | | | | > Add an extension override bubble and warning box for proxy extensions. > > Also use the browser action highlighting for extensions that have a browser action icon. > > BUG=381291 > R=dbeam@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/288923004 TBR=finnur@chromium.org Review URL: https://codereview.chromium.org/312403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275255 0039d316-1c4b-4281-b951-d872f2087c98