summaryrefslogtreecommitdiffstats
path: root/extensions/common/extension_builder.h
Commit message (Collapse)AuthorAgeFilesLines
* Make extensions::DictionaryBuilder and extensions::ListValue unmovable.dcheng2016-02-271-6/+3
| | | | | | | | | | | | | | | | | | | There's no reason for these classes to be movable. std::move() is just being used as a synonym for Build(). In addition: - Build() is fewer characters than std::move(). - clang-format works better when builder syntax is consistently used, which makes it easier for readers to visually match up deeply nested builders. - It's surprising to see std::move() used with what looks like a temporary. BUG=none Review URL: https://codereview.chromium.org/1739183003 Cr-Commit-Position: refs/heads/master@{#378107}
* Switch to standard integer types in extensions/.avi2015-12-231-0/+1
| | | | | | | | | BUG=138542 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1543053002 Cr-Commit-Position: refs/heads/master@{#366716}
* Use rvalue reference instead of extensions::DictionaryBuilder::pass()limasdf2015-12-191-1/+1
| | | | | | | | | | | C++ 11 enables rvalue reference with std::move() so that removing DictionaryBuilder::Pass(). BUG=563649 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1532193003 Cr-Commit-Position: refs/heads/master@{#366280}
* Use rvalue reference instead of ExtensionBuilder::pass()limasdf2015-12-181-4/+6
| | | | | | | | | | | C++ 11 enables rvalue reference with std::move() so that removing legacy ListBuilder::Pass(). BUG=563649 TBR=thankis@chromium.org Review URL: https://codereview.chromium.org/1511103003 Cr-Commit-Position: refs/heads/master@{#365969}
* Clean-up coding stylehaibane84@gmail.com2014-04-161-1/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/238383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264144 0039d316-1c4b-4281-b951-d872f2087c98
* Moved extension and value builder code to extensions component.benwells@chromium.org2013-11-051-0/+63
This is only used by tests but it has no chrome dependencies, and test in extensions use it, so it should move down to. TBR=sky@chromium.org BUG=162530 Review URL: https://codereview.chromium.org/48643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233119 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-08 03:25:22 +0000