| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
One of these was for internal testing only, and the other no longer
exists.
BUG=281715
R=asargent@chromium.org
Review URL: https://codereview.chromium.org/1831403002
Cr-Commit-Position: refs/heads/master@{#383352}
|
|
|
|
|
|
|
|
|
|
|
| |
R=sergiyb@chromium.org
TBR=treib
BUG=583578
Review URL: https://codereview.chromium.org/1818423002 .
Cr-Commit-Position: refs/heads/master@{#382816}
|
|
|
|
|
|
|
|
| |
BUG=595168
Review URL: https://codereview.chromium.org/1806723003
Cr-Commit-Position: refs/heads/master@{#381591}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upcoming changes in the Chrome OS networking daemon (shill) will allow
third party VPNs to transition "backwards" from Online->Configuring if
the default physical connection changes. Add a "reconnect" flag so
that VPN apps can signal their compatibility with this new scheme,
and add the necessary UI changes so that Chrome can identify
reconnections and present them to the user in a sensible way.
Also, change the UI so that users can cancel VPN reconnections
(and connections) using the "Disconnect" button.
BUG=514343
Review URL: https://codereview.chromium.org/1722453002
Cr-Commit-Position: refs/heads/master@{#381566}
|
|
|
|
|
|
|
|
|
|
|
| |
Add a bunch of private APIs to the list that will get presubmit checks. Also
normalize the paths and check that each exists.
BUG=469920
Review URL: https://codereview.chromium.org/1761663002
Cr-Commit-Position: refs/heads/master@{#380488}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message
TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*
BUG=593194
Review URL: https://codereview.chromium.org/1781563003
Cr-Commit-Position: refs/heads/master@{#380386}
|
|
|
|
|
|
|
|
| |
BUG=554293
Review URL: https://codereview.chromium.org/1774443002
Cr-Commit-Position: refs/heads/master@{#380369}
|
|
|
|
|
|
|
|
| |
BUG=554987
Review URL: https://codereview.chromium.org/1773593004
Cr-Commit-Position: refs/heads/master@{#380001}
|
|
|
|
|
|
|
|
| |
BUG=533086
Review URL: https://codereview.chromium.org/1774103002
Cr-Commit-Position: refs/heads/master@{#379840}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce binding time as much as possible, use std::map(O(1)) instead of std::vector(O(n)).
Also, use 'const_iterator' to fix improper usage of 'auto'.
BUG=592537
TEST=Every tests are green.
Review URL: https://codereview.chromium.org/1772683002
Cr-Commit-Position: refs/heads/master@{#379711}
|
|
|
|
|
|
|
|
|
| |
BUG=556939
TBR=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/1768103002
Cr-Commit-Position: refs/heads/master@{#379547}
|
|
|
|
|
|
|
|
|
| |
BUG=514768
TBR=sky@chromium.org (trivial c/b/ui changes)
Review URL: https://codereview.chromium.org/1761913003
Cr-Commit-Position: refs/heads/master@{#379336}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to avoid any
security issues with this, going forward.
Both of the uses of URL_SPECIAL_CHARS in file_util.cc look problematic,
so modifying them to no longer escape paragraph separators, and adding
a pair of tests.
BUG=589257
Review URL: https://codereview.chromium.org/1760073003
Cr-Commit-Position: refs/heads/master@{#379291}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.
BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
Review URL: https://codereview.chromium.org/1722773002
Cr-Commit-Position: refs/heads/master@{#379122}
|
|
|
|
|
|
|
|
| |
BUG=591783
Review URL: https://codereview.chromium.org/1757383003
Cr-Commit-Position: refs/heads/master@{#379120}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1722773002/ )
Reason for revert:
Broke compile on iOS_Simulator_GN_(dbg): https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29/builds/1777
Original issue's description:
> Move GURL ParamTraits to url/ipc
>
> As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
> content/. One such dependency is GURL. As per discussion here:
> https://codereview.chromium.org/1703163002/, the plan of record is to move
> GURL ParamTraits out of content/ and into url/.
>
> BUG=586368
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
> Cr-Commit-Position: refs/heads/master@{#378859}
TBR=fsamuel@chromium.org,piman@chromium.org,brettw@chromium.org,tsepez@chromium.org,thakis@chromium.org,markdittmer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=586368
Review URL: https://codereview.chromium.org/1755363003
Cr-Commit-Position: refs/heads/master@{#378869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.
BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1722773002
Cr-Commit-Position: refs/heads/master@{#378859}
|
|
|
|
|
|
|
|
|
|
| |
Removes ~4100 sloc, and 50k off the binary size.
BUG=542912
Review URL: https://codereview.chromium.org/1695563002
Cr-Commit-Position: refs/heads/master@{#378624}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WDS library implements a Wi-Fi Display dialect of RTSP
that includes the parser, actual negotiation logic for sink
and source, and the related data structures.
This patch contains initial implementation of WDS library
embedder interfaces.
BUG=242107
Review URL: https://codereview.chromium.org/1698473004
Cr-Commit-Position: refs/heads/master@{#378182}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's no reason for these classes to be movable. std::move() is just
being used as a synonym for Build().
In addition:
- Build() is fewer characters than std::move().
- clang-format works better when builder syntax is consistently used,
which makes it easier for readers to visually match up deeply nested
builders.
- It's surprising to see std::move() used with what looks like a
temporary.
BUG=none
Review URL: https://codereview.chromium.org/1739183003
Cr-Commit-Position: refs/heads/master@{#378107}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=reillyg@chromium.org, dcheng@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1724293002
Cr-Commit-Position: refs/heads/master@{#378054}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a presubmit script that checks for when extension api files are touched, but
the corresponding extern file is not. Right now, this is very simple - it only
checks that the extern is modified in some way (doesn't validate that it's the
*right* way), and is only a warning (because sometimes api file changes don't
cause extern changes). As an improvement, we would validate that the extern
files contain the proper content - let's do that later.
This will also be rolled out piecemeal, since many APIs don't currently have a
dedicated extern file. This change only imposes the check on bluetooth (because
it was handy) - if all goes well, we'll roll this out to all api files.
Also establish a dedicated extern folder, since it's silly for chrome-generated
externs to live in third_party/.
BUG=469920
Review URL: https://codereview.chromium.org/1718243003
Cr-Commit-Position: refs/heads/master@{#378018}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.
The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion
callback call (which is more natural since this problem is
detected before a new session is started).
JS bindings code is simplified.
BUG=242107
Review URL: https://codereview.chromium.org/1730583002
Cr-Commit-Position: refs/heads/master@{#377864}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Packaged apps do not support a persistent background page, so the
manifest entry is ignored. To make this more obvious, this CL adds a
warning when validating the manifest.
R=rockot@chromium.org,asargent@chromium.org
BUG=586535
Review URL: https://codereview.chromium.org/1701523002
Cr-Commit-Position: refs/heads/master@{#377775}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change introduces a "include_directories" entry in the manifest
file for file_handlers. In case the value is true, the file handler
becomes a generic handler and adds the given extension to the right
click menu.
BUG=415897
R=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/1407473003
Cr-Commit-Position: refs/heads/master@{#377467}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch clarifies that the transfer length is only the maximum number
of bytes that will be read from the device as the device is allowed to
respond with a short packet.
BUG=578508
Review URL: https://codereview.chromium.org/1724203002
Cr-Commit-Position: refs/heads/master@{#377163}
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:587613
TEST=None
Review URL: https://codereview.chromium.org/1724863002
Cr-Commit-Position: refs/heads/master@{#377144}
|
|
|
|
|
|
|
|
| |
BUG=588179
Review URL: https://codereview.chromium.org/1717723002
Cr-Commit-Position: refs/heads/master@{#376523}
|
|
|
|
|
|
|
|
| |
BUG=500075
Review URL: https://codereview.chromium.org/1705373002
Cr-Commit-Position: refs/heads/master@{#376276}
|
|
|
|
|
|
|
|
|
|
| |
picker.
BUG=557222
Review URL: https://codereview.chromium.org/1688973003
Cr-Commit-Position: refs/heads/master@{#376257}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch reduces amount of possible session error types and
makes them more generic (less WiFi Display oriented).
BUG=242107
Review URL: https://codereview.chromium.org/1689913003
Cr-Commit-Position: refs/heads/master@{#375437}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use mediaGalleries.getMetadata API to fetch media metadata in our Files.app(Chrome OS FileManager).
We pass the blob object(~binary data) to the API,
so we don't need any permissions.
This API has "read" permission, but this permission means "reading files in the MediaGallery", but we don't read it - the blob objects we pass is from filesystem, not from MediaGallery.
We need "empty" permissions, but if we pass a empty list as permissions, it causes permission error and the app doesn't start at all.
In this patch, I introduce a permission without sub-permissions,
and you can specify this permission in a manifest file like:
> "mediaGalleries",
https://developer.chrome.com/apps/mediaGalleries
BUG=581614
Review URL: https://codereview.chromium.org/1643183002
Cr-Commit-Position: refs/heads/master@{#375400}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch provides several fixes and improvements (simplifications)
to the session life cycle notification mechanism:
1) The 'startSession'/'terminateSession' call completion callbacks are
invoked when the session is actually started/terminated and in accordance
with 'onSessionStarted'/'onSessionTerminated' events propagating (and as
per documentation).
2) The notification from the required sink is filtered out in browser process
avoiding unneeded IPC calls
3) Methods in mojo interface are renamed in order to improve readability
BUG=242107
Review URL: https://codereview.chromium.org/1674583002
Cr-Commit-Position: refs/heads/master@{#374929}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a generic required_field_trials to FeatureSwitch that takes the
place of a singular field_trial_name. When deciding whether to enable or
disable a feature with field trials, all field trials will be queried
(though short circuiting can occur):
- If user is in "Enabled" group for all field trials, then enable
feature.
- If user is in "Disabled group for any field trials, then disable
feature.
- Otherwise, fall back to default value.
Change the MR FeatureSwitches to depend on the EAR field trial. Per
discussion, we will change the interpretation of MR field trial to
be "X% of users that have EAR field trial enabled".
BUG=541315
Review URL: https://codereview.chromium.org/1680823004
Cr-Commit-Position: refs/heads/master@{#374834}
|
|
|
|
|
|
|
|
|
|
|
|
| |
uint64_t for IPC safety.
Also add a few checked_cast for places where we converted from size_t and we're sure that it's safe.
BUG=581409
Review URL: https://codereview.chromium.org/1684793003
Cr-Commit-Position: refs/heads/master@{#374788}
|
|
|
|
|
|
|
|
|
|
|
| |
All users are on the new EDK now. This wipes out third_party/mojo,
updates all dependencies, and removes the use-new-edk flag.
BUG=None
Review URL: https://codereview.chromium.org/1676913002
Cr-Commit-Position: refs/heads/master@{#374631}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The argument to the createConfig() callback is an undefined variable
on error. It is not an empty string.
BUG=580760
TEST=chrome.vpnProvider.createConfig("", function(x) {
console.debug(typeof(x)); })
TEST=chrome.vpnProvider.createConfig("duplicate_name", function(x) {
console.debug(typeof(x)); })
Review URL: https://codereview.chromium.org/1628763002
Cr-Commit-Position: refs/heads/master@{#374504}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of size_t.
size_t's size depends on the architecture. We need IPCs to match as we're now going to support 32 and 64 bit processes communicating on Android.
This is split off from https://codereview.chromium.org/1619363002/.
BUG=581409
Review URL: https://codereview.chromium.org/1676093003
Cr-Commit-Position: refs/heads/master@{#374268}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Cache required_platform_version info in KioskAppData and
in LocalState;
- Add a KioskAppManager::GetAutoLaunchAppRequiredPlatformVersion to
expose the info for auto launched app;
BUG=577783
TEST=KioskAppManagerTest.*
Review URL: https://codereview.chromium.org/1636813002
Cr-Commit-Position: refs/heads/master@{#374214}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a documentation-only change.
Disabling presubmit checks, due to "noparent" settings for the following files:
components/policy/resources/policy_templates.json
content/common/font_config_ipc_linux.h
BUG=567488
NOPRESUBMIT=true
TBR=atwilson,dcheng
Review URL: https://codereview.chromium.org/1592403002
Cr-Commit-Position: refs/heads/master@{#374213}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Re-implemented https://codereview.chromium.org/952473002/, with all
checks at the browser side instead of just the renderer.
- Use the last committed URL for checking permissions instead of the
visible URL. As a result, executeScript/insertCSS will now succeed in
frames where the currently committed page is scriptable by extensions,
but the target of the pending navigation is is not.
- ExecuteScript: Do not send IPC to non-live frames (they're not going
to reply anyway).
- Include URL in the error if the extension has the tabs permission
(follow-up to TODO from https://codereview.chromium.org/1414223005).
BUG=63979,551626
TEST=./browser_tests --gtest_filter=ExecuteScriptApiTest.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1628423002
Cr-Commit-Position: refs/heads/master@{#374057}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I searched for "length() - 1]", which won't find all potential sites to use
back(), but should hit a reasonable number. These were all converted.
I don't consider str.front() to be vastly more readable than str[0], so I made
no effort to seek these out and change them. I did change code to use front()
when it would make for better parallel structure with a place I was making use
back(), e.g.:
if (str[0] == 'x' && str[str.length() - 1] == 'y') {
...was transformed to:
if (str.front() == 'x' && str.back() == 'y') {
...and not:
if (str[0] == 'x' && str.back() == 'y') {
I also added front() and back() methods to StringPiece so people wouldn't need to distinguish between string and StringPiece for these purposes.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1663253004
Cr-Commit-Position: refs/heads/master@{#373672}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
more source type "audio".
With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.
Current functionality is behind flag
--enable-audio-support-for-desktop-share.
Design Doc is at https://goo.gl/yIJ08b
This CL is implementation of Use Case 4.a
BUG=557222
Review URL: https://codereview.chromium.org/1644073002
Cr-Commit-Position: refs/heads/master@{#373576}
|
|
|
|
|
|
|
|
|
|
| |
GURL::GetOrigin does not do the right thing for all types of URLs.
BUG=573317
Review URL: https://codereview.chromium.org/1658913002
Cr-Commit-Position: refs/heads/master@{#373381}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes consumers of IPC::Message to generally refer
refer to base::Pickle instead when performing serialization
and deserialization operations. The few specific instances
where the IPC::Message interface (Read/WriteAttachent) is
needed can safely be static_cast'd, as IPC::Message is the
only public subclass of base::Pickle.
The purpose of this change is to facilitate the transition
to Mojo IPC, as we've trained the Mojo bindings layer to
use existing ParamTraits<T> parameterized over base::Pickle.
To support this base::Pickle has had some stub interfaces
added for WriteAttachment and ReadAttachment, along with a
Pickle::Attachment.
A follow-up patch will add sizing traits to the standard
IPC_STRUCT macros, enabling the majority of Chrome IPC
structs to be carried over Mojo message pipes as-is.
BUG=577685
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1659003003
Cr-Commit-Position: refs/heads/master@{#373323}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add pieces in ActiveScriptController to handle web requests being blocked by
click-to-script (--scripts-require-action). Right now, these are only stubs -
the next patch will actually call them.
BUG=460306
Review URL: https://codereview.chromium.org/1646133002
Cr-Commit-Position: refs/heads/master@{#373064}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBRing trivial include changes
TBR=derat@chromium.org
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/1654043002
Cr-Commit-Position: refs/heads/master@{#372945}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements webview.captureVisibleRegion(), an extension/apps
API to allow WebView users to capture screenshots of the contents
displayed in a WebView. The surfaces contents capture has been plumbed
via RenderWidgetHostViewChildFrame so this implementation should not
require changes when WebView switches to using OOPIF.
As part of the implementation, there are two notable refactors:
1) CaptureWebContentsFunction has been refactored into
WebContentsCaptureClient to remove the extensions::AsyncExtensionFunction
dependence so that this code can be used by both tabs.captureVisibleTab
and webview.captureVisibleRegion, and
2) common code from DelegatedFrameHost has ben moved to
content/browser/compositor/surface_utils.* in order to avoid duplication
as both DelegatedFrameHost and RenderWidgetHostViewChildFrame now
use the code.
Finally, this CL adds a surface-drawn callback to
RenderWidgetHostViewChildFrame, to allow deferring a
screen capture request until a frame has actually been
drawn. This callback can be used to simplify some
existing tests.
BUG=326755
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1635513003
Cr-Commit-Position: refs/heads/master@{#372799}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added some information about:
-user gesture requirement
-native confirmation UI
BUG=178319
Review URL: https://codereview.chromium.org/1649803002
Cr-Commit-Position: refs/heads/master@{#372143}
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/1551423003
Cr-Commit-Position: refs/heads/master@{#372106}
|