| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
GetValidLocales is already called on first extension install. There's no need to check the locales again (i.e. on extension loading) until a new install. GetValidLocales can be costly since it stats all subdirectories and messages.json of an extension's _locales subfolder.
BUG=516745
Committed: https://crrev.com/0db5da63004e13f458c5a76391da1b309222d71e
Cr-Commit-Position: refs/heads/master@{#343805}
Review URL: https://codereview.chromium.org/1281523005
Cr-Commit-Position: refs/heads/master@{#344269}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1281523005/ )
Reason for revert:
Test breakage in build http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/46007 .
Stack traces point to extension_l10n_util.
Original issue's description:
> Remove extraneous GetValidLocales calls.
>
> GetValidLocales is already called on first extension install. There's no need to check the locales again (i.e. on extension loading) until a new install. GetValidLocales can be costly since it stats all subdirectories and messages.json of an extension's _locales subfolder.
>
> BUG=516745
>
> Committed: https://crrev.com/0db5da63004e13f458c5a76391da1b309222d71e
> Cr-Commit-Position: refs/heads/master@{#343805}
TBR=asargent@chromium.org,erikchen@chromium.org,robliao@chromium.org,sydli@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516745
Review URL: https://codereview.chromium.org/1298093005
Cr-Commit-Position: refs/heads/master@{#343844}
|
| |
|
|
|
|
|
|
|
|
| |
GetValidLocales is already called on first extension install. There's no need to check the locales again (i.e. on extension loading) until a new install. GetValidLocales can be costly since it stats all subdirectories and messages.json of an extension's _locales subfolder.
BUG=516745
Review URL: https://codereview.chromium.org/1281523005
Cr-Commit-Position: refs/heads/master@{#343805}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They don't need to run in Chrome's unit_tests suite any more.
* Move ExtensionL10UtilTest
* Move FileUtilTest
* Keep browser action and page action tests in Chrome, since those are
Chrome-specific concepts
This CL depends on https://codereview.chromium.org/565423003/ for cleanup
of _manifest_features.json
BUG=397165
TEST=extensions_unittests, unit_tests
Review URL: https://codereview.chromium.org/562273006
Cr-Commit-Position: refs/heads/master@{#295605}
|
| |
|
|
|
|
|
|
| |
extensions/
Review URL: https://codereview.chromium.org/558833002
Cr-Commit-Position: refs/heads/master@{#294136}
|
|
|
There are three important changes in this CL, all
interdependent enough that it seemed best to tackle
them at the same time.
1. message_bundle moves to //extensions. (mechanical)
2. extension_l10n_util moves to //extensions. (mechanical)
3. MessageBundle-related functionality from
//chrome/c/e/extension_file_util has been
moved into //extensions/common/file_util
to support the move of extension_l10n_util.
BUG=359836
TBR=sky@chromium.org for chrome/utility, browser_process_impl
TBR=kalman@chromium.org for tabs API
TBR=zork@chromium.org for //c/b/chromeos/input_method
TBR=satorux@chromium.org for //c/b/chromeos/e/file_manager
Review URL: https://codereview.chromium.org/228073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262552 0039d316-1c4b-4281-b951-d872f2087c98
|
