| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/1543053002
Cr-Commit-Position: refs/heads/master@{#366716}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running app_shell-based tests the content shell data path should be
set to the test data directory so that tests do not interfere with each
other or result in persistent state changes. This is what is done by the
ContentTestLauncherDelegate for content_shell-based tests.
BUG=483328
Review URL: https://codereview.chromium.org/1118183002
Cr-Commit-Position: refs/heads/master@{#328400}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We would like to use app_shell as the basis for all
content-browser integration tests within the
extensions layer.
This simply moves the test target up to the parent
//extensions path and renames it to
extensions_browsertests
BUG=388893
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/797023006
Cr-Commit-Position: refs/heads/master@{#312669}
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a new function for unloading extensions
to ShellApiTest. It is needed by
SocketTCPServerUnbindOnUnload and others tests as
we migrate them.
Review URL: https://codereview.chromium.org/854703003
Cr-Commit-Position: refs/heads/master@{#312410}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Very basic support for app_shell on Mac cocoa. It allows building and running app_shell, app_shell_unittests, and app_shell_browsertests on Mac. It introduces app_shell_framework and app_shell_helper targets. Much of the work is based on the content_shell equivalents.
The above targets build as part of 'all' on Mac, but are not yet covered by trybots.
Shortcomings compared to Aura:
- The AppShell desktop controller doesn't support tracking multiple app windows.
- Running App Shell --load-apps works (at least for the Calculator sample) but can only be exited via ^C at the command line, and there is no Mac menu.
BUG=399363
Review URL: https://codereview.chromium.org/745093002
Cr-Commit-Position: refs/heads/master@{#309256}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add the LoadExtension method to ShellApiTest used by
several test cases. This method returns an Extension instance
that can be used for recoverying the MainFrame and injecting
JavaScript commands.
BUG=392842
Review URL: https://codereview.chromium.org/764763003
Cr-Commit-Position: refs/heads/master@{#306607}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-Aura implementations.
Rename ShellDesktopController to ShellDesktopControllerAura; make ShellNativeAppWindow implement only some of the BaseWindow methods, and move aura-specific bits to ShellNativeAppWindowAura. Adds a unit test for ShellNativeAppWindowAura.
This is a precursor to a Cocoa implementation for Mac.
BUG=399363
TBR=danakj@chromium.org,reed@google.com
Review URL: https://codereview.chromium.org/696063008
Cr-Commit-Position: refs/heads/master@{#304897}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/667153007
Cr-Commit-Position: refs/heads/master@{#301453}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* To load the apps you can specify a comma-separated list in the command-line.
For example: 'app_shell --app-shell-app-path=path/to/app1/,path/to/app2'
* For now there's no API to control the focus of the apps, so the only way
to switch apps is to either close the app_window (which will switch focus to
the next app in the hierarchy) or using the aura::Window API directly and
calling Focus() on the windows.
BUG=422618
Review URL: https://codereview.chromium.org/642383003
Cr-Commit-Position: refs/heads/master@{#301135}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/664933004
Cr-Commit-Position: refs/heads/master@{#300475}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the following tests to app_shell_browsertest:
- TestDialogAlert
- TestDialogConfirm
- TestDialogConfirmCancel
- TestDialogConfirmDefaultCancel
- TestDialogConfirmDefaultGCCancel
- TestDialogPrompt
Also, makes sure that we call content::BrowserTestBase::SetUpCommandLine(...) from AppShellTest.
BUG=352293
Review URL: https://codereview.chromium.org/634403003
Cr-Commit-Position: refs/heads/master@{#299121}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/622343002
Cr-Commit-Position: refs/heads/master@{#298042}
|
|
|
|
|
|
|
|
|
|
|
|
| |
is separated out from AppShellTest.
Move the remaining DnsApiTest to app_shell_browsertests.
BUG=388893
Review URL: https://codereview.chromium.org/529293003
Cr-Commit-Position: refs/heads/master@{#293517}
|
|
This does:
- Move files
- Fix up all namespaces in these files to be extensions, not apps
- Clean up DEPS files
This does not:
- Change the name of the build targets (app_shell, app_shell_browsertests)
BUG=394987
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/412713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285144 0039d316-1c4b-4281-b951-d872f2087c98
|