summaryrefslogtreecommitdiffstats
path: root/extensions/utility
Commit message (Collapse)AuthorAgeFilesLines
* Replace base::Tuple in //extensions with std::tupletzik2016-03-091-1/+2
| | | | | | | | BUG=554987 Review URL: https://codereview.chromium.org/1773593004 Cr-Commit-Position: refs/heads/master@{#380001}
* Move GURL ParamTraits to url/ipcmarkdittmer2016-03-031-1/+0
| | | | | | | | | | | | | | | | | As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on content/. One such dependency is GURL. As per discussion here: https://codereview.chromium.org/1703163002/, the plan of record is to move GURL ParamTraits out of content/ and into url/. BUG=586368 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa Cr-Commit-Position: refs/heads/master@{#378859} Review URL: https://codereview.chromium.org/1722773002 Cr-Commit-Position: refs/heads/master@{#379122}
* Revert of Mustash: Move GURL ParamTraits to url/ipc (patchset #18 id:330001 ↵dimich2016-03-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1722773002/ ) Reason for revert: Broke compile on iOS_Simulator_GN_(dbg): https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29/builds/1777 Original issue's description: > Move GURL ParamTraits to url/ipc > > As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on > content/. One such dependency is GURL. As per discussion here: > https://codereview.chromium.org/1703163002/, the plan of record is to move > GURL ParamTraits out of content/ and into url/. > > BUG=586368 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa > Cr-Commit-Position: refs/heads/master@{#378859} TBR=fsamuel@chromium.org,piman@chromium.org,brettw@chromium.org,tsepez@chromium.org,thakis@chromium.org,markdittmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586368 Review URL: https://codereview.chromium.org/1755363003 Cr-Commit-Position: refs/heads/master@{#378869}
* Move GURL ParamTraits to url/ipcmarkdittmer2016-03-021-1/+0
| | | | | | | | | | | | | | As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on content/. One such dependency is GURL. As per discussion here: https://codereview.chromium.org/1703163002/, the plan of record is to move GURL ParamTraits out of content/ and into url/. BUG=586368 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1722773002 Cr-Commit-Position: refs/heads/master@{#378859}
* Reland of Change extension icon load errors to warnings (patchset #2 ↵estade2015-12-291-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:300001 of https://codereview.chromium.org/1554583002/ ) Reason for revert: this revert managed to break the tree Original issue's description: > Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ ) > > Reason for revert: > file read from wrong thread > > Original issue's description: > > Change extension icon load errors to warnings > > > > During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary. > > > > Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake. > > > > BUG=570249 > > > > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b > > Cr-Commit-Position: refs/heads/master@{#366253} > > TBR=rdevlin.cronin@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=570249 > > Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31 > Cr-Commit-Position: refs/heads/master@{#367080} TBR=rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570249 Review URL: https://codereview.chromium.org/1547413002 Cr-Commit-Position: refs/heads/master@{#367081}
* Revert of Change extension icon load errors to warnings (patchset #8 ↵estade2015-12-291-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:140001 of https://codereview.chromium.org/1537473003/ ) Reason for revert: file read from wrong thread Original issue's description: > Change extension icon load errors to warnings > > During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary. > > Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake. > > BUG=570249 > > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b > Cr-Commit-Position: refs/heads/master@{#366253} TBR=rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570249 Review URL: https://codereview.chromium.org/1554583002 Cr-Commit-Position: refs/heads/master@{#367080}
* Switch to standard integer types in extensions/.avi2015-12-232-0/+3
| | | | | | | | | BUG=138542 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1543053002 Cr-Commit-Position: refs/heads/master@{#366716}
* Change extension icon load errors to warningsestade2015-12-191-3/+2
| | | | | | | | | | | | During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary. Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake. BUG=570249 Review URL: https://codereview.chromium.org/1537473003 Cr-Commit-Position: refs/heads/master@{#366253}
* Convert Pass()→std::move() in //extensionsdcheng2015-12-181-1/+2
| | | | | | | | BUG=557422 Review URL: https://codereview.chromium.org/1537893002 Cr-Commit-Position: refs/heads/master@{#366120}
* Make ValueDeserializer::Deserialize return scoped_ptrolli.raula2015-10-161-3/+3
| | | | | | | | | | | | Make ValueDeserializer::Deserialize return scoped_ptr as almost all consumers already use scoped_ptr and it is also better way to do it. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1394993004 Cr-Commit-Position: refs/heads/master@{#354458}
* Add scoped_ptr-safe base::Value to Dictionary/List conversion functions.reillyg2015-09-112-7/+6
| | | | | | | | | | | | | | | | | | | | This change adds two static From() functions to the DictionaryValue and ListValue classes which take a scoped_ptr to a Value and either convert it to a scoped_ptr to a DictionaryValue or ListValue, or return nullptr. These are intended to replace the existing pattern, make_scoped_ptr(static_cast<base::DictionaryValue*>(value.release())) with the shorter and safer alternative, base::DictionaryValue::From(value.Pass()) Instances of this pattern in //extensions have been converted as examples. Review URL: https://codereview.chromium.org/1308013005 Cr-Commit-Position: refs/heads/master@{#348294}
* Let the SandboxedUnpacker start with either crx files or directoriesasargent2015-08-282-29/+14
| | | | | | | | | | | | | | | | | Traditionally installing always had to start with a .crx file, which was first unzipped followed by having some files sanitized. But to support differential updates, we'll no longer be starting with a .crx file, but rather with an unpacked directory that was assembled for us by the differential update code applying patches to copies of files from the currently installed version. So we need a way to do the sanitizing starting from the equivalent of an unzipped directory. BUG=490418 Review URL: https://codereview.chromium.org/1256263007 Cr-Commit-Position: refs/heads/master@{#346255}
* Initialize blink only when needed in utility processes.sammc2015-07-291-0/+1
| | | | | | | | | | | | | | | | | | Currently, in a utility process containing a v8 proxy resolver, both blink and the proxy resolver attempt to use v8 in incompatible ways, causing a crash on shutdown. This cl changes the utility process to only initialize blink when needed. On Windows, initializing blink with v8 before enabling the sandbox calls RtlGenRandom(), which leaves it available from within the sandbox. To avoid breaking base::RandBytes(), this cl also adds a call to base::RandBytes before enabling the sandbox. BUG=506439 Review URL: https://codereview.chromium.org/1251823002 Cr-Commit-Position: refs/heads/master@{#340835}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-2/+4
| | | | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071}
* Revert of Remove some legacy versions of StartsWith and EndsWith. (patchset ↵yosin2015-07-161-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:100001 of https://codereview.chromium.org/1239493005/) Reason for revert: Compilation error on Windows: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c ..\..\chrome\installer\gcapi\gcapi.cc /Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C3083: 'StartsWith': the symbol to the left of a '::' must be a type c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base' c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2065: 'INSENSITIVE_ASCII' : undeclared identifier ninja: build stopped: subcommand failed. Original issue's description: > Remove some legacy versions of StartsWith and EndsWith. > > This just replaces > true -> base::CompareCase::SENSITIVE > false -> base::CompareCase::INSENSITIVE_ASCII > > I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. > > extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. > > BUG=506255 > TBR=jam > > Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56 > Cr-Commit-Position: refs/heads/master@{#338996} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506255 Review URL: https://codereview.chromium.org/1233453011 Cr-Commit-Position: refs/heads/master@{#338998}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-2/+4
| | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996}
* Move MatchPattern to its own header and the base namespace.brettw2015-07-061-8/+10
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1226673003 Cr-Commit-Position: refs/heads/master@{#337488}
* Fix missing build dependency in //extensions/utilitytapted2015-06-191-0/+1
| | | | | | | | | | | | | | | | | | | | | Tree is closed because of this. http://build.chromium.org/p/chromium/builders/Win/builds/32969/ In file included from ../../extensions/utility/unpacker.cc:20: In file included from ../../content/public/common/common_param_traits.h:21: In file included from ../../content/public/common/common_param_traits_macros.h:25: ../../ui/accessibility/ax_node_data.h:14:10: fatal error: 'ui/accessibility/ax_enums.h' file not found content_common.gypi has export_dependent_settings for ax_gen, but extensions/utility's dependency on content_common was missing. NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1192783002 Cr-Commit-Position: refs/heads/master@{#335222}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-121-4/+4
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* Pull unzipping out of the Unpacker classasargent2015-06-084-86/+69
| | | | | | | | | | | | | | | | | | | | | | | Before this patch, the Unpacker did unzipping of a .crx file followed by a bunch of work to parse/sanitize the extension contents. The CL pulls out the unzipping and leaves Unpacker just doing the parsing/sanitizing. This is incremental work towards the goal of supporting support differential extension updates. The common updater code in components/updater_client that we'll eventually be using will not hand us a .crx file for the new version of the extenion, but rather an already unzipped directory. The files in that directory can have 3 sources: (1) copied from the previous install, (2) entire new files that were downloaded, or (3) files that were copied and then had a patch applied. The next step in a future CL will be similarly splitting the currently commingled crx file and unpacked directory sanitizing in the SandboxedUnpacker class. BUG=490418 Review URL: https://codereview.chromium.org/1168533005 Cr-Commit-Position: refs/heads/master@{#333306}
* Move Tuple to base namespace.brettw2015-05-291-1/+1
| | | | | | | | | | | | | | Namespace change only, no functionality change. The only non-search-and-replace change is in generate_gmock_mutant.py which changes some line wrapping logic for the generated gmock_mutant header. NOPRESUBMIT=true (No presubmit due to long lines in the generated gmock_mutant.h header). R=sky Review URL: https://codereview.chromium.org/1159553007 Cr-Commit-Position: refs/heads/master@{#332058}
* Move UnzipToDir IPC code to top-level extensions directoryasargent2015-05-292-3/+21
| | | | | | | | | | | | | | | This is an early prerequisite step for some code I'm working on to use the new Omaha update code in extensions. Also adjust the name of the extension unpack IPC messages, which had previously moved from chrome/ to extensions/ but still had the 'Chrome' prefix on their names. BUG=490418 Review URL: https://codereview.chromium.org/1162503003 Cr-Commit-Position: refs/heads/master@{#331987}
* Split ValueSerializer into separate Serializer and Deserializer classes.prashhir2015-03-051-4/+4
| | | | | | | | | | | | | This CL removes the Deserializer functionality from ValueSerializer, and puts into separate class ValueDeserializer, so that class responsibility is maintained. BUG=455453 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/925783002 Cr-Commit-Position: refs/heads/master@{#319239}
* Update existing uses of /wd4267 to use the GN configbrettw2015-02-191-4/+3
| | | | | | | | | | This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read. Minor updates to Win64 build, including some fixes for size_t to int conversions. Review URL: https://codereview.chromium.org/929793006 Cr-Commit-Position: refs/heads/master@{#317162}
* Merge extensions sources lists into shared gypisrockot2015-02-111-6/+4
| | | | | | | | | | | | This eliminates source list duplication between GYP and GN builds by merging all source lists into unified gypis. BUG=457404 Review URL: https://codereview.chromium.org/908333004 Cr-Commit-Position: refs/heads/master@{#315871}
* Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/asargent2015-01-272-0/+38
| | | | | | | | | | | This is a mostly mechanical change to move these files over, and make corresponding changes to strings, build files, and include paths. BUG=447014 Review URL: https://codereview.chromium.org/864093002 Cr-Commit-Position: refs/heads/master@{#313404}
* Move unpacker_unittests.cc and data files from chrome/ to extensions/asargent2015-01-161-0/+205
| | | | | | | | | | | | | | | | | | | | | | | | | | Most of the changes here are just moves, with only a few more notable changes: Add "manifest_version : 2" and change from theme to extension -extensions/test/data/unpacker/bad_zip/manifest.json -extensions/test/data/unpacker/bad_image/manifest.json -extensions/test/data/unpacker/good_package/manifest.json Changed BadPathError test and misc cleanup -extensions/utility/unpacker_unittest.cc Support for changes to the above mentioned BadPathError test -extensions/test/test_extensions_client.h -extensions/test/test_extensions_client.cc Entire directory just deleted, not moved -chrome/test/data/extensions/unpacker/bad_path/ BUG=447014 Review URL: https://codereview.chromium.org/849803004 Cr-Commit-Position: refs/heads/master@{#311954}
* Refactoring: move extension unpacker from chrome/ to extensions/asargent2015-01-154-0/+428
| | | | | | | | | | | | | | | This is mostly a series of mechanical changes to move unpacker.{h,cc} from chrome/utility to extensions/utility. The unpacker_unittests.cc and associated data files will be moved in a follow-up CL to keep this one easy to review, because there are a lot of test data files to move. BUG=447014 Review URL: https://codereview.chromium.org/818943004 Cr-Commit-Position: refs/heads/master@{#311598}
* gn format //extensionsscottmg2014-12-031-3/+1
| | | | | | | | | | | No intended functionality change. R=brettw@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/774283002 Cr-Commit-Position: refs/heads/master@{#306641}
* Add rudimentary UpdateService to app_shellrockot2014-11-064-0/+133
It can download a CRX from the web store using an ID given at the command line. This wires up utility process support for app_shell and establishes a base for factoring additional extensions utility IPCs out of //chrome in the near future. BUG=398671 TBR=asargent@chromium.org for cloned dependency on omaha_query_params Review URL: https://codereview.chromium.org/693233003 Cr-Commit-Position: refs/heads/master@{#303055}
generated by cgit v1.1 at 2025-01-06 21:53:17 +0000