summaryrefslogtreecommitdiffstats
path: root/net/url_request/url_request_test_job.h
Commit message (Collapse)AuthorAgeFilesLines
* Fix typos in comments in url_requestkimwjdalsl2015-12-161-1/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1527303002 Cr-Commit-Position: refs/heads/master@{#365633}
* Remove reference counting from URLRequestJob.mmenke2015-12-081-2/+2
| | | | | | | | | | | | | | The URLRequest now has control over its lifetime, so undead URLRequestJobs can't come back to haunt us after the request has been destroyed. Longer term, hopefully we'll be able to delete URLRequestJobs on cancellation. BUG=490668 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1457043005 Cr-Commit-Position: refs/heads/master@{#363819}
* URLRequestJob: change ReadRawData contractxunjieli2015-11-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the interface for URLRequestJob::ReadRawData was as follows: bool ReadRawData(IOBuffer*, int, int*) Subclasses were expected to signal completion of the ReadRawData call by calling NotifyDone, SetStatus, or maybe one of the other Notify* functions on URLRequestJob, most of which do internal housekeeping and also drive the URLRequest's state machine. This made it difficult to reason about the URLRequestJob's state machine and needlessly complicated most of URLRequestJob. The new interface is as follows: int ReadRawData(IOBuffer*, int) Subclasses are required to either: a) Return ERR_IO_PENDING, and call ReadRawDataComplete when the read completes in any way, or b) Return a count of bytes read >= 0, indicating synchronous success, or c) Return another error code < 0, indicating synchronous failure. This substantially narrows the interface between URLRequestJob and its subclasses and moves the logic for the URLRequest state machine largely into URLRequestJob. Also, the signature of URLRequestJob::ReadFilteredData and some other internal URLRequestJob helpers changes to propagate detailed error codes instead of coercing all errors to FAILED. TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,davidben@chromium.org,falken@chromium.org,mtomasz@chromium.org, sky@chromium.org,jianli@chromium.org,zork@chromium.org,rdsmith@chromium.org BUG=553300 Review URL: https://codereview.chromium.org/1467603002 Cr-Commit-Position: refs/heads/master@{#361158}
* Revert "Reland: URLRequestJob: change ReadRawData contract"xunjieli2015-11-201-1/+1
| | | | | | | | | | | | | | | | | | | This reverts commit d77911ac82186d65a8f11555a7a6b1678c769ba2. The previous CL caused a top crasher on Canary. Reverting this CL now since fixing the crash isn't straightforward. TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,davidben@chromium.org,falken@chromium.org,mtomasz@chromium.org, sky@chromium.org,jianli@chromium.org,zork@chromium.org,mmenke@chromium.org,rdsmith@chromium.org BUG=558224 BUG=553300 BUG=474859 BUG=329902 Review URL: https://codereview.chromium.org/1459333002 Cr-Commit-Position: refs/heads/master@{#360809}
* Reland: URLRequestJob: change ReadRawData contractxunjieli2015-11-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL is to reland crrev.com/1410643007 which was reverted in crrev.com/1437523002. Previously, the interface for URLRequestJob::ReadRawData was as follows: bool ReadRawData(IOBuffer*, int, int*) Subclasses were expected to signal completion of the ReadRawData call by calling NotifyDone, SetStatus, or maybe one of the other Notify* functions on URLRequestJob, most of which do internal housekeeping and also drive the URLRequest's state machine. This made it difficult to reason about the URLRequestJob's state machine and needlessly complicated most of URLRequestJob. The new interface is as follows: int ReadRawData(IOBuffer*, int) Subclasses are required to either: a) Return ERR_IO_PENDING, and call ReadRawDataComplete when the read completes in any way, or b) Return a count of bytes read >= 0, indicating synchronous success, or c) Return another error code < 0, indicating synchronous failure. This substantially narrows the interface between URLRequestJob and its subclasses and moves the logic for the URLRequest state machine largely into URLRequestJob. Also, the signature of URLRequestJob::ReadFilteredData and some other internal URLRequestJob helpers changes to propagate detailed error codes instead of coercing all errors to FAILED. TBR=michaeln@chromium.org,mtomasz@chromium.org,jianli@chromium.org,zork@chromium.org BUG=474859 BUG=329902 Review URL: https://codereview.chromium.org/1439953006 Cr-Commit-Position: refs/heads/master@{#360327}
* Revert "URLRequestJob: change ReadRawData contract"xunjieli2015-11-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a505cbb45ec92d2617fe80490acf7d01ef4d3225. Revert "Disable http/tests/serviceworker/registration.html" This reverts commit e2bf349b84f10e940b5ebe5a8fcaf2cf8c8eb322. Revert "Remove incorrect DCHECK_NE in ServiceWorkerWriteToCacheJob::OnReadCompleted." This reverts commit 5b28d0b0efd8a75a9ad783bd849fa41eb9339a3b. Revert "Do not call NotifyDone in URLRequestJob::ReadRawDataComplete if ERR_IO_PENDING" This reverts commit 876da269322a66d5e2741de0892e01b24ab98065. TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,davidben@chromium.org,falken@chromium.org,mtomasz@chromium.org, sky@chromium.org,jianli@chromium.org,zork@chromium.org BUG=553300 BUG=474859 Review URL: https://codereview.chromium.org/1437523002 Cr-Commit-Position: refs/heads/master@{#358686}
* URLRequestJob: change ReadRawData contractxunjieli2015-11-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL is patched from ellyjones@ CL at crrev.com/1227893004. Previously, the interface for URLRequestJob::ReadRawData was as follows: bool ReadRawData(IOBuffer*, int, int*) Subclasses were expected to signal completion of the ReadRawData call by calling NotifyDone, SetStatus, or maybe one of the other Notify* functions on URLRequestJob, most of which do internal housekeeping and also drive the URLRequest's state machine. This made it difficult to reason about the URLRequestJob's state machine and needlessly complicated most of URLRequestJob. The new interface is as follows: int ReadRawData(IOBuffer*, int) Subclasses are required to either: a) Return ERR_IO_PENDING, and call ReadRawDataComplete when the read completes in any way, or b) Return a count of bytes read >= 0, indicating synchronous success, or c) Return another error code < 0, indicating synchronous failure. This substantially narrows the interface between URLRequestJob and its subclasses and moves the logic for the URLRequest state machine largely into URLRequestJob. Also, the signature of URLRequestJob::ReadFilteredData and some other internal URLRequestJob helpers changes to propagate detailed error codes instead of coercing all errors to FAILED. BUG=474859 BUG=329902 Review URL: https://codereview.chromium.org/1410643007 Cr-Commit-Position: refs/heads/master@{#358327}
* Make URLRequestTestJob accept \n terminated header lines.martijn2015-10-281-2/+2
| | | | | | | | BUG=516724 Review URL: https://codereview.chromium.org/1414983002 Cr-Commit-Position: refs/heads/master@{#356617}
* Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandlersvaldez2015-08-241-1/+2
| | | | | | | | | | Adding scoped_ptr to call in order to take ownership of handler. BUG=517161 Review URL: https://codereview.chromium.org/1295523006 Cr-Commit-Position: refs/heads/master@{#345185}
* net cleanup: Remove unnecessary namespace prefixes.ttuttle2015-04-231-1/+1
| | | | | | | | BUG=475208 Review URL: https://codereview.chromium.org/1095823003 Cr-Commit-Position: refs/heads/master@{#326610}
* Standardize usage of virtual/override/final in net/dcheng2014-10-211-14/+10
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=rsleevi@chromium.org Review URL: https://codereview.chromium.org/667923003 Cr-Commit-Position: refs/heads/master@{#300466}
* replace OVERRIDE and FINAL with override and final in net/mostynb2014-10-091-9/+9
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623213004 Cr-Commit-Position: refs/heads/master@{#298844}
* Reland "Fix various issues in RedirectToFileResourceHandler."davidben@chromium.org2014-03-141-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It got reverted due to ASan issues. Fix child_id registration in ResourceDispatcherHostTests so that they happen on ForwardingFilter creation, rather than ad-hoc on a per-request basis. Original description: > - Handle errors in creating temporary files. > - Cancel on write failure instead of resuming. This used to work, but got > lost in some refactoring in r142108. > - Fix the OnResponseCompleted resume logic to account for partial writes. > - Don't lose write errors which occur after OnResponseCompleted is received. > - WeakPtrFactory goes after other members. > - OnWillStart was never forwarded to downstream handlers. > - Make sure the file is closed before deleting it. > > Also add a lot of machinery so we can better unit test this stack. Original Review URL: https://codereview.chromium.org/82273002 BUG=316634,347663 TEST=ResourceDispatcherHostTest.DownloadToFile ResourceDispatcherHostTest.RegisterDownloadedTempFile ResourceLoaderRedirectToFileTest.* TemporaryFileStreamTest.Basic Review URL: https://codereview.chromium.org/199453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257147 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 256688 "Fix various issues in RedirectToFileResourceHandler."cpu@chromium.org2014-03-131-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The linux asan bot went red ResourceDispatcherHostTest.DownloadToFile (run #1): [ RUN ] ResourceDispatcherHostTest.DownloadToFile [ OK ] ResourceDispatcherHostTest.DownloadToFile (212 ms) [----------] 1 test from ResourceDispatcherHostTest (212 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (213 ms total) [ PASSED ] 1 test. YOU HAVE 5 DISABLED TESTS ================================================================= ==9125==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x49be81 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x23ce695 in content::ResourceDispatcherHostImpl::BeginRequest(int, ResourceHostMsg_Request const&, IPC::Message*, int) content/browser/loader/resource_dispatcher_host_impl.cc:1045 #2 0x23cba80 in OnRequestResource content/browser/loader/resource_dispatcher_host_impl.cc:879 #3 0x23cba80 in Dispatch\u003Ccontent::ResourceDispatcherHostImpl, content::ResourceDispatcherHostImpl, int, const ResourceHostMsg_Request &> content/common/resource_messages.h:305 #4 0x23cba80 in content::ResourceDispatcherHostImpl::OnMessageReceived(IPC::Message const&, content::ResourceMessageFilter*, bool*) content/browser/loader/resource_dispatcher_host_impl.cc:841 #5 0xe04954 in content::ResourceDispatcherHostTest_DownloadToFile_Test::TestBody() content/browser/loader/resource_dispatcher_host_unittest.cc:2840 #6 0x2c10c9a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #7 0x2c10c9a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #8 0x2c12dea in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #9 0x2c13bb3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #10 0x2c24c6a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #11 0x2c24250 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #12 0x2c24250 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #13 0x2b9ed2c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #14 0x2b9ed2c in base::TestSuite::Run() base/test/test_suite.cc:213 #15 0x2b92bcb in Run base/callback.h:401 #16 0x2b92bcb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #17 0x199a83e in main content/test/run_all_unittests.cc:14 #18 0x7f6e898bf76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s). http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/409 > Fix various issues in RedirectToFileResourceHandler. > > - Handle errors in creating temporary files. > - Cancel on write failure instead of resuming. This used to work, but got > lost in some refactoring in r142108. > - Fix the OnResponseCompleted resume logic to account for partial writes. > - Don't lose write errors which occur after OnResponseCompleted is received. > - WeakPtrFactory goes after other members. > - OnWillStart was never forwarded to downstream handlers. > - Make sure the file is closed before deleting it. > > Also add a lot of machinery so we can better unit test this stack. > > BUG=316634,347663 > TEST=ResourceDispatcherHostTest.DownloadToFile > ResourceDispatcherHostTest.RegisterDownloadedTempFile > ResourceLoaderTest.RedirectToFile* > TemporaryFileStreamTest.Basic > > Review URL: https://codereview.chromium.org/82273002 TBR=davidben@chromium.org Review URL: https://codereview.chromium.org/196533013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256704 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various issues in RedirectToFileResourceHandler.davidben@chromium.org2014-03-121-2/+3
| | | | | | | | | | | | | | | | | | | | | | | - Handle errors in creating temporary files. - Cancel on write failure instead of resuming. This used to work, but got lost in some refactoring in r142108. - Fix the OnResponseCompleted resume logic to account for partial writes. - Don't lose write errors which occur after OnResponseCompleted is received. - WeakPtrFactory goes after other members. - OnWillStart was never forwarded to downstream handlers. - Make sure the file is closed before deleting it. Also add a lot of machinery so we can better unit test this stack. BUG=316634,347663 TEST=ResourceDispatcherHostTest.DownloadToFile ResourceDispatcherHostTest.RegisterDownloadedTempFile ResourceLoaderTest.RedirectToFile* TemporaryFileStreamTest.Basic Review URL: https://codereview.chromium.org/82273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256688 0039d316-1c4b-4281-b951-d872f2087c98
* Allow prefetches to outlive their owning RenderViewHost.davidben@chromium.org2013-11-201-2/+8
| | | | | | | | | | | | | | | | | | | | | | This is a rework of r231910. Instead of putting the detachable logic in AsyncResourceHandler, move it to a wrapper DetachableResourceHandler. On detach, it simulates a cancel to the ResourceHandler it wraps and then continues to drain the request itself. This should have fewer buffering complications. BUG=286186 TEST=ResourceDispatcherHostTest.Cancel, ResourceDispatcherHostTest.DetachedResourceTimesOut, ResourceDispatcherHostTest.DeletedFilterDetached, ResourceDispatcherHostTest.DeletedFilterDetachedRedirect, ResourceDispatcherHostTest.DetachWhileStartIsDeferred ResourceDispatcherHostTest.TestProcessCancelDetachedTimeout, ResourceDispatcherHostTest.CancelRequestsForContextDetached, ResourceDispatcherHostTest.DataSentBeforeDetach Review URL: https://codereview.chromium.org/59783003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236132 0039d316-1c4b-4281-b951-d872f2087c98
* Experimental Revert of 231910 "Allows prefetch and other detachable requests ↵mmenke@chromium.org2013-11-041-8/+2
| | | | | | | | | | | | | | | | | | | | to ...", to see if it fixes 314726. > Allows prefetch and other detachable requests to live beyond the renderer by delaying LinkLoader::Cancel requests by a few seconds and through the use of a new DetachedResourceHandler. > > The general concept of a detachable resource should be useful for <a ping> as well. > > BUG=286186,314726 > > Review URL: https://codereview.chromium.org/25772002 TBR=jkarlin@google.com Review URL: https://codereview.chromium.org/58343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232785 0039d316-1c4b-4281-b951-d872f2087c98
* Allows prefetch and other detachable requests to live beyond the renderer by ↵jkarlin@google.com2013-10-301-2/+8
| | | | | | | | | | | | delaying LinkLoader::Cancel requests by a few seconds and through the use of a new DetachedResourceHandler. The general concept of a detachable resource should be useful for <a ping> as well. BUG=286186 Review URL: https://codereview.chromium.org/25772002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231910 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a load timing bug in which proxy resolution times couldmmenke@chromium.org2013-04-081-0/+9
| | | | | | | | | | | | | | | be before request start in the case of reusing a SPDY session (Or HTTP pipeline, though HTTP pipelining is disabled by default). Also move logic to fix up LoadTimingInfo into net/, to reduce chrome's dependency on internal net/ details. BUG=225935 R=eroman@chromium.org Review URL: https://codereview.chromium.org/13653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192863 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Propagate priority changes from URLRequest to HttpTransactionakalin@chromium.org2013-03-221-0/+5
| | | | | | | | | | | | | | | This is in preparation for propagating priority changes from ResourceScheduler all the way to HostResolver and ClientSocketPool. Add some NetLog events and parameters for priority. BUG=166689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189829 Review URL: https://codereview.chromium.org/12701011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189894 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 189829 "[Net] Propagate priority changes from URLRequest ..."msw@chromium.org2013-03-221-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See heapcheck failures: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563 http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563/steps/heapcheck%20test%3A%20net/logs/stdio Example (one of many): Leak of 792 bytes in 1 objects allocated from: @ 10d675b URLRequestFtpJobPriorityTest @ 10d68e7 URLRequestFtpJobPriorityTest_SetPriorityBasic_Test @ 10de383 CreateTest Suppression (error hash=#0A68FF60C5D043B8#): { <insert_a_suppression_name_here> Heapcheck:Leak fun:URLRequestFtpJobPriorityTest fun:URLRequestFtpJobPriorityTest_SetPriorityBasic_Test fun:CreateTest } > [Net] Propagate priority changes from URLRequest to HttpTransaction > > This is in preparation for propagating priority changes from > ResourceScheduler all the way to HostResolver and ClientSocketPool. > > Add some NetLog events and parameters for priority. > > BUG=166689 > TBR=simonjam@chromium.org,sky@chromium.org > > Review URL: https://codereview.chromium.org/12701011 TBR=akalin@chromium.org Review URL: https://codereview.chromium.org/12676022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189872 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Propagate priority changes from URLRequest to HttpTransactionakalin@chromium.org2013-03-221-0/+5
| | | | | | | | | | | | | | This is in preparation for propagating priority changes from ResourceScheduler all the way to HostResolver and ClientSocketPool. Add some NetLog events and parameters for priority. BUG=166689 TBR=simonjam@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/12701011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189829 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring: ProtocolHandler::MaybeCreateJob and other functions take ↵shalev@chromium.org2012-08-241-2/+5
| | | | | | | | | | | | | | NetworkDelegate as argument This change goes a long way to prepare for removing NetworkDelegate from URLRequestContext. TBR=sky@chromium.org, michaeln@chromium.org, benjhayden@chromium.org, brettw@chromium.org, ben@chromium.org, davemoore@chromium.org, zelidrag@chromium.org, mnissler@chromium.org, thestig@chromium.org, asargent@chromium.org, jhawkins@chromium.org, bulach@chromium.org BUG=crbug.com/142945 Review URL: https://chromiumcodereview.appspot.com/10855209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153133 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Use ByteStream in downloads system to decouple source and sink.rdsmith@chromium.org2012-06-041-1/+7
| | | | | | | | | | | BUG=123192 BUG=93006 BUG=111588 Review URL: https://chromiumcodereview.appspot.com/10392111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140328 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NewRunnableMethod() calls to base::Bind().ajwong@chromium.org2011-12-201-2/+2
| | | | | | | | | | BUG=none TEST=existing tests. Review URL: http://codereview.chromium.org/8956017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115181 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to net/.avi@chromium.org2011-11-161-7/+10
| | | | | | | | BUG=104314 Review URL: http://codereview.chromium.org/8568021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110231 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NET_API to NET_EXPORT, and rename NET_TEST to NET_EXPORT_PRIVATE.darin@chromium.org2011-08-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7529043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96560 0039d316-1c4b-4281-b951-d872f2087c98
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-261-5/+5
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add NET_API to url_request.rvargas@google.com2011-05-201-1/+1
| | | | | | | | BUG=76997 TEST=none Review URL: http://codereview.chromium.org/7033036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86125 0039d316-1c4b-4281-b951-d872f2087c98
* Stop refcounting URLRequestTestJobwillchan@chromium.org2011-04-301-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6883259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83643 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestTestJob URLRequestTestJob;tfarina@chromium.org2011-01-111-3/+0
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6202002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70966 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to the remaining files under url_request directory.tfarina@chromium.org2011-01-061-11/+18
| | | | | | | | | | | | It just adds the 'namespace net' to these files and a typedef for them, because there are many entries to fix in one pass. They will be fixed later. BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/6056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70592 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequest URLRequest;tfarina@chromium.org2010-11-301-4/+4
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to URLRequest and URLRequestJob classes.tfarina@chromium.org2010-11-281-1/+1
| | | | | | | | | BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/5298008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67497 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 49081: AppCache: Use a MockHttpServer instead of starting a seperate ↵michaeln@chromium.org2010-06-071-0/+1
| | | | | | | | | | | http server for update job unittests. This should reduce flakiness and timing variance and the total time it takes to conduct these tests. BUG=45664 TEST=yes Review URL: http://codereview.chromium.org/2662006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49088 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49081 - AppCache: Use a MockHttpServer instead of starting a seperate ↵michaeln@google.com2010-06-071-1/+0
| | | | | | | | | | | | | | | http server for update job unittests. This should reduce flakiness and timing variance and the total time it takes to conduct these tests. BUG=45664 TEST=yes Review URL: http://codereview.chromium.org/2624003 TBR=michaeln@chromium.org Review URL: http://codereview.chromium.org/2669003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49084 0039d316-1c4b-4281-b951-d872f2087c98
* AppCache: Use a MockHttpServer instead of starting a seperate http server ↵michaeln@chromium.org2010-06-071-0/+1
| | | | | | | | | | | | for update job unittests. This should reduce flakiness and timing variance and the total time it takes to conduct these tests. BUG=45664 TEST=yes Review URL: http://codereview.chromium.org/2624003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49081 0039d316-1c4b-4281-b951-d872f2087c98
* Second patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-2/+2
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/368001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31165 0039d316-1c4b-4281-b951-d872f2087c98
* URLRequest::Interceptor enhancements1) Allow an interceptor to change its ↵michaeln@google.com2009-04-161-11/+59
| | | | | | | | mind and not intercept after all. This allows the decision to start or not to start to be made asynchronously.2) Allow an interceptor to intercept on error conditions if the original job fails. This is to support the FALLBACK semantics in the appcache.Info about where this is going can be found in the appcache design doc at https://docs.google.com/a/google.com/Doc?docid=agv6ghfsqr_15f749cgt3&hl=enI still have to put together test cases, so I'm not ready to submit this yet, but wanted to get some feedback at this point. Review URL: http://codereview.chromium.org/67019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13877 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-111-1/+0
| | | | | | | | | Normalize end of file newlines in net/. All files end in a single newline. Review URL: http://codereview.chromium.org/43079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11442 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilterContext to allow filters to access URLRequestJob datajar@chromium.org2009-03-091-2/+4
| | | | | | | r=wtc,darin,huanr Review URL: http://codereview.chromium.org/40138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11248 0039d316-1c4b-4281-b951-d872f2087c98
* Change URLRequest to use a ref-counted buffer for actual IO.rvargas@google.com2009-01-291-2/+2
| | | | | | | | | | This will re-land http://codereview.chromium.org/18390 BUG=5325 Review URL: http://codereview.chromium.org/19004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8847 0039d316-1c4b-4281-b951-d872f2087c98
* revert r8603rvargas@google.com2009-01-241-2/+2
| | | | | | Review URL: http://codereview.chromium.org/18576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8605 0039d316-1c4b-4281-b951-d872f2087c98
* Change URLRequest to use a ref-counted buffer for actual IO.The ref-counting ↵rvargas@google.com2009-01-241-2/+2
| | | | | | | | will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325 Review URL: http://codereview.chromium.org/18390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix header include guards.darin@google.com2008-08-041-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@344 0039d316-1c4b-4281-b951-d872f2087c98
* Add net to the repository.initial.commit2008-07-261-0/+110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 12:18:25 +0000