summaryrefslogtreecommitdiffstats
path: root/net/url_request
Commit message (Collapse)AuthorAgeFilesLines
* Fix DCHECK on multiple SSL client auths for the same request.mattm@chromium.org2011-04-071-2/+2
| | | | | | | | | BUG=78679 TEST=see bug Review URL: http://codereview.chromium.org/6814009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80828 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the *AcceptCharset* and *AcceptLanguage* net test failures on the ↵ananta@chromium.org2011-04-071-8/+8
| | | | | | | | | | | | | | | | | | ChromeFrame IE6 builder. These tests randomly fail as IE6 caches the response as per the directive passed back by the python webserver. Proposed fix is to send back the no-cache header for all echoheader requests. The URLRequestTestHTTP.VaryHeader test expects the response to be cached. Added a new url substring /echoheadercache which returns back the expected cache header. Removed the echoheaderoverride url handling from the test server. BUG=none TEST=ChromeFrame net tests should pass on IE6. Net tests should continue to pass everywhere else. Review URL: http://codereview.chromium.org/6810001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80808 0039d316-1c4b-4281-b951-d872f2087c98
* Remove async functionality from net::CookiePolicy.willchan@chromium.org2011-04-065-177/+12
| | | | | | | | | | | | This lets us stop refcounting URLRequestHttpJob. BUG=none TEST=none Review URL: http://codereview.chromium.org/6749044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80660 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the EmptyAcceptLanguage and EmptyAcceptCharset net test failures on IE6. ↵ananta@chromium.org2011-04-061-2/+4
| | | | | | | | | | | | | | IE6 at times sends over cached request headers from the DefaultAcceptLanguage and DefaultAcceptCharset tests which causes these tests to fail. Fix is to use the echoheaderoverride prefix in the url which was added precisely for this reason. BUG=none TEST=ChromeFrame net tests should now pass consistently with IE6. Review URL: http://codereview.chromium.org/6677175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80578 0039d316-1c4b-4281-b951-d872f2087c98
* Removing check for NULL pointer. The memory stomper has been fixed.joi@chromium.org2011-04-051-7/+1
| | | | | | | | | BUG=71721 TEST=none Review URL: http://codereview.chromium.org/6794029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80446 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLRequestContextGetter to net/ so it can be used by projects such as ↵sanjeevr@chromium.org2011-03-312-0/+108
| | | | | | | | | | jingle. BUG=None TEST=Build. Review URL: http://codereview.chromium.org/6778025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80033 0039d316-1c4b-4281-b951-d872f2087c98
* Add request_id to HttpRequestInfo and pass it to the NetworkDelegate for events.mpcomplete@chromium.org2011-03-305-10/+24
| | | | | | | | | | | | | | This lets us look up the request associated with an http transaction and send event details for the webRequest.onBeforeRequest extension event. I also hooked up the onBeforeRequest event for HTTP network and cache transactions so that they are separate from other requests. This lets us have the request header information. BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6698009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79905 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the comment for URLRequest::Cancel().kinuko@chromium.org2011-03-301-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Its original comment says it will never call any methods of the delegate after Cancel() is made, including during the call to Cancel itself, but the actual code eventually calls delegate's OnReadCompleted if 1) the response has been handled, 2) the request is still alive, 3) the request has not been marked success and 4) it has a live delegate. (It looks like we could set the delegate to null somewhere in the Cancel(), but changing the code is scary and I'm not 100% sure if it's the right behavior.) The call path: URLRequest::Cancel() -> URLRequest::DoCancel() -> URLRequestJob::Kill() -> URLRequestJob::NotifyCanceled() -> URLRequestJob::CompleteNotifyDone() -> request_->delegate()->OnReadCompleted() BUG=none TEST=none Review URL: http://codereview.chromium.org/6732017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79806 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send empty Accept-Language / Accept-Charset headers.willchan@chromium.org2011-03-302-10/+46
| | | | | | | | | | BUG=77365 TEST=Start Chrome, check that the GoogleURLTracker request headers do not include Accept-Language/Accept-Charset. Review URL: http://codereview.chromium.org/6731070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79771 0039d316-1c4b-4281-b951-d872f2087c98
* Add another AllowIO exception to URLRequestFileJob.fischman@chromium.org2011-03-291-8/+13
| | | | | | | | | | | Without this, playback of local-file videos FATALs w/ a violation message, but only if the file isn't small enough to have been cached by a previous operation that had an AllowIO in effect. Oy! BUG=59849,76713 TEST=local playback works again, and trybots. Review URL: http://codereview.chromium.org/6747012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79688 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to address a comment in r79555.agl@chromium.org2011-03-281-2/+2
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79556 0039d316-1c4b-4281-b951-d872f2087c98
* net: allow revocation check failures for HSTS sitesagl@chromium.org2011-03-281-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6747002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79555 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly report HttpOnly cookies and correctly reset the Cookie Monsterjochen@chromium.org2011-03-281-1/+3
| | | | | | | | | BUG=77199 TEST=as described in the bug Review URL: http://codereview.chromium.org/6736030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79529 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-2812-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Update port handling to patch latest HSTS intention. See the bug for URLs thatcevans@chromium.org2011-03-261-1/+0
| | | | | | | | | | reference the decisions and factors involved. BUG=77467 TEST=see bug Review URL: http://codereview.chromium.org/6748012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79478 0039d316-1c4b-4281-b951-d872f2087c98
* Add an opt-out header for HTTP throttling. Never throttle for localhost.joi@chromium.org2011-03-257-41/+282
| | | | | | | | | | | | | | | | | Added net::IsLocalhost() function to net/base/net_utils.h Unit tests for the above. Also fix flakiness in the ReceivedContentMalformed test that was caused by non-zero jitter. Modify back-off policy to ignore first 4 errors to help avoid back-off from erroneously kicking in on flaky connections. Make maximum back-off period 15 minutes instead of 60. Added documentation of results of analyzing behavior this new policy will give. Add a simple server for manual testing of the throttling feature. BUG=66062 TEST=net_unittests Review URL: http://codereview.chromium.org/6711046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79464 0039d316-1c4b-4281-b951-d872f2087c98
* Support enabling/disabling the URL request throttler via the ↵joi@chromium.org2011-03-255-14/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | about:net-internals page: - Add a new tab to the about:net-internals page. - Add a preference item to persist user's choice. - Remove the command line switch --disable-enforced-throttling. - Make throttling feature off by default for now. This is 95% based on yzshen@chromium.org's patch http://codereview.chromium.org/6286001/ which was never landed. The changes that have been made from that patch are mostly cosmetic, apart from updating it to match the codebase (the patch was prepared ~2 months ago) and responding to eroman@'s initial round of code review comments. BUG=66062 TEST=Make sure the checkbox on about:net-internals > HTTP Throttling is checked. (1) Type in the addresss bar a URL which is expected to return 5XX. (2) Keep clicking the "reload" button. (3) After a few clicks, Chrome displays an error page explaining why a net::ERR_TEMPORARILY_THROTTLED error occurs. Make sure the checkbox on about:net-internals > HTTP Throttling is unchecked. Following step (1) and (2) described above won't result in a net::ERR_TEMPORARILY_THROTTLED error page. Review URL: http://codereview.chromium.org/6677085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79455 0039d316-1c4b-4281-b951-d872f2087c98
* Move declaration of private nested URLRequestHttpJob::HttpRequestContext to ↵adamk@chromium.org2011-03-252-25/+28
| | | | | | | | | | | | | .cc file. R=willchan@chromium.org BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/6745014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79453 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all "net::" prefixes under net/url_request for code that'sadamk@chromium.org2011-03-2422-403/+413
| | | | | | | | already in the net namespace. Review URL: http://codereview.chromium.org/6730034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79340 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLRequestJob's histogram logic to URLRequestHttpJob.adamk@chromium.org2011-03-244-354/+323
| | | | | | | | | | | | | While this slightly degeneralizes some stats-collection code, the svn history shows that this code has, over several years, only been used for SDCH, and thus it's worth some degeneralization in order to greatly simplify URLRequestJob. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/6713019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove AddRef()/Release() from ViewHttpCacheJob. Use a Core class.willchan@chromium.org2011-03-222-3/+3
| | | | | | | | | | | | This is part of the process to remove refcounting from URLRequestJob. BUG=none TEST=none Review URL: http://codereview.chromium.org/6717012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79057 0039d316-1c4b-4281-b951-d872f2087c98
* Add field trial & prerendering information to Net.HttpTimeToFirstBytegavinp@chromium.org2011-03-221-0/+33
| | | | | | | | | | | This is a second try, my first pass in Issue 6685030 had to be reverted due to windows try failures. BUG=70957 TEST=about:histograms/Net.HttpTimeToFirstByte Review URL: http://codereview.chromium.org/6708061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78979 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up the last easy URLRequestJob refcounting offenders.willchan@chromium.org2011-03-216-43/+57
| | | | | | | | | | | | Also clean up net:: use in URLRequestJob while I'm there. BUG=none TEST=none Review URL: http://codereview.chromium.org/6709050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78902 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78883 - Add field trial & prerendering information to ↵gavinp@chromium.org2011-03-211-34/+1
| | | | | | | | | | | | | | Net.HttpTimeToFirstByte BUG=70957 TEST=about:histograms/Net.HttpTimeToFirstByte Review URL: http://codereview.chromium.org/6685030 TBR=gavinp@chromium.org Review URL: http://codereview.chromium.org/6712060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78886 0039d316-1c4b-4281-b951-d872f2087c98
* Add field trial & prerendering information to Net.HttpTimeToFirstBytegavinp@chromium.org2011-03-211-1/+34
| | | | | | | | | BUG=70957 TEST=about:histograms/Net.HttpTimeToFirstByte Review URL: http://codereview.chromium.org/6685030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78883 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux clang build.willchan@chromium.org2011-03-192-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6709049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78806 0039d316-1c4b-4281-b951-d872f2087c98
* Change some URLRequestJob subclasses to use ScopedRunnableMethodFactory.willchan@chromium.org2011-03-196-13/+31
| | | | | | | | | | | | This is a step towards not refcounting URLRequestJobs. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78803 0039d316-1c4b-4281-b951-d872f2087c98
* Stop subclassing FilterContext in URLRequestJob.adamk@chromium.org2011-03-174-55/+96
| | | | | | | | | | | | | | | | Create a wrapper for URLRequestHttpJob that subclasses FilterContext, and pass an instance of this facade to Filter::Factory(). Reduce the scope of URLRequestJob's interface as much as possible, moving methods into URLRequestHttpJob or its facade as appropriate, and making methods that remain in URLRequestJob non-virtual where possible. BUG=none TEST=net_unittests,try bots Review URL: http://codereview.chromium.org/6677104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78576 0039d316-1c4b-4281-b951-d872f2087c98
* Remove minidump analysis aides from URLRequestThrottlerManager. Leavejoi@chromium.org2011-03-173-110/+24
| | | | | | | | | | | | | | | in guard against null values. We are no longer getting any new information from more minidumps for this particular crash, so the aides are no longer necessary and I'm leaving the guard in place to minimize the impact on our users. BUG=71721 TEST=net_unittests Review URL: http://codereview.chromium.org/6698033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78552 0039d316-1c4b-4281-b951-d872f2087c98
* Extracting core back-off logic into a separate class,joi@chromium.org2011-03-176-208/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | BackoffEntry. Simplifying the logic slightly while I'm there, removing special support for "after the fact" malformed bodies (the error count doesn't need to be 100% accurate) and removing a constant value added to back-off times (it was only being added once anyway, had close to zero effect). Modifying URLRequestThrottlerEntry and related tests to use the new class instead of co-mingling sliding window logic and exponential back-off logic. Removing now-unnecessary StressTest and associated ugly wart "SetEntryLifetimeMsForTest" method on the URLRequestThrottlerEntryInterface class. Fixing up a few minor things e.g. #pragma once while I'm in there. BUG=none TEST=net_unittests.exe, unit_tests.exe Review URL: http://codereview.chromium.org/6697001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78548 0039d316-1c4b-4281-b951-d872f2087c98
* Make URLRequestHttpJob the only URLRequestJob concerned with FilterContext.adamk@chromium.org2011-03-177-58/+27
| | | | | | | | | | | | | | | | In order to allow this, provide a new factory method in Filter to return a GZipFilter (used by URLRequestFileJob and URLRequestJobTrackerTest), and invert control so that URLRequestJobs are responsible for constructing filters. This is one step away from removing FilterContext as a base class of URLRequestJob, which will be tackled in a followup change. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/6674042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78489 0039d316-1c4b-4281-b951-d872f2087c98
* Remove URLRequestJobMetrics and related code.adamk@chromium.org2011-03-166-142/+0
| | | | | | | | | | | | It's apparently no longer used. R=eroman@chromium.org BUG=none TEST=try bots Review URL: http://codereview.chromium.org/6672036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78417 0039d316-1c4b-4281-b951-d872f2087c98
* Various small cleanups in URLRequestJob:adamk@chromium.org2011-03-162-39/+23
| | | | | | | | | | | | | | - Remove unused or unneeded methods. - Make (almost) all data private. R=eroman@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6697035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78319 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for partitioning cookies for isolated apps.creis@google.com2011-03-152-0/+36
| | | | | | | | | | | | | | | | This CL adds experimental support for letting installed apps request isolated storage in their manifest. An isolated app will have its own cookie store that is not shared with other apps or normal pages, even if they share an origin. The feature is currently behind a --enable-experimental-app-manifests flag. BUG=69335 TEST=ExtensionManifestTest.IsolatedApps TEST=IsolatedAppApiTest.CookieIsolation* Review URL: http://codereview.chromium.org/6201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78301 0039d316-1c4b-4281-b951-d872f2087c98
* Reland rest of r77399.willchan@chromium.org2011-03-121-6/+0
| | | | | | | | | | | I had temporarily reverted it so I could break it up into 2 commits, so the first could be merged to 696. This is part 2. BUG=none TEST=none Review URL: http://codereview.chromium.org/6684019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77908 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r77399 in preparation for merging a small portion of it to 696.willchan@chromium.org2011-03-111-0/+6
| | | | | | | | | | | | | | | | | | Reland r77075,r77077. They were reverted due to flaky tests, especially on valgrind. Basically, we kept hitting the backup socket timer (500ms) which would create another socket, which the tests don't expect, so they crash. I disabled the backup socket timer completely for the SPDY tests, because they make it too hard to handle the parallel alternate protocol jobs. I also deleted the HTTP fallback test from SpdyNetworkTransactionTest, because it had a similar problem. Also, it was already being tested in HttpNetworkTransactionTest. BUG=69688,75000 TEST=Try connecting to belshe.com with various proxy configurations. Should work still. Review URL: http://codereview.chromium.org/6635047 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6681012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77864 0039d316-1c4b-4281-b951-d872f2087c98
* Revert to CHECK when null entries appear in the throttler map.joi@chromium.org2011-03-111-2/+1
| | | | | | | | | | | | | This was always the plan for after the M11 branch point. A recent change (pkasting's r77258) fixed a memory corruption issue, possibly the same as what we're seeing, but hard to verify unless in the wild. BUG=71721 TEST=none Review URL: http://codereview.chromium.org/6680005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77856 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix unnecessary call by values.vandebo@chromium.org2011-03-112-2/+2
| | | | | | | | | | | CID 13152, 14252 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6665016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77826 0039d316-1c4b-4281-b951-d872f2087c98
* Extends NetworkDelegate to avoid use of static_cast<> when handling ↵tony@chromium.org2011-03-103-0/+10
| | | | | | | | | | | | | | | | | | | | | RegisterProtocolHandler URLs. Currently we use a static_cast<> to convert a URLRequestContext into a ChromeURLRequestContext in a ProtocolFactory. However, ProtocolFactory is global and not all URLRequestContexts are instances of ChromeURLRequestContext, so this will always crash in certain circumstances (such as the one described in the TEST field). This change solves the problem by providing a MaybeCreateURLRequestJob() method in NetworkDelegate and then having the ProtocolHandlerRegistry::Factory() call it instead of casting. BUG=74063 TEST=Requesting a URL that has a registerProtocolHandler() from chrome://net-internals/#tests doesn't crash. Review URL: http://codereview.chromium.org/6592060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77559 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r77075,r77077.willchan@chromium.org2011-03-091-6/+0
| | | | | | | | | | | | | They were reverted due to flaky tests, especially on valgrind. Basically, we kept hitting the backup socket timer (500ms) which would create another socket, which the tests don't expect, so they crash. I disabled the backup socket timer completely for the SPDY tests, because they make it too hard to handle the parallel alternate protocol jobs. I also deleted the HTTP fallback test from SpdyNetworkTransactionTest, because it had a similar problem. Also, it was already being tested in HttpNetworkTransactionTest. BUG=69688,75000 TEST=Try connecting to belshe.com with various proxy configurations. Should work still. Review URL: http://codereview.chromium.org/6635047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77399 0039d316-1c4b-4281-b951-d872f2087c98
* Put Filter into namespace net.adamk@chromium.org2011-03-081-28/+30
| | | | | | | | | BUG=64263 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6639002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77373 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of the onBeforeRequest callback in URLRequest.mpcomplete@chromium.org2011-03-081-3/+3
| | | | | | | | | | TBR=willchan BUG=no TEST=no Review URL: http://codereview.chromium.org/6648010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77354 0039d316-1c4b-4281-b951-d872f2087c98
* Implement blocking for webRequest.onBeforeRequest extension event.mpcomplete@chromium.org2011-03-084-8/+48
| | | | | | | | | | | | | I did some measurements with a Release build of chrome, both manually and via the page cycler tests. It seems that a simple empty blocking event listener can add anywhere from a 1 to 30ms delay to request times, largely depending on how many requests are in the queue (when many requests come at once, the last ones to be processed by the extension are delayed the longest). From page cycler data (on my local machine), the average increase in page load time seems to be around 6ms. This is independent of total page load time (which makes sense). BUG=60101 TEST=covered by apitests Review URL: http://codereview.chromium.org/6574049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77339 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetInputStreamBufferSize() method from FilterContext.adamk@chromium.org2011-03-082-12/+0
| | | | | | | | | | | | | This virtual method, implemented only by URLRequestJob and MockFilterContext, was only used for testing purposes. The kFilterBufSize constant now lives in filter.cc (the only place it was used), and for the few tests that needed to override the buffer size, I've added a test-only method in filter.h. The result is a smaller interface surface in URLRequestJob and simpler tests for most cases in gzip_filter_unittest.cc and sdch_filter_unittest.cc. I've done some further refactoring of the former to remove redundancy (most of Filter's complexity is exercised only in the SDCH test). Review URL: http://codereview.chromium.org/6516025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77315 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77075 - Don't block on stream requests on Alternate-Protocol.jochen@chromium.org2011-03-071-0/+6
| | | | | | | | | | | | | | Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it. BUG=69688,75000 TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types). Review URL: http://codereview.chromium.org/6610034 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6621040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77117 0039d316-1c4b-4281-b951-d872f2087c98
* Don't block on stream requests on Alternate-Protocol.willchan@chromium.org2011-03-061-6/+0
| | | | | | | | | | | Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it. BUG=69688,75000 TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types). Review URL: http://codereview.chromium.org/6610034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77075 0039d316-1c4b-4281-b951-d872f2087c98
* Change from CHECK to DCHECK and attempt to handle NULL values, in ↵joi@chromium.org2011-03-052-24/+17
| | | | | | | | | | | | | | | preparation for M11 branch point. Add boolean to iteration history for whether item was removed from map, to verify something I saw in 11.0.690.0 crash dumps. Remove copy of command-line as we have seen there is no correlation between command line and these crashes. BUG=71721 TEST=net_unittests Review URL: http://codereview.chromium.org/6624028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77043 0039d316-1c4b-4281-b951-d872f2087c98
* Change other usages of .size() to .empty() when applicable.erg@google.com2011-03-042-2/+2
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
* Add chunked uploads support to SPDYsatish@chromium.org2011-03-043-19/+13
| | | | | | | | | | | | | | | As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData needs to serve both. BUG=none TEST=net_unittests (2 new tests added) Committed and rolled back: http://src.chromium.org/viewvc/chrome?view=rev&revision=76892 Review URL: http://codereview.chromium.org/6292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76930 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add chunked uploads support to SPDY"satish@chromium.org2011-03-043-13/+19
| | | | | | | | This reverts commit 8431a6e7be70b1b50b0d5b851bbe728b7fef220f. TBR=satish git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76896 0039d316-1c4b-4281-b951-d872f2087c98