summaryrefslogtreecommitdiffstats
path: root/net/url_request
Commit message (Collapse)AuthorAgeFilesLines
...
* Move declaration of private nested URLRequestHttpJob::HttpRequestContext to ↵adamk@chromium.org2011-03-252-25/+28
| | | | | | | | | | | | | .cc file. R=willchan@chromium.org BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/6745014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79453 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all "net::" prefixes under net/url_request for code that'sadamk@chromium.org2011-03-2422-403/+413
| | | | | | | | already in the net namespace. Review URL: http://codereview.chromium.org/6730034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79340 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLRequestJob's histogram logic to URLRequestHttpJob.adamk@chromium.org2011-03-244-354/+323
| | | | | | | | | | | | | While this slightly degeneralizes some stats-collection code, the svn history shows that this code has, over several years, only been used for SDCH, and thus it's worth some degeneralization in order to greatly simplify URLRequestJob. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/6713019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove AddRef()/Release() from ViewHttpCacheJob. Use a Core class.willchan@chromium.org2011-03-222-3/+3
| | | | | | | | | | | | This is part of the process to remove refcounting from URLRequestJob. BUG=none TEST=none Review URL: http://codereview.chromium.org/6717012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79057 0039d316-1c4b-4281-b951-d872f2087c98
* Add field trial & prerendering information to Net.HttpTimeToFirstBytegavinp@chromium.org2011-03-221-0/+33
| | | | | | | | | | | This is a second try, my first pass in Issue 6685030 had to be reverted due to windows try failures. BUG=70957 TEST=about:histograms/Net.HttpTimeToFirstByte Review URL: http://codereview.chromium.org/6708061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78979 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up the last easy URLRequestJob refcounting offenders.willchan@chromium.org2011-03-216-43/+57
| | | | | | | | | | | | Also clean up net:: use in URLRequestJob while I'm there. BUG=none TEST=none Review URL: http://codereview.chromium.org/6709050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78902 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78883 - Add field trial & prerendering information to ↵gavinp@chromium.org2011-03-211-34/+1
| | | | | | | | | | | | | | Net.HttpTimeToFirstByte BUG=70957 TEST=about:histograms/Net.HttpTimeToFirstByte Review URL: http://codereview.chromium.org/6685030 TBR=gavinp@chromium.org Review URL: http://codereview.chromium.org/6712060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78886 0039d316-1c4b-4281-b951-d872f2087c98
* Add field trial & prerendering information to Net.HttpTimeToFirstBytegavinp@chromium.org2011-03-211-1/+34
| | | | | | | | | BUG=70957 TEST=about:histograms/Net.HttpTimeToFirstByte Review URL: http://codereview.chromium.org/6685030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78883 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux clang build.willchan@chromium.org2011-03-192-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6709049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78806 0039d316-1c4b-4281-b951-d872f2087c98
* Change some URLRequestJob subclasses to use ScopedRunnableMethodFactory.willchan@chromium.org2011-03-196-13/+31
| | | | | | | | | | | | This is a step towards not refcounting URLRequestJobs. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78803 0039d316-1c4b-4281-b951-d872f2087c98
* Stop subclassing FilterContext in URLRequestJob.adamk@chromium.org2011-03-174-55/+96
| | | | | | | | | | | | | | | | Create a wrapper for URLRequestHttpJob that subclasses FilterContext, and pass an instance of this facade to Filter::Factory(). Reduce the scope of URLRequestJob's interface as much as possible, moving methods into URLRequestHttpJob or its facade as appropriate, and making methods that remain in URLRequestJob non-virtual where possible. BUG=none TEST=net_unittests,try bots Review URL: http://codereview.chromium.org/6677104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78576 0039d316-1c4b-4281-b951-d872f2087c98
* Remove minidump analysis aides from URLRequestThrottlerManager. Leavejoi@chromium.org2011-03-173-110/+24
| | | | | | | | | | | | | | | in guard against null values. We are no longer getting any new information from more minidumps for this particular crash, so the aides are no longer necessary and I'm leaving the guard in place to minimize the impact on our users. BUG=71721 TEST=net_unittests Review URL: http://codereview.chromium.org/6698033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78552 0039d316-1c4b-4281-b951-d872f2087c98
* Extracting core back-off logic into a separate class,joi@chromium.org2011-03-176-208/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | BackoffEntry. Simplifying the logic slightly while I'm there, removing special support for "after the fact" malformed bodies (the error count doesn't need to be 100% accurate) and removing a constant value added to back-off times (it was only being added once anyway, had close to zero effect). Modifying URLRequestThrottlerEntry and related tests to use the new class instead of co-mingling sliding window logic and exponential back-off logic. Removing now-unnecessary StressTest and associated ugly wart "SetEntryLifetimeMsForTest" method on the URLRequestThrottlerEntryInterface class. Fixing up a few minor things e.g. #pragma once while I'm in there. BUG=none TEST=net_unittests.exe, unit_tests.exe Review URL: http://codereview.chromium.org/6697001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78548 0039d316-1c4b-4281-b951-d872f2087c98
* Make URLRequestHttpJob the only URLRequestJob concerned with FilterContext.adamk@chromium.org2011-03-177-58/+27
| | | | | | | | | | | | | | | | In order to allow this, provide a new factory method in Filter to return a GZipFilter (used by URLRequestFileJob and URLRequestJobTrackerTest), and invert control so that URLRequestJobs are responsible for constructing filters. This is one step away from removing FilterContext as a base class of URLRequestJob, which will be tackled in a followup change. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/6674042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78489 0039d316-1c4b-4281-b951-d872f2087c98
* Remove URLRequestJobMetrics and related code.adamk@chromium.org2011-03-166-142/+0
| | | | | | | | | | | | It's apparently no longer used. R=eroman@chromium.org BUG=none TEST=try bots Review URL: http://codereview.chromium.org/6672036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78417 0039d316-1c4b-4281-b951-d872f2087c98
* Various small cleanups in URLRequestJob:adamk@chromium.org2011-03-162-39/+23
| | | | | | | | | | | | | | - Remove unused or unneeded methods. - Make (almost) all data private. R=eroman@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6697035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78319 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for partitioning cookies for isolated apps.creis@google.com2011-03-152-0/+36
| | | | | | | | | | | | | | | | This CL adds experimental support for letting installed apps request isolated storage in their manifest. An isolated app will have its own cookie store that is not shared with other apps or normal pages, even if they share an origin. The feature is currently behind a --enable-experimental-app-manifests flag. BUG=69335 TEST=ExtensionManifestTest.IsolatedApps TEST=IsolatedAppApiTest.CookieIsolation* Review URL: http://codereview.chromium.org/6201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78301 0039d316-1c4b-4281-b951-d872f2087c98
* Reland rest of r77399.willchan@chromium.org2011-03-121-6/+0
| | | | | | | | | | | I had temporarily reverted it so I could break it up into 2 commits, so the first could be merged to 696. This is part 2. BUG=none TEST=none Review URL: http://codereview.chromium.org/6684019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77908 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r77399 in preparation for merging a small portion of it to 696.willchan@chromium.org2011-03-111-0/+6
| | | | | | | | | | | | | | | | | | Reland r77075,r77077. They were reverted due to flaky tests, especially on valgrind. Basically, we kept hitting the backup socket timer (500ms) which would create another socket, which the tests don't expect, so they crash. I disabled the backup socket timer completely for the SPDY tests, because they make it too hard to handle the parallel alternate protocol jobs. I also deleted the HTTP fallback test from SpdyNetworkTransactionTest, because it had a similar problem. Also, it was already being tested in HttpNetworkTransactionTest. BUG=69688,75000 TEST=Try connecting to belshe.com with various proxy configurations. Should work still. Review URL: http://codereview.chromium.org/6635047 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6681012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77864 0039d316-1c4b-4281-b951-d872f2087c98
* Revert to CHECK when null entries appear in the throttler map.joi@chromium.org2011-03-111-2/+1
| | | | | | | | | | | | | This was always the plan for after the M11 branch point. A recent change (pkasting's r77258) fixed a memory corruption issue, possibly the same as what we're seeing, but hard to verify unless in the wild. BUG=71721 TEST=none Review URL: http://codereview.chromium.org/6680005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77856 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix unnecessary call by values.vandebo@chromium.org2011-03-112-2/+2
| | | | | | | | | | | CID 13152, 14252 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6665016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77826 0039d316-1c4b-4281-b951-d872f2087c98
* Extends NetworkDelegate to avoid use of static_cast<> when handling ↵tony@chromium.org2011-03-103-0/+10
| | | | | | | | | | | | | | | | | | | | | RegisterProtocolHandler URLs. Currently we use a static_cast<> to convert a URLRequestContext into a ChromeURLRequestContext in a ProtocolFactory. However, ProtocolFactory is global and not all URLRequestContexts are instances of ChromeURLRequestContext, so this will always crash in certain circumstances (such as the one described in the TEST field). This change solves the problem by providing a MaybeCreateURLRequestJob() method in NetworkDelegate and then having the ProtocolHandlerRegistry::Factory() call it instead of casting. BUG=74063 TEST=Requesting a URL that has a registerProtocolHandler() from chrome://net-internals/#tests doesn't crash. Review URL: http://codereview.chromium.org/6592060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77559 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r77075,r77077.willchan@chromium.org2011-03-091-6/+0
| | | | | | | | | | | | | They were reverted due to flaky tests, especially on valgrind. Basically, we kept hitting the backup socket timer (500ms) which would create another socket, which the tests don't expect, so they crash. I disabled the backup socket timer completely for the SPDY tests, because they make it too hard to handle the parallel alternate protocol jobs. I also deleted the HTTP fallback test from SpdyNetworkTransactionTest, because it had a similar problem. Also, it was already being tested in HttpNetworkTransactionTest. BUG=69688,75000 TEST=Try connecting to belshe.com with various proxy configurations. Should work still. Review URL: http://codereview.chromium.org/6635047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77399 0039d316-1c4b-4281-b951-d872f2087c98
* Put Filter into namespace net.adamk@chromium.org2011-03-081-28/+30
| | | | | | | | | BUG=64263 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6639002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77373 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of the onBeforeRequest callback in URLRequest.mpcomplete@chromium.org2011-03-081-3/+3
| | | | | | | | | | TBR=willchan BUG=no TEST=no Review URL: http://codereview.chromium.org/6648010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77354 0039d316-1c4b-4281-b951-d872f2087c98
* Implement blocking for webRequest.onBeforeRequest extension event.mpcomplete@chromium.org2011-03-084-8/+48
| | | | | | | | | | | | | I did some measurements with a Release build of chrome, both manually and via the page cycler tests. It seems that a simple empty blocking event listener can add anywhere from a 1 to 30ms delay to request times, largely depending on how many requests are in the queue (when many requests come at once, the last ones to be processed by the extension are delayed the longest). From page cycler data (on my local machine), the average increase in page load time seems to be around 6ms. This is independent of total page load time (which makes sense). BUG=60101 TEST=covered by apitests Review URL: http://codereview.chromium.org/6574049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77339 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetInputStreamBufferSize() method from FilterContext.adamk@chromium.org2011-03-082-12/+0
| | | | | | | | | | | | | This virtual method, implemented only by URLRequestJob and MockFilterContext, was only used for testing purposes. The kFilterBufSize constant now lives in filter.cc (the only place it was used), and for the few tests that needed to override the buffer size, I've added a test-only method in filter.h. The result is a smaller interface surface in URLRequestJob and simpler tests for most cases in gzip_filter_unittest.cc and sdch_filter_unittest.cc. I've done some further refactoring of the former to remove redundancy (most of Filter's complexity is exercised only in the SDCH test). Review URL: http://codereview.chromium.org/6516025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77315 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77075 - Don't block on stream requests on Alternate-Protocol.jochen@chromium.org2011-03-071-0/+6
| | | | | | | | | | | | | | Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it. BUG=69688,75000 TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types). Review URL: http://codereview.chromium.org/6610034 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6621040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77117 0039d316-1c4b-4281-b951-d872f2087c98
* Don't block on stream requests on Alternate-Protocol.willchan@chromium.org2011-03-061-6/+0
| | | | | | | | | | | Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it. BUG=69688,75000 TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types). Review URL: http://codereview.chromium.org/6610034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77075 0039d316-1c4b-4281-b951-d872f2087c98
* Change from CHECK to DCHECK and attempt to handle NULL values, in ↵joi@chromium.org2011-03-052-24/+17
| | | | | | | | | | | | | | | preparation for M11 branch point. Add boolean to iteration history for whether item was removed from map, to verify something I saw in 11.0.690.0 crash dumps. Remove copy of command-line as we have seen there is no correlation between command line and these crashes. BUG=71721 TEST=net_unittests Review URL: http://codereview.chromium.org/6624028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77043 0039d316-1c4b-4281-b951-d872f2087c98
* Change other usages of .size() to .empty() when applicable.erg@google.com2011-03-042-2/+2
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
* Add chunked uploads support to SPDYsatish@chromium.org2011-03-043-19/+13
| | | | | | | | | | | | | | | As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData needs to serve both. BUG=none TEST=net_unittests (2 new tests added) Committed and rolled back: http://src.chromium.org/viewvc/chrome?view=rev&revision=76892 Review URL: http://codereview.chromium.org/6292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76930 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add chunked uploads support to SPDY"satish@chromium.org2011-03-043-13/+19
| | | | | | | | This reverts commit 8431a6e7be70b1b50b0d5b851bbe728b7fef220f. TBR=satish git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76896 0039d316-1c4b-4281-b951-d872f2087c98
* Add chunked uploads support to SPDYsatish@chromium.org2011-03-043-19/+13
| | | | | | | | | | | | | As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData needs to serve both. BUG=none TEST=net_unittests (2 new tests added) Review URL: http://codereview.chromium.org/6292013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76892 0039d316-1c4b-4281-b951-d872f2087c98
* Modify ThreadChecker and NonThreadSafe so that theirjoi@chromium.org2011-03-032-52/+2
| | | | | | | | | | | | | | | functionality is available in release builds if explicitly requested by using their Impl types. The default usage remains that they do nothing in release mode. Also, update unit tests to run in release mode, verifying that the release versions of NonThreadSafe and ThreadChecker do nothing in release builds. BUG=none TEST=base unit tests Review URL: http://codereview.chromium.org/6599004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76833 0039d316-1c4b-4281-b951-d872f2087c98
* Single-threaded stress test for URLRequestThrottlerManagerjoi@chromium.org2011-03-026-16/+168
| | | | | | | | | | | | | | | to try to reproduce bug seen only in the wild. On my system, it does not reproduce the bug. Want to check in in case it reproduces on any of the bots. Also, add code that will make minidumps of this crash more information-rich, to help track down problem. Add guard buffers around a couple of key things, to help identify memory overwrite. Add simple unit test to make sure the new style of CHECK for one or more null values in the map works correctly. BUG=71721 TEST=none Review URL: http://codereview.chromium.org/6598043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76487 0039d316-1c4b-4281-b951-d872f2087c98
* Add a hard CHECK on use from a single thread to URLRequestThrottlerManager. ↵joi@chromium.org2011-02-253-51/+111
| | | | | | | | | | | | | This is done via a temporary copy of ThreadChecker so it can be made to work in release builds as well. Revert iterator use back to most optimal approach (previous changes were intended as temporary). BUG=71721 TEST=net_unittest Review URL: http://codereview.chromium.org/6581014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76018 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor of NetworkDelegate.willchan@chromium.org2011-02-248-33/+35
| | | | | | | | | | | | | | * Renames HttpNetworkDelegate to NetworkDelegate, moves to net/base/network_delegate.h. NOTE: this is a layering violation. wtc/eroman/willchan have agreed to this exception because the other solutions are less palatable. * Move the virtuals in NetworkDelegate to the private section. Use non-virtual public interface as the network stack's interface for notifying the delegate. Add sanity checking to the implmentation in NetworkDelegate. The private virtual interface is for consumers to receive notifications. * Remove ExtensionIOEventRouter from ChromeURLRequestContext, it is only used by the ChromeNetworkDelegate. Pass it directly to the ChromeNetworkDelegate's constructor. * Introduce a SystemNetworkDelegate. It does nothing right now. BUG=67232 TEST=none Review URL: http://codereview.chromium.org/6580002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75822 0039d316-1c4b-4281-b951-d872f2087c98
* Create a URLRequestContextStorage object to provide storage for ↵willchan@chromium.org2011-02-235-24/+230
| | | | | | | | | | | URLRequestContext objects. BUG=none TEST=none Review URL: http://codereview.chromium.org/6560001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75756 0039d316-1c4b-4281-b951-d872f2087c98
* Send fatal proxy errors to the network delegate.jochen@chromium.org2011-02-235-2/+138
| | | | | | | | | BUG=60099 TEST=browser test Review URL: http://codereview.chromium.org/6541021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75726 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram for tracking time to HTTP-response data available.gavinp@chromium.org2011-02-222-0/+39
| | | | | | | | | | | | | | This CL adds a new histogram, Net.HttpStartTime, which tracks the amount of time from the creation of an UrlRequestHttpJob, until the first data is available to be passed back. This is part of issue 70957, and arguably the easier half. BUG=70957 TEST=none Review URL: http://codereview.chromium.org/6537025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75632 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate the remote socket address to URLRequest and to ↵bryner@chromium.org2011-02-229-1/+67
| | | | | | | | | | | | | | | | ViewHostMsg_FrameNavigate. This will be used to run pre-classification checks for client-side phishing detection, and will also enable the socket address to be exposed via the webRequest extension API. This is adapted from the original patch by pmarks on http://codereview.chromium.org/6369003/ . BUG=51663 TEST=added socket address checks to various unittests Review URL: http://codereview.chromium.org/6488010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75620 0039d316-1c4b-4281-b951-d872f2087c98
* Update customization manifest reader to match desing docdpolukhin@chromium.org2011-02-211-1/+1
| | | | | | | | | BUG=chromium-os:11736 TEST=ServicesCustomizationDocumentTest.* StartupCustomizationDocumentTest.* Review URL: http://codereview.chromium.org/6541025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75548 0039d316-1c4b-4281-b951-d872f2087c98
* Removing AccessLog class. This is a partial revert of yzshen's r74872.joi@chromium.org2011-02-182-69/+1
| | | | | | | | | | | | | | | | | | | | The AccessLog class was something we added to track down a crash, which is no longer happening after that change. Reverting piece by piece and waiting for the next canary build before doing the next part. Note that the use of the AccessLog class could have introduced slight serialization to the method URLRequestThrottlerManager::RegisterRequestUrl as it would call the AccessLog::Add method which synchronized on a lock. So removing is not 100% safe; I will watch for crashes in the canary builds after this. BUG=71721 TEST=none Review URL: http://codereview.chromium.org/6538061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75438 0039d316-1c4b-4281-b951-d872f2087c98
* Add unique identifier to url requestsjochen@chromium.org2011-02-173-1/+30
| | | | | | | | | BUG=60101 TEST=net_unittests Review URL: http://codereview.chromium.org/6526014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75241 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-165-60/+75
| | | | | | | | | | | Merged correctly this time. BUG=none TEST=none Review URL: http://codereview.chromium.org/6523067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75165 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75143 - Reland r74842willchan@chromium.org2011-02-165-75/+60
| | | | | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6480120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75152 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-165-60/+75
| | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75143 0039d316-1c4b-4281-b951-d872f2087c98
* Add checks to URLRequestThrottlerManager to help identify the cause of crashes.yzshen@chromium.org2011-02-142-17/+108
| | | | | | | | | BUG=71721 TEST=None Review URL: http://codereview.chromium.org/6474024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74872 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74842 - It seems to have broken the ChromeOS "PFQ bot"?willchan@chromium.org2011-02-145-75/+60
| | | | | | | | | | | | | | | | r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK. I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6484041 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6517021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74848 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 22:02:17 +0000