summaryrefslogtreecommitdiffstats
path: root/pdf/out_of_process_instance.cc
Commit message (Collapse)AuthorAgeFilesLines
* PDF: Fix potential bad indexes in find results.thestig2014-11-041-0/+1
| | | | | | | | | | | Add a new FindTextData class to store the index to avoid all the size_t to int casts. BUG=416696 Review URL: https://codereview.chromium.org/691273003 Cr-Commit-Position: refs/heads/master@{#302532}
* Support non-integer scroll offsets being passed to the PDF plugin.raymes2014-10-291-15/+17
| | | | | | | | | | This broke as a result of non-integer scroll offsets being introduced into blink. BUG=303491 Review URL: https://codereview.chromium.org/685923002 Cr-Commit-Position: refs/heads/master@{#301765}
* Handle the keyboard event for ctrl+a inside pdf.js instead of ↵deepak.m12014-10-031-10/+4
| | | | | | | | | | | | out_of_process_pdf.cc This moves the logic to handle the ctrl+a keyboard event into the pdf.js container page, sending a message to the plugin to select all the text. This ensures that the event is handled, even if the plugin element doesn't have focus in the document. BUG=419986 Review URL: https://codereview.chromium.org/615853003 Cr-Commit-Position: refs/heads/master@{#297998}
* PDF Viewer - Add keyboard shortcuts for rotationn.bansal2014-09-191-0/+7
| | | | | | | | | | | | | | | Currently there are no keyboard shortcuts to rotate pdf documents. This patch adds the following keyboard shortcuts to rotate pdf documents : Rotate counterclockwise : Control + [ Rotate clockwise : Control + ] BUG=111232 Review URL: https://codereview.chromium.org/581913003 Cr-Commit-Position: refs/heads/master@{#295757}
* Remove unneeded #include from out_of_proces_instance.ccraymes2014-09-161-1/+0
| | | | | | Review URL: https://codereview.chromium.org/571843002 Cr-Commit-Position: refs/heads/master@{#294995}
* OOP PDF - Add support for "page" open pdf parametern.bansal@samsung.com2014-08-191-55/+1
| | | | | | | | | | | | | | | This patch adds support for "page" feature of open PDF parameters in OOP PDF. When page is used as an open PDF parameter, then PDF should initially be loaded at the page specified by user. BUG=64309 Review URL: https://codereview.chromium.org/476733003 Cr-Commit-Position: refs/heads/master@{#290529} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove OS_NACL #ifdefs in pdf/raymes@chromium.org2014-08-011-4/+0
| | | | | | | | | | | There are some OS_NACL ifdefs in pdf/{instance.cc/out_of_process_instance.cc}. I assume these are from long ago when we tried to get PDF running in NaCl but I believe that at present many more changes would be required to get it running in NaCl again so we might as well remove these. Review URL: https://codereview.chromium.org/424763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286927 0039d316-1c4b-4281-b951-d872f2087c98
* PDF: Fix navigation for links that are just relative fragments.thestig@chromium.org2014-07-151-0/+7
| | | | | | | | | BUG=389333 TEST=Manual, see bug. Review URL: https://codereview.chromium.org/335993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283268 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for re-enabling more MSVC level 4 warnings: pdf/ editionpkasting@chromium.org2014-07-091-14/+8
| | | | | | | | | | | | | | | | | | This contains fixes for the following sorts of issues: * Signedness mismatch This relies on https://codereview.chromium.org/376003003 to make FPDF_FillRect() take a 32-bit value for the color in order to make the changes here as simple and clean as possible. This also contains a few other cleanups to make code simpler or more consistent. BUG=81439 TEST=none Review URL: https://codereview.chromium.org/372273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282146 0039d316-1c4b-4281-b951-d872f2087c98
* PDF: Cleanup the declarations for a bunch of const char* variables.thestig@chromium.org2014-06-271-50/+50
| | | | | | Review URL: https://codereview.chromium.org/354513007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280228 0039d316-1c4b-4281-b951-d872f2087c98
* Improve scrolling performance in OOP PDFraymes@chromium.org2014-06-261-32/+51
| | | | | | | | | | | | | | | | | | | | | | | This increases the performance of scrolling in OOP PDF by not sending viewport changes via postMessage every time a scroll event occurs on the page. Instead, scroll events are sent along with pepper DidChangeView messages, which is a much more responsive way of updating the scroll position. Unfortunately this introduces some issues coordinating zoom and scroll events on the page. When a zoom happens in the container page, a scroll message might be sent to the plugin via DidChangeView. Then we send a zoom change message via postMessage. The result is that the zooming and scrolling happen asynchronously and result in a flickering effect. To avoid this, we first notify the plugin that we are about to zoom which causes it to stop reacting to scroll messages. After we have finished zooming we notify the plugin again so that it can continue reacting to scroll messages. BUG=386920 Review URL: https://codereview.chromium.org/347763007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279910 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable PDFExtensionTest.BasicPluginraymes@chromium.org2014-06-191-1/+1
| | | | | | | | | | | | | This test was disabled because it was failing. A few changes have been made: -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). BUG=303491 Review URL: https://codereview.chromium.org/290803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278340 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 278043 "Re-enable PDFExtensionTest.BasicPlugin"brettw@chromium.org2014-06-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test fails consistently on Linux Tests (dbg) (1) [ RUN ] PDFExtensionTest.BasicPlugin ... [1023:1023:0618/142028:INFO:CONSOLE(0)] "[SUCCESS] testPageSize", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://127.0.0.1:42118/pdf/test.pdf (0) [17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully. [17:17:0618/142028:ERROR:pepper_uma_host.cc(106)] Host or histogram name is not allowed to use the UMA API. [17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully. memory allocation bug: object at 0x7f5a852272c0 has never been allocated BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f9e4351c8b5 base::debug::StackTrace::StackTrace() #1 0x00000462f8f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9e2fb2f4a0 \u003Cunknown> #3 0x7f9e2fbe1a43 __poll #4 0x7f9e30917ff6 \u003Cunknown> #5 0x7f9e30918124 g_main_context_iteration #6 0x7f9e434e49e5 base::MessagePumpGlib::Run() <truncated, full output is in gzipped JSON output at end of step> #31 0x7f9e34f05dc7 content::RunNamedProcessTypeMain() #32 0x7f9e34f074df content::ContentMainRunnerImpl::Run() #33 0x7f9e34f0528b content::ContentMain() ... > Re-enable PDFExtensionTest.BasicPlugin > > This test was disabled because it was failing. A few changes have been made: > -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. > -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. > -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). > > BUG=303491 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186 > > Review URL: https://codereview.chromium.org/290803007 TBR=raymes@chromium.org Review URL: https://codereview.chromium.org/346693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278191 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable PDFExtensionTest.BasicPluginraymes@chromium.org2014-06-181-1/+1
| | | | | | | | | | | | | | | | | This test was disabled because it was failing. A few changes have been made: -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186 Review URL: https://codereview.chromium.org/290803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278043 0039d316-1c4b-4281-b951-d872f2087c98
* Merge DidStartLoading/DidStopLoading imbalance patch to OOP PDFraymes@chromium.org2014-06-131-14/+23
| | | | | | | | | | | This merges this CL https://chromereviews.googleplex.com/32997013/ to OOP PDF and also corrects some minor differences that had arisen in document loading. BUG=303491 Review URL: https://codereview.chromium.org/333553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276954 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 274186 "Re-enable PDFExtensionTest.BasicPlugin"battre@chromium.org2014-06-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Reverting - still flaky. See http://crbug.com/303491#c104 for details. > Re-enable PDFExtensionTest.BasicPlugin > > This test was disabled because it was failing. A few changes have been made: > -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. > -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. > -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). > > BUG=303491 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819 > > Review URL: https://codereview.chromium.org/290803007 TBR=raymes@chromium.org Review URL: https://codereview.chromium.org/302163007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274219 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable PDFExtensionTest.BasicPluginraymes@chromium.org2014-06-021-1/+1
| | | | | | | | | | | | | | | This test was disabled because it was failing. A few changes have been made: -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819 Review URL: https://codereview.chromium.org/290803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix loading PDFs with no HTTP response headers in OOP PDFraymes@chromium.org2014-05-311-0/+6
| | | | | | | | | | | | | | | | | | | Currently if no response headers are passed into the plugin in OOP PDF then the headers fetched URLLoader that loaded the stream URL will be used, but the MIME type for the blob URL is always plain text, which causes the document loader to refuse to load the document. Currently, if no headers are passed to the in process plugin, we always try to load the document, so this just mimics that behavior in the OOP plugin. When the in-process plugin is removed we can change the document loader and remove the hack. This also removes blob: URLs from the MIME type check in document loader because they are no longer ever passed in. BUG=303491 Review URL: https://codereview.chromium.org/301223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274081 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most references to VarPrivate/InstancePrivate from OOP PDFraymes@chromium.org2014-05-211-23/+53
| | | | | | | | | | | | | | | | | This removes most references to VarPrivate and InstancePrivate from OOP PDF. These APIs are deprecated and we'd like to remove them. In most cases where they are currently used, we can simply switch to using a PostMessage to communicate with the extension. In the case of modal dialogs, these need to run synchronously from the perspective of the PDF engine and so PostMessage isn't sufficient. Right now these calls still use InstancePrivate but we should switch to using a specific private API eventually. BUG=303491 Review URL: https://codereview.chromium.org/286933011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271998 0039d316-1c4b-4281-b951-d872f2087c98
* Add the pdf plugin's source in src\pdf.jam@chromium.org2014-05-201-0/+1362
I've updated gypi files to not use internal_pdf variable anymore, which was brought in from pdf repo's supplemental.gypi. R=thestig@chromium.org TBR=darin Review URL: https://codereview.chromium.org/294793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271531 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-11 12:23:10 +0000