| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
Cr-Commit-Position: refs/heads/master@{#382939}
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#383105}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1817573003/ )
Reason for revert:
Breaks downstream Android ToT builds, and hence prevents Chromium changes rolling into downstream Android builds.
BUG= 597559
Original issue's description:
> Move ServiceUrls to remoting/host
>
> ServiceUrls was used only in one place in android client and it's
> not really useful there. Moved it to the host directory.
>
> TBR=rogerta@chromium.org
>
> Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
> Cr-Commit-Position: refs/heads/master@{#382939}
TBR=lambroslambrou@chromium.org,rogerta@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1830993002
Cr-Commit-Position: refs/heads/master@{#383060}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will later also consider storing max latency data in server
BUG=560950
Committed: https://crrev.com/e37a467453f3814a9ecb0eb6769bd7c58b61cbae
Cr-Commit-Position: refs/heads/master@{#382663}
Review URL: https://codereview.chromium.org/1811833002
Cr-Commit-Position: refs/heads/master@{#382957}
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#382939}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1811833002/ )
Reason for revert:
Caused compile failure on 64-bit Android bots. See crbug.com/597155
Original issue's description:
> Show max latency on client's status bar
>
> Will later also consider storing max latency data in server
>
> BUG=560950
>
> Committed: https://crrev.com/e37a467453f3814a9ecb0eb6769bd7c58b61cbae
> Cr-Commit-Position: refs/heads/master@{#382663}
TBR=sergeyu@chromium.org,kelvinp@chromium.org,dbeam@chromium.org,yuweih@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=560950
Review URL: https://codereview.chromium.org/1817093005
Cr-Commit-Position: refs/heads/master@{#382777}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland http://crrev.com/1764503002 with fixes for the Android app and
tests:
* Initialize ChromotingClientRuntime::ui_task_runner_
* Add new unittest to GN build.
* Don't call MessageLoopForUI::Start() in Android test.
TBR=nicholss
Review URL: https://codereview.chromium.org/1827573002
Cr-Commit-Position: refs/heads/master@{#382757}
|
|
|
|
|
|
|
|
|
|
| |
Will later also consider storing max latency data in server
BUG=560950
Review URL: https://codereview.chromium.org/1811833002
Cr-Commit-Position: refs/heads/master@{#382663}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#23 id:440001 of https://codereview.chromium.org/1764503002/ )
Reason for revert:
Broke Android client and tests - see bug 596240.
Original issue's description:
> Adding container class for chromoting client runtimes.
>
> R=lambroslambrou@chromium.org
>
> Committed: https://crrev.com/b34c0f6877af54e8bdd6052bf8934dd46a3b5899
> Cr-Commit-Position: refs/heads/master@{#380979}
TBR=sergeyu@chromium.org,nicholss@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1821623003
Cr-Commit-Position: refs/heads/master@{#382411}
|
|
|
|
|
|
|
|
|
| |
These are no longer needed, now that we are using device-based
authentication via GoogleAuthUtil from Google Play Services.
Review URL: https://codereview.chromium.org/1818673002
Cr-Commit-Position: refs/heads/master@{#382158}
|
|
|
|
|
|
|
|
|
|
| |
Reduced official build size from 7.9MB to 6.4MB. Can reenable WebRTC by changing the BUILD.gn file.
BUG=595038
Review URL: https://codereview.chromium.org/1806963002
Cr-Commit-Position: refs/heads/master@{#381636}
|
|
|
|
|
|
|
|
| |
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/1764503002
Cr-Commit-Position: refs/heads/master@{#380979}
|
|
|
|
|
|
|
|
|
|
|
| |
Moved ClientAuthenticationConfig to a separate file and now it's used
in PairingClientAuthenticator.
BUG=593123
Review URL: https://codereview.chromium.org/1794433002
Cr-Commit-Position: refs/heads/master@{#380872}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.
BUG=589698
Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
Review URL: https://codereview.chromium.org/1778023002
Cr-Commit-Position: refs/heads/master@{#380831}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:40001 of https://codereview.chromium.org/1778023002/ )
Reason for revert:
Appears to be breaking compile on Linux and Mac:
https://build.chromium.org/p/chromium/builders/Linux/builds/72875
https://build.chromium.org/p/chromium/builders/Mac/builds/13060
Output:
FAILED: /b/build/slave/Linux/build/src/build/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ ... -c ../../remoting/test/chromoting_test_fixture.cc -o obj/remoting/test/chromoting_test_driver.chromoting_test_fixture.o
In file included from ../../remoting/test/chromoting_test_fixture.cc:14:
In file included from ../../remoting/test/test_chromoting_client.h:14:
In file included from ../../remoting/client/chromoting_client.h:19:
In file included from ../../remoting/protocol/negotiating_client_authenticator.h:15:
In file included from ../../remoting/protocol/negotiating_authenticator_base.h:16:
../../third_party/webrtc/libjingle/xmllite/xmlelement.h:17:10: fatal error: 'webrtc/libjingle/xmllite/qname.h' file not found
#include "webrtc/libjingle/xmllite/qname.h"
^
1 error generated.
ninja: build stopped: subcommand failed.
Original issue's description:
> Move NegotiatingClientAuthentication creation to ChromotingClient.
>
> For the new SPAKE2 authenticator we need to pass client_jid
> to the authenticator. This wasn't possible previously because
> NegotiatingClientAuthenticator was created before signaling is
> connected. Moved NegotiatingClientAuthentication creation to
> ChromotingClient.
>
> BUG=589698
>
> Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
> Cr-Commit-Position: refs/heads/master@{#380779}
TBR=jamiewalch@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589698
Review URL: https://codereview.chromium.org/1788943002
Cr-Commit-Position: refs/heads/master@{#380785}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.
BUG=589698
Review URL: https://codereview.chromium.org/1778023002
Cr-Commit-Position: refs/heads/master@{#380779}
|
|
|
|
|
|
|
|
|
| |
Callbacks are already used to fetch PIN. It doesn't make sense to
use a different style to fetch third-party tokens.
Review URL: https://codereview.chromium.org/1774113005
Cr-Commit-Position: refs/heads/master@{#380316}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously AuthenticationMethod type was used in many places. Removed
all dependencies on it except from NegotiatingAuthenticator classes.
AuthenticationMethod has been moved to
NegotiatingAuthenticatorBase::Method.
Also includes the following cleanups:
- removed old authentication functions from auth_util.cc which were
no longer needed.
- Remove HashFunction enum as it wasn't useful.
BUG=589698
Review URL: https://codereview.chromium.org/1768383004
Cr-Commit-Position: refs/heads/master@{#380078}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1 Previously AuthenticationMethod was a class. Replaced
it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
that passes around PIN hash.
3 If the host config contains PIN in plain text then now
the host hashes it instead of using spake2_plain
authenticator method. This means that spake2_hmac is
always used for Me2Me even when the PIN is not hashed
in the config.
This change will make it easier to add new authentication
methods.
BUG=589698
Review URL: https://codereview.chromium.org/1755273003
Cr-Commit-Position: refs/heads/master@{#379365}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PepperPortAllocator and ChromiumPortAllocator were different only in
how they were sending HTTP requests to allocate relay session. They were
using pp::URLLoader and net::URLFetcher respectively, but otherwise
contained largely the same logic. Now URL request logic is abstracted
with remoting::UrlRequest interface and so a single PortAllocator
implementation can be used in all cases.
BUG=577954
Review URL: https://codereview.chromium.org/1681393006
Cr-Commit-Position: refs/heads/master@{#375042}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new flags field in shared preferences that can used to pass
flags to the client. There is no UI to update the flags, but the
included script allows to update the flags using ADB.
BUG=547158
Review URL: https://codereview.chromium.org/1645213002
Cr-Commit-Position: refs/heads/master@{#372416}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moved FrameConsumer interface to remoting/protocol. This
will allow to implement video rendering in WebrtcConnectionToHost as
WebRTC stack is responsible for video decoding.
BUG=547158
Review URL: https://codereview.chromium.org/1559043004
Cr-Commit-Position: refs/heads/master@{#367600}
|
|
|
|
|
|
|
|
|
|
|
| |
VideoRenderer interface is going to be used by ConnectionToHost, so it
belongs to the protocol layer.
BUG=547158
Review URL: https://codereview.chromium.org/1559023003
Cr-Commit-Position: refs/heads/master@{#367588}
|
|
|
|
|
|
|
|
|
|
| |
Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.
Review URL: https://codereview.chromium.org/1545723002
Cr-Commit-Position: refs/heads/master@{#366778}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/1542203002
Cr-Commit-Position: refs/heads/master@{#366684}
|
|
|
|
|
|
|
|
|
|
|
| |
We will have another implementation of ConnectionToHost. Renaming the
current implementation will make it easier to distinguish between them.
BUG=547158
Review URL: https://codereview.chromium.org/1532123005
Cr-Commit-Position: refs/heads/master@{#366024}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add joedow@.
Add notices to keep files in sync.
Removed some people who are not working on or reviewing Android code.
(Since we don't set noparent, anyone in the parent OWNERS can still
approve changes. Keeping OWNERS lists small will help people outside
our team to select reviewers).
Review URL: https://codereview.chromium.org/1533623002
Cr-Commit-Position: refs/heads/master@{#365858}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new TransportContext is now used to store all parameters required
to initialize Transport objects and is applicable both to IceTransport
and WebrtcTransport. It also allowed to reduce amount of boilerplate
code when passing around these parameters.
BUG=547158
Review URL: https://codereview.chromium.org/1521883006
Cr-Commit-Position: refs/heads/master@{#365649}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass all object parameters to JNI methods in JavaParamRef<> wrappers.
This matches previous changes made to do this for JNI non-method
functions.
BUG=519562
R=solb@chromium.org
Review URL: https://codereview.chromium.org/1472053003
Cr-Commit-Position: refs/heads/master@{#363000}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of each user of base setting the native-side global app context
separately, introduce a Java-side global app context, which is always
in sync with the native-side one. Switch most callers to setting
it on the Java side, except where this is problematic.
Callers of ApplicationStatus.getApplicationContext will be updated
incrementally in followup CLs once it's been verified that they only
require a Context and not a BaseChromiumApplication.
BUG=552419
Review URL: https://codereview.chromium.org/1407233017
Cr-Commit-Position: refs/heads/master@{#361306}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first in a series of changes to implement touch input on the
Android client, consumers of this change will appear in a subsequent
change.
The Change includes the data structure we will use for storing touch event
data, the code needed to marshal the data across the java/c++ boundary,
and the code to create the native TouchEvent structure to be sent to the
host.
BUG=454549
Review URL: https://codereview.chromium.org/1424603002
Cr-Commit-Position: refs/heads/master@{#356672}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previosly JingleSession was responsible to establishing connection
with the peer and managing list of channels. Now the new
IceTransportSession class (that implements TransportSession interface)
is responsible for managing list of channels and so it will be possible
to add support for WebRTC-based transport by adding another
TransportSession implementation.
There are no functional changes in this CL.
BUG=547158
Committed: https://crrev.com/7a5351f4c6e407e456978f6599d475616a69fc0b
Cr-Commit-Position: refs/heads/master@{#356588}
Review URL: https://codereview.chromium.org/1420273002
Cr-Commit-Position: refs/heads/master@{#356638}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch renames base::MessageLoop::{Quit,QuitClosure} to
base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}.
BUG=131220
TEST=
R=joedow@chromium.org
Review URL: https://codereview.chromium.org/1394803004
Cr-Commit-Position: refs/heads/master@{#353583}
|
|
|
|
|
|
|
|
|
|
| |
Previously decode and rendering time wasn't include the total roundtrip
estimation, which is fixed now. Also moved latency calculation logic to
PerformanceTracker, which allowed to simplify rendering code.
Review URL: https://codereview.chromium.org/1382523002
Cr-Commit-Position: refs/heads/master@{#351850}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously PerformanceTracker was owned by VideoRenderer
implementations. Move it to ChromotingInstance and
ChromotingJniInstance because the tracker will be responsible for
tracking all performance stats that may not be related to video
rendering.
Review URL: https://codereview.chromium.org/1353443003
Cr-Commit-Position: refs/heads/master@{#349498}
|
|
|
|
|
|
|
|
|
|
| |
The class will be used directly from protocol dispatchers, so it needs
to be accessible on the protocol layer. Also renamed it so the name
reflects what the class is responsible for.
Review URL: https://codereview.chromium.org/1351723004
Cr-Commit-Position: refs/heads/master@{#349295}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't allow JavaParamRefs to be used to construct ScopedJavaLocalRefs.
This leads to incorrect reference handling behaviour, since parameters
are not allowed to be deleted. Instead code should simply pass the
JavaParamRef by reference; functions should be taking "const JavaRef&"
for input which is compatible.
Fix the cases in the code where this conversion is currently being
relied upon.
BUG=506850
Review URL: https://codereview.chromium.org/1326763009
Cr-Commit-Position: refs/heads/master@{#347923}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously android app was using key code when sending keyboard events.
That approach doesn't work well with physical keyboard when using
layout other than QWERTY. Fixed the client to use scan codes, so that
the events are always send correctly and layout mapping is applied
only on the client.
BUG=475713
Review URL: https://codereview.chromium.org/1321223003
Cr-Commit-Position: refs/heads/master@{#347874}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass all object parameters to JNI functions in JavaParamRef<> wrappers.
This new type behaves like ScopedJavaLocalRef, but does not free the
local reference when it goes out of scope, since the JVM does not allow
method parameters to be freed and this causes a warning.
This CL only changes the implementation of the generator and the
signatures of JNI functions which take JavaParamRef arguments; the
minimum required to allow it to compile and work. An implicit cast from
JavaParamRef<T> to T is defined, to allow function bodies to remain
unaltered. These will be migrated over future CLs and the cast removed.
BUG=506850
Review URL: https://codereview.chromium.org/1312153003
Cr-Commit-Position: refs/heads/master@{#347379}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds new Java/C++ classes (empty stubs) for managing a connection
to the host. A new instance will be created each time a connection is
made, which should eliminate a class of bugs where notifications are
received from previous connections.
Now that more than 1 Java class is using JNI, this CL also adds
remoting_jni_registrar.cc to manage all the JNI registrations, in line
with other examples in Chromium code.
This also renames the ..onload.cc file, to follow the naming convention
used elsewhere (since our code lives in the remoting/ directory).
BUG=526336
Review URL: https://codereview.chromium.org/1319293002
Cr-Commit-Position: refs/heads/master@{#346998}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedJavaLocalRef."
Instead of only expecting C++ methods to return ScopedJavaLocalRefs for
object return values, apply this to all native functions. This further
reduces the difference between methods and nonmethods. The vast majority
of native nonmethod functions already have a ScopedJavaLocalRef and
currently write "return foo.Release()" to return it, so this is a fairly
small change in actual behaviour; only a few functions need to create
one.
Also, remove the namespace qualifiers from the existing generated
references to ScopedJavaLocalRef, since jni_generator_helper.h already
includes a "using" declaration for it.
BUG=379897
Review URL: https://codereview.chromium.org/1314853004
Cr-Commit-Position: refs/heads/master@{#345602}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedJavaLocalRef. (patchset #5 id:80001 of https://codereview.chromium.org/1288183004/ )
Reason for revert:
Broke Android GN build:
http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/29644
FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/mojo/android/libmojo_java_unittests/validation_test_util.o.d -DUNIT_TEST -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DDONT_EMBED_BUILD_METADATA -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__GNU_SOURCE=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DGTEST_USE_OWN_TR1_TUPLE=1 -DGTEST_HAS_TR1_TUPLE=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -I../.. -Igen -Igen/mojo/android/jni_headers -Igen/mojo/android/jni_headers/mojo -Igen/mojo/android/system_java_jni_headers -Igen/mojo/android/system_java_jni_headers/mojo -I../../testing/gtest/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/mojo/src -Igen/third_party/mojo/src -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fvisibility=hidden --sysroot=/b/build/slave/Android_GN/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm -Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -fno-rtti -fno-exceptions -c ../../mojo/android/javatests/validation_test_util.cc -o obj/mojo/android/libmojo_java_unittests/validation_test_util.o
../../mojo/android/javatests/validation_test_util.cc: In function '_jobject* mojo::android::ParseData(JNIEnv*, jclass, jstring)':
../../mojo/android/javatests/validation_test_util.cc:21:70:error: ambiguating new declaration of '_jobject* mojo::android::ParseData(JNIEnv*, jclass, jstring)'
jobject ParseData(JNIEnv* env, jclass jcaller, jstring data_as_string) {
^
In file included from ../../mojo/android/javatests/validation_test_util.cc:11:0:
gen/mojo/android/jni_headers/mojo/jni/ValidationTestUtil_jni.h:34:36: note: old declaration 'base::android::ScopedJavaLocalRef<_jobject*> mojo::android::ParseData(JNIEnv*, jclass, jstring)'
static ScopedJavaLocalRef<jobject> ParseData(JNIEnv* env, jclass jcaller,
^
gen/mojo/android/jni_headers/mojo/jni/ValidationTestUtil_jni.h: At global scope:
gen/mojo/android/jni_headers/mojo/jni/ValidationTestUtil_jni.h:34:36:error: 'base::android::ScopedJavaLocalRef<_jobject*> mojo::android::ParseData(JNIEnv*, jclass, jstring)' declared 'static' but never defined [-Werror=unused-function]
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.
Original issue's description:
> jni_generator: Make all object-returning natives return ScopedJavaLocalRef.
>
> Instead of only expecting C++ methods to return ScopedJavaLocalRefs for
> object return values, apply this to all native functions. This further
> reduces the difference between methods and nonmethods. The vast majority
> of native nonmethod functions already have a ScopedJavaLocalRef and
> currently write "return foo.Release()" to return it, so this is a fairly
> small change in actual behaviour; only a few functions need to create
> one.
>
> Also, remove the namespace qualifiers from the existing generated
> references to ScopedJavaLocalRef, since jni_generator_helper.h already
> includes a "using" declaration for it.
>
> BUG=379897
>
> Committed: https://crrev.com/be33e691030b6de0351d9a7eeaaca218685dd5bb
> Cr-Commit-Position: refs/heads/master@{#345147}
TBR=aurimas@chromium.org,jshin@chromium.org,jwd@chromium.org,mlerman@chromium.org,mmenke@chromium.org,nyquist@chromium.org,rmcilroy@chromium.org,sievers@chromium.org,sky@chromium.org,solb@chromium.org,yfriedman@google.com,lambroslambrou@chromium.org,yfriedman@chromium.org,torne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=379897
Review URL: https://codereview.chromium.org/1308363003
Cr-Commit-Position: refs/heads/master@{#345171}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of only expecting C++ methods to return ScopedJavaLocalRefs for
object return values, apply this to all native functions. This further
reduces the difference between methods and nonmethods. The vast majority
of native nonmethod functions already have a ScopedJavaLocalRef and
currently write "return foo.Release()" to return it, so this is a fairly
small change in actual behaviour; only a few functions need to create
one.
Also, remove the namespace qualifiers from the existing generated
references to ScopedJavaLocalRef, since jni_generator_helper.h already
includes a "using" declaration for it.
BUG=379897
Review URL: https://codereview.chromium.org/1288183004
Cr-Commit-Position: refs/heads/master@{#345147}
|
|
|
|
|
|
|
|
|
|
| |
libyuv is now used for YUV conversions on both ends.
BUG=256850
Review URL: https://codereview.chromium.org/1290273004
Cr-Commit-Position: refs/heads/master@{#344905}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now FrameConsumer implementation is responsible for scaling. This makes
interaction with FrameConsumer much simpler. Also removed FrameProducer
interface as it's no longer needed.
Currently video scaling is only used in the plugin when Graphics3D is
not available. In that case Graphics2D::SetScale() performs better than
trying to scale the image in the plugin, especially given that the
scaling code is not optimized for PNaCl.
This refactoring also allowed to simplify threading logic in the
rendering both on Android and in the plugin.
BUG=256850, 486917, 509914
Review URL: https://codereview.chromium.org/1288063004
Cr-Commit-Position: refs/heads/master@{#344404}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move driving of uploading UMA stats to ChromotingStats, using callbacks defined in ChromotingInstance.
Also add UMA histograms for latency metrics.
BUG=508602
Committed: https://crrev.com/d4abf8724d7dc81eb816d86c8ae82d799aafabda
Cr-Commit-Position: refs/heads/master@{#343339}
Review URL: https://codereview.chromium.org/1253193003
Cr-Commit-Position: refs/heads/master@{#343504}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously hosts supplying a shaped desktop needed to attach the desktop
shape to every frame, wasting bandwidth since the shape changes
relatively infrequently.
This CL updates the VideoRenderer implementations to preserve the shape
(or lack of one) from the preceding frame if the VideoPacket does not
include the use_desktop_shape field.
Also simplifies FrameConsumerProxy to remove the need for ref-counting,
updates NULL->nullptr throughout remoting/codec/, and removes
unnecessary transparency logic from VideoDecoderVpx.
BUG=446288
Review URL: https://codereview.chromium.org/1236663002
Cr-Commit-Position: refs/heads/master@{#339212}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to
{MessageLoop,Thread}::task_runner(). Since the types at the call sites
have already been updated, this is just a bulk rename.
BUG=465354
Review URL: https://codereview.chromium.org/1181213004
Cr-Commit-Position: refs/heads/master@{#334212}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we were using legacy, non-standard version of ICE. This
change adds ICE version negotiation and enabled standard ICE by default,
when both peers support it.
BUG=473758
Committed: https://crrev.com/5a5854ee3e1c5760b422f26d31909bfb5dca631f
Cr-Commit-Position: refs/heads/master@{#326560}
Review URL: https://codereview.chromium.org/1085703003
Cr-Commit-Position: refs/heads/master@{#326600}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1085703003/)
Reason for revert:
This change did cause test failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/34169/ (the link in the first revert was incorrect)
Original issue's description:
> Use standard ICE in Chromoting.
>
> Previously we were using legacy, non-standard version of ICE. This
> change adds ICE version negotiation and enabled standard ICE by default,
> when both peers support it.
>
> BUG=473758
>
> Committed: https://crrev.com/5a5854ee3e1c5760b422f26d31909bfb5dca631f
> Cr-Commit-Position: refs/heads/master@{#326560}
TBR=rmsousa@chromium.org,wez@chromium.org,dcaiafa@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=473758
Review URL: https://codereview.chromium.org/1089253005
Cr-Commit-Position: refs/heads/master@{#326570}
|