| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
Cr-Commit-Position: refs/heads/master@{#382939}
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#383105}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1817573003/ )
Reason for revert:
Breaks downstream Android ToT builds, and hence prevents Chromium changes rolling into downstream Android builds.
BUG= 597559
Original issue's description:
> Move ServiceUrls to remoting/host
>
> ServiceUrls was used only in one place in android client and it's
> not really useful there. Moved it to the host directory.
>
> TBR=rogerta@chromium.org
>
> Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
> Cr-Commit-Position: refs/heads/master@{#382939}
TBR=lambroslambrou@chromium.org,rogerta@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1830993002
Cr-Commit-Position: refs/heads/master@{#383060}
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#382939}
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the Cardboard SDK shared library, reducing the size of the
APK, if remoting_enable_cardboard build flag is not set.
BUG=595027
Review URL: https://codereview.chromium.org/1829543002
Cr-Commit-Position: refs/heads/master@{#382904}
|
|
|
|
|
|
|
|
|
|
| |
Reduced official build size from 7.9MB to 6.4MB. Can reenable WebRTC by changing the BUILD.gn file.
BUG=595038
Review URL: https://codereview.chromium.org/1806963002
Cr-Commit-Position: refs/heads/master@{#381636}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this, we were getting:
Exception: Wrong instrumented package. Expected
com.google.chromeremotedesktop, got org.chromium.chromoting
BUG=577483
Review URL: https://codereview.chromium.org/1573913010
Cr-Commit-Position: refs/heads/master@{#369647}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
- Changes remoting_apk in GYP so that it uses the same version_code and
version_name as chrome_apk
- Declares new GN variables so that remoting_apk in GN can share the
same version_code and version_name as chrome_apk. (CL which ports remoting_apk
to GN is at https://codereview.chromium.org/1473713005/)
BUG=544298
Review URL: https://codereview.chromium.org/1491423003
Cr-Commit-Position: refs/heads/master@{#363266}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This modifies the remoting_apk target to unconditionally build
'Chromoting.apk' instead of 'ChromeRemoteDesktop.apk' on the official
builders. This is to avoid a naming collision with a separate target
which will be introduced on the official builders.
BUG=517688
Review URL: https://codereview.chromium.org/1436613003
Cr-Commit-Position: refs/heads/master@{#359368}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first in a series of changes to implement touch input on the
Android client, consumers of this change will appear in a subsequent
change.
The Change includes the data structure we will use for storing touch event
data, the code needed to marshal the data across the java/c++ boundary,
and the code to create the native TouchEvent structure to be sent to the
host.
BUG=454549
Review URL: https://codereview.chromium.org/1424603002
Cr-Commit-Position: refs/heads/master@{#356672}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, only the Java code was being imported. This includes the
native code as well, on architectures where the Cardboard SDK provides
native code.
BUG=516871
Review URL: https://codereview.chromium.org/1391373005
Cr-Commit-Position: refs/heads/master@{#354610}
|
|
|
|
|
|
|
|
|
|
|
| |
As a result of an old CL:
http://crrev.com/568c12964fe00214c1e28845e806739224d43a66
the conditional of one section became identical to a previous section,
so they can be merged.
Review URL: https://codereview.chromium.org/1403613007
Cr-Commit-Position: refs/heads/master@{#354308}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds some GYP variables to allow official builds to modify the
remoting_apk target.
Also adds a destroy() method to the interface, to release resources
used by the account-switcher.
Also adds hooks to allow the account-switcher to gracefully
handle connection errors to Google Play Services.
BUG=517688
Review URL: https://codereview.chromium.org/1369903002
Cr-Commit-Position: refs/heads/master@{#351693}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously android app was using key code when sending keyboard events.
That approach doesn't work well with physical keyboard when using
layout other than QWERTY. Fixed the client to use scan codes, so that
the events are always send correctly and layout mapping is applied
only on the client.
BUG=475713
Review URL: https://codereview.chromium.org/1321223003
Cr-Commit-Position: refs/heads/master@{#347874}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds new Java/C++ classes (empty stubs) for managing a connection
to the host. A new instance will be created each time a connection is
made, which should eliminate a class of bugs where notifications are
received from previous connections.
Now that more than 1 Java class is using JNI, this CL also adds
remoting_jni_registrar.cc to manage all the JNI registrations, in line
with other examples in Chromium code.
This also renames the ..onload.cc file, to follow the naming convention
used elsewhere (since our code lives in the remoting/ directory).
BUG=526336
Review URL: https://codereview.chromium.org/1319293002
Cr-Commit-Position: refs/heads/master@{#346998}
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add dependency to the Cardboard SDK, which will be used to render 3D scenes.
2. Add new permissions: android.permission.NFC(required by the Cardboard SDK to access Cardboard's NFC tag), android.permission.READ_EXTERNAL_STORAGE and android.permission.WRITE_EXTERNAL_STORAGE(these permissions are required by the Cardboard SDK to pair the user's phone to their VR viewer).
3. Create VRDesktop activity enabling user to interact with the VR Chromoting desktop.
4. Create CardboardView renderer that will be used to generate 3D graphics.
Review URL: https://codereview.chromium.org/1231153002
Cr-Commit-Position: refs/heads/master@{#338730}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(re-land of https://codereview.chromium.org/1202523007)
This also slightly changes the behavior of the embedded WebView. Now it
only renders content inline if it originates from the initial host that
it was told to use (otherwise it launches an external browser). This
simplifies the code (by using a single explicitly-defined
WebViewClient implementation).
BUG=499478
Review URL: https://codereview.chromium.org/1207073003
Cr-Commit-Position: refs/heads/master@{#336079}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1202523007/)
Reason for revert:
Appears to break gclient runhooks:
Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/Android/build
Updating projects from gyp files...
Traceback (most recent call last):
File "src/build/gyp_chromium", line 323, in <module>
gyp_rc = gyp.main(args)
File "/b/build/slave/Android/build/src/tools/gyp/pylib/gyp/__init__.py", line 538, in main
return gyp_main(args)
File "/b/build/slave/Android/build/src/tools/gyp/pylib/gyp/__init__.py", line 514, in gyp_main
options.duplicate_basename_check)
File "/b/build/slave/Android/build/src/tools/gyp/pylib/gyp/__init__.py", line 130, in Load
params['parallel'], params['root_targets'])
File "/b/build/slave/Android/build/src/tools/gyp/pylib/gyp/input.py", line 2785, in Load
RemoveLinkDependenciesFromNoneTargets(targets)
File "/b/build/slave/Android/build/src/tools/gyp/pylib/gyp/input.py", line 1501, in RemoveLinkDependenciesFromNoneTargets
if targets[t].get('variables', {}).get('link_dependency', 0):
KeyError: '/b/build/slave/Android/build/src/remoting/remoting.gyp:remoting_credits#target'
Hook '/usr/bin/python src/build/gyp_chromium' took 12.40 secs
Original issue's description:
> Chromoting Android: Add Credits screen.
>
> This also slightly changes the behavior of the embedded WebView. Now it
> only renders content inline if it originates from the initial host that
> it was told to use (otherwise it launches an external browser). This
> simplifies the code (by using a single explicitly-defined
> WebViewClient implementation).
>
> BUG=499478
>
> Committed: https://crrev.com/6dd51554c5c0c8378096aa47b04baf5b5c004560
> Cr-Commit-Position: refs/heads/master@{#336030}
TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=499478
Review URL: https://codereview.chromium.org/1206723005
Cr-Commit-Position: refs/heads/master@{#336037}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also slightly changes the behavior of the embedded WebView. Now it
only renders content inline if it originates from the initial host that
it was told to use (otherwise it launches an external browser). This
simplifies the code (by using a single explicitly-defined
WebViewClient implementation).
BUG=499478
Review URL: https://codereview.chromium.org/1202523007
Cr-Commit-Position: refs/heads/master@{#336030}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the separate AndroidManifest.xml for Cast support, and
makes the Chromoting Android client unconditionally dependent on
Google Play Services, now that it is available in Chromium builds.
This library will allow us to add Cast support, use GoogleAuthUtil,
improve the account-switching UX, and maybe other stuff as well.
BUG=403850,417799
Review URL: https://codereview.chromium.org/906403005
Cr-Commit-Position: refs/heads/master@{#316024}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates all icons in the app to the Material Design versions.
This also updates the app launcher icon with the Android-specific
version of the new logo.
BUG=430328
Review URL: https://codereview.chromium.org/896923002
Cr-Commit-Position: refs/heads/master@{#315735}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently chrome creates a file path when uploading a photo taken through camera
However, this doesn't always work.
Instead, we should use content URI. See more details in the crbug.
BUG=405593
Review URL: https://codereview.chromium.org/489053003
Cr-Commit-Position: refs/heads/master@{#292257}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support for:
1. Capability enumeration, negotiation and managment.
2. Generic client-side extensions, similar to HostExtension model in Chromoting host.
3. Interaction with Chromoting host's CastExtension and support for Cast Sender API
(prototype for Cast support).
Note:
The android app has four new dependencies: v4 support, v7 appcompat, v7 mediarouter,
google play services. The first three are in third_party/android_tools/,
but the last isn't. See crbug.com/403948. This CL will not break any builds
since the code is behind a gyp flag in remoting.gyp.
Review URL: https://codereview.chromium.org/451973002
Cr-Commit-Position: refs/heads/master@{#289897}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is especially needed because ui/gfx headers, in turn, can include skia headers,
which are only meaningful in the context of skia's compile flags. Those are available
from ui/gfx since it re-exports skia's dependencies.
Landing tbr to unblock skia's DEPS roll.
TBR=lambros@chromium.org
Review URL: https://codereview.chromium.org/341633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a long time (crrev.com/133053) OS==android implies:
gtest_target_type=shared_library
Cleanup the spurious conditions and obsolete TODOs.
BUG=
Review URL: https://codereview.chromium.org/302533009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The underlying rule is now "long" by default.
Mechanical change:
git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
Relands crrev.com/270750 (reverted by 270849)
BUG=317523
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/288223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suspected to cause Android Tests bot failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13592
> Android: cleans up jni_generator_ptr_type.
>
> The underlying rule is now "long" by default.
> Mechanical change:
> git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
>
> BUG=317523
> TBR=darin@chromium.org
>
> Review URL: https://codereview.chromium.org/288963002
TBR=bulach@chromium.org
Review URL: https://codereview.chromium.org/292433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The underlying rule is now "long" by default.
Mechanical change:
git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
BUG=317523
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/288963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a separate target, remoting_java, that builds the Java
code and resources. The remoting_apk target depends on this target and
builds the final APK.
Several changes were needed, since the build/java.gypi file has some
features and checks not present in build/java_apk.gypi:
* switch/case statements changed to if/else chains, since the generated
R.java uses 'int' instead of 'const int' for resource IDs.
* XML style fixes necessitated by the lint-style checking, and v14
resource generation.
* A new Java class added: RemotingApplication. This is needed right now
because the APK build step requires at least one Java source file. In
future, this class will override onCreate(), and a different override
will be used for official builds, to dependency-inject Java code that
requires closed-source dependencies (such as the Help+Feedback
implementation).
TEST=Builds and runs. Touching various files triggers rebuild.
Review URL: https://codereview.chromium.org/245893004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This path is now only inferred from test_suite_name.
TBR=darin
NOTRY=true
Review URL: https://codereview.chromium.org/226353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the Android-specific resources to a /res/ folder alongside
the Java sources.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/235923015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These inputs are not necessary because RULE_INPUT_PATH is always
an input of a rule. And the .gyp spec doesn't guarantee that the
RULE_INPUT_* variables exist for the inputs list.
BUG=
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/197233010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These copies are no longer required, since the Android resources now
follow the correct directory layout. More importantly, this prevents
build failures resulting from stale copies of resources, which can
happen if an xml resource file is deleted (for example, if a CL that
adds a new XML file gets reverted).
This also moves the README file up a level, since the android resources
directory cannot contain any non-resource files.
NOTRY=true
Review URL: https://codereview.chromium.org/183863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/181653007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a Help & feedback menu-item for each screen of the app. The
Help screen embeds a WebView, which shows a URL dependent on
which screen the Help was launched from.
There is also a Feedback menu-item, which is currently hidden, pending
implementation of this feature (only the Official build will have it).
A menu-item is provided for showing the Play Store entry for the
application. More menu-items can be added (such as Copyright,
Privacy policy, Open source licences) if they are required in the app.
BUG=333129
NOTRY=true
Review URL: https://codereview.chromium.org/179003006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the icon does not work well with light themes, this CL specifies
Holo Dark theme for the app, instead of the device default.
Also removed text next to icons, as the keyboard icon does not have
sufficient padding. The icon is descriptive enough in itself, and the
text appears anyway if you long-press the buttons.
BUG=338773
NOTRY=true
Review URL: https://codereview.chromium.org/180703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=338773
Review URL: https://codereview.chromium.org/165743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that Ant regenerates the R.java resource file if the
remoting/resources/remoting_strings.grd file is changed. This had the
potential to cause incremental build failures if a new Android string
were added to this grd file (and a .java file tried to access the new
resource).
TEST=Build remoting_apk, touch the remoting grd file and rebuild the target - verify that the R.java/R.txt step runs.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/171423018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added copyright notices to these files.
strings.xml has been moved to a values/ directory for consistency,
although we ultimately want to get rid of that file.
NOTRY=true
Review URL: https://codereview.chromium.org/171533011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Build remoting_apk with branding=Chrome, verify it runs OK, and verify 'aapt dump badging out/Debug/apks/ChromeRemoteDesktop.apk' shows new package name.
Review URL: https://codereview.chromium.org/155083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=333129
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/135193005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Merged remoting_jingle_glue into remoting_protocol.
- Merged remoting_host_logging and remoting_host_event_logger
into remoting_host.
Review URL: https://codereview.chromium.org/145003019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Official builds will produce ChromeRemoteDesktop.apk instead of
Chromoting.apk
R=kerz@chromium.org, sergeyu@chromium.org
Review URL: https://codereview.chromium.org/141213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
An APK built from a later Chromium branch should have a higher version
number than one built from an earlier branch. This CL fixes the
Chromoting Android package's internal version to have that property.
The scheme implemented here matches official Chrome.apk.
Review URL: https://codereview.chromium.org/133123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed code that hid the ActionBar whenever the display area changed
size. As a side-effect, the ActionBar no longer disappears when the
keyboard is shown.
Previously, the ActionBar was overlayed so that it obscured the top
portion of the remote desktop. This is no longer desirable now that the
ActionBar is visible by default, so this CL restores the default
ActionBar behavior to resize the View when shown/hidden.
BUG=333129
Review URL: https://codereview.chromium.org/132933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317523
Review URL: https://codereview.chromium.org/130963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This pulls Android-specific targets out of remoting.gyp into a new
gypi file.
Review URL: https://codereview.chromium.org/129943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243868 0039d316-1c4b-4281-b951-d872f2087c98
|