| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
| |
versatile by allowing other gypi's that include it to define script_args and additional closure_args. remoting/ and components/resources/enhanced_bookmarks/ have been refactored to use compile_js.gypi (rather than calling compile.py directly).
BUG=496276
Review URL: https://codereview.chromium.org/1152583011
Cr-Commit-Position: refs/heads/master@{#335692}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove now unused qunit_proto.js
- Ensure the gyp variable has _files in the name, as that implies
special (necessary) path handling
--
chromoting: Add JS externs for qunit.
This is one of a few fixes needed to enable ES6 mode in remoting/.
BUG=481705
Committed: https://crrev.com/ffbf1b6110ff79b0f9683a4f4acc67baf4900499
Cr-Commit-Position: refs/heads/master@{#335097}
Review URL: https://codereview.chromium.org/1195643002
Cr-Commit-Position: refs/heads/master@{#335532}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1196453003/)
Reason for revert:
Broke JSCompiler FYI bot
Original issue's description:
> chromoting: Add JS externs for qunit.
>
> This is one of a few fixes needed to enable ES6 mode in remoting/.
>
> BUG=481705
>
> Committed: https://crrev.com/ffbf1b6110ff79b0f9683a4f4acc67baf4900499
> Cr-Commit-Position: refs/heads/master@{#335097}
TBR=garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481705
Review URL: https://codereview.chromium.org/1183973010
Cr-Commit-Position: refs/heads/master@{#335113}
|
| |
|
|
|
|
|
|
|
|
| |
This is one of a few fixes needed to enable ES6 mode in remoting/.
BUG=481705
Review URL: https://codereview.chromium.org/1196453003
Cr-Commit-Position: refs/heads/master@{#335097}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Closure compiler ships with externs for chrome extensions.
This CL re-annotates our source code to be compliant with the chrome_extensions externs
defined in closure_compiler. This will prevent us from getting broken by future closure
compiler version updates.
Since third_party/closure_compiler/externs/chrome_extensions.js is maintained in a
separate GitHub repository, a private copy of chrome_proto.js is still necessary to
bridge the gap between the discrepancies in type annotations.
BUG=491299
Review URL: https://codereview.chromium.org/1143113004
Cr-Commit-Position: refs/heads/master@{#331722}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current unittest reuses the chrome_proto.js as stubs in the unittest.
chrome_proto.js is subjected to changes as JSCompile augments the existing
set of functions through externs.
Summary of changes:
1. Auto activate/restore chrome mocks in each unittest.
2. Separates chrome mocks from chrome protos.
Review URL: https://codereview.chromium.org/1143033004
Cr-Commit-Position: refs/heads/master@{#331441}
|
| |
|
|
|
|
|
|
|
|
|
| |
Modify Runner.java to understand quoted args and add
optional --output_wrapper argument to checker.py
BUG=393874
Review URL: https://codereview.chromium.org/1081073002
Cr-Commit-Position: refs/heads/master@{#325856}
|
|
|
There was an unfortunate bug that swallowed Java stacks.
Issues were discovered when Java stacks started surfacing:
https://codereview.chromium.org/476453002/
So change the way remoting is built. It doesn't need to be
built on all bots by default: they have undefined Java versions
and likely weren't working before (and shouldn't differ).
Instead, run when run_jscompile=1 is defined in GYP:
export GYP_DEFINES=run_jscompile=1 && build/gyp_chromium
# or add in ~/.gyp/includes.gypi or $SRC/../chromium.gyp_env
# or build/gyp_chromium -Drun_jscompile=1
and on the Closure Compilation Linux FYI bot:
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux
This also fixes some GYP inputs problems (if I changed compile_js.gypi or
other things in remoting/ ninja wouldn't rebuild anything).
R=jamiewalch@chromium.org
BUG=none
TEST=green bots, remoting runs on Closure Compliation Linux FYI bot
Review URL: https://codereview.chromium.org/1037613002
Cr-Commit-Position: refs/heads/master@{#322193}
|
